Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — master (#3410)
by
unknown
11:29
created
src/app/Http/Controllers/Operations/FetchOperation.php 1 patch
Spacing   +6 added lines, -8 removed lines patch added patch discarded remove patch
@@ -46,8 +46,8 @@  discard block
 block discarded – undo
46 46
         // otherwise assume the arguments are actually the configuration array
47 47
         $config = [];
48 48
 
49
-        if (! is_array($arg)) {
50
-            if (! class_exists($arg)) {
49
+        if (!is_array($arg)) {
50
+            if (!class_exists($arg)) {
51 51
                 return response()->json(['error' => 'Class: '.$arg.' does not exists'], 500);
52 52
             }
53 53
             $config['model'] = $arg;
@@ -77,8 +77,7 @@  discard block
 block discarded – undo
77 77
 
78 78
         if ($search_string === false) {
79 79
             return ($config['paginate'] !== false) ?
80
-            $config['query']->paginate($config['paginate']) :
81
-            $config['query']->get();
80
+            $config['query']->paginate($config['paginate']) : $config['query']->get();
82 81
         }
83 82
 
84 83
         $textColumnTypes = ['string', 'json_string', 'text', 'longText', 'json_array', 'json'];
@@ -89,8 +88,8 @@  discard block
 block discarded – undo
89 88
         // .... 'query' => function($model) { return $model->where('active', 1); }
90 89
         // So it reads: SELECT ... WHERE active = 1 AND (XXX = x OR YYY = y) and not SELECT ... WHERE active = 1 AND XXX = x OR YYY = y;
91 90
 
92
-        if (! empty($config['query']->getQuery()->wheres)) {
93
-            $config['query'] = $config['query']->where(function ($query) use ($model_instance, $config, $search_string, $textColumnTypes) {
91
+        if (!empty($config['query']->getQuery()->wheres)) {
92
+            $config['query'] = $config['query']->where(function($query) use ($model_instance, $config, $search_string, $textColumnTypes) {
94 93
                 foreach ((array) $config['searchable_attributes'] as $k => $searchColumn) {
95 94
                     $operation = ($k == 0) ? 'where' : 'orWhere';
96 95
                     $columnType = $model_instance->getColumnType($searchColumn);
@@ -122,7 +121,6 @@  discard block
 block discarded – undo
122 121
 
123 122
         // return the results with or without pagination
124 123
         return ($config['paginate'] !== false) ?
125
-                    $config['query']->paginate($config['paginate']) :
126
-                    $config['query']->get();
124
+                    $config['query']->paginate($config['paginate']) : $config['query']->get();
127 125
     }
128 126
 }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Read.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
      */
57 57
     public function getEntry($id)
58 58
     {
59
-        if (! $this->entry) {
59
+        if (!$this->entry) {
60 60
             $this->entry = $this->model->findOrFail($id);
61 61
             $this->entry = $this->entry->withFakes();
62 62
         }
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
258 258
                 // we will apply the same labels as the values to the menu if developer didn't
259 259
                 $this->abortIfInvalidPageLength($menu[0]);
260 260
 
261
-                if (! isset($menu[1]) || ! is_array($menu[1])) {
261
+                if (!isset($menu[1]) || !is_array($menu[1])) {
262 262
                     $menu[1] = $menu[0];
263 263
                 }
264 264
             } else {
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Create.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
     {
92 92
         $all_relation_fields = $this->getRelationFields();
93 93
 
94
-        return Arr::where($all_relation_fields, function ($value, $key) {
94
+        return Arr::where($all_relation_fields, function($value, $key) {
95 95
             return isset($value['pivot']) && $value['pivot'];
96 96
         });
97 97
     }
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
                             $field_data = json_decode($data[$field['name']], true);
156 156
 
157 157
                             // we grab from the parsed data the specific values for this pivot
158
-                            $pivot_data = Arr::first($field_data, function ($item) use ($pivot_id, $field) {
158
+                            $pivot_data = Arr::first($field_data, function($item) use ($pivot_id, $field) {
159 159
                                 return $item[$field['name']] === $pivot_id;
160 160
                             });
161 161
 
@@ -188,12 +188,12 @@  discard block
 block discarded – undo
188 188
      */
189 189
     private function createRelationsForItem($item, $formattedData)
190 190
     {
191
-        if (! isset($formattedData['relations'])) {
191
+        if (!isset($formattedData['relations'])) {
192 192
             return false;
193 193
         }
194 194
 
195 195
         foreach ($formattedData['relations'] as $relationMethod => $relationData) {
196
-            if (! isset($relationData['model'])) {
196
+            if (!isset($relationData['model'])) {
197 197
                 continue;
198 198
             }
199 199
 
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
                     // we first check if there are relations of the relation
207 207
                     if (isset($relationData['relations'])) {
208 208
                         // if there are nested relations, we first add the BelongsTo like in main entry
209
-                        $belongsToRelations = Arr::where($relationData['relations'], function ($relation_data) {
209
+                        $belongsToRelations = Arr::where($relationData['relations'], function($relation_data) {
210 210
                             return $relation_data['relation_type'] == 'BelongsTo';
211 211
                         });
212 212
 
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
                         $valuesWithRelations = $this->associateHasOneBelongsTo($belongsToRelations, $relationData['values'], $relation->getModel());
216 216
 
217 217
                         // remove previously added BelongsTo relations from relation data.
218
-                        $relationData['relations'] = Arr::where($relationData['relations'], function ($item) {
218
+                        $relationData['relations'] = Arr::where($relationData['relations'], function($item) {
219 219
                             return $item['relation_type'] != 'BelongsTo';
220 220
                         });
221 221
 
@@ -315,7 +315,7 @@  discard block
 block discarded – undo
315 315
     private function getRelationDataFromFormData($data)
316 316
     {
317 317
         // exclude the already attached belongs to relations but include nested belongs to.
318
-        $relation_fields = Arr::where($this->getRelationFields(), function ($field, $key) {
318
+        $relation_fields = Arr::where($this->getRelationFields(), function($field, $key) {
319 319
             return $field['relation_type'] !== 'BelongsTo' || $this->isNestedRelation($field);
320 320
         });
321 321
 
@@ -326,10 +326,10 @@  discard block
 block discarded – undo
326 326
             if (isset($relation_field['pivot']) && $relation_field['pivot'] !== true) {
327 327
                 $key = implode('.relations.', explode('.', $this->getOnlyRelationEntity($relation_field)));
328 328
                 $fieldData = Arr::get($relationData, 'relations.'.$key, []);
329
-                if (! array_key_exists('model', $fieldData)) {
329
+                if (!array_key_exists('model', $fieldData)) {
330 330
                     $fieldData['model'] = $relation_field['model'];
331 331
                 }
332
-                if (! array_key_exists('parent', $fieldData)) {
332
+                if (!array_key_exists('parent', $fieldData)) {
333 333
                     $fieldData['parent'] = $this->getRelationModel($attributeKey, -1);
334 334
                 }
335 335
 
@@ -343,7 +343,7 @@  discard block
 block discarded – undo
343 343
                 // this allow developers to override that behavior and force deletion from database
344 344
                 $fieldData['force_delete'] = $relation_field['force_delete'] ?? false;
345 345
 
346
-                if (! array_key_exists('relation_type', $fieldData)) {
346
+                if (!array_key_exists('relation_type', $fieldData)) {
347 347
                     $fieldData['relation_type'] = $relation_field['relation_type'];
348 348
                 }
349 349
                 $relatedAttribute = Arr::last(explode('.', $attributeKey));
@@ -386,7 +386,7 @@  discard block
 block discarded – undo
386 386
                     ->where($relation_foreign_key, $item->{$relation_local_key})
387 387
                     ->update([$relation_foreign_key => $relationData['fallback_id']]);
388 388
             } else {
389
-                if (! $relation_column_is_nullable || $force_delete) {
389
+                if (!$relation_column_is_nullable || $force_delete) {
390 390
                     $model_instance->whereNotIn($model_instance->getKeyName(), $relation_values)
391 391
                         ->where($relation_foreign_key, $item->{$relation_local_key})
392 392
                         ->delete();
@@ -403,7 +403,7 @@  discard block
 block discarded – undo
403 403
                 $model_instance->where($relation_foreign_key, $item->{$relation_local_key})
404 404
                     ->update([$relation_foreign_key => $relationData['fallback_id']]);
405 405
             } else {
406
-                if (! $relation_column_is_nullable || $force_delete) {
406
+                if (!$relation_column_is_nullable || $force_delete) {
407 407
                     $model_instance->where($relation_foreign_key, $item->{$relation_local_key})->delete();
408 408
                 } else {
409 409
                     $model_instance->where($relation_foreign_key, $item->{$relation_local_key})
@@ -433,7 +433,7 @@  discard block
 block discarded – undo
433 433
             $created_ids = [];
434 434
 
435 435
             foreach ($items as $item) {
436
-                if (isset($item[$relation_local_key]) && ! empty($item[$relation_local_key])) {
436
+                if (isset($item[$relation_local_key]) && !empty($item[$relation_local_key])) {
437 437
                     $entry->{$relationMethod}()->updateOrCreate([$relation_local_key => $item[$relation_local_key]], $item);
438 438
                 } else {
439 439
                     $created_ids[] = $entry->{$relationMethod}()->create($item)->{$relation_local_key};
@@ -443,7 +443,7 @@  discard block
 block discarded – undo
443 443
             // get from $items the sent ids, and merge the ones created.
444 444
             $relatedItemsSent = array_merge(array_filter(Arr::pluck($items, $relation_local_key)), $created_ids);
445 445
 
446
-            if (! empty($relatedItemsSent)) {
446
+            if (!empty($relatedItemsSent)) {
447 447
                 // we perform the cleanup of removed database items
448 448
                 $entry->{$relationMethod}()->whereNotIn($relation_local_key, $relatedItemsSent)->delete();
449 449
             }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Relationships.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
         return collect($this->fields())
62 62
             ->where('model')
63 63
             ->whereIn('relation_type', $relation_types)
64
-            ->filter(function ($item) {
64
+            ->filter(function($item) {
65 65
                 $related_model = get_class($this->model->{Str::before($item['entity'], '.')}()->getRelated());
66 66
 
67 67
                 return Str::contains($item['entity'], '.') && $item['model'] !== $related_model ? false : true;
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
         $relation_model = $this->getRelationModel($relation_field['entity'], -1);
207 207
         $related_method = Str::afterLast($relation_field['entity'], '.');
208 208
 
209
-        if (! method_exists($relation_model, $related_method) && $this->isNestedRelation($relation_field)) {
209
+        if (!method_exists($relation_model, $related_method) && $this->isNestedRelation($relation_field)) {
210 210
             return Str::beforeLast($relation_field['entity'], '.');
211 211
         }
212 212
 
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/ListOperation.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
     {
42 42
         $this->crud->allowAccess('list');
43 43
 
44
-        $this->crud->operation('list', function () {
44
+        $this->crud->operation('list', function() {
45 45
             $this->crud->loadDefaultOperationSettingsFromConfig();
46 46
         });
47 47
     }
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
                 $column_number = (int) $order['column'];
100 100
                 $column_direction = (strtolower((string) $order['dir']) == 'asc' ? 'ASC' : 'DESC');
101 101
                 $column = $this->crud->findColumnById($column_number);
102
-                if ($column['tableColumn'] && ! isset($column['orderLogic'])) {
102
+                if ($column['tableColumn'] && !isset($column['orderLogic'])) {
103 103
                     // apply the current orderBy rules
104 104
                     $this->crud->orderByWithPrefix($column['name'], $column_direction);
105 105
                 }
@@ -119,12 +119,12 @@  discard block
 block discarded – undo
119 119
         $table = $this->crud->model->getTable();
120 120
         $key = $this->crud->model->getKeyName();
121 121
 
122
-        $hasOrderByPrimaryKey = collect($orderBy)->some(function ($item) use ($key, $table) {
122
+        $hasOrderByPrimaryKey = collect($orderBy)->some(function($item) use ($key, $table) {
123 123
             return (isset($item['column']) && $item['column'] === $key)
124 124
                 || (isset($item['sql']) && str_contains($item['sql'], "$table.$key"));
125 125
         });
126 126
 
127
-        if (! $hasOrderByPrimaryKey) {
127
+        if (!$hasOrderByPrimaryKey) {
128 128
             $this->crud->orderByWithPrefix($this->crud->model->getKeyName(), 'DESC');
129 129
         }
130 130
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/FieldsProtectedMethods.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
      */
70 70
     public function overwriteFieldNameFromDotNotationToArray($field)
71 71
     {
72
-        if (! is_array($field['name']) && strpos($field['name'], '.') !== false) {
72
+        if (!is_array($field['name']) && strpos($field['name'], '.') !== false) {
73 73
             $entity_array = explode('.', $field['name']);
74 74
             $name_string = '';
75 75
 
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
             return ['name' => $field];
97 97
         }
98 98
 
99
-        if (is_array($field) && ! isset($field['name'])) {
99
+        if (is_array($field) && !isset($field['name'])) {
100 100
             abort(500, 'All fields must have their name defined');
101 101
         }
102 102
 
@@ -154,13 +154,13 @@  discard block
 block discarded – undo
154 154
     protected function makeSureFieldHasRelationshipData($field)
155 155
     {
156 156
         // only do this if "entity" is defined on the field
157
-        if (! isset($field['entity'])) {
157
+        if (!isset($field['entity'])) {
158 158
             return $field;
159 159
         }
160 160
 
161 161
         $extraFieldAttributes = $this->inferFieldAttributesFromRelationship($field);
162 162
 
163
-        if (! empty($extraFieldAttributes)) {
163
+        if (!empty($extraFieldAttributes)) {
164 164
             $field = array_merge($field, $extraFieldAttributes);
165 165
         } else {
166 166
             abort(500, 'Unable to process relationship data: '.$field['name']);
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
172 172
     protected function overwriteFieldNameFromEntity($field)
173 173
     {
174 174
         // if the entity doesn't have a dot, it means we don't need to overwrite the name
175
-        if (! Str::contains($field['entity'], '.')) {
175
+        if (!Str::contains($field['entity'], '.')) {
176 176
             return $field;
177 177
         }
178 178
 
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
         if (count(explode('.', $field['entity'])) == count(explode('.', $this->getOnlyRelationEntity($field)))) {
185 185
             $field['name'] = implode('.', array_slice(explode('.', $field['entity']), 0, -1));
186 186
             $relation = $this->getRelationInstance($field);
187
-            if (! empty($field['name'])) {
187
+            if (!empty($field['name'])) {
188 188
                 $field['name'] .= '.';
189 189
             }
190 190
             $field['name'] .= $relation->getForeignKeyName();
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
     {
198 198
         // if there's a model defined, but no attribute
199 199
         // guess an attribute using the identifiableAttribute functionality in CrudTrait
200
-        if (isset($field['model']) && ! isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
200
+        if (isset($field['model']) && !isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
201 201
             $field['attribute'] = call_user_func([(new $field['model']), 'identifiableAttribute']);
202 202
         }
203 203
 
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
      */
214 214
     protected function makeSureFieldHasLabel($field)
215 215
     {
216
-        if (! isset($field['label'])) {
216
+        if (!isset($field['label'])) {
217 217
             $name = is_array($field['name']) ? $field['name'][0] : $field['name'];
218 218
             $name = str_replace('_id', '', $name);
219 219
             $field['label'] = mb_ucfirst(str_replace('_', ' ', $name));
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
      */
232 232
     protected function makeSureFieldHasType($field)
233 233
     {
234
-        if (! isset($field['type'])) {
234
+        if (!isset($field['type'])) {
235 235
             $field['type'] = isset($field['relation_type']) ? $this->inferFieldTypeFromFieldRelation($field) : $this->inferFieldTypeFromDbColumnType($field['name']);
236 236
         }
237 237
 
@@ -248,7 +248,7 @@  discard block
 block discarded – undo
248 248
     {
249 249
         // if a tab was mentioned, we should enable it
250 250
         if (isset($field['tab'])) {
251
-            if (! $this->tabsEnabled()) {
251
+            if (!$this->tabsEnabled()) {
252 252
                 $this->enableTabs();
253 253
             }
254 254
         }
Please login to merge, or discard this patch.
src/app/Console/Commands/AddCustomRouteContent.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
 
84 84
         // otherwise, in case the last line HAS been modified
85 85
         // return the last line that has an ending in it
86
-        $possible_end_lines = array_filter($file_lines, function ($k) {
86
+        $possible_end_lines = array_filter($file_lines, function($k) {
87 87
             return strpos($k, '});') === 0;
88 88
         });
89 89
 
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
      */
105 105
     private function getLastLineNumberThatContains($needle, $haystack)
106 106
     {
107
-        $matchingLines = array_filter($haystack, function ($k) use ($needle) {
107
+        $matchingLines = array_filter($haystack, function($k) use ($needle) {
108 108
             return strpos($k, $needle) !== false;
109 109
         });
110 110
 
Please login to merge, or discard this patch.