We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
Total Complexity | 40 |
Total Lines | 205 |
Duplicated Lines | 0 % |
Changes | 6 | ||
Bugs | 2 | Features | 0 |
Complex classes like Relationships often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Relationships, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
9 | trait Relationships |
||
10 | { |
||
11 | /** |
||
12 | * From the field entity we get the relation instance. |
||
13 | * |
||
14 | * @param array $entity |
||
15 | * @return object |
||
16 | */ |
||
17 | public function getRelationInstance($field) |
||
47 | } |
||
48 | |||
49 | /** |
||
50 | * Get the fields for relationships, according to the relation type. It looks only for direct |
||
51 | * relations - it will NOT look through relationships of relationships. |
||
52 | * |
||
53 | * @param string|array $relation_types Eloquent relation class or array of Eloquent relation classes. Eg: BelongsTo |
||
54 | * |
||
55 | * @return array The fields with corresponding relation types. |
||
56 | */ |
||
57 | public function getFieldsWithRelationType($relation_types): array |
||
58 | { |
||
59 | $relation_types = (array) $relation_types; |
||
60 | |||
61 | return collect($this->fields()) |
||
62 | ->where('model') |
||
63 | ->whereIn('relation_type', $relation_types) |
||
64 | ->filter(function ($item) { |
||
65 | $related_model = get_class($this->model->{Str::before($item['entity'], '.')}()->getRelated()); |
||
66 | |||
67 | return Str::contains($item['entity'], '.') && $item['model'] !== $related_model ? false : true; |
||
68 | }) |
||
69 | ->toArray(); |
||
70 | } |
||
71 | |||
72 | /** |
||
73 | * Grabs an relation instance and returns the class name of the related model. |
||
74 | * |
||
75 | * @param array $field |
||
76 | * @return string |
||
77 | */ |
||
78 | public function inferFieldModelFromRelationship($field) |
||
79 | { |
||
80 | $relation = $this->getRelationInstance($field); |
||
81 | |||
82 | return get_class($relation->getRelated()); |
||
83 | } |
||
84 | |||
85 | /** |
||
86 | * Return the relation type from a given field: BelongsTo, HasOne ... etc. |
||
87 | * |
||
88 | * @param array $field |
||
89 | * @return string |
||
90 | */ |
||
91 | public function inferRelationTypeFromRelationship($field) |
||
96 | } |
||
97 | |||
98 | /** |
||
99 | * Parse the field name back to the related entity after the form is submited. |
||
100 | * Its called in getAllFieldNames(). |
||
101 | * |
||
102 | * @param array $fields |
||
103 | * @return array |
||
104 | */ |
||
105 | public function parseRelationFieldNamesFromHtml($fields) |
||
122 | } |
||
123 | |||
124 | /** |
||
125 | * Based on relation type returns the default field type. |
||
126 | * |
||
127 | * @param string $relation_type |
||
128 | * @return string |
||
129 | */ |
||
130 | public function inferFieldTypeFromFieldRelation($field) |
||
142 | } |
||
143 | } |
||
144 | |||
145 | /** |
||
146 | * Based on relation type returns if relation allows multiple entities. |
||
147 | * |
||
148 | * @param string $relation_type |
||
149 | * @return bool |
||
150 | */ |
||
151 | public function guessIfFieldHasMultipleFromRelationType($relation_type) |
||
152 | { |
||
153 | switch ($relation_type) { |
||
154 | case 'BelongsToMany': |
||
155 | case 'HasMany': |
||
156 | case 'HasManyThrough': |
||
157 | case 'HasOneOrMany': |
||
158 | case 'MorphMany': |
||
159 | case 'MorphOneOrMany': |
||
160 | case 'MorphToMany': |
||
161 | return true; |
||
162 | default: |
||
163 | return false; |
||
164 | } |
||
165 | } |
||
166 | |||
167 | /** |
||
168 | * Based on relation type returns if relation has a pivot table. |
||
169 | * |
||
170 | * @param string $relation_type |
||
171 | * @return bool |
||
172 | */ |
||
173 | public function guessIfFieldHasPivotFromRelationType($relation_type) |
||
183 | } |
||
184 | } |
||
185 | |||
186 | /** |
||
187 | * Check if field name contains a dot, if so, meaning it's a nested relation. |
||
188 | * |
||
189 | * @param array $field |
||
190 | * @return bool |
||
191 | */ |
||
192 | protected function isNestedRelation($field): bool |
||
195 | } |
||
196 | |||
197 | /** |
||
198 | * Return the relation without any model attributes there. |
||
199 | * Eg. user.entity_id would return user, as entity_id is not a relation in user. |
||
200 | * |
||
201 | * @param array $relation_field |
||
202 | * @return string |
||
203 | */ |
||
204 | public function getOnlyRelationEntity($relation_field) |
||
216 |
This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.
This is most likely a typographical error or the method has been renamed.