Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Failed
Pull Request — main (#5478)
by Pedro
26:53
created
src/app/Library/CrudPanel/Traits/Create.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
                     // - a single dimensional array: [1,2,3]
125 125
                     // - an array of arrays: [[1][2][3]]
126 126
                     // if is as single dimensional array we can only attach.
127
-                    if ($relationValues === null || ! is_multidimensional_array($relationValues)) {
127
+                    if ($relationValues === null || !is_multidimensional_array($relationValues)) {
128 128
                         $this->attachManyRelation($item, $relation, $relationDetails, $relationValues);
129 129
                     } else {
130 130
                         $this->createManyEntries($item, $relation, $relationMethod, $relationDetails);
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
                             
147 147
                             $toDelete = array_diff($dbValues, $sentIds);
148 148
                             
149
-                            if (! empty($toDelete)) {
149
+                            if (!empty($toDelete)) {
150 150
                                 foreach ($toDelete as $id) {
151 151
                                     $relation->newPivot()->where($keyName, $id)->delete();
152 152
                                 }
@@ -187,7 +187,7 @@  discard block
 block discarded – undo
187 187
         }
188 188
     }
189 189
 
190
-    private function preparePivotAttributesForSave(array $attributes, BelongsToMany|MorphToMany $relation, string|int $relatedItemKey, $pivotKeyName)
190
+    private function preparePivotAttributesForSave(array $attributes, BelongsToMany | MorphToMany $relation, string | int $relatedItemKey, $pivotKeyName)
191 191
     {
192 192
         $attributes[$relation->getForeignPivotKeyName()] = $relatedItemKey;
193 193
         $attributes[$relation->getRelatedPivotKeyName()] = $attributes[$relation->getRelationName()];
@@ -333,7 +333,7 @@  discard block
 block discarded – undo
333 333
         }
334 334
         // if column is not nullable in database, and there is no column default (null),
335 335
         // we will delete the entry from the database, otherwise it will throw and ugly DB error.
336
-        if (! $relationColumnIsNullable && $dbColumnDefault === null) {
336
+        if (!$relationColumnIsNullable && $dbColumnDefault === null) {
337 337
             return $removedEntries->lazy()->each->delete();
338 338
         }
339 339
 
@@ -378,7 +378,7 @@  discard block
 block discarded – undo
378 378
         }
379 379
 
380 380
         // use the collection of sent ids to match against database ids, delete the ones not found in the submitted ids.
381
-        if (! empty($relatedItemsSent)) {
381
+        if (!empty($relatedItemsSent)) {
382 382
             // we perform the cleanup of removed database items
383 383
             $entry->{$relationMethod}()->whereNotIn($relatedModelLocalKey, $relatedItemsSent)->lazy()->each->delete();
384 384
         }
Please login to merge, or discard this patch.
src/macros.php 1 patch
Spacing   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -19,8 +19,8 @@  discard block
 block discarded – undo
19 19
  *      - when true: `address[street]`
20 20
  *      - when false: `[address][street]`
21 21
  */
22
-if (! Str::hasMacro('dotsToSquareBrackets')) {
23
-    Str::macro('dotsToSquareBrackets', function ($string, $ignore = [], $keyFirst = true) {
22
+if (!Str::hasMacro('dotsToSquareBrackets')) {
23
+    Str::macro('dotsToSquareBrackets', function($string, $ignore = [], $keyFirst = true) {
24 24
         $stringParts = explode('.', $string);
25 25
         $result = '';
26 26
 
@@ -34,8 +34,8 @@  discard block
 block discarded – undo
34 34
         return $result;
35 35
     });
36 36
 }
37
-if (! CrudColumn::hasMacro('withFiles')) {
38
-    CrudColumn::macro('withFiles', function ($uploadDefinition = [], $subfield = null, $registerUploaderEvents = true) {
37
+if (!CrudColumn::hasMacro('withFiles')) {
38
+    CrudColumn::macro('withFiles', function($uploadDefinition = [], $subfield = null, $registerUploaderEvents = true) {
39 39
         $uploadDefinition = is_array($uploadDefinition) ? $uploadDefinition : [];
40 40
         /** @var CrudField|CrudColumn $this */
41 41
         RegisterUploadEvents::handle($this, $uploadDefinition, 'withFiles', $subfield, $registerUploaderEvents);
@@ -44,8 +44,8 @@  discard block
 block discarded – undo
44 44
     });
45 45
 }
46 46
 
47
-if (! CrudField::hasMacro('withFiles')) {
48
-    CrudField::macro('withFiles', function ($uploadDefinition = [], $subfield = null, $registerUploaderEvents = true) {
47
+if (!CrudField::hasMacro('withFiles')) {
48
+    CrudField::macro('withFiles', function($uploadDefinition = [], $subfield = null, $registerUploaderEvents = true) {
49 49
         $uploadDefinition = is_array($uploadDefinition) ? $uploadDefinition : [];
50 50
         /** @var CrudField|CrudColumn $this */
51 51
         RegisterUploadEvents::handle($this, $uploadDefinition, 'withFiles', $subfield, $registerUploaderEvents);
@@ -54,8 +54,8 @@  discard block
 block discarded – undo
54 54
     });
55 55
 }
56 56
 
57
-if (! CrudColumn::hasMacro('linkTo')) {
58
-    CrudColumn::macro('linkTo', function (string|array|Closure $routeOrConfiguration, ?array $parameters = []): static {
57
+if (!CrudColumn::hasMacro('linkTo')) {
58
+    CrudColumn::macro('linkTo', function(string | array | Closure $routeOrConfiguration, ?array $parameters = []): static {
59 59
         $wrapper = $this->attributes['wrapper'] ?? [];
60 60
 
61 61
         // parse the function input to get the actual route and parameters we'll be working with
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
 
69 69
         // if the route is a closure, we'll just call it
70 70
         if ($route instanceof Closure) {
71
-            $wrapper['href'] = function ($crud, $column, $entry, $related_key) use ($route) {
71
+            $wrapper['href'] = function($crud, $column, $entry, $related_key) use ($route) {
72 72
                 return $route($entry, $related_key, $column, $crud);
73 73
             };
74 74
             $this->wrapper($wrapper);
@@ -77,13 +77,13 @@  discard block
 block discarded – undo
77 77
         }
78 78
 
79 79
         // if the route doesn't exist, we'll throw an exception
80
-        if (! $routeInstance = Route::getRoutes()->getByName($route)) {
80
+        if (!$routeInstance = Route::getRoutes()->getByName($route)) {
81 81
             throw new \Exception("Route [{$route}] not found while building the link for column [{$this->attributes['name']}].");
82 82
         }
83 83
 
84 84
         // calculate the parameters we'll be using for the route() call
85 85
         // (eg. if there's only one parameter and user didn't provide it, we'll assume it's the entry's related key)
86
-        $parameters = (function () use ($parameters, $routeInstance, $route) {
86
+        $parameters = (function() use ($parameters, $routeInstance, $route) {
87 87
             $expectedParameters = $routeInstance->parameterNames();
88 88
 
89 89
             if (count($expectedParameters) === 0) {
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
             if (count($autoInferredParameter) > 1) {
95 95
                 throw new \Exception("Route [{$route}] expects parameters [".implode(', ', $expectedParameters)."]. Insufficient parameters provided in column: [{$this->attributes['name']}].");
96 96
             }
97
-            $autoInferredParameter = current($autoInferredParameter) ? [current($autoInferredParameter) => function ($entry, $related_key, $column, $crud) {
97
+            $autoInferredParameter = current($autoInferredParameter) ? [current($autoInferredParameter) => function($entry, $related_key, $column, $crud) {
98 98
                 $entity = $crud->isAttributeInRelationString($column) ? Str::before($column['entity'], '.') : $column['entity'];
99 99
 
100 100
                 return $related_key ?? $entry->{$entity}?->getKey();
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
         })();
105 105
 
106 106
         // set up the wrapper href attribute
107
-        $wrapper['href'] = function ($crud, $column, $entry, $related_key) use ($route, $parameters) {
107
+        $wrapper['href'] = function($crud, $column, $entry, $related_key) use ($route, $parameters) {
108 108
             // if the parameter is callable, we'll call it
109 109
             $parameters = collect($parameters)->map(fn ($item) => is_callable($item) ? $item($entry, $related_key, $column, $crud) : $item)->toArray();
110 110
 
@@ -121,17 +121,17 @@  discard block
 block discarded – undo
121 121
     });
122 122
 }
123 123
 
124
-if (! CrudColumn::hasMacro('linkToShow')) {
125
-    CrudColumn::macro('linkToShow', function (): static {
124
+if (!CrudColumn::hasMacro('linkToShow')) {
125
+    CrudColumn::macro('linkToShow', function(): static {
126 126
         $name = $this->attributes['name'];
127 127
         $entity = $this->attributes['entity'] ?? null;
128 128
         $route = "$entity.show";
129 129
 
130
-        if (! $entity) {
130
+        if (!$entity) {
131 131
             throw new \Exception("Entity not found while building the link for column [{$name}].");
132 132
         }
133 133
 
134
-        if (! Route::getRoutes()->getByName($route)) {
134
+        if (!Route::getRoutes()->getByName($route)) {
135 135
             throw new \Exception("Route '{$route}' not found while building the link for column [{$name}].");
136 136
         }
137 137
 
@@ -142,8 +142,8 @@  discard block
 block discarded – undo
142 142
     });
143 143
 }
144 144
 
145
-if (! CrudColumn::hasMacro('linkTarget')) {
146
-    CrudColumn::macro('linkTarget', function (string $target = '_self'): static {
145
+if (!CrudColumn::hasMacro('linkTarget')) {
146
+    CrudColumn::macro('linkTarget', function(string $target = '_self'): static {
147 147
         $this->wrapper([
148 148
             ...$this->attributes['wrapper'] ?? [],
149 149
             'target' => $target,
@@ -159,8 +159,8 @@  discard block
 block discarded – undo
159 159
  *
160 160
  * It will go to the given CrudController and get the setupRoutes() method on it.
161 161
  */
162
-if (! Route::hasMacro('crud')) {
163
-    Route::macro('crud', function ($name, $controller) {
162
+if (!Route::hasMacro('crud')) {
163
+    Route::macro('crud', function($name, $controller) {
164 164
         // put together the route name prefix,
165 165
         // as passed to the Route::group() statements
166 166
         $routeName = '';
Please login to merge, or discard this patch.
src/app/Console/Commands/Themes/InstallsTheme.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
         }
72 72
 
73 73
         // Display general error in case it failed
74
-        if (! $this->isInstalled()) {
74
+        if (!$this->isInstalled()) {
75 75
             $this->errorProgressBlock();
76 76
             $this->note('For further information please check the log file.');
77 77
             $this->note('You can also follow the manual installation process documented on GitHub.');
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
         $this->progressBlock('Publish theme config file');
85 85
 
86 86
         // manually include the provider in the run-time
87
-        if (! class_exists(self::$addon['provider'])) {
87
+        if (!class_exists(self::$addon['provider'])) {
88 88
             include self::$addon['provider_path'] ?? self::$addon['path'].'/src/AddonServiceProvider.php';
89 89
             app()->register(self::$addon['provider']);
90 90
         }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudPanel.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -109,11 +109,11 @@  discard block
 block discarded – undo
109 109
      */
110 110
     public function setModel($model_namespace)
111 111
     {
112
-        if (! class_exists($model_namespace)) {
112
+        if (!class_exists($model_namespace)) {
113 113
             throw new \Exception('The model does not exist.', 500);
114 114
         }
115 115
 
116
-        if (! method_exists($model_namespace, 'hasCrudTrait')) {
116
+        if (!method_exists($model_namespace, 'hasCrudTrait')) {
117 117
             throw new \Exception('Please use CrudTrait on the model.', 500);
118 118
         }
119 119
 
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
 
207 207
         $complete_route = $route.'.index';
208 208
 
209
-        if (! \Route::has($complete_route)) {
209
+        if (!\Route::has($complete_route)) {
210 210
             throw new \Exception('There are no routes for this route name.', 404);
211 211
         }
212 212
 
@@ -304,7 +304,7 @@  discard block
 block discarded – undo
304 304
      */
305 305
     public function getFirstOfItsTypeInArray($type, $array)
306 306
     {
307
-        return Arr::first($array, function ($item) use ($type) {
307
+        return Arr::first($array, function($item) use ($type) {
308 308
             return $item['type'] == $type;
309 309
         });
310 310
     }
@@ -324,8 +324,8 @@  discard block
 block discarded – undo
324 324
      */
325 325
     public function sync($type, $fields, $attributes)
326 326
     {
327
-        if (! empty($this->{$type})) {
328
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
327
+        if (!empty($this->{$type})) {
328
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
329 329
                 if (in_array($field['name'], (array) $fields)) {
330 330
                     $field = array_merge($field, $attributes);
331 331
                 }
@@ -355,15 +355,15 @@  discard block
 block discarded – undo
355 355
     {
356 356
         $relationArray = explode('.', $relationString);
357 357
 
358
-        if (! isset($length)) {
358
+        if (!isset($length)) {
359 359
             $length = count($relationArray);
360 360
         }
361 361
 
362
-        if (! isset($model)) {
362
+        if (!isset($model)) {
363 363
             $model = $this->model;
364 364
         }
365 365
 
366
-        $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
366
+        $result = array_reduce(array_splice($relationArray, 0, $length), function($obj, $method) {
367 367
             try {
368 368
                 $result = $obj->$method();
369 369
 
@@ -398,7 +398,7 @@  discard block
 block discarded – undo
398 398
             if (is_array($entries)) {
399 399
                 //if attribute does not exist in main array we have more than one entry OR the attribute
400 400
                 //is an accessor that is not in $appends property of model.
401
-                if (! isset($entries[$attribute])) {
401
+                if (!isset($entries[$attribute])) {
402 402
                     //we first check if we don't have the attribute because it's an accessor that is not in appends.
403 403
                     if ($model_instance->hasGetMutator($attribute) && isset($entries[$modelKey])) {
404 404
                         $entry_in_database = $model_instance->find($entries[$modelKey]);
@@ -437,21 +437,21 @@  discard block
 block discarded – undo
437 437
      */
438 438
     public function parseTranslatableAttributes($model, $attribute, $value)
439 439
     {
440
-        if (! method_exists($model, 'isTranslatableAttribute')) {
440
+        if (!method_exists($model, 'isTranslatableAttribute')) {
441 441
             return $value;
442 442
         }
443 443
 
444
-        if (! $model->isTranslatableAttribute($attribute)) {
444
+        if (!$model->isTranslatableAttribute($attribute)) {
445 445
             return $value;
446 446
         }
447 447
 
448
-        if (! is_array($value)) {
448
+        if (!is_array($value)) {
449 449
             $decodedAttribute = json_decode($value, true);
450 450
         } else {
451 451
             $decodedAttribute = $value;
452 452
         }
453 453
 
454
-        if (is_array($decodedAttribute) && ! empty($decodedAttribute)) {
454
+        if (is_array($decodedAttribute) && !empty($decodedAttribute)) {
455 455
             if (isset($decodedAttribute[app()->getLocale()])) {
456 456
                 return $decodedAttribute[app()->getLocale()];
457 457
             } else {
@@ -477,7 +477,7 @@  discard block
 block discarded – undo
477 477
         $relation = $model->{$firstRelationName};
478 478
 
479 479
         $results = [];
480
-        if (! is_null($relation)) {
480
+        if (!is_null($relation)) {
481 481
             if ($relation instanceof Collection) {
482 482
                 $currentResults = $relation->all();
483 483
             } elseif (is_array($relation)) {
@@ -490,7 +490,7 @@  discard block
 block discarded – undo
490 490
 
491 491
             array_shift($relationArray);
492 492
 
493
-            if (! empty($relationArray)) {
493
+            if (!empty($relationArray)) {
494 494
                 foreach ($currentResults as $currentResult) {
495 495
                     $results = array_merge_recursive($results, $this->getRelatedEntries($currentResult, implode('.', $relationArray)));
496 496
                 }
Please login to merge, or discard this patch.