Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — main (#5611)
by Pedro
30:19 queued 15:46
created
tests/Unit/CrudPanel/CrudPanelSearchTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
         $this->crudPanel->addColumn([
91 91
             'name' => 'test',
92 92
             'type' => 'my_custom_type',
93
-            'searchLogic' => function ($query, $column, $searchTerm) {
93
+            'searchLogic' => function($query, $column, $searchTerm) {
94 94
                 $query->where($column['name'], 'like', "%{$searchTerm}%");
95 95
             },
96 96
             'tableColumn' => true,
@@ -225,7 +225,7 @@  discard block
 block discarded – undo
225 225
             'name' => 'name',
226 226
             'type' => 'text',
227 227
             'tableColumn' => true,
228
-            'orderLogic' => function ($query, $column, $searchTerm) {
228
+            'orderLogic' => function($query, $column, $searchTerm) {
229 229
                 $query->orderBy('name', 'asc');
230 230
             },
231 231
         ]);
@@ -244,7 +244,7 @@  discard block
 block discarded – undo
244 244
             'name' => 'name',
245 245
             'type' => 'text',
246 246
             'tableColumn' => true,
247
-            'orderLogic' => function ($query, $column, $searchTerm) {
247
+            'orderLogic' => function($query, $column, $searchTerm) {
248 248
                 $query->orderBy('id', 'asc');
249 249
             },
250 250
         ]);
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Search.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -22,9 +22,9 @@  discard block
 block discarded – undo
22 22
      */
23 23
     public function applySearchTerm($searchTerm)
24 24
     {
25
-        return $this->query->where(function ($query) use ($searchTerm) {
25
+        return $this->query->where(function($query) use ($searchTerm) {
26 26
             foreach ($this->columns() as $column) {
27
-                if (! isset($column['type'])) {
27
+                if (!isset($column['type'])) {
28 28
                     abort(400, 'Missing column type when trying to apply search term.');
29 29
                 }
30 30
 
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 
85 85
                 case 'select':
86 86
                 case 'select_multiple':
87
-                    $query->orWhereHas($column['entity'], function ($q) use ($column, $searchTerm, $searchOperator) {
87
+                    $query->orWhereHas($column['entity'], function($q) use ($column, $searchTerm, $searchOperator) {
88 88
                         $q->where($this->getColumnWithTableNamePrefixed($q, $column['attribute']), $searchOperator, '%'.$searchTerm.'%');
89 89
                     });
90 90
                     break;
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
                 $column_direction = (strtolower((string) $order['dir']) == 'asc' ? 'ASC' : 'DESC');
109 109
                 $column = $this->findColumnById($column_number);
110 110
 
111
-                if ($column['tableColumn'] && ! isset($column['orderLogic'])) {
111
+                if ($column['tableColumn'] && !isset($column['orderLogic'])) {
112 112
                     if (method_exists($this->model, 'translationEnabled') &&
113 113
                         $this->model->translationEnabled() &&
114 114
                         $this->model->isTranslatableAttribute($column['name']) &&
@@ -136,12 +136,12 @@  discard block
 block discarded – undo
136 136
         $key = $this->model->getKeyName();
137 137
         $groupBy = $this->query->toBase()->groups;
138 138
 
139
-        $hasOrderByPrimaryKey = collect($orderBy)->some(function ($item) use ($key, $table) {
139
+        $hasOrderByPrimaryKey = collect($orderBy)->some(function($item) use ($key, $table) {
140 140
             return (isset($item['column']) && $item['column'] === $key)
141 141
                 || (isset($item['sql']) && str_contains($item['sql'], "$table.$key"));
142 142
         });
143 143
 
144
-        if (! $hasOrderByPrimaryKey && empty($groupBy)) {
144
+        if (!$hasOrderByPrimaryKey && empty($groupBy)) {
145 145
             $this->orderByWithPrefix($key, 'DESC');
146 146
         }
147 147
     }
@@ -320,13 +320,13 @@  discard block
 block discarded – undo
320 320
         if (isset($column['type'])) {
321 321
             // create a list of paths to column blade views
322 322
             // including the configured view_namespaces
323
-            $columnPaths = array_map(function ($item) use ($column) {
323
+            $columnPaths = array_map(function($item) use ($column) {
324 324
                 return $item.'.'.$column['type'];
325 325
             }, ViewNamespaces::getFor('columns'));
326 326
 
327 327
             // but always fall back to the stock 'text' column
328 328
             // if a view doesn't exist
329
-            if (! in_array('crud::columns.text', $columnPaths)) {
329
+            if (!in_array('crud::columns.text', $columnPaths)) {
330 330
                 $columnPaths[] = 'crud::columns.text';
331 331
             }
332 332
 
@@ -365,7 +365,7 @@  discard block
 block discarded – undo
365 365
      */
366 366
     private function renderCellView($view, $column, $entry, $rowNumber = false)
367 367
     {
368
-        if (! view()->exists($view)) {
368
+        if (!view()->exists($view)) {
369 369
             $view = 'crud::columns.text'; // fallback to text column
370 370
         }
371 371
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/FieldsProtectedMethods.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
             return ['name' => Str::replace(' ', '', $field)];
116 116
         }
117 117
 
118
-        if (is_array($field) && ! isset($field['name'])) {
118
+        if (is_array($field) && !isset($field['name'])) {
119 119
             abort(500, 'All fields must have their name defined');
120 120
         }
121 121
 
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
         }
190 190
         // if there's a model defined, but no attribute
191 191
         // guess an attribute using the identifiableAttribute functionality in CrudTrait
192
-        if (isset($field['model']) && ! isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
192
+        if (isset($field['model']) && !isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
193 193
             $field['attribute'] = (new $field['model']())->identifiableAttribute();
194 194
         }
195 195
 
@@ -205,7 +205,7 @@  discard block
 block discarded – undo
205 205
      */
206 206
     protected function makeSureFieldHasLabel($field)
207 207
     {
208
-        if (! isset($field['label'])) {
208
+        if (!isset($field['label'])) {
209 209
             $name = str_replace(',', ' ', $field['name']);
210 210
             $name = str_replace('_id', '', $name);
211 211
             $field['label'] = mb_ucfirst(str_replace('_', ' ', $name));
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
      */
224 224
     protected function makeSureFieldHasType($field)
225 225
     {
226
-        if (! isset($field['type'])) {
226
+        if (!isset($field['type'])) {
227 227
             $field['type'] = isset($field['relation_type']) ? $this->inferFieldTypeFromRelationType($field['relation_type']) : $this->inferFieldTypeFromDbColumnType($field['name']);
228 228
         }
229 229
 
@@ -256,16 +256,16 @@  discard block
 block discarded – undo
256 256
      */
257 257
     protected function makeSureSubfieldsHaveNecessaryAttributes($field, $includeRelationFields = true)
258 258
     {
259
-        if (! isset($field['subfields']) || ! is_array($field['subfields'])) {
259
+        if (!isset($field['subfields']) || !is_array($field['subfields'])) {
260 260
             return $field;
261 261
         }
262 262
 
263
-        if (! is_multidimensional_array($field['subfields'], true)) {
263
+        if (!is_multidimensional_array($field['subfields'], true)) {
264 264
             abort(500, 'Subfields of «'.$field['name'].'» are malformed. Make sure you provide an array of subfields.');
265 265
         }
266 266
 
267 267
         foreach ($field['subfields'] as $key => $subfield) {
268
-            if (empty($subfield) || ! isset($subfield['name'])) {
268
+            if (empty($subfield) || !isset($subfield['name'])) {
269 269
                 abort(500, 'A subfield of «'.$field['name'].'» is malformed. Subfield attribute name can\'t be empty.');
270 270
             }
271 271
 
@@ -278,7 +278,7 @@  discard block
 block discarded – undo
278 278
 
279 279
             $subfield['parentFieldName'] = $field['name'];
280 280
 
281
-            if (! isset($field['model'])) {
281
+            if (!isset($field['model'])) {
282 282
                 // we're inside a simple 'repeatable' with no model/relationship, so
283 283
                 // we assume all subfields are supposed to be text fields
284 284
                 $subfield['type'] = $subfield['type'] ?? 'text';
@@ -305,11 +305,11 @@  discard block
 block discarded – undo
305 305
                 case 'BelongsToMany':
306 306
                     $pivotSelectorField = static::getPivotFieldStructure($field);
307 307
 
308
-                    $pivot = Arr::where($field['subfields'], function ($item) use ($pivotSelectorField) {
308
+                    $pivot = Arr::where($field['subfields'], function($item) use ($pivotSelectorField) {
309 309
                         return $item['name'] === $pivotSelectorField['name'];
310 310
                     });
311 311
 
312
-                    if (! empty($pivot)) {
312
+                    if (!empty($pivot)) {
313 313
                         break;
314 314
                     }
315 315
 
@@ -333,11 +333,11 @@  discard block
 block discarded – undo
333 333
                     $entity = isset($field['baseEntity']) ? $field['baseEntity'].'.'.$field['entity'] : $field['entity'];
334 334
                     $relationInstance = $this->getRelationInstance(['entity' => $entity]);
335 335
 
336
-                    $localKeyField = Arr::where($field['subfields'], function ($item) use ($relationInstance) {
336
+                    $localKeyField = Arr::where($field['subfields'], function($item) use ($relationInstance) {
337 337
                         return $item['name'] === $relationInstance->getRelated()->getKeyName();
338 338
                     });
339 339
 
340
-                    if (! empty($localKeyField)) {
340
+                    if (!empty($localKeyField)) {
341 341
                         break;
342 342
                     }
343 343
 
@@ -362,7 +362,7 @@  discard block
 block discarded – undo
362 362
     {
363 363
         // if a tab was mentioned, we should enable it
364 364
         if (isset($field['tab'])) {
365
-            if (! $this->tabsEnabled()) {
365
+            if (!$this->tabsEnabled()) {
366 366
                 $this->enableTabs();
367 367
             }
368 368
         }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudColumn.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
      */
88 88
     public function key(string $key)
89 89
     {
90
-        if (! isset($this->attributes['name'])) {
90
+        if (!isset($this->attributes['name'])) {
91 91
             abort(500, 'Column name must be defined before changing the key.');
92 92
         }
93 93
 
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
      */
116 116
     public function subfields($subfields)
117 117
     {
118
-        $callAttributeMacro = ! isset($this->attributes['subfields']);
118
+        $callAttributeMacro = !isset($this->attributes['subfields']);
119 119
         $this->attributes['subfields'] = $subfields;
120 120
         $this->attributes = $this->crud()->makeSureColumnHasNeededAttributes($this->attributes);
121 121
 
Please login to merge, or discard this patch.