Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Setup Failed
Pull Request — master (#2349)
by Mustafa
07:05
created
src/app/Library/CrudPanel/Traits/Settings.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -113,7 +113,7 @@
 block discarded – undo
113 113
      *
114 114
      * @param string $key Has no operation prepended. (ex: exportButtons)
115 115
      *
116
-     * @return mixed [description]
116
+     * @return boolean [description]
117 117
      */
118 118
     public function hasOperationSetting(string $key, $operation = null)
119 119
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@
 block discarded – undo
55 55
      */
56 56
     public function settings()
57 57
     {
58
-        return array_sort($this->settings, function ($value, $key) {
58
+        return array_sort($this->settings, function($value, $key) {
59 59
             return $key;
60 60
         });
61 61
     }
Please login to merge, or discard this patch.
src/resources/views/crud/fields/checklist_dependency.blade.php 1 patch
Indentation   +24 added lines, -24 removed lines patch added patch discarded remove patch
@@ -22,36 +22,36 @@
 block discarded – undo
22 22
             }
23 23
         }
24 24
 
25
-      //for update form, get initial state of the entity
26
-      if (isset($id) && $id) {
25
+        //for update form, get initial state of the entity
26
+        if (isset($id) && $id) {
27 27
 
28 28
         //get entity with relations for primary dependency
29
-          $entity_dependencies = $entity_model->with($primary_dependency['entity'])
30
-          ->with($primary_dependency['entity'].'.'.$primary_dependency['entity_secondary'])
31
-          ->find($id);
29
+            $entity_dependencies = $entity_model->with($primary_dependency['entity'])
30
+            ->with($primary_dependency['entity'].'.'.$primary_dependency['entity_secondary'])
31
+            ->find($id);
32 32
 
33
-          $secondaries_from_primary = [];
33
+            $secondaries_from_primary = [];
34 34
 
35
-          //convert relation in array
36
-          $primary_array = $entity_dependencies->{$primary_dependency['entity']}->toArray();
35
+            //convert relation in array
36
+            $primary_array = $entity_dependencies->{$primary_dependency['entity']}->toArray();
37 37
 
38
-          $secondary_ids = [];
38
+            $secondary_ids = [];
39 39
 
40
-          //create secondary dependency from primary relation, used to check what chekbox must be check from second checklist
41
-          if (old($primary_dependency['name'])) {
42
-              foreach (old($primary_dependency['name']) as $primary_item) {
43
-                  foreach ($dependencyArray[$primary_item] as $second_item) {
44
-                      $secondary_ids[$second_item] = $second_item;
45
-                  }
46
-              }
47
-          } else { //create dependecies from relation if not from validate error
48
-              foreach ($primary_array as $primary_item) {
49
-                  foreach ($primary_item[$secondary_dependency['entity']] as $second_item) {
50
-                      $secondary_ids[$second_item['id']] = $second_item['id'];
51
-                  }
52
-              }
53
-          }
54
-      }
40
+            //create secondary dependency from primary relation, used to check what chekbox must be check from second checklist
41
+            if (old($primary_dependency['name'])) {
42
+                foreach (old($primary_dependency['name']) as $primary_item) {
43
+                    foreach ($dependencyArray[$primary_item] as $second_item) {
44
+                        $secondary_ids[$second_item] = $second_item;
45
+                    }
46
+                }
47
+            } else { //create dependecies from relation if not from validate error
48
+                foreach ($primary_array as $primary_item) {
49
+                    foreach ($primary_item[$secondary_dependency['entity']] as $second_item) {
50
+                        $secondary_ids[$second_item['id']] = $second_item['id'];
51
+                    }
52
+                }
53
+            }
54
+        }
55 55
 
56 56
         //json encode of dependency matrix
57 57
         $dependencyJson = json_encode($dependencyArray);
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/UpdateOperation.php 2 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,6 @@
 block discarded – undo
9 9
     /**
10 10
      * Define which routes are needed for this operation.
11 11
      *
12
-     * @param string $name       Name of the current entity (singular). Used as first URL segment.
13 12
      * @param string $routeName  Prefix of the route name.
14 13
      * @param string $controller Name of the current CrudController.
15 14
      */
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
     {
42 42
         $this->crud->allowAccess('update');
43 43
 
44
-        $this->crud->operation('update', function () {
44
+        $this->crud->operation('update', function() {
45 45
             $this->crud->loadDefaultOperationSettingsFromConfig();
46 46
 
47 47
             if ($this->crud->getModel()->translationEnabled()) {
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
             }
54 54
         });
55 55
 
56
-        $this->crud->operation(['list', 'show'], function () {
56
+        $this->crud->operation(['list', 'show'], function() {
57 57
             $this->crud->addButton('line', 'update', 'view', 'crud::buttons.update', 'end');
58 58
         });
59 59
     }
Please login to merge, or discard this patch.
src/resources/views/crud/columns/array_count.blade.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,7 @@
 block discarded – undo
8 8
     $suffix = isset($column['suffix']) ? $column['suffix'] : 'items';
9 9
 
10 10
     // the value should be an array wether or not attribute casting is used
11
-    if (! is_array($array)) {
11
+    if (!is_array($array)) {
12 12
         $array = json_decode($array, true);
13 13
     }
14 14
     if ($array && count($array)) {
Please login to merge, or discard this patch.
src/resources/views/crud/reorder.blade.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
 <?php
29 29
 function tree_element($entry, $key, $all_entries, $crud)
30 30
 {
31
-    if (! isset($entry->tree_element_shown)) {
31
+    if (!isset($entry->tree_element_shown)) {
32 32
         // mark the element as shown
33 33
         $all_entries[$key]->tree_element_shown = true;
34 34
         $entry->tree_element_shown = true;
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
             <ol class="sortable mt-0">
72 72
             <?php
73 73
                 $all_entries = collect($entries->all())->sortBy('lft')->keyBy($crud->getModel()->getKeyName());
74
-                $root_entries = $all_entries->filter(function ($item) {
74
+                $root_entries = $all_entries->filter(function($item) {
75 75
                     return $item->parent_id == 0;
76 76
                 });
77 77
                 foreach ($root_entries as $key => $entry) {
Please login to merge, or discard this patch.
src/resources/views/crud/fields/date_picker.blade.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -9,10 +9,10 @@
 block discarded – undo
9 9
 
10 10
     $field_language = isset($field['date_picker_options']['language']) ? $field['date_picker_options']['language'] : \App::getLocale();
11 11
 
12
-    if (! isset($field['attributes']['style'])) {
12
+    if (!isset($field['attributes']['style'])) {
13 13
         $field['attributes']['style'] = 'background-color: white!important;';
14 14
     }
15
-    if (! isset($field['attributes']['readonly'])) {
15
+    if (!isset($field['attributes']['readonly'])) {
16 16
         $field['attributes']['readonly'] = 'readonly';
17 17
     }
18 18
 ?>
Please login to merge, or discard this patch.
src/resources/views/crud/fields/date_range.blade.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -3,11 +3,11 @@
 block discarded – undo
3 3
 <?php
4 4
     // if the column has been cast to Carbon or Date (using attribute casting)
5 5
     // get the value as a date string
6
-    if (! function_exists('formatDate')) {
6
+    if (!function_exists('formatDate')) {
7 7
         function formatDate($entry, $dateFieldName)
8 8
         {
9 9
             $formattedDate = null;
10
-            if (isset($entry) && ! empty($entry->{$dateFieldName})) {
10
+            if (isset($entry) && !empty($entry->{$dateFieldName})) {
11 11
                 $dateField = $entry->{$dateFieldName};
12 12
                 if ($dateField instanceof \Carbon\CarbonInterface) {
13 13
                     $formattedDate = $dateField->format('Y-m-d H:i:s');
Please login to merge, or discard this patch.
src/resources/views/crud/fields/page_or_link.blade.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
         </div>
38 38
         <div class="col-sm-9">
39 39
             <!-- external link input -->
40
-              <div class="page_or_link_value page_or_link_external_link <?php if (! isset($entry) || $entry->type != 'external_link') {
40
+              <div class="page_or_link_value page_or_link_external_link <?php if (!isset($entry) || $entry->type != 'external_link') {
41 41
     echo 'd-none';
42 42
 } ?>">
43 43
                 <input
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
                     >
57 57
               </div>
58 58
               <!-- internal link input -->
59
-              <div class="page_or_link_value page_or_link_internal_link <?php if (! isset($entry) || $entry->type != 'internal_link') {
59
+              <div class="page_or_link_value page_or_link_internal_link <?php if (!isset($entry) || $entry->type != 'internal_link') {
60 60
     echo 'd-none';
61 61
 } ?>">
62 62
                 <input
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Fields.php 2 patches
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -38,23 +38,23 @@  discard block
 block discarded – undo
38 38
 
39 39
         // if this is a relation type field and no corresponding model was specified, get it from the relation method
40 40
         // defined in the main model
41
-        if (isset($newField['entity']) && ! isset($newField['model'])) {
41
+        if (isset($newField['entity']) && !isset($newField['model'])) {
42 42
             $newField['model'] = $this->getRelationModel($newField['entity']);
43 43
         }
44 44
 
45 45
         // if the label is missing, we should set it
46
-        if (! isset($newField['label'])) {
46
+        if (!isset($newField['label'])) {
47 47
             $newField['label'] = mb_ucfirst(str_replace('_', ' ', $newField['name']));
48 48
         }
49 49
 
50 50
         // if the field type is missing, we should set it
51
-        if (! isset($newField['type'])) {
51
+        if (!isset($newField['type'])) {
52 52
             $newField['type'] = $this->getFieldTypeFromDbColumnType($newField['name']);
53 53
         }
54 54
 
55 55
         // if a tab was mentioned, we should enable it
56 56
         if (isset($newField['tab'])) {
57
-            if (! $this->tabsEnabled()) {
57
+            if (!$this->tabsEnabled()) {
58 58
                 $this->enableTabs();
59 59
             }
60 60
         }
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
      */
91 91
     public function afterField($targetFieldName)
92 92
     {
93
-        $this->transformFields(function ($fields) use ($targetFieldName) {
93
+        $this->transformFields(function($fields) use ($targetFieldName) {
94 94
             return $this->moveField($fields, $targetFieldName, false);
95 95
         });
96 96
     }
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
      */
104 104
     public function beforeField($targetFieldName)
105 105
     {
106
-        $this->transformFields(function ($fields) use ($targetFieldName) {
106
+        $this->transformFields(function($fields) use ($targetFieldName) {
107 107
             return $this->moveField($fields, $targetFieldName, true);
108 108
         });
109 109
     }
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
      */
147 147
     public function removeField($name)
148 148
     {
149
-        $this->transformFields(function ($fields) use ($name) {
149
+        $this->transformFields(function($fields) use ($name) {
150 150
             array_forget($fields, $name);
151 151
 
152 152
             return $fields;
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
      */
161 161
     public function removeFields($array_of_names)
162 162
     {
163
-        if (! empty($array_of_names)) {
163
+        if (!empty($array_of_names)) {
164 164
             foreach ($array_of_names as $name) {
165 165
                 $this->removeField($name);
166 166
             }
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
     public function removeAllFields()
174 174
     {
175 175
         $current_fields = $this->getCurrentFields();
176
-        if (! empty($current_fields)) {
176
+        if (!empty($current_fields)) {
177 177
             foreach ($current_fields as $field) {
178 178
                 $this->removeField($field['name']);
179 179
             }
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
                 $jsonCastables = ['array', 'object', 'json'];
248 248
                 $fieldCasting = $casted_attributes[$field['name']];
249 249
 
250
-                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && ! empty($data[$field['name']]) && ! is_array($data[$field['name']])) {
250
+                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && !empty($data[$field['name']]) && !is_array($data[$field['name']])) {
251 251
                     try {
252 252
                         $data[$field['name']] = json_decode($data[$field['name']]);
253 253
                     } catch (\Exception $e) {
@@ -276,7 +276,7 @@  discard block
 block discarded – undo
276 276
      */
277 277
     public function orderFields($order)
278 278
     {
279
-        $this->transformFields(function ($fields) use ($order) {
279
+        $this->transformFields(function($fields) use ($order) {
280 280
             return $this->applyOrderToFields($fields, $order);
281 281
         });
282 282
     }
@@ -339,7 +339,7 @@  discard block
 block discarded – undo
339 339
     public function hasUploadFields()
340 340
     {
341 341
         $fields = $this->getFields();
342
-        $upload_fields = array_where($fields, function ($value, $key) {
342
+        $upload_fields = array_where($fields, function($value, $key) {
343 343
             return isset($value['upload']) && $value['upload'] == true;
344 344
         });
345 345
 
@@ -399,7 +399,7 @@  discard block
 block discarded – undo
399 399
         $alreadyLoaded = $this->getLoadedFieldTypes();
400 400
         $type = $this->getFieldTypeWithNamespace($field);
401 401
 
402
-        if (! in_array($type, $this->getLoadedFieldTypes(), true)) {
402
+        if (!in_array($type, $this->getLoadedFieldTypes(), true)) {
403 403
             $alreadyLoaded[] = $type;
404 404
             $this->setLoadedFieldTypes($alreadyLoaded);
405 405
 
@@ -440,7 +440,7 @@  discard block
 block discarded – undo
440 440
      */
441 441
     public function fieldTypeNotLoaded($field)
442 442
     {
443
-        return ! in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
443
+        return !in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
444 444
     }
445 445
 
446 446
     /**
Please login to merge, or discard this patch.
Doc Comments   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -326,8 +326,6 @@  discard block
 block discarded – undo
326 326
      * Check if the create/update form has upload fields.
327 327
      * Upload fields are the ones that have "upload" => true defined on them.
328 328
      *
329
-     * @param string   $form create/update/both - defaults to 'both'
330
-     * @param bool|int $id   id of the entity - defaults to false
331 329
      *
332 330
      * @return bool
333 331
      */
@@ -358,7 +356,7 @@  discard block
 block discarded – undo
358 356
     /**
359 357
      * Set an array of field type names as already loaded for the current operation.
360 358
      *
361
-     * @param array $fieldTypes
359
+     * @param string[] $fieldTypes
362 360
      */
363 361
     public function setLoadedFieldTypes($fieldTypes)
364 362
     {
@@ -369,7 +367,7 @@  discard block
 block discarded – undo
369 367
      * Get a namespaced version of the field type name.
370 368
      * Appends the 'view_namespace' attribute of the field to the `type', using dot notation.
371 369
      *
372
-     * @param  array $field Field array
370
+     * @param  string $field Field array
373 371
      * @return string Namespaced version of the field type name. Ex: 'text', 'custom.view.path.text'
374 372
      */
375 373
     public function getFieldTypeWithNamespace($field)
Please login to merge, or discard this patch.