Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Push — separate-responsive-controls-f... ( e21722...a08eeb )
by Pedro
22:51 queued 08:05
created
tests/BaseTestClass.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
             (array) config('backpack.base.middleware_key', 'admin'),
26 26
             'prefix' => config('backpack.base.route_prefix', 'admin'),
27 27
         ],
28
-            function () {
28
+            function() {
29 29
                 Route::get('articles/{id}/show/{detail}', ['as' => 'article.show.detail', 'action' => 'Backpack\CRUD\Tests\config\Http\Controllers\ArticleCrudController@detail']);
30 30
                 Route::crud('users', 'Backpack\CRUD\Tests\config\Http\Controllers\UserCrudController');
31 31
                 Route::crud('articles', 'Backpack\CRUD\Tests\config\Http\Controllers\ArticleCrudController');
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
     protected function setupUserCreateRequest()
46 46
     {
47 47
         $request = request()->create('/admin/users/create', 'POST', ['name' => 'foo']);
48
-        $request->setRouteResolver(function () use ($request) {
48
+        $request->setRouteResolver(function() use ($request) {
49 49
             return (new RouteInstance('POST', 'admin/users/create', ['UserCrudController', 'create']))->bind($request);
50 50
         });
51 51
         $this->crudPanel->setRequest($request);
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelQueryTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
 
33 33
     public function testItCanAddAClauseToTheQueryUsingAClosure()
34 34
     {
35
-        $closure = function ($query) {
35
+        $closure = function($query) {
36 36
             $query->where('id', 1);
37 37
         };
38 38
 
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 
52 52
     public function testItCanAddABaseClauseToTheQueryUsingAClosure()
53 53
     {
54
-        $closure = function ($query) {
54
+        $closure = function($query) {
55 55
             $query->where('id', 1);
56 56
         };
57 57
 
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
         $this->crudPanel->addColumn([
116 116
             'name' => 'name',
117 117
             'type' => 'text',
118
-            'orderLogic' => function ($query, $column, $direction) {
118
+            'orderLogic' => function($query, $column, $direction) {
119 119
                 $query->orderBy('name', $direction);
120 120
             },
121 121
         ]);
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelSaveActionsTest.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -25,13 +25,13 @@  discard block
 block discarded – undo
25 25
         $this->singleSaveAction = [
26 26
             'name' => 'save_action_one',
27 27
             'button_text' => 'custom',
28
-            'redirect' => function ($crud, $request, $itemId) {
28
+            'redirect' => function($crud, $request, $itemId) {
29 29
                 return 'https://backpackforlaravel.com';
30 30
             },
31
-            'referrer_url' => function ($crud, $request, $itemId) {
31
+            'referrer_url' => function($crud, $request, $itemId) {
32 32
                 return 'https://backpackforlaravel.com';
33 33
             },
34
-            'visible' => function ($crud) {
34
+            'visible' => function($crud) {
35 35
                 return true;
36 36
             },
37 37
         ];
@@ -39,19 +39,19 @@  discard block
 block discarded – undo
39 39
         $this->multipleSaveActions = [
40 40
             [
41 41
                 'name' => 'save_action_one',
42
-                'redirect' => function ($crud, $request, $itemId) {
42
+                'redirect' => function($crud, $request, $itemId) {
43 43
                     return $crud->route;
44 44
                 },
45
-                'visible' => function ($crud) {
45
+                'visible' => function($crud) {
46 46
                     return true;
47 47
                 },
48 48
             ],
49 49
             [
50 50
                 'name' => 'save_action_two',
51
-                'redirect' => function ($crud, $request, $itemId) {
51
+                'redirect' => function($crud, $request, $itemId) {
52 52
                     return $crud->route;
53 53
                 },
54
-                'visible' => function ($crud) {
54
+                'visible' => function($crud) {
55 55
                     return true;
56 56
                 },
57 57
             ],
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/SaveActions.php 1 patch
Spacing   +15 added lines, -16 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
         $higherAction = $this->getSaveActionByOrder(1);
29 29
 
30 30
         //if there is an higher action and that action is not the backpack default higher one `save_and_back` we return it.
31
-        if (! empty($higherAction) && key($higherAction) !== 'save_and_back') {
31
+        if (!empty($higherAction) && key($higherAction) !== 'save_and_back') {
32 32
             return key($higherAction);
33 33
         }
34 34
 
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
      */
48 48
     public function getSaveActionByOrder($order)
49 49
     {
50
-        return array_filter($this->getOperationSetting('save_actions') ?? [], function ($arr) use ($order) {
50
+        return array_filter($this->getOperationSetting('save_actions') ?? [], function($arr) use ($order) {
51 51
             return $arr['order'] == $order;
52 52
         });
53 53
     }
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
 
89 89
         $actions = $this->getOperationSetting('save_actions') ?? [];
90 90
 
91
-        if (! in_array($saveAction['name'], $actions)) {
91
+        if (!in_array($saveAction['name'], $actions)) {
92 92
             $actions[$saveAction['name']] = $saveAction;
93 93
         }
94 94
 
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
     public function orderSaveAction(string $saveAction, int $wantedOrder)
106 106
     {
107 107
         $actions = $this->getOperationSetting('save_actions') ?? [];
108
-        if (! empty($actions)) {
108
+        if (!empty($actions)) {
109 109
             $replaceOrder = isset($actions[$saveAction]) ? $actions[$saveAction]['order'] : count($actions) + 1;
110 110
 
111 111
             foreach ($actions as $key => $sv) {
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
199 199
     public function orderSaveActions(array $saveActions)
200 200
     {
201 201
         foreach ($saveActions as $sv => $order) {
202
-            if (! is_int($order)) {
202
+            if (!is_int($order)) {
203 203
                 $this->orderSaveAction($order, $sv + 1);
204 204
             } else {
205 205
                 $this->orderSaveAction($sv, $order);
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
     {
217 217
         $actions = $this->getOperationSetting('save_actions') ?? [];
218 218
 
219
-        uasort($actions, function ($a, $b) {
219
+        uasort($actions, function($a, $b) {
220 220
             return $a['order'] <=> $b['order'];
221 221
         });
222 222
 
@@ -238,7 +238,7 @@  discard block
 block discarded – undo
238 238
             }
239 239
         }
240 240
 
241
-        return array_filter($actions, function ($action) {
241
+        return array_filter($actions, function($action) {
242 242
             return $action['visible'] == true;
243 243
         }, ARRAY_FILTER_USE_BOTH);
244 244
     }
@@ -300,8 +300,7 @@  discard block
 block discarded – undo
300 300
      */
301 301
     public function setSaveAction($forceSaveAction = null)
302 302
     {
303
-        $saveAction = $forceSaveAction ?:
304
-            $this->getRequest()->input('_save_action', $this->getFallBackSaveAction());
303
+        $saveAction = $forceSaveAction ?: $this->getRequest()->input('_save_action', $this->getFallBackSaveAction());
305 304
 
306 305
         $showBubble = $this->getOperationSetting('showSaveActionChange') ?? config('backpack.crud.operations.'.$this->getCurrentOperation().'.showSaveActionChange') ?? true;
307 306
 
@@ -369,20 +368,20 @@  discard block
 block discarded – undo
369 368
         $defaultSaveActions = [
370 369
             [
371 370
                 'name' => 'save_and_back',
372
-                'visible' => function ($crud) {
371
+                'visible' => function($crud) {
373 372
                     return $crud->hasAccess('list');
374 373
                 },
375
-                'redirect' => function ($crud, $request, $itemId = null) {
374
+                'redirect' => function($crud, $request, $itemId = null) {
376 375
                     return $request->has('_http_referrer') ? $request->get('_http_referrer') : $crud->route;
377 376
                 },
378 377
                 'button_text' => trans('backpack::crud.save_action_save_and_back'),
379 378
             ],
380 379
             [
381 380
                 'name' => 'save_and_edit',
382
-                'visible' => function ($crud) {
381
+                'visible' => function($crud) {
383 382
                     return $crud->hasAccess('update');
384 383
                 },
385
-                'redirect' => function ($crud, $request, $itemId = null) {
384
+                'redirect' => function($crud, $request, $itemId = null) {
386 385
                     $itemId = $itemId ?: $request->get('id');
387 386
                     $redirectUrl = $crud->route.'/'.$itemId.'/edit';
388 387
                     if ($request->has('_locale')) {
@@ -394,17 +393,17 @@  discard block
 block discarded – undo
394 393
 
395 394
                     return $redirectUrl;
396 395
                 },
397
-                'referrer_url' => function ($crud, $request, $itemId) {
396
+                'referrer_url' => function($crud, $request, $itemId) {
398 397
                     return url($crud->route.'/'.$itemId.'/edit');
399 398
                 },
400 399
                 'button_text' => trans('backpack::crud.save_action_save_and_edit'),
401 400
             ],
402 401
             [
403 402
                 'name' => 'save_and_new',
404
-                'visible' => function ($crud) {
403
+                'visible' => function($crud) {
405 404
                     return $crud->hasAccess('create');
406 405
                 },
407
-                'redirect' => function ($crud, $request, $itemId = null) {
406
+                'redirect' => function($crud, $request, $itemId = null) {
408 407
                     return $this->route.'/create';
409 408
                 },
410 409
                 'button_text' => trans('backpack::crud.save_action_save_and_new'),
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelSearchTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
         $this->crudPanel->addColumn([
91 91
             'name' => 'test',
92 92
             'type' => 'my_custom_type',
93
-            'searchLogic' => function ($query, $column, $searchTerm) {
93
+            'searchLogic' => function($query, $column, $searchTerm) {
94 94
                 $query->where($column['name'], 'like', "%{$searchTerm}%");
95 95
             },
96 96
             'tableColumn' => true,
@@ -225,7 +225,7 @@  discard block
 block discarded – undo
225 225
             'name' => 'name',
226 226
             'type' => 'text',
227 227
             'tableColumn' => true,
228
-            'orderLogic' => function ($query, $column, $searchTerm) {
228
+            'orderLogic' => function($query, $column, $searchTerm) {
229 229
                 $query->orderBy('name', 'asc');
230 230
             },
231 231
         ]);
@@ -244,7 +244,7 @@  discard block
 block discarded – undo
244 244
             'name' => 'name',
245 245
             'type' => 'text',
246 246
             'tableColumn' => true,
247
-            'orderLogic' => function ($query, $column, $searchTerm) {
247
+            'orderLogic' => function($query, $column, $searchTerm) {
248 248
                 $query->orderBy('id', 'asc');
249 249
             },
250 250
         ]);
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/ColumnsProtectedMethods.php 1 patch
Spacing   +8 added lines, -9 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
             return ['name' => Str::replace(' ', '', $column)];
51 51
         }
52 52
 
53
-        if (is_array($column) && ! isset($column['name'])) {
53
+        if (is_array($column) && !isset($column['name'])) {
54 54
             $column['name'] = 'anonymous_column_'.Str::random(5);
55 55
         }
56 56
 
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
      */
69 69
     protected function makeSureColumnHasLabel($column)
70 70
     {
71
-        if (! isset($column['label'])) {
71
+        if (!isset($column['label'])) {
72 72
             $column['label'] = mb_ucfirst($this->makeLabel($column['name']));
73 73
         }
74 74
 
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
      */
154 154
     protected function makeSureColumnHasKey($column)
155 155
     {
156
-        if (! isset($column['key'])) {
156
+        if (!isset($column['key'])) {
157 157
             $column['key'] = str_replace('.', '__', $column['name']);
158 158
         }
159 159
 
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
      */
171 171
     protected function makeSureColumnHasWrapper($column)
172 172
     {
173
-        if (! isset($column['wrapper'])) {
173
+        if (!isset($column['wrapper'])) {
174 174
             $column['wrapper'] = [];
175 175
         }
176 176
 
@@ -255,7 +255,7 @@  discard block
 block discarded – undo
255 255
     {
256 256
         // if this is a relation type field and no corresponding model was specified,
257 257
         // get it from the relation method defined in the main model
258
-        if (isset($column['entity']) && $column['entity'] !== false && ! isset($column['model'])) {
258
+        if (isset($column['entity']) && $column['entity'] !== false && !isset($column['model'])) {
259 259
             $column['model'] = $this->getRelationModel($column['entity']);
260 260
         }
261 261
 
@@ -292,8 +292,7 @@  discard block
 block discarded – undo
292 292
         $columnsArray = $this->columns();
293 293
 
294 294
         if (array_key_exists($targetColumnName, $columnsArray)) {
295
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) :
296
-                array_search($targetColumnName, array_keys($columnsArray)) + 1;
295
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) : array_search($targetColumnName, array_keys($columnsArray)) + 1;
297 296
 
298 297
             $element = array_pop($columnsArray);
299 298
 
@@ -322,7 +321,7 @@  discard block
 block discarded – undo
322 321
     {
323 322
         static $cache = [];
324 323
 
325
-        if (! $this->driverIsSql()) {
324
+        if (!$this->driverIsSql()) {
326 325
             return true;
327 326
         }
328 327
 
@@ -338,7 +337,7 @@  discard block
 block discarded – undo
338 337
     /**
339 338
      * Prepare the column attributes and add it to operation settings.
340 339
      */
341
-    private function prepareAttributesAndAddColumn(array|string $column): CrudColumn
340
+    private function prepareAttributesAndAddColumn(array | string $column): CrudColumn
342 341
     {
343 342
         $column = $this->makeSureColumnHasNeededAttributes($column);
344 343
         $this->addColumnToOperationSettings($column);
Please login to merge, or discard this patch.
src/app/Console/Commands/Install.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
 
84 84
         // Install Backpack Generators
85 85
         $this->progressBlock('Installing Generators');
86
-        if (! file_exists('vendor/backpack/generators/composer.json')) {
86
+        if (!file_exists('vendor/backpack/generators/composer.json')) {
87 87
             // only do this if Generators aren't already required
88 88
             $process = new Process(['composer', 'require', '--dev', 'backpack/generators']);
89 89
             $process->setTimeout(300);
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
         $this->closeProgressBlock();
98 98
 
99 99
         // Optional commands
100
-        if (! $this->option('no-interaction')) {
100
+        if (!$this->option('no-interaction')) {
101 101
             // Themes
102 102
             $this->installTheme();
103 103
 
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
 
107 107
             // Addons
108 108
             $this->installAddons();
109
-        } elseif (! $this->isAnyThemeInstalled()) {
109
+        } elseif (!$this->isAnyThemeInstalled()) {
110 110
             // Install default theme
111 111
             $this->progressBlock('Installing default theme');
112 112
             $this->executeArtisanProcess('backpack:require:theme-tabler');
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
 
190 190
         $this->deleteLines(3);
191 191
 
192
-        if (! $total) {
192
+        if (!$total) {
193 193
             $this->deleteLines();
194 194
             $this->note('Skipping creating an admin user.');
195 195
             $this->newLine();
@@ -198,14 +198,14 @@  discard block
 block discarded – undo
198 198
 
199 199
     private function isEveryAddonInstalled()
200 200
     {
201
-        return collect($this->addons)->every(function ($addon) {
201
+        return collect($this->addons)->every(function($addon) {
202 202
             return file_exists($addon->path);
203 203
         });
204 204
     }
205 205
 
206 206
     private function updateAddonsStatus()
207 207
     {
208
-        $this->addons = $this->addons->each(function (&$addon) {
208
+        $this->addons = $this->addons->each(function(&$addon) {
209 209
             $isInstalled = file_exists($addon->path);
210 210
             $addon->status = $isInstalled ? 'installed' : 'not installed';
211 211
             $addon->statusColor = $isInstalled ? 'green' : 'yellow';
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
     {
217 217
         // map the addons
218 218
         $this->addons = collect($this->addons)
219
-            ->map(function ($class) {
219
+            ->map(function($class) {
220 220
                 return (object) $class::$addon;
221 221
             });
222 222
 
@@ -235,15 +235,15 @@  discard block
 block discarded – undo
235 235
 
236 236
         // Calculate the printed line count
237 237
         $printedLines = $this->addons
238
-            ->map(function ($e) {
238
+            ->map(function($e) {
239 239
                 return count($e->description);
240 240
             })
241
-            ->reduce(function ($sum, $item) {
241
+            ->reduce(function($sum, $item) {
242 242
                 return $sum + $item + 2;
243 243
             }, 0);
244 244
 
245 245
         $total = 0;
246
-        while (! $this->isEveryAddonInstalled()) {
246
+        while (!$this->isEveryAddonInstalled()) {
247 247
             $input = (int) $this->listChoice('Would you like to install a premium Backpack add-on? <fg=gray>(enter an option number from above or press any other key to continue the installation)</>', $this->addons->toArray());
248 248
 
249 249
             if ($input < 1 || $input > $this->addons->count()) {
@@ -278,14 +278,14 @@  discard block
 block discarded – undo
278 278
 
279 279
     private function isEveryThemeInstalled()
280 280
     {
281
-        return $this->themes()->every(function ($theme) {
281
+        return $this->themes()->every(function($theme) {
282 282
             return $theme->status == 'installed';
283 283
         });
284 284
     }
285 285
 
286 286
     private function isAnyThemeInstalled()
287 287
     {
288
-        return $this->themes()->filter(function ($theme) {
288
+        return $this->themes()->filter(function($theme) {
289 289
             return $theme->status == 'installed';
290 290
         })->count() > 0;
291 291
     }
@@ -303,10 +303,10 @@  discard block
 block discarded – undo
303 303
 
304 304
         // Calculate the printed line count
305 305
         $printedLines = $this->themes()
306
-            ->map(function ($e) {
306
+            ->map(function($e) {
307 307
                 return count($e->description);
308 308
             })
309
-            ->reduce(function ($sum, $item) {
309
+            ->reduce(function($sum, $item) {
310 310
                 return $sum + $item + 2;
311 311
             }, 0);
312 312
 
@@ -342,9 +342,9 @@  discard block
 block discarded – undo
342 342
     public function themes()
343 343
     {
344 344
         return collect($this->themes)
345
-            ->map(function ($class) {
345
+            ->map(function($class) {
346 346
                 return (object) $class::$addon;
347
-            })->each(function (&$theme) {
347
+            })->each(function(&$theme) {
348 348
                 $isInstalled = file_exists($theme->path);
349 349
                 $theme->status = $isInstalled ? 'installed' : 'not installed';
350 350
                 $theme->statusColor = $isInstalled ? 'green' : 'yellow';
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Input.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
         }
99 99
 
100 100
         //remove fields that are not in the submitted form input
101
-        $relationFields = array_filter($relationFields, function ($field) use ($input) {
101
+        $relationFields = array_filter($relationFields, function($field) use ($input) {
102 102
             return Arr::has($input, $field['name']) || isset($input[$field['name']]) || Arr::has($input, Str::afterLast($field['name'], '.'));
103 103
         });
104 104
 
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
                     // the key used to store the values is the main relation key
128 128
                     $key = Str::beforeLast($this->getOnlyRelationEntity($field), '.');
129 129
 
130
-                    if (! isset($field['parentFieldName']) && isset($field['entity'])) {
130
+                    if (!isset($field['parentFieldName']) && isset($field['entity'])) {
131 131
                         $mainField = $field;
132 132
                         $mainField['entity'] = Str::beforeLast($field['entity'], '.');
133 133
 
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
 
186 186
             // when using dot notation if relationMethod is not set we are sure we want to exclude those relations.
187 187
             if ($this->getOnlyRelationEntity($field) !== $field['entity']) {
188
-                if (! $relationMethod) {
188
+                if (!$relationMethod) {
189 189
                     $excludedFields[] = $nameToExclude;
190 190
                 }
191 191
 
@@ -199,8 +199,8 @@  discard block
 block discarded – undo
199 199
             }
200 200
         }
201 201
 
202
-        return Arr::where($input, function ($item, $key) use ($excludedFields) {
203
-            return ! in_array($key, $excludedFields);
202
+        return Arr::where($input, function($item, $key) use ($excludedFields) {
203
+            return !in_array($key, $excludedFields);
204 204
         });
205 205
     }
206 206
 
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
226 226
                 $jsonCastables = ['array', 'object', 'json'];
227 227
                 $fieldCasting = $casted_attributes[$field['name']];
228 228
 
229
-                if (in_array($fieldCasting, $jsonCastables) && isset($input[$field['name']]) && ! empty($input[$field['name']]) && ! is_array($input[$field['name']])) {
229
+                if (in_array($fieldCasting, $jsonCastables) && isset($input[$field['name']]) && !empty($input[$field['name']]) && !is_array($input[$field['name']])) {
230 230
                     try {
231 231
                         $input[$field['name']] = json_decode($input[$field['name']]);
232 232
                     } catch (\Exception $e) {
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelColumnsTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -931,7 +931,7 @@
 block discarded – undo
931 931
 
932 932
     public function testItCanInferFieldAttributesFromADynamicRelation()
933 933
     {
934
-        User::resolveRelationUsing('dynamicRelation', function ($user) {
934
+        User::resolveRelationUsing('dynamicRelation', function($user) {
935 935
             return $user->belongsTo(\Backpack\CRUD\Tests\config\Models\Bang::class);
936 936
         });
937 937
 
Please login to merge, or discard this patch.