SaveActions - Code Metrics - Inspection of "changelog for 3.2.0" - Laravel-Backpack/CRUD - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f35a35...781975 )

by Cristian

created 2017-02-13 15:26 UTC

SaveActions A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	106
Duplicated Lines	11.32 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
dl	12
loc	106
rs	10
c	1
b	1
f	0
wmc	17
lcom	1
cbo	2

4 Methods

Rating	Name	Duplication	Size	Complexity
B	getSaveAction()	12	30	4
A	setSaveAction()	0	14	3
B	performSaveAction()	0	23	6
A	getSaveActionButtonName()	0	15	4

How to fix Duplicated Code

<?php

namespace Backpack\CRUD\app\Http\Controllers\CrudFeatures;

//save_and_back save_and_edit save_and_new
trait SaveActions
{
    /**
     * Get the save configured save action or the one stored in a session variable.
     * @return [type] [description]

     */
    public function getSaveAction()
    {
        $saveAction = session('save_action', config('backback.crud.default_save_action', 'save_and_back'));
        $saveOptions = [];
        $saveCurrent = [
            'value' => $saveAction,
            'label' => $this->getSaveActionButtonName($saveAction),
        ];

        switch ($saveAction) {
            case 'save_and_edit':

                $saveOptions['save_and_back'] = $this->getSaveActionButtonName('save_and_back');
                $saveOptions['save_and_new'] = $this->getSaveActionButtonName('save_and_new');
                break;
            case 'save_and_new':

                $saveOptions['save_and_back'] = $this->getSaveActionButtonName('save_and_back');
                $saveOptions['save_and_edit'] = $this->getSaveActionButtonName('save_and_edit');
                break;
            case 'save_and_black':
            default:

                $saveOptions['save_and_edit'] = $this->getSaveActionButtonName('save_and_edit');
                $saveOptions['save_and_new'] = $this->getSaveActionButtonName('save_and_new');
                break;
        }

        return [
            'active' => $saveCurrent,
            'options' => $saveOptions,
        ];
    }

    /**
     * Change the session variable that remembers what to do after the "Save" action.
     * @param [type] $forceSaveAction [description]

     */
    public function setSaveAction($forceSaveAction = null)
    {
        if ($forceSaveAction) {
            $saveAction = $forceSaveAction;
        } else {
            $saveAction = \Request::input('save_action', config('backback.crud.default_save_action', 'save_and_back'));
        }

        if (session('save_action', 'save_and_back') !== $saveAction) {
            \Alert::info(trans('backpack::crud.save_action_changed_notification'))->flash();
        }

        session(['save_action' => $saveAction]);
    }

    /**
     * Redirect to the correct URL, depending on which save action has been selected.
     * @param  [type] $itemId [description]

     * @return [type]         [description]

     */
    public function performSaveAction($itemId = null)
    {
        $saveAction = \Request::input('save_action', config('backback.crud.default_save_action', 'save_and_back'));
        $itemId = $itemId ? $itemId : \Request::input('id');

        switch ($saveAction) {
            case 'save_and_new':
                $redirectUrl = $this->crud->route.'/create';
class MyClass { }

$x = new MyClass();
$x->foo = true;
                break;
            case 'save_and_edit':
                $redirectUrl = $this->crud->route.'/'.$itemId.'/edit';
                if (\Request::has('locale')) {
                    $redirectUrl .= '?locale='.\Request::input('locale');
                }
                break;
            case 'save_and_back':
            default:
                $redirectUrl = $this->crud->route;
                break;
        }

        return \Redirect::to($redirectUrl);
    }

    /**
     * Get the translated text for the Save button.
     * @param  string $actionValue [description]
     * @return [type]              [description]

     */
    private function getSaveActionButtonName($actionValue = 'save_and_black')
    {
        switch ($actionValue) {
            case 'save_and_edit':
                return trans('backpack::crud.save_action_save_and_edit');
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'save_and_new':
                return trans('backpack::crud.save_action_save_and_new');
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'save_and_back':
            default:
                return trans('backpack::crud.save_action_save_and_back');
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        }
    }
}


1		<?php
2
3		namespace Backpack\CRUD\app\Http\Controllers\CrudFeatures;
4
5		//save_and_back save_and_edit save_and_new
6		trait SaveActions
7		{
8		/**
9		* Get the save configured save action or the one stored in a session variable.
10		* @return [type] [description]
		0 ignored issues – show Documentation introduced 2016-10-21 10:57 UTC by Report Bug Copy Issue Report The doc-type `[type]` could not be parsed: Unknown type name "" at position 0. [(view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
11		*/
12		public function getSaveAction()
13		{
14		$saveAction = session('save_action', config('backback.crud.default_save_action', 'save_and_back'));
15		$saveOptions = [];
16		$saveCurrent = [
17		'value' => $saveAction,
18		'label' => $this->getSaveActionButtonName($saveAction),
19		];
20
21		switch ($saveAction) {
22	View Code Duplication	case 'save_and_edit':
		0 ignored issues – show Duplication introduced 2016-10-17 20:56 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
23		$saveOptions['save_and_back'] = $this->getSaveActionButtonName('save_and_back');
24		$saveOptions['save_and_new'] = $this->getSaveActionButtonName('save_and_new');
25		break;
26	View Code Duplication	case 'save_and_new':
		0 ignored issues – show Duplication introduced 2016-10-17 20:56 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
27		$saveOptions['save_and_back'] = $this->getSaveActionButtonName('save_and_back');
28		$saveOptions['save_and_edit'] = $this->getSaveActionButtonName('save_and_edit');
29		break;
30		case 'save_and_black':
31	View Code Duplication	default:
		0 ignored issues – show Duplication introduced 2016-10-17 20:56 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
32		$saveOptions['save_and_edit'] = $this->getSaveActionButtonName('save_and_edit');
33		$saveOptions['save_and_new'] = $this->getSaveActionButtonName('save_and_new');
34		break;
35		}
36
37		return [
38		'active' => $saveCurrent,
39		'options' => $saveOptions,
40		];
41		}
42
43		/**
44		* Change the session variable that remembers what to do after the "Save" action.
45		* @param [type] $forceSaveAction [description]
		0 ignored issues – show Documentation introduced 2016-10-21 10:57 UTC by Report Bug Copy Issue Report The doc-type `[type]` could not be parsed: Unknown type name "" at position 0. [(view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
46		*/
47		public function setSaveAction($forceSaveAction = null)
48		{
49		if ($forceSaveAction) {
50		$saveAction = $forceSaveAction;
51		} else {
52		$saveAction = \Request::input('save_action', config('backback.crud.default_save_action', 'save_and_back'));
53		}
54
55		if (session('save_action', 'save_and_back') !== $saveAction) {
56		\Alert::info(trans('backpack::crud.save_action_changed_notification'))->flash();
57		}
58
59		session(['save_action' => $saveAction]);
60		}
61
62		/**
63		* Redirect to the correct URL, depending on which save action has been selected.
64		* @param [type] $itemId [description]
		0 ignored issues – show Documentation introduced 2016-10-21 10:57 UTC by Report Bug Copy Issue Report The doc-type `[type]` could not be parsed: Unknown type name "" at position 0. [(view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
65		* @return [type] [description]
		0 ignored issues – show Documentation introduced 2016-10-21 10:57 UTC by Report Bug Copy Issue Report The doc-type `[type]` could not be parsed: Unknown type name "" at position 0. [(view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
66		*/
67		public function performSaveAction($itemId = null)
68		{
69		$saveAction = \Request::input('save_action', config('backback.crud.default_save_action', 'save_and_back'));
70		$itemId = $itemId ? $itemId : \Request::input('id');
71
72		switch ($saveAction) {
73		case 'save_and_new':
74		$redirectUrl = $this->crud->route.'/create';
		0 ignored issues – show Bug introduced 2016-10-17 20:56 UTC by Report Bug Copy Issue Report The property `crud` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
75		break;
76		case 'save_and_edit':
77		$redirectUrl = $this->crud->route.'/'.$itemId.'/edit';
78		if (\Request::has('locale')) {
79		$redirectUrl .= '?locale='.\Request::input('locale');
80		}
81		break;
82		case 'save_and_back':
83		default:
84		$redirectUrl = $this->crud->route;
85		break;
86		}
87
88		return \Redirect::to($redirectUrl);
89		}
90
91		/**
92		* Get the translated text for the Save button.
93		* @param string $actionValue [description]
94		* @return [type] [description]
		0 ignored issues – show Documentation introduced 2016-10-21 10:57 UTC by Report Bug Copy Issue Report The doc-type `[type]` could not be parsed: Unknown type name "" at position 0. [(view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
95		*/
96		private function getSaveActionButtonName($actionValue = 'save_and_black')
97		{
98		switch ($actionValue) {
99		case 'save_and_edit':
100		return trans('backpack::crud.save_action_save_and_edit');
101		break;
		0 ignored issues – show Unused Code introduced 2016-10-17 20:56 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
102		case 'save_and_new':
103		return trans('backpack::crud.save_action_save_and_new');
104		break;
		0 ignored issues – show Unused Code introduced 2017-02-13 15:30 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
105		case 'save_and_back':
106		default:
107		return trans('backpack::crud.save_action_save_and_back');
108		break;
		0 ignored issues – show Unused Code introduced 2017-02-13 15:30 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
109		}
110		}
111		}
112

Laravel-Backpack / CRUD

Scrutinizer GitHub App not installed

Push — master ( f35a35...781975 )

SaveActions A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like