Laravel-Backpack / CRUD

src/PanelTraits/Columns.php

Spacing +16 added lines, -17 removed lines

@@ -66,7 +66,7 @@ 
     public function addColumn($column)
     {
         // if a string was passed, not an array, change it to an array
-        if (! is_array($column)) {
+        if (!is_array($column)) {
             $column = ['name' => $column];
         }
 
@@ -74,7 +74,7 @@ 
         $column_with_details = $this->addDefaultLabel($column);
 
         // make sure the column has a name
-        if (! array_key_exists('name', $column_with_details)) {
+        if (!array_key_exists('name', $column_with_details)) {
             $column_with_details['name'] = 'anonymous_column_'.str_random(5);
         }
 
@@ -82,27 +82,27 @@ 
         $columnExistsInDb = $this->hasColumn($this->model->getTable(), $column_with_details['name']);
 
         // make sure the column has a type
-        if (! array_key_exists('type', $column_with_details)) {
+        if (!array_key_exists('type', $column_with_details)) {
             $column_with_details['type'] = 'text';
         }
 
         // make sure the column has a key
-        if (! array_key_exists('key', $column_with_details)) {
+        if (!array_key_exists('key', $column_with_details)) {
             $column_with_details['key'] = $column_with_details['name'];
         }
 
         // make sure the column has a tableColumn boolean
-        if (! array_key_exists('tableColumn', $column_with_details)) {
+        if (!array_key_exists('tableColumn', $column_with_details)) {
             $column_with_details['tableColumn'] = $columnExistsInDb ? true : false;
         }
 
         // make sure the column has a orderable boolean
-        if (! array_key_exists('orderable', $column_with_details)) {
+        if (!array_key_exists('orderable', $column_with_details)) {
             $column_with_details['orderable'] = $columnExistsInDb ? true : false;
         }
 
         // make sure the column has a searchLogic
-        if (! array_key_exists('searchLogic', $column_with_details)) {
+        if (!array_key_exists('searchLogic', $column_with_details)) {
             $column_with_details['searchLogic'] = $columnExistsInDb ? true : false;
         }
 
@@ -110,14 +110,14 @@ 
 
         // make sure the column has a priority in terms of visibility
         // if no priority has been defined, use the order in the array plus one
-        if (! array_key_exists('priority', $column_with_details)) {
+        if (!array_key_exists('priority', $column_with_details)) {
             $position_in_columns_array = (int) array_search($column_with_details['key'], array_keys($this->columns));
             $this->columns[$column_with_details['key']]['priority'] = $position_in_columns_array + 1;
         }
 
         // if this is a relation type field and no corresponding model was specified, get it from the relation method
         // defined in the main model
-        if (isset($column_with_details['entity']) && ! isset($column_with_details['model'])) {
+        if (isset($column_with_details['entity']) && !isset($column_with_details['model'])) {
             $column_with_details['model'] = $this->getRelationModel($column_with_details['entity']);
         }
 
@@ -163,7 +163,7 @@ 
      */
     public function makeFirstColumn()
     {
-        if (! $this->columns) {
+        if (!$this->columns) {
             return false;
         }
 
@@ -184,8 +184,7 @@ 
         $targetColumnName = is_array($targetColumn) ? $targetColumn['name'] : $targetColumn;
 
         if (array_key_exists($targetColumnName, $this->columns)) {
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($this->columns)) :
-                array_search($targetColumnName, array_keys($this->columns)) + 1;
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($this->columns)) : array_search($targetColumnName, array_keys($this->columns)) + 1;
 
             $element = array_pop($this->columns);
             $beginningPart = array_slice($this->columns, 0, $targetColumnPosition, true);
@@ -219,7 +218,7 @@ 
      */
     public function addDefaultLabel($array)
     {
-        if (! array_key_exists('label', (array) $array) && array_key_exists('name', (array) $array)) {
+        if (!array_key_exists('label', (array) $array) && array_key_exists('name', (array) $array)) {
             $array = array_merge(['label' => ucfirst($this->makeLabel($array['name']))], $array);
 
             return $array;
@@ -245,7 +244,7 @@ 
      */
     public function removeColumns($columns)
     {
-        if (! empty($columns)) {
+        if (!empty($columns)) {
             foreach ($columns as $columnName) {
                 $this->removeColumn($columnName);
             }
@@ -266,8 +265,8 @@ 
      */
     public function remove($entity, $fields)
     {
-        return array_values(array_filter($this->{$entity}, function ($field) use ($fields) {
-            return ! in_array($field['name'], (array) $fields);
+        return array_values(array_filter($this->{$entity}, function($field) use ($fields) {
+            return !in_array($field['name'], (array) $fields);
         }));
     }
 
@@ -312,7 +311,7 @@ 
     {
         $columns = $this->getColumns();
 
-        return collect($columns)->pluck('entity')->reject(function ($value, $key) {
+        return collect($columns)->pluck('entity')->reject(function($value, $key) {
             return $value == null;
         })->toArray();
     }

Doc Comments +3 added lines, -3 removed lines

@@ -143,7 +143,7 @@ 
     /**
      * Move the most recently added column after the given target column.
      *
-     * @param string|array $targetColumn The target column name or array.
+     * @param string $targetColumn The target column name or array.
      */
     public function afterColumn($targetColumn)
     {
@@ -162,7 +162,7 @@ 
 
     /**
      * Move this column to be first in the columns list.
-     * @return bool|null
+     * @return false|null
      */
     public function makeFirstColumn()
     {
@@ -281,7 +281,7 @@ 
     /**
      * Change attributes for multiple columns.
      *
-     * @param array $columns
+     * @param string[] $columns
      * @param array $attributes
      */
     public function setColumnsDetails($columns, $attributes)

src/app/Http/Controllers/Operations/Reorder.php

Spacing +1 added lines, -1 removed lines

@@ -174,7 +174,7 @@
     {
         $this->crud->hasAccessOrFail('reorder');
 
-        if (! $this->crud->isReorderEnabled()) {
+        if (!$this->crud->isReorderEnabled()) {
             abort(403, 'Reorder is disabled.');
         }
 

src/app/Http/Controllers/Operations/Revisions.php

Spacing +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
         $this->crud->hasAccessOrFail('revisions');
 
         $revisionId = \Request::input('revision_id', false);
-        if (! $revisionId) {
+        if (!$revisionId) {
             abort(500, 'Can\'t restore revision without revision_id');
         } else {
             $this->crud->restoreRevision($id, $revisionId); // do the update

src/app/Http/Controllers/Operations/SaveActions.php

Spacing +3 added lines, -4 removed lines

@@ -22,11 +22,11 @@ 
 
         $saveOptions = collect($permissions)
             // Restrict list to allowed actions.
-            ->filter(function ($action, $permission) {
+            ->filter(function($action, $permission) {
                 return $this->crud->hasAccess($permission);
             })
             // Generate list of possible actions.
-            ->mapWithKeys(function ($action, $permission) {
+            ->mapWithKeys(function($action, $permission) {
                 return [$action => $this->getSaveActionButtonName($action)];
             })
             ->all();
@@ -61,8 +61,7 @@ 
      */
     public function setSaveAction($forceSaveAction = null)
     {
-        $saveAction = $forceSaveAction ?:
-            \Request::input('save_action', config('backpack.crud.default_save_action', 'save_and_back'));
+        $saveAction = $forceSaveAction ?: \Request::input('save_action', config('backpack.crud.default_save_action', 'save_and_back'));
 
         if (config('backpack.crud.show_save_action_change', true) &&
             session('save_action', 'save_and_back') !== $saveAction) {

src/CrudUsageStats.php

Doc Comments +2 added lines, -2 removed lines

@@ -10,7 +10,7 @@ 
      * Check if the application is running in normal conditions
      * (production env, not in console, not in unit tests).
      *
-     * @return void
+     * @return boolean
      */
     private function runningInProduction()
     {
@@ -86,7 +86,7 @@ 
      * @param  string $method  HTTP Method to use for the request.
      * @param  string $url     URL to point the request at.
      * @param  array $payload  The data you want sent to the URL.
-     * @return void
+     * @return boolean
      */
     private function makeCurlRequest($method, $url, $payload)
     {

Spacing +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
     private function sendUsageStats()
     {
         // only send usage stats in production
-        if (! $this->runningInProduction()) {
+        if (!$this->runningInProduction()) {
             return;
         }
 

src/resources/views/columns/array_count.blade.php

Spacing +1 added lines, -1 removed lines

@@ -2,7 +2,7 @@
 <span>
     <?php
     $array = $entry->{$column['name']};
-    $suffix = isset($column['suffix'])?$column['suffix']:'items';
+    $suffix = isset($column['suffix']) ? $column['suffix'] : 'items';
 
     // the value should be an array wether or not attribute casting is used
     if (!is_array($array)) {

tests/Unit/CrudPanel/CrudPanelTabsTest.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -2,8 +2,8 @@
 
 namespace Backpack\CRUD\Tests\Unit\CrudPanel;
 
-use Illuminate\Support\Facades\DB;
 use Backpack\CRUD\Tests\Unit\Models\Article;
+use Illuminate\Support\Facades\DB;
 
 class CrudPanelTabsTest extends BaseDBCrudPanelTest
 {

src/PanelTraits/Tabs.php

Spacing +7 added lines, -7 removed lines

@@ -35,7 +35,7 @@ 
      */
     public function tabsDisabled()
     {
-        return ! $this->tabsEnabled;
+        return !$this->tabsEnabled;
     }
 
     public function setTabsType($type)
@@ -116,8 +116,8 @@ 
     {
         $all_fields = $this->getCurrentFields();
 
-        $fields_without_a_tab = collect($all_fields)->filter(function ($value, $key) {
-            return ! isset($value['tab']);
+        $fields_without_a_tab = collect($all_fields)->filter(function($value, $key) {
+            return !isset($value['tab']);
         });
 
         return $fields_without_a_tab;
@@ -133,7 +133,7 @@ 
         if ($this->tabExists($label)) {
             $all_fields = $this->getCurrentFields();
 
-            $fields_for_current_tab = collect($all_fields)->filter(function ($value, $key) use ($label) {
+            $fields_for_current_tab = collect($all_fields)->filter(function($value, $key) use ($label) {
                 return isset($value['tab']) && $value['tab'] == $label;
             });
 
@@ -152,11 +152,11 @@ 
         $fields = $this->getCurrentFields();
 
         $fields_with_tabs = collect($fields)
-            ->filter(function ($value, $key) {
+            ->filter(function($value, $key) {
                 return isset($value['tab']);
             })
-            ->each(function ($value, $key) use (&$tabs) {
-                if (! in_array($value['tab'], $tabs)) {
+            ->each(function($value, $key) use (&$tabs) {
+                if (!in_array($value['tab'], $tabs)) {
                     $tabs[] = $value['tab'];
                 }
             });