We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
Total Complexity | 49 |
Total Lines | 262 |
Duplicated Lines | 0 % |
Changes | 11 | ||
Bugs | 9 | Features | 0 |
Complex classes like HandleRepeatableUploads often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use HandleRepeatableUploads, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
12 | trait HandleRepeatableUploads |
||
13 | { |
||
14 | public bool $handleRepeatableFiles = false; |
||
15 | |||
16 | public ?string $repeatableContainerName = null; |
||
17 | |||
18 | /******************************* |
||
19 | * Setters - fluently configure the uploader |
||
20 | *******************************/ |
||
21 | public function repeats(string $repeatableContainerName): self |
||
22 | { |
||
23 | $this->handleRepeatableFiles = true; |
||
24 | |||
25 | $this->repeatableContainerName = $repeatableContainerName; |
||
26 | |||
27 | return $this; |
||
28 | } |
||
29 | |||
30 | /******************************* |
||
31 | * Getters |
||
32 | *******************************/ |
||
33 | public function getRepeatableContainerName(): ?string |
||
34 | { |
||
35 | return $this->repeatableContainerName; |
||
36 | } |
||
37 | |||
38 | /******************************* |
||
39 | * Default implementation methods |
||
40 | *******************************/ |
||
41 | protected function uploadRepeatableFiles($values, $previousValues, $entry = null) |
||
42 | { |
||
43 | } |
||
44 | |||
45 | protected function handleRepeatableFiles(Model $entry): Model |
||
58 | } |
||
59 | |||
60 | private function uploadRelationshipFiles(Model $entry, mixed $value): Model |
||
61 | { |
||
62 | $modelCount = CRUD::get('uploaded_'.$this->getRepeatableContainerName().'_count'); |
||
63 | $value = $value->slice($modelCount, 1)->toArray(); |
||
64 | |||
65 | foreach (app('UploadersRepository')->getRepeatableUploadersFor($this->getRepeatableContainerName()) as $uploader) { |
||
66 | if (array_key_exists($modelCount, $value) && array_key_exists($uploader->getAttributeName(), $value[$modelCount])) { |
||
67 | $entry->{$uploader->getAttributeName()} = $uploader->uploadFiles($entry, $value[$modelCount][$uploader->getAttributeName()]); |
||
68 | } |
||
69 | } |
||
70 | |||
71 | return $entry; |
||
72 | } |
||
73 | |||
74 | protected function processRepeatableUploads(Model $entry, Collection $values): Collection |
||
75 | { |
||
76 | foreach (app('UploadersRepository')->getRepeatableUploadersFor($this->getRepeatableContainerName()) as $uploader) { |
||
77 | $uploadedValues = $uploader->uploadRepeatableFiles($values->pluck($uploader->getAttributeName())->toArray(), $this->getPreviousRepeatableValues($entry, $uploader)); |
||
78 | |||
79 | $values = $values->map(function ($item, $key) use ($uploadedValues, $uploader) { |
||
80 | $item[$uploader->getAttributeName()] = $uploadedValues[$key] ?? null; |
||
81 | |||
82 | return $item; |
||
83 | }); |
||
84 | } |
||
85 | |||
86 | return $values; |
||
87 | } |
||
88 | |||
89 | private function retrieveRepeatableFiles(Model $entry): Model |
||
110 | } |
||
111 | |||
112 | private function retrieveRepeatableRelationFiles(Model $entry) |
||
113 | { |
||
114 | switch($this->getRepeatableRelationType()) { |
||
115 | case 'BelongsToMany': |
||
116 | case 'MorphToMany': |
||
117 | $pivotClass = app('crud')->getModel()->{$this->getUploaderSubfield()['baseEntity']}()->getPivotClass(); |
||
118 | $pivotFieldName = 'pivot_'.$this->getAttributeName(); |
||
119 | $connectedEntry = new $pivotClass([$this->getAttributeName() => $entry->$pivotFieldName]); |
||
120 | $entry->{$pivotFieldName} = $this->retrieveFiles($connectedEntry)->{$this->getAttributeName()}; |
||
121 | |||
122 | break; |
||
123 | default: |
||
124 | $entry = $this->retrieveFiles($entry); |
||
125 | } |
||
126 | |||
127 | return $entry; |
||
128 | } |
||
129 | |||
130 | private function getRepeatableRelationType() |
||
131 | { |
||
132 | return $this->getUploaderField()->getAttributes()['relation_type']; |
||
133 | } |
||
134 | |||
135 | private function getUploaderField() |
||
136 | { |
||
137 | return app('crud')->field($this->getRepeatableContainerName()); |
||
138 | } |
||
139 | |||
140 | private function getUploaderSubfield() |
||
141 | { |
||
142 | return collect($this->getUploaderFieldSubfields())->where('name', '===', $this->getName())->first(); |
||
143 | } |
||
144 | |||
145 | private function getUploaderFieldSubfields() |
||
146 | { |
||
147 | return $this->getUploaderField()->getAttributes()['subfields']; |
||
148 | } |
||
149 | |||
150 | private function deleteRepeatableFiles(Model $entry): void |
||
151 | { |
||
152 | if ($this->isRelationship) { |
||
153 | switch($this->getRepeatableRelationType()) { |
||
154 | case 'BelongsToMany': |
||
155 | case 'MorphToMany': |
||
156 | $pivotAttributes = $entry->getAttributes(); |
||
157 | $connectedPivot = $entry->pivotParent->{$this->getRepeatableContainerName()}->where(function ($item) use ($pivotAttributes) { |
||
158 | $itemPivotAttributes = $item->pivot->only(array_keys($pivotAttributes)); |
||
159 | |||
160 | return $itemPivotAttributes === $pivotAttributes; |
||
161 | })->first(); |
||
162 | |||
163 | if (! $connectedPivot) { |
||
164 | return; |
||
165 | } |
||
166 | |||
167 | $files = $connectedPivot->getOriginal()['pivot_'.$this->getAttributeName()]; |
||
168 | |||
169 | if (! $files) { |
||
170 | return; |
||
171 | } |
||
172 | |||
173 | if (is_array($files)) { |
||
174 | foreach ($files as $value) { |
||
175 | $value = Str::start($value, $this->getPath()); |
||
176 | Storage::disk($this->getDisk())->delete($value); |
||
177 | } |
||
178 | |||
179 | return; |
||
180 | } |
||
181 | |||
182 | $value = Str::start($files, $this->getPath()); |
||
183 | Storage::disk($this->getDisk())->delete($value); |
||
184 | |||
185 | return; |
||
186 | } |
||
187 | |||
188 | $this->deleteFiles($entry); |
||
189 | |||
190 | return; |
||
191 | } |
||
192 | |||
193 | $repeatableValues = collect($entry->{$this->getName()}); |
||
194 | foreach (app('UploadersRepository')->getRepeatableUploadersFor($this->getRepeatableContainerName()) as $upload) { |
||
195 | if (! $upload->shouldDeleteFiles()) { |
||
196 | continue; |
||
197 | } |
||
198 | $values = $repeatableValues->pluck($upload->getName())->toArray(); |
||
199 | foreach ($values as $value) { |
||
200 | if (! $value) { |
||
201 | continue; |
||
202 | } |
||
203 | |||
204 | if (is_array($value)) { |
||
205 | foreach ($value as $subvalue) { |
||
206 | Storage::disk($upload->getDisk())->delete($upload->getPath().$subvalue); |
||
207 | } |
||
208 | |||
209 | continue; |
||
210 | } |
||
211 | |||
212 | Storage::disk($upload->getDisk())->delete($upload->getPath().$value); |
||
213 | } |
||
214 | } |
||
215 | } |
||
216 | /******************************* |
||
217 | * Helper methods |
||
218 | *******************************/ |
||
219 | |||
220 | /** |
||
221 | * Given two multidimensional arrays/collections, merge them recursively. |
||
222 | */ |
||
223 | protected function mergeValuesRecursive(array|Collection $array1, array|Collection $array2): array|Collection |
||
224 | { |
||
225 | $merged = $array1; |
||
226 | foreach ($array2 as $key => &$value) { |
||
227 | if (is_array($value) && isset($merged[$key]) && is_array($merged[$key])) { |
||
228 | $merged[$key] = $this->mergeValuesRecursive($merged[$key], $value); |
||
229 | } else { |
||
230 | $merged[$key] = $value; |
||
231 | } |
||
232 | } |
||
233 | |||
234 | return $merged; |
||
235 | } |
||
236 | |||
237 | /** |
||
238 | * Repeatable items send `_order_` parameter in the request. |
||
239 | * This holds the order of the items in the repeatable container. |
||
240 | */ |
||
241 | protected function getFileOrderFromRequest(): array |
||
251 | } |
||
252 | |||
253 | private function getPreviousRepeatableValues(Model $entry, UploaderInterface $uploader): array |
||
254 | { |
||
255 | $previousValues = json_decode($entry->getOriginal($uploader->getRepeatableContainerName()), true); |
||
256 | |||
257 | if (! empty($previousValues)) { |
||
258 | $previousValues = array_column($previousValues, $uploader->getName()); |
||
259 | } |
||
260 | |||
261 | return $previousValues ?? []; |
||
262 | } |
||
263 | |||
264 | private function getValuesWithPathStripped(array|string|null $item, UploaderInterface $upload) |
||
274 | } |
||
275 | } |
||
276 |