Laravel-Backpack / CRUD

src/PanelTraits/Delete.php

Doc Comments +1 added lines, -1 removed lines

@@ -15,7 +15,7 @@
      *
      * @param  int $id The id of the item to be deleted.
      *
-     * @return bool True if the item was deleted.
+     * @return string True if the item was deleted.
      *
      * @throws \Illuminate\Database\Eloquent\ModelNotFoundException if the model was not found.
      *

src/CrudPanel.php

Doc Comments +1 added lines

@@ -123,6 +123,7 @@
      *
      * @param [string] Route name.
      * @param [array] Parameters.
+     * @param string $route
      */
     public function setRouteName($route, $parameters = [])
     {

Spacing +12 added lines, -12 removed lines

@@ -88,7 +88,7 @@ 
      */
     public function setModel($model_namespace)
     {
-        if (! class_exists($model_namespace)) {
+        if (!class_exists($model_namespace)) {
             throw new \Exception('This model does not exist.', 404);
         }
 
@@ -138,7 +138,7 @@ 
     {
         $complete_route = $route.'.index';
 
-        if (! \Route::has($complete_route)) {
+        if (!\Route::has($complete_route)) {
             throw new \Exception('There are no routes for this route name.', 404);
         }
 
@@ -188,7 +188,7 @@ 
      */
     public function getFirstOfItsTypeInArray($type, $array)
     {
-        return array_first($array, function ($item) use ($type) {
+        return array_first($array, function($item) use ($type) {
             return $item['type'] == $type;
         });
     }
@@ -205,8 +205,8 @@ 
 
     public function sync($type, $fields, $attributes)
     {
-        if (! empty($this->{$type})) {
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
+        if (!empty($this->{$type})) {
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
                 if (in_array($field['name'], (array) $fields)) {
                     $field = array_merge($field, $attributes);
                 }
@@ -238,8 +238,8 @@ 
                 }
             }
 
-            return $this->{$items} = array_merge($elements, array_filter($this->{$items}, function ($item) use ($items) {
-                return ! in_array($item['name'], $this->sort[$items]);
+            return $this->{$items} = array_merge($elements, array_filter($this->{$items}, function($item) use ($items) {
+                return !in_array($item['name'], $this->sort[$items]);
             }));
         }
 
@@ -268,15 +268,15 @@ 
     {
         $relationArray = explode('.', $relationString);
 
-        if (! isset($length)) {
+        if (!isset($length)) {
             $length = count($relationArray);
         }
 
-        if (! isset($model)) {
+        if (!isset($model)) {
             $model = $this->model;
         }
 
-        $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
+        $result = array_reduce(array_splice($relationArray, 0, $length), function($obj, $method) {
             return $obj->$method()->getRelated();
         }, $model);
 
@@ -323,7 +323,7 @@ 
         $relation = $model->{$firstRelationName};
 
         $results = [];
-        if (! empty($relation)) {
+        if (!empty($relation)) {
             if ($relation instanceof Collection) {
                 $currentResults = $relation->toArray();
             } else {
@@ -332,7 +332,7 @@ 
 
             array_shift($relationArray);
 
-            if (! empty($relationArray)) {
+            if (!empty($relationArray)) {
                 foreach ($currentResults as $currentResult) {
                     $results = array_merge($results, $this->getRelationModelInstances($currentResult, implode('.', $relationArray)));
                 }

Unused Use Statements +13 added lines, -13 removed lines

@@ -2,28 +2,28 @@
 
 namespace Backpack\CRUD;
 
-use Backpack\CRUD\PanelTraits\Read;
-use Backpack\CRUD\PanelTraits\Tabs;
-use Backpack\CRUD\PanelTraits\Query;
-use Backpack\CRUD\PanelTraits\Views;
 use Backpack\CRUD\PanelTraits\Access;
+use Backpack\CRUD\PanelTraits\AutoFocus;
+use Backpack\CRUD\PanelTraits\AutoSet;
+use Backpack\CRUD\PanelTraits\Buttons;
+use Backpack\CRUD\PanelTraits\Columns;
 use Backpack\CRUD\PanelTraits\Create;
 use Backpack\CRUD\PanelTraits\Delete;
 use Backpack\CRUD\PanelTraits\Errors;
+use Backpack\CRUD\PanelTraits\FakeColumns;
+use Backpack\CRUD\PanelTraits\FakeFields;
 use Backpack\CRUD\PanelTraits\Fields;
-use Backpack\CRUD\PanelTraits\Search;
-use Backpack\CRUD\PanelTraits\Update;
-use Backpack\CRUD\PanelTraits\AutoSet;
-use Backpack\CRUD\PanelTraits\Buttons;
-use Backpack\CRUD\PanelTraits\Columns;
 use Backpack\CRUD\PanelTraits\Filters;
+use Backpack\CRUD\PanelTraits\Query;
+use Backpack\CRUD\PanelTraits\Read;
 use Backpack\CRUD\PanelTraits\Reorder;
-use Backpack\CRUD\PanelTraits\AutoFocus;
-use Backpack\CRUD\PanelTraits\FakeFields;
-use Backpack\CRUD\PanelTraits\FakeColumns;
-use Illuminate\Database\Eloquent\Collection;
 use Backpack\CRUD\PanelTraits\RequiredFields;
+use Backpack\CRUD\PanelTraits\Search;
+use Backpack\CRUD\PanelTraits\Tabs;
+use Backpack\CRUD\PanelTraits\Update;
+use Backpack\CRUD\PanelTraits\Views;
 use Backpack\CRUD\PanelTraits\ViewsAndRestoresRevisions;
+use Illuminate\Database\Eloquent\Collection;
 
 class CrudPanel
 {

src/PanelTraits/Access.php

Doc Comments +6 added lines

@@ -12,12 +12,18 @@
     |--------------------------------------------------------------------------
     */
 
+    /**
+     * @param string $access
+     */
     public function allowAccess($access)
     {
         // $this->addButtons((array)$access);
         return $this->access = array_merge(array_diff((array) $access, $this->access), $this->access);
     }
 
+    /**
+     * @param string $access
+     */
     public function denyAccess($access)
     {
         // $this->removeButtons((array)$access);

Spacing +3 added lines, -3 removed lines

@@ -33,7 +33,7 @@ 
      */
     public function hasAccess($permission)
     {
-        if (! in_array($permission, $this->access)) {
+        if (!in_array($permission, $this->access)) {
             return false;
         }
 
@@ -68,7 +68,7 @@ 
     public function hasAccessToAll($permission_array)
     {
         foreach ($permission_array as $key => $permission) {
-            if (! in_array($permission, $this->access)) {
+            if (!in_array($permission, $this->access)) {
                 return false;
             }
         }
@@ -86,7 +86,7 @@ 
      */
     public function hasAccessOrFail($permission)
     {
-        if (! in_array($permission, $this->access)) {
+        if (!in_array($permission, $this->access)) {
             throw new AccessDeniedException(trans('backpack::crud.unauthorized_access', ['access' => $permission]));
         }
 

src/PanelTraits/Buttons.php

Doc Comments +12 added lines

@@ -59,6 +59,9 @@ 
         $this->addButton($stack, $name, 'model_function', $model_function_name, $position);
     }
 
+    /**
+     * @param string $view
+     */
     public function addButtonFromView($stack, $name, $view, $position = false)
     {
         $view = 'vendor.backpack.crud.buttons.'.$view;
@@ -104,6 +107,9 @@ 
         $this->buttons = collect([]);
     }
 
+    /**
+     * @param string $stack
+     */
     public function removeAllButtonsFromStack($stack)
     {
         $this->buttons = $this->buttons->reject(function ($button) use ($stack) {
@@ -126,6 +132,12 @@ 
     public $type = 'view';
     public $content;
 
+    /**
+     * @param string $stack
+     * @param string $name
+     * @param string $type
+     * @param string $content
+     */
     public function __construct($stack, $name, $type, $content)
     {
         $this->stack = $stack;

Spacing +4 added lines, -4 removed lines

@@ -97,7 +97,7 @@ 
     {
         $button = $this->buttons()->firstWhere('name', $name);
 
-        if (! $button) {
+        if (!$button) {
             abort(500, 'CRUD Button "'.$name.'" not found. Please check the button exists before you modify it.');
         }
 
@@ -118,7 +118,7 @@ 
      */
     public function removeButton($name, $stack = null)
     {
-        $this->buttons = $this->buttons->reject(function ($button) use ($name, $stack) {
+        $this->buttons = $this->buttons->reject(function($button) use ($name, $stack) {
             return $stack == null ? $button->name == $name : ($button->stack == $stack) && ($button->name == $name);
         });
     }
@@ -130,14 +130,14 @@ 
 
     public function removeAllButtonsFromStack($stack)
     {
-        $this->buttons = $this->buttons->reject(function ($button) use ($stack) {
+        $this->buttons = $this->buttons->reject(function($button) use ($stack) {
             return $button->stack == $stack;
         });
     }
 
     public function removeButtonFromStack($name, $stack)
     {
-        $this->buttons = $this->buttons->reject(function ($button) use ($name, $stack) {
+        $this->buttons = $this->buttons->reject(function($button) use ($name, $stack) {
             return $button->name == $name && $button->stack == $stack;
         });
     }

src/PanelTraits/Update.php

Doc Comments +1 added lines

@@ -15,6 +15,7 @@
      *
      * @param  [Int] The entity's id
      * @param  [Request] All inputs to be updated.
+     * @param integer $id
      *
      * @return [Eloquent Collection]
      */

Spacing +3 added lines, -3 removed lines

@@ -51,7 +51,7 @@ 
 
         foreach ($fields as &$field) {
             // set the value
-            if (! isset($field['value'])) {
+            if (!isset($field['value'])) {
                 if (isset($field['subfields'])) {
                     $field['value'] = [];
                     foreach ($field['subfields'] as $subfield) {
@@ -64,7 +64,7 @@ 
         }
 
         // always have a hidden input for the entry id
-        if (! array_key_exists('id', $fields)) {
+        if (!array_key_exists('id', $fields)) {
             $fields['id'] = [
                 'name'  => $entry->getKeyName(),
                 'value' => $entry->getKey(),
@@ -87,7 +87,7 @@ 
     {
         if (isset($field['entity'])) {
             $relationArray = explode('.', $field['entity']);
-            $relatedModel = array_reduce(array_splice($relationArray, 0, -1), function ($obj, $method) {
+            $relatedModel = array_reduce(array_splice($relationArray, 0, -1), function($obj, $method) {
                 return $obj->{$method} ? $obj->{$method} : $obj;
             }, $model);
 

tests/Unit/CrudPanel/CrudPanelCreateTest.php

Unused Use Statements +2 added lines, -2 removed lines

@@ -2,9 +2,9 @@
 
 namespace Backpack\CRUD\Tests\Unit\CrudPanel;
 
-use Faker\Factory;
-use Backpack\CRUD\Tests\Unit\Models\User;
 use Backpack\CRUD\Tests\Unit\Models\Article;
+use Backpack\CRUD\Tests\Unit\Models\User;
+use Faker\Factory;
 
 class CrudPanelCreateTest extends BaseDBCrudPanelTest
 {

tests/Unit/CrudPanel/CrudPanelDeleteTest.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -2,9 +2,9 @@
 
 namespace Backpack\CRUD\Tests\Unit\CrudPanel;
 
-use Illuminate\Support\Facades\DB;
 use Backpack\CRUD\Tests\Unit\Models\Article;
 use Illuminate\Database\Eloquent\ModelNotFoundException;
+use Illuminate\Support\Facades\DB;
 
 class CrudPanelDeleteTest extends BaseDBCrudPanelTest
 {

tests/Unit/CrudPanel/CrudPanelReadTest.php

Unused Use Statements +3 added lines, -3 removed lines

@@ -2,11 +2,11 @@
 
 namespace Backpack\CRUD\Tests\Unit\CrudPanel;
 
-use Illuminate\Support\Collection;
-use Illuminate\Support\Facades\DB;
-use Backpack\CRUD\Tests\Unit\Models\User;
 use Backpack\CRUD\Tests\Unit\Models\Article;
+use Backpack\CRUD\Tests\Unit\Models\User;
 use Illuminate\Database\Eloquent\ModelNotFoundException;
+use Illuminate\Support\Collection;
+use Illuminate\Support\Facades\DB;
 
 class CrudPanelReadTest extends BaseDBCrudPanelTest
 {

tests/config/database/migrations/2017_09_08_000000_create_user_roles_table.php

Spacing +2 added lines, -2 removed lines

@@ -13,13 +13,13 @@
      */
     public function up()
     {
-        Schema::create('roles', function (Blueprint $table) {
+        Schema::create('roles', function(Blueprint $table) {
             $table->increments('id');
             $table->string('name')->unique();
             $table->timestamps();
         });
 
-        Schema::create('user_role', function (Blueprint $table) {
+        Schema::create('user_role', function(Blueprint $table) {
             $table->integer('user_id')->length(10)->unsigned();
             $table->integer('role_id')->length(10)->unsigned();
             $table->timestamps();