Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Setup Failed
Pull Request — master (#2940)
by Cristian
26:19 queued 11:33
created
src/app/Library/CrudPanel/Traits/Fields.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
      */
89 89
     public function afterField($targetFieldName)
90 90
     {
91
-        $this->transformFields(function ($fields) use ($targetFieldName) {
91
+        $this->transformFields(function($fields) use ($targetFieldName) {
92 92
             return $this->moveField($fields, $targetFieldName, false);
93 93
         });
94 94
     }
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
      */
101 101
     public function beforeField($targetFieldName)
102 102
     {
103
-        $this->transformFields(function ($fields) use ($targetFieldName) {
103
+        $this->transformFields(function($fields) use ($targetFieldName) {
104 104
             return $this->moveField($fields, $targetFieldName, true);
105 105
         });
106 106
     }
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
      */
113 113
     public function makeFirstField()
114 114
     {
115
-        if (! $this->fields()) {
115
+        if (!$this->fields()) {
116 116
             return false;
117 117
         }
118 118
 
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
      */
128 128
     public function removeField($name)
129 129
     {
130
-        $this->transformFields(function ($fields) use ($name) {
130
+        $this->transformFields(function($fields) use ($name) {
131 131
             Arr::forget($fields, $name);
132 132
 
133 133
             return $fields;
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
      */
142 142
     public function removeFields($array_of_names)
143 143
     {
144
-        if (! empty($array_of_names)) {
144
+        if (!empty($array_of_names)) {
145 145
             foreach ($array_of_names as $name) {
146 146
                 $this->removeField($name);
147 147
             }
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
     public function removeAllFields()
155 155
     {
156 156
         $current_fields = $this->getCleanStateFields();
157
-        if (! empty($current_fields)) {
157
+        if (!empty($current_fields)) {
158 158
             foreach ($current_fields as $field) {
159 159
                 $this->removeField($field['name']);
160 160
             }
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
                 $jsonCastables = ['array', 'object', 'json'];
247 247
                 $fieldCasting = $casted_attributes[$field['name']];
248 248
 
249
-                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && ! empty($data[$field['name']]) && ! is_array($data[$field['name']])) {
249
+                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && !empty($data[$field['name']]) && !is_array($data[$field['name']])) {
250 250
                     try {
251 251
                         $data[$field['name']] = json_decode($data[$field['name']]);
252 252
                     } catch (\Exception $e) {
@@ -275,7 +275,7 @@  discard block
 block discarded – undo
275 275
      */
276 276
     public function orderFields($order)
277 277
     {
278
-        $this->transformFields(function ($fields) use ($order) {
278
+        $this->transformFields(function($fields) use ($order) {
279 279
             return $this->applyOrderToFields($fields, $order);
280 280
         });
281 281
     }
@@ -301,7 +301,7 @@  discard block
 block discarded – undo
301 301
     public function hasUploadFields()
302 302
     {
303 303
         $fields = $this->getCleanStateFields();
304
-        $upload_fields = Arr::where($fields, function ($value, $key) {
304
+        $upload_fields = Arr::where($fields, function($value, $key) {
305 305
             return isset($value['upload']) && $value['upload'] == true;
306 306
         });
307 307
 
@@ -364,7 +364,7 @@  discard block
 block discarded – undo
364 364
         $alreadyLoaded = $this->getLoadedFieldTypes();
365 365
         $type = $this->getFieldTypeWithNamespace($field);
366 366
 
367
-        if (! in_array($type, $this->getLoadedFieldTypes(), true)) {
367
+        if (!in_array($type, $this->getLoadedFieldTypes(), true)) {
368 368
             $alreadyLoaded[] = $type;
369 369
             $this->setLoadedFieldTypes($alreadyLoaded);
370 370
 
@@ -405,7 +405,7 @@  discard block
 block discarded – undo
405 405
      */
406 406
     public function fieldTypeNotLoaded($field)
407 407
     {
408
-        return ! in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
408
+        return !in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
409 409
     }
410 410
 
411 411
     /**
@@ -445,7 +445,7 @@  discard block
 block discarded – undo
445 445
      */
446 446
     public function hasFieldWhere($attribute, $value)
447 447
     {
448
-        $match = Arr::first($this->getCleanStateFields(), function ($field, $fieldKey) use ($attribute, $value) {
448
+        $match = Arr::first($this->getCleanStateFields(), function($field, $fieldKey) use ($attribute, $value) {
449 449
             return isset($field[$attribute]) && $field[$attribute] == $value;
450 450
         });
451 451
 
@@ -461,7 +461,7 @@  discard block
 block discarded – undo
461 461
      */
462 462
     public function firstFieldWhere($attribute, $value)
463 463
     {
464
-        return Arr::first($this->getCleanStateFields(), function ($field, $fieldKey) use ($attribute, $value) {
464
+        return Arr::first($this->getCleanStateFields(), function($field, $fieldKey) use ($attribute, $value) {
465 465
             return isset($field[$attribute]) && $field[$attribute] == $value;
466 466
         });
467 467
     }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/FieldsProtectedMethods.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
      */
69 69
     public function overwriteFieldNameFromDotNotationToArray($field)
70 70
     {
71
-        if (! is_array($field['name']) && strpos($field['name'], '.') !== false) {
71
+        if (!is_array($field['name']) && strpos($field['name'], '.') !== false) {
72 72
             $entity_array = explode('.', $field['name']);
73 73
             $name_string = '';
74 74
 
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
             return ['name' => $field];
111 111
         }
112 112
 
113
-        if (is_array($field) && ! isset($field['name'])) {
113
+        if (is_array($field) && !isset($field['name'])) {
114 114
             abort(500, 'All fields must have their name defined');
115 115
         }
116 116
 
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
     {
170 170
         // if there's a model defined, but no attribute
171 171
         // guess an attribute using the identifiableAttribute functionality in CrudTrait
172
-        if (isset($field['model']) && ! isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
172
+        if (isset($field['model']) && !isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
173 173
             $field['attribute'] = call_user_func([(new $field['model']), 'identifiableAttribute']);
174 174
         }
175 175
 
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
      */
186 186
     protected function makeSureFieldHasLabel($field)
187 187
     {
188
-        if (! isset($field['label'])) {
188
+        if (!isset($field['label'])) {
189 189
             $name = is_array($field['name']) ? $field['name'][0] : $field['name'];
190 190
             $name = str_replace('_id', '', $name);
191 191
             $field['label'] = mb_ucfirst(str_replace('_', ' ', $name));
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
      */
204 204
     protected function makeSureFieldHasType($field)
205 205
     {
206
-        if (! isset($field['type'])) {
206
+        if (!isset($field['type'])) {
207 207
             $field['type'] = isset($field['relation_type']) ? $this->inferFieldTypeFromFieldRelation($field) : $this->inferFieldTypeFromDbColumnType($field['name']);
208 208
         }
209 209
 
@@ -220,7 +220,7 @@  discard block
 block discarded – undo
220 220
     {
221 221
         // if a tab was mentioned, we should enable it
222 222
         if (isset($field['tab'])) {
223
-            if (! $this->tabsEnabled()) {
223
+            if (!$this->tabsEnabled()) {
224 224
                 $this->enableTabs();
225 225
             }
226 226
         }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/ColumnsProtectedMethods.php 1 patch
Spacing   +7 added lines, -8 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
             $column = ['name' => $column];
50 50
         }
51 51
 
52
-        if (is_array($column) && ! isset($column['name'])) {
52
+        if (is_array($column) && !isset($column['name'])) {
53 53
             $column['name'] = 'anonymous_column_'.Str::random(5);
54 54
         }
55 55
 
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
      */
66 66
     protected function makeSureColumnHasLabel($column)
67 67
     {
68
-        if (! isset($column['label'])) {
68
+        if (!isset($column['label'])) {
69 69
             $column['label'] = mb_ucfirst($this->makeLabel($column['name']));
70 70
         }
71 71
 
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
      */
147 147
     protected function makeSureColumnHasKey($column)
148 148
     {
149
-        if (! isset($column['key'])) {
149
+        if (!isset($column['key'])) {
150 150
             $column['key'] = str_replace('.', '__', $column['name']);
151 151
         }
152 152
 
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
      */
165 165
     protected function makeSureColumnHasWrapper($column)
166 166
     {
167
-        if (! isset($column['wrapper'])) {
167
+        if (!isset($column['wrapper'])) {
168 168
             $column['wrapper'] = [];
169 169
         }
170 170
 
@@ -255,7 +255,7 @@  discard block
 block discarded – undo
255 255
     {
256 256
         // if this is a relation type field and no corresponding model was specified,
257 257
         // get it from the relation method defined in the main model
258
-        if (isset($column['entity']) && $column['entity'] !== false && ! isset($column['model'])) {
258
+        if (isset($column['entity']) && $column['entity'] !== false && !isset($column['model'])) {
259 259
             $column['model'] = $this->getRelationModel($column['entity']);
260 260
         }
261 261
 
@@ -276,8 +276,7 @@  discard block
 block discarded – undo
276 276
         $columnsArray = $this->columns();
277 277
 
278 278
         if (array_key_exists($targetColumnName, $columnsArray)) {
279
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) :
280
-                array_search($targetColumnName, array_keys($columnsArray)) + 1;
279
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) : array_search($targetColumnName, array_keys($columnsArray)) + 1;
281 280
 
282 281
             $element = array_pop($columnsArray);
283 282
             $beginningPart = array_slice($columnsArray, 0, $targetColumnPosition, true);
@@ -299,7 +298,7 @@  discard block
 block discarded – undo
299 298
     {
300 299
         static $cache = [];
301 300
 
302
-        if (! $this->driverIsSql()) {
301
+        if (!$this->driverIsSql()) {
303 302
             return true;
304 303
         }
305 304
 
Please login to merge, or discard this patch.
database/migrations/2020_03_31_114745_create_pivotable_relations_tables.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -13,14 +13,14 @@  discard block
 block discarded – undo
13 13
      */
14 14
     public function up()
15 15
     {
16
-        Schema::create('comments', function (Blueprint $table) {
16
+        Schema::create('comments', function(Blueprint $table) {
17 17
             $table->bigIncrements('id');
18 18
             $table->string('text')->nullable();
19 19
             $table->morphs('commentable');
20 20
             $table->timestamps();
21 21
         });
22 22
 
23
-        Schema::create('recommendables', function (Blueprint $table) {
23
+        Schema::create('recommendables', function(Blueprint $table) {
24 24
             $table->bigIncrements('id');
25 25
             $table->string('text')->nullable();
26 26
             $table->morphs('recommendable');
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
             $table->timestamps();
29 29
         });
30 30
 
31
-        Schema::create('billables', function (Blueprint $table) {
31
+        Schema::create('billables', function(Blueprint $table) {
32 32
             $table->bigIncrements('id');
33 33
             $table->string('text')->nullable();
34 34
             $table->morphs('billable');
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
             $table->timestamps();
37 37
         });
38 38
 
39
-        Schema::create('articles_user', function (Blueprint $table) {
39
+        Schema::create('articles_user', function(Blueprint $table) {
40 40
             $table->increments('id');
41 41
             $table->integer('article_id')->unsigned();
42 42
             $table->integer('user_id')->unsigned();
@@ -44,19 +44,19 @@  discard block
 block discarded – undo
44 44
             $table->nullableTimestamps();
45 45
         });
46 46
 
47
-        Schema::create('recommends', function (Blueprint $table) {
47
+        Schema::create('recommends', function(Blueprint $table) {
48 48
             $table->bigIncrements('id');
49 49
             $table->string('title')->nullable();
50 50
             $table->timestamps();
51 51
         });
52 52
 
53
-        Schema::create('bills', function (Blueprint $table) {
53
+        Schema::create('bills', function(Blueprint $table) {
54 54
             $table->bigIncrements('id');
55 55
             $table->string('title')->nullable();
56 56
             $table->timestamps();
57 57
         });
58 58
 
59
-        Schema::create('stars', function (Blueprint $table) {
59
+        Schema::create('stars', function(Blueprint $table) {
60 60
             $table->bigIncrements('id');
61 61
             $table->string('starable_type');
62 62
             $table->bigInteger('starable_id');
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/ShowOperation.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -30,25 +30,25 @@
 block discarded – undo
30 30
         $this->crud->allowAccess('show');
31 31
         $this->crud->setOperationSetting('setFromDb', true);
32 32
 
33
-        $this->crud->operation('show', function () {
33
+        $this->crud->operation('show', function() {
34 34
             $this->crud->loadDefaultOperationSettingsFromConfig();
35 35
 
36
-            if (! method_exists($this, 'setupShowOperation')) {
36
+            if (!method_exists($this, 'setupShowOperation')) {
37 37
                 $this->autoSetupShowOperation();
38 38
             }
39 39
         });
40 40
 
41
-        $this->crud->operation('list', function () {
41
+        $this->crud->operation('list', function() {
42 42
             $this->crud->addButton('line', 'show', 'view', 'crud::buttons.show', 'beginning');
43 43
         });
44 44
 
45
-        $this->crud->operation(['create', 'update'], function () {
45
+        $this->crud->operation(['create', 'update'], function() {
46 46
             $this->crud->addSaveAction([
47 47
                 'name' => 'save_and_preview',
48
-                'visible' => function ($crud) {
48
+                'visible' => function($crud) {
49 49
                     return $crud->hasAccess('show');
50 50
                 },
51
-                'redirect' => function ($crud, $request, $itemId = null) {
51
+                'redirect' => function($crud, $request, $itemId = null) {
52 52
                     $itemId = $itemId ?: $request->input('id');
53 53
                     $redirectUrl = $crud->route.'/'.$itemId.'/show';
54 54
                     if ($request->has('_locale')) {
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Update.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
 
54 54
         foreach ($fields as &$field) {
55 55
             // set the value
56
-            if (! isset($field['value'])) {
56
+            if (!isset($field['value'])) {
57 57
                 if (isset($field['subfields'])) {
58 58
                     $field['value'] = [];
59 59
                     foreach ($field['subfields'] as $subfield) {
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
         }
67 67
 
68 68
         // always have a hidden input for the entry id
69
-        if (! array_key_exists('id', $fields)) {
69
+        if (!array_key_exists('id', $fields)) {
70 70
             $fields['id'] = [
71 71
                 'name'  => $entry->getKeyName(),
72 72
                 'value' => $entry->getKey(),
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
     {
109 109
         [$related_model, $relation_method] = $this->getModelAndMethodFromEntity($model, $field);
110 110
 
111
-        if (! method_exists($related_model, $relation_method)) {
111
+        if (!method_exists($related_model, $relation_method)) {
112 112
             return $related_model->{$relation_method};
113 113
         }
114 114
 
@@ -119,11 +119,11 @@  discard block
 block discarded – undo
119 119
             case 'HasMany':
120 120
             case 'BelongsToMany':
121 121
             case 'MorphToMany':
122
-                if (! isset($field['pivotFields'])) {
122
+                if (!isset($field['pivotFields'])) {
123 123
                     return $related_model->{$relation_method};
124 124
                 }
125 125
                 // we want to exclude the "self pivot field" since we already have it.
126
-                $pivot_fields = Arr::where($field['pivotFields'], function ($item) use ($field) {
126
+                $pivot_fields = Arr::where($field['pivotFields'], function($item) use ($field) {
127 127
                     return $field['name'] != $item['name'];
128 128
                 });
129 129
                 $related_models = $related_model->{$relation_method};
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
             break;
161 161
             case 'HasOne':
162 162
             case 'MorphOne':
163
-                if (! $related_model->{$relation_method}) {
163
+                if (!$related_model->{$relation_method}) {
164 164
                     return;
165 165
                 }
166 166
 
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
 
180 180
         $relation_array = explode('.', $relational_entity);
181 181
 
182
-        $related_model = array_reduce(array_splice($relation_array, 0, -1), function ($obj, $method) {
182
+        $related_model = array_reduce(array_splice($relation_array, 0, -1), function($obj, $method) {
183 183
             $method = Str::endsWith($method, '_id') ? Str::replaceLast('_id', '', $method) : $method;
184 184
 
185 185
             return $obj->{$method} ? $obj->{$method} : $obj;
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Create.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -150,11 +150,11 @@  discard block
 block discarded – undo
150 150
      */
151 151
     private function createRelationsForItem($item, $formattedRelations)
152 152
     {
153
-        if (! isset($formattedRelations['relations'])) {
153
+        if (!isset($formattedRelations['relations'])) {
154 154
             return false;
155 155
         }
156 156
         foreach ($formattedRelations['relations'] as $relationMethod => $relationDetails) {
157
-            if (! isset($relationDetails['model'])) {
157
+            if (!isset($relationDetails['model'])) {
158 158
                 continue;
159 159
             }
160 160
             $model = $relationDetails['model'];
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
         $relationFields = $this->getRelationFieldsWithoutPivot();
202 202
 
203 203
         //remove fields that are not in the submitted form input
204
-        $relationFields = array_filter($relationFields, function ($item) use ($input) {
204
+        $relationFields = array_filter($relationFields, function($item) use ($input) {
205 205
             return Arr::has($input, $item['name']);
206 206
         });
207 207
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Relationships.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
         $model = $this->getRelationModel($field['entity'], -1);
63 63
         $lastSegmentAfterDot = Str::of($field['entity'])->afterLast('.');
64 64
 
65
-        if (! method_exists($model, $lastSegmentAfterDot)) {
65
+        if (!method_exists($model, $lastSegmentAfterDot)) {
66 66
             return (string) Str::of($field['entity'])->beforeLast('.');
67 67
         }
68 68
 
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
         return collect($this->fields())
84 84
             ->where('model')
85 85
             ->whereIn('relation_type', $relation_types)
86
-            ->filter(function ($item) {
86
+            ->filter(function($item) {
87 87
                 $related_model = get_class($this->model->{Str::before($item['entity'], '.')}()->getRelated());
88 88
 
89 89
                 return Str::contains($item['entity'], '.') && $item['model'] !== $related_model ? false : true;
@@ -207,8 +207,8 @@  discard block
 block discarded – undo
207 207
     {
208 208
         $all_relation_fields = $this->getRelationFields();
209 209
 
210
-        return Arr::where($all_relation_fields, function ($value, $key) {
211
-            return isset($value['pivot']) && ! $value['pivot'];
210
+        return Arr::where($all_relation_fields, function($value, $key) {
211
+            return isset($value['pivot']) && !$value['pivot'];
212 212
         });
213 213
     }
214 214
 
@@ -221,7 +221,7 @@  discard block
 block discarded – undo
221 221
     {
222 222
         $all_relation_fields = $this->getRelationFields();
223 223
 
224
-        return Arr::where($all_relation_fields, function ($value, $key) {
224
+        return Arr::where($all_relation_fields, function($value, $key) {
225 225
             return isset($value['pivot']) && $value['pivot'];
226 226
         });
227 227
     }
Please login to merge, or discard this patch.