Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Setup Failed
Pull Request — main (#5725)
by Pedro
25:49 queued 10:59
created
src/app/Library/CrudPanel/Traits/Fields.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
      */
137 137
     public function afterField($targetFieldName)
138 138
     {
139
-        $this->transformFields(function ($fields) use ($targetFieldName) {
139
+        $this->transformFields(function($fields) use ($targetFieldName) {
140 140
             return $this->moveField($fields, $targetFieldName, false);
141 141
         });
142 142
     }
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
      */
149 149
     public function beforeField($targetFieldName)
150 150
     {
151
-        $this->transformFields(function ($fields) use ($targetFieldName) {
151
+        $this->transformFields(function($fields) use ($targetFieldName) {
152 152
             return $this->moveField($fields, $targetFieldName, true);
153 153
         });
154 154
     }
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
      */
161 161
     public function makeFirstField()
162 162
     {
163
-        if (! $this->fields()) {
163
+        if (!$this->fields()) {
164 164
             return false;
165 165
         }
166 166
 
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
      */
176 176
     public function removeField($name)
177 177
     {
178
-        $this->transformFields(function ($fields) use ($name) {
178
+        $this->transformFields(function($fields) use ($name) {
179 179
             Arr::forget($fields, $name);
180 180
 
181 181
             return $fields;
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
      */
190 190
     public function removeFields($array_of_names)
191 191
     {
192
-        if (! empty($array_of_names)) {
192
+        if (!empty($array_of_names)) {
193 193
             foreach ($array_of_names as $name) {
194 194
                 $this->removeField($name);
195 195
             }
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
     public function removeAllFields()
203 203
     {
204 204
         $current_fields = $this->getCleanStateFields();
205
-        if (! empty($current_fields)) {
205
+        if (!empty($current_fields)) {
206 206
             foreach ($current_fields as $field) {
207 207
                 $this->removeField($field['name']);
208 208
             }
@@ -290,7 +290,7 @@  discard block
 block discarded – undo
290 290
      */
291 291
     public function orderFields($order)
292 292
     {
293
-        $this->transformFields(function ($fields) use ($order) {
293
+        $this->transformFields(function($fields) use ($order) {
294 294
             return $this->applyOrderToFields($fields, $order);
295 295
         });
296 296
     }
@@ -314,7 +314,7 @@  discard block
 block discarded – undo
314 314
     public function hasUploadFields()
315 315
     {
316 316
         $fields = $this->getCleanStateFields();
317
-        $upload_fields = Arr::where($fields, function ($value, $key) {
317
+        $upload_fields = Arr::where($fields, function($value, $key) {
318 318
             // check if any subfields have uploads
319 319
             if (isset($value['subfields'])) {
320 320
                 foreach ($value['subfields'] as $subfield) {
@@ -386,7 +386,7 @@  discard block
 block discarded – undo
386 386
         $alreadyLoaded = $this->getLoadedFieldTypes();
387 387
         $type = $this->getFieldTypeWithNamespace($field);
388 388
 
389
-        if (! in_array($type, $this->getLoadedFieldTypes(), true)) {
389
+        if (!in_array($type, $this->getLoadedFieldTypes(), true)) {
390 390
             $alreadyLoaded[] = $type;
391 391
             $this->setLoadedFieldTypes($alreadyLoaded);
392 392
 
@@ -427,7 +427,7 @@  discard block
 block discarded – undo
427 427
      */
428 428
     public function fieldTypeNotLoaded($field)
429 429
     {
430
-        return ! in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
430
+        return !in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
431 431
     }
432 432
 
433 433
     /**
@@ -439,7 +439,7 @@  discard block
 block discarded – undo
439 439
     {
440 440
         $fieldNamesArray = array_column($this->getCleanStateFields(), 'name');
441 441
 
442
-        return array_reduce($fieldNamesArray, function ($names, $item) {
442
+        return array_reduce($fieldNamesArray, function($names, $item) {
443 443
             if (strpos($item, ',') === false) {
444 444
                 $names[] = $item;
445 445
 
@@ -490,7 +490,7 @@  discard block
 block discarded – undo
490 490
      */
491 491
     public function hasFieldWhere($attribute, $value)
492 492
     {
493
-        $match = Arr::first($this->getCleanStateFields(), function ($field, $fieldKey) use ($attribute, $value) {
493
+        $match = Arr::first($this->getCleanStateFields(), function($field, $fieldKey) use ($attribute, $value) {
494 494
             return isset($field[$attribute]) && $field[$attribute] == $value;
495 495
         });
496 496
 
@@ -506,7 +506,7 @@  discard block
 block discarded – undo
506 506
      */
507 507
     public function firstFieldWhere($attribute, $value)
508 508
     {
509
-        return Arr::first($this->getCleanStateFields(), function ($field, $fieldKey) use ($attribute, $value) {
509
+        return Arr::first($this->getCleanStateFields(), function($field, $fieldKey) use ($attribute, $value) {
510 510
             return isset($field[$attribute]) && $field[$attribute] == $value;
511 511
         });
512 512
     }
Please login to merge, or discard this patch.
src/app/Models/Traits/HasIdentifiableAttribute.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
         // we get the first column from database
56 56
         // that is NOT indexed (usually primary, foreign keys)
57 57
         foreach ($columnNames as $columnName) {
58
-            if (! in_array($columnName, $indexes)) {
58
+            if (!in_array($columnName, $indexes)) {
59 59
                 //check for convention "field<_id>" in case developer didn't add foreign key constraints.
60 60
                 if (strpos($columnName, '_id') !== false) {
61 61
                     continue;
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
 
68 68
         // in case everything fails we just return the first column in database
69 69
         $firstColumnInTable = Arr::first($columnNames);
70
-        if (! empty($firstColumnInTable)) {
70
+        if (!empty($firstColumnInTable)) {
71 71
             return $firstColumnInTable;
72 72
         }
73 73
 
Please login to merge, or discard this patch.
tests/config/database/migrations/2024_07_30_000000_create_reorder_table.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
      */
14 14
     public function up()
15 15
     {
16
-        Schema::create('reorders', function (Blueprint $table) {
16
+        Schema::create('reorders', function(Blueprint $table) {
17 17
             $table->increments('id');
18 18
             $table->string('name');
19 19
             $table->bigInteger('parent_id')->nullable();
Please login to merge, or discard this patch.
tests/BaseTestClass.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
             (array) config('backpack.base.middleware_key', 'admin'),
26 26
             'prefix' => config('backpack.base.route_prefix', 'admin'),
27 27
         ],
28
-            function () {
28
+            function() {
29 29
                 Route::get('articles/{id}/show/{detail}', ['as' => 'article.show.detail', 'action' => 'Backpack\CRUD\Tests\config\Http\Controllers\ArticleCrudController@detail']);
30 30
                 Route::crud('users', 'Backpack\CRUD\Tests\config\Http\Controllers\UserCrudController');
31 31
                 Route::crud('articles', 'Backpack\CRUD\Tests\config\Http\Controllers\ArticleCrudController');
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
     protected function setupUserCreateRequest()
46 46
     {
47 47
         $request = request()->create('/admin/users/create', 'POST', ['name' => 'foo']);
48
-        $request->setRouteResolver(function () use ($request) {
48
+        $request->setRouteResolver(function() use ($request) {
49 49
             return (new RouteInstance('POST', 'admin/users/create', ['UserCrudController', 'create']))->bind($request);
50 50
         });
51 51
         $this->crudPanel->setRequest($request);
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelQueryTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
 
33 33
     public function testItCanAddAClauseToTheQueryUsingAClosure()
34 34
     {
35
-        $closure = function ($query) {
35
+        $closure = function($query) {
36 36
             $query->where('id', 1);
37 37
         };
38 38
 
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 
52 52
     public function testItCanAddABaseClauseToTheQueryUsingAClosure()
53 53
     {
54
-        $closure = function ($query) {
54
+        $closure = function($query) {
55 55
             $query->where('id', 1);
56 56
         };
57 57
 
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
         $this->crudPanel->addColumn([
116 116
             'name' => 'name',
117 117
             'type' => 'text',
118
-            'orderLogic' => function ($query, $column, $direction) {
118
+            'orderLogic' => function($query, $column, $direction) {
119 119
                 $query->orderBy('name', $direction);
120 120
             },
121 121
         ]);
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelSaveActionsTest.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -25,13 +25,13 @@  discard block
 block discarded – undo
25 25
         $this->singleSaveAction = [
26 26
             'name' => 'save_action_one',
27 27
             'button_text' => 'custom',
28
-            'redirect' => function ($crud, $request, $itemId) {
28
+            'redirect' => function($crud, $request, $itemId) {
29 29
                 return 'https://backpackforlaravel.com';
30 30
             },
31
-            'referrer_url' => function ($crud, $request, $itemId) {
31
+            'referrer_url' => function($crud, $request, $itemId) {
32 32
                 return 'https://backpackforlaravel.com';
33 33
             },
34
-            'visible' => function ($crud) {
34
+            'visible' => function($crud) {
35 35
                 return true;
36 36
             },
37 37
         ];
@@ -39,19 +39,19 @@  discard block
 block discarded – undo
39 39
         $this->multipleSaveActions = [
40 40
             [
41 41
                 'name' => 'save_action_one',
42
-                'redirect' => function ($crud, $request, $itemId) {
42
+                'redirect' => function($crud, $request, $itemId) {
43 43
                     return $crud->route;
44 44
                 },
45
-                'visible' => function ($crud) {
45
+                'visible' => function($crud) {
46 46
                     return true;
47 47
                 },
48 48
             ],
49 49
             [
50 50
                 'name' => 'save_action_two',
51
-                'redirect' => function ($crud, $request, $itemId) {
51
+                'redirect' => function($crud, $request, $itemId) {
52 52
                     return $crud->route;
53 53
                 },
54
-                'visible' => function ($crud) {
54
+                'visible' => function($crud) {
55 55
                     return true;
56 56
                 },
57 57
             ],
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/SaveActions.php 1 patch
Spacing   +15 added lines, -16 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
         $higherAction = $this->getSaveActionByOrder(1);
29 29
 
30 30
         //if there is an higher action and that action is not the backpack default higher one `save_and_back` we return it.
31
-        if (! empty($higherAction) && key($higherAction) !== 'save_and_back') {
31
+        if (!empty($higherAction) && key($higherAction) !== 'save_and_back') {
32 32
             return key($higherAction);
33 33
         }
34 34
 
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
      */
48 48
     public function getSaveActionByOrder($order)
49 49
     {
50
-        return array_filter($this->getOperationSetting('save_actions') ?? [], function ($arr) use ($order) {
50
+        return array_filter($this->getOperationSetting('save_actions') ?? [], function($arr) use ($order) {
51 51
             return $arr['order'] == $order;
52 52
         });
53 53
     }
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
 
89 89
         $actions = $this->getOperationSetting('save_actions') ?? [];
90 90
 
91
-        if (! in_array($saveAction['name'], $actions)) {
91
+        if (!in_array($saveAction['name'], $actions)) {
92 92
             $actions[$saveAction['name']] = $saveAction;
93 93
         }
94 94
 
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
     public function orderSaveAction(string $saveAction, int $wantedOrder)
106 106
     {
107 107
         $actions = $this->getOperationSetting('save_actions') ?? [];
108
-        if (! empty($actions)) {
108
+        if (!empty($actions)) {
109 109
             $replaceOrder = isset($actions[$saveAction]) ? $actions[$saveAction]['order'] : count($actions) + 1;
110 110
 
111 111
             foreach ($actions as $key => $sv) {
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
199 199
     public function orderSaveActions(array $saveActions)
200 200
     {
201 201
         foreach ($saveActions as $sv => $order) {
202
-            if (! is_int($order)) {
202
+            if (!is_int($order)) {
203 203
                 $this->orderSaveAction($order, $sv + 1);
204 204
             } else {
205 205
                 $this->orderSaveAction($sv, $order);
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
     {
217 217
         $actions = $this->getOperationSetting('save_actions') ?? [];
218 218
 
219
-        uasort($actions, function ($a, $b) {
219
+        uasort($actions, function($a, $b) {
220 220
             return $a['order'] <=> $b['order'];
221 221
         });
222 222
 
@@ -238,7 +238,7 @@  discard block
 block discarded – undo
238 238
             }
239 239
         }
240 240
 
241
-        return array_filter($actions, function ($action) {
241
+        return array_filter($actions, function($action) {
242 242
             return $action['visible'] == true;
243 243
         }, ARRAY_FILTER_USE_BOTH);
244 244
     }
@@ -300,8 +300,7 @@  discard block
 block discarded – undo
300 300
      */
301 301
     public function setSaveAction($forceSaveAction = null)
302 302
     {
303
-        $saveAction = $forceSaveAction ?:
304
-            $this->getRequest()->input('_save_action', $this->getFallBackSaveAction());
303
+        $saveAction = $forceSaveAction ?: $this->getRequest()->input('_save_action', $this->getFallBackSaveAction());
305 304
 
306 305
         $showBubble = $this->getOperationSetting('showSaveActionChange') ?? config('backpack.crud.operations.'.$this->getCurrentOperation().'.showSaveActionChange') ?? true;
307 306
 
@@ -369,20 +368,20 @@  discard block
 block discarded – undo
369 368
         $defaultSaveActions = [
370 369
             [
371 370
                 'name' => 'save_and_back',
372
-                'visible' => function ($crud) {
371
+                'visible' => function($crud) {
373 372
                     return $crud->hasAccess('list');
374 373
                 },
375
-                'redirect' => function ($crud, $request, $itemId = null) {
374
+                'redirect' => function($crud, $request, $itemId = null) {
376 375
                     return $request->has('_http_referrer') ? $request->get('_http_referrer') : $crud->route;
377 376
                 },
378 377
                 'button_text' => trans('backpack::crud.save_action_save_and_back'),
379 378
             ],
380 379
             [
381 380
                 'name' => 'save_and_edit',
382
-                'visible' => function ($crud) {
381
+                'visible' => function($crud) {
383 382
                     return $crud->hasAccess('update');
384 383
                 },
385
-                'redirect' => function ($crud, $request, $itemId = null) {
384
+                'redirect' => function($crud, $request, $itemId = null) {
386 385
                     $itemId = $itemId ?: $request->get('id');
387 386
                     $redirectUrl = $crud->route.'/'.$itemId.'/edit';
388 387
                     if ($request->has('_locale')) {
@@ -394,17 +393,17 @@  discard block
 block discarded – undo
394 393
 
395 394
                     return $redirectUrl;
396 395
                 },
397
-                'referrer_url' => function ($crud, $request, $itemId) {
396
+                'referrer_url' => function($crud, $request, $itemId) {
398 397
                     return url($crud->route.'/'.$itemId.'/edit');
399 398
                 },
400 399
                 'button_text' => trans('backpack::crud.save_action_save_and_edit'),
401 400
             ],
402 401
             [
403 402
                 'name' => 'save_and_new',
404
-                'visible' => function ($crud) {
403
+                'visible' => function($crud) {
405 404
                     return $crud->hasAccess('create');
406 405
                 },
407
-                'redirect' => function ($crud, $request, $itemId = null) {
406
+                'redirect' => function($crud, $request, $itemId = null) {
408 407
                     return $this->route.'/create';
409 408
                 },
410 409
                 'button_text' => trans('backpack::crud.save_action_save_and_new'),
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelSearchTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
         $this->crudPanel->addColumn([
91 91
             'name' => 'test',
92 92
             'type' => 'my_custom_type',
93
-            'searchLogic' => function ($query, $column, $searchTerm) {
93
+            'searchLogic' => function($query, $column, $searchTerm) {
94 94
                 $query->where($column['name'], 'like', "%{$searchTerm}%");
95 95
             },
96 96
             'tableColumn' => true,
@@ -225,7 +225,7 @@  discard block
 block discarded – undo
225 225
             'name' => 'name',
226 226
             'type' => 'text',
227 227
             'tableColumn' => true,
228
-            'orderLogic' => function ($query, $column, $searchTerm) {
228
+            'orderLogic' => function($query, $column, $searchTerm) {
229 229
                 $query->orderBy('name', 'asc');
230 230
             },
231 231
         ]);
@@ -244,7 +244,7 @@  discard block
 block discarded – undo
244 244
             'name' => 'name',
245 245
             'type' => 'text',
246 246
             'tableColumn' => true,
247
-            'orderLogic' => function ($query, $column, $searchTerm) {
247
+            'orderLogic' => function($query, $column, $searchTerm) {
248 248
                 $query->orderBy('id', 'asc');
249 249
             },
250 250
         ]);
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/ColumnsProtectedMethods.php 1 patch
Spacing   +8 added lines, -9 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
             return ['name' => Str::replace(' ', '', $column)];
51 51
         }
52 52
 
53
-        if (is_array($column) && ! isset($column['name'])) {
53
+        if (is_array($column) && !isset($column['name'])) {
54 54
             $column['name'] = 'anonymous_column_'.Str::random(5);
55 55
         }
56 56
 
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
      */
69 69
     protected function makeSureColumnHasLabel($column)
70 70
     {
71
-        if (! isset($column['label'])) {
71
+        if (!isset($column['label'])) {
72 72
             $column['label'] = mb_ucfirst($this->makeLabel($column['name']));
73 73
         }
74 74
 
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
      */
154 154
     protected function makeSureColumnHasKey($column)
155 155
     {
156
-        if (! isset($column['key'])) {
156
+        if (!isset($column['key'])) {
157 157
             $column['key'] = str_replace('.', '__', $column['name']);
158 158
         }
159 159
 
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
      */
171 171
     protected function makeSureColumnHasWrapper($column)
172 172
     {
173
-        if (! isset($column['wrapper'])) {
173
+        if (!isset($column['wrapper'])) {
174 174
             $column['wrapper'] = [];
175 175
         }
176 176
 
@@ -255,7 +255,7 @@  discard block
 block discarded – undo
255 255
     {
256 256
         // if this is a relation type field and no corresponding model was specified,
257 257
         // get it from the relation method defined in the main model
258
-        if (isset($column['entity']) && $column['entity'] !== false && ! isset($column['model'])) {
258
+        if (isset($column['entity']) && $column['entity'] !== false && !isset($column['model'])) {
259 259
             $column['model'] = $this->getRelationModel($column['entity']);
260 260
         }
261 261
 
@@ -292,8 +292,7 @@  discard block
 block discarded – undo
292 292
         $columnsArray = $this->columns();
293 293
 
294 294
         if (array_key_exists($targetColumnName, $columnsArray)) {
295
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) :
296
-                array_search($targetColumnName, array_keys($columnsArray)) + 1;
295
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) : array_search($targetColumnName, array_keys($columnsArray)) + 1;
297 296
 
298 297
             $element = array_pop($columnsArray);
299 298
 
@@ -322,7 +321,7 @@  discard block
 block discarded – undo
322 321
     {
323 322
         static $cache = [];
324 323
 
325
-        if (! $this->driverIsSql()) {
324
+        if (!$this->driverIsSql()) {
326 325
             return true;
327 326
         }
328 327
 
@@ -338,7 +337,7 @@  discard block
 block discarded – undo
338 337
     /**
339 338
      * Prepare the column attributes and add it to operation settings.
340 339
      */
341
-    private function prepareAttributesAndAddColumn(array|string $column): CrudColumn
340
+    private function prepareAttributesAndAddColumn(array | string $column): CrudColumn
342 341
     {
343 342
         $column = $this->makeSureColumnHasNeededAttributes($column);
344 343
         $this->addColumnToOperationSettings($column);
Please login to merge, or discard this patch.