Create::syncPivot() - Code Metrics - Inspection of "Feature select2_many and select2_one" - Laravel-Backpack/CRUD - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1453)

by Oliver

created 2018-06-09 18:52 UTC

Create::syncPivot() C

↳ Parent: Create

Complexity

Conditions	11
Paths	11

Size

Total Lines	24
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	13.8217

Importance

Changes

Metric	Value
cc	11
eloc	13
nc	11
nop	3
dl	0
loc	24
ccs	10
cts	14
cp	0.7143
crap	13.8217
rs	5.3305
c	0
b	0
f	0

How to fix Complexity

<?php

namespace Backpack\CRUD\PanelTraits;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Relations\HasOne;
use Illuminate\Database\Eloquent\Relations\HasMany;
use Illuminate\Database\Eloquent\Relations\BelongsTo;

trait Create
{
    /*
    |--------------------------------------------------------------------------
    |                                   CREATE
    |--------------------------------------------------------------------------
    */

    /**
     * Insert a row in the database.
     *
     * @param  [Request] All input values to be inserted.
     *
     * @return [Eloquent Collection]

     */
    public function create($data)

    {
        $data = $this->decodeJsonCastedAttributes($data, 'create');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $data = $this->compactFakeFields($data, 'create');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        // omit the n-n relationships when updating the eloquent item
        $nn_relationships = array_pluck($this->getRelationFieldsWithPivot('create'), 'name');
        $item = $this->model->create(array_except($data, $nn_relationships));
class MyClass { }

$x = new MyClass();
$x->foo = true;

        // if there are any relationships available, also sync those
        $this->createRelations($item, $data);

        return $item;
    }

    /**
     * Get all fields needed for the ADD NEW ENTRY form.
     *
     * @return [array] The fields with attributes and fake attributes.

     */
    public function getCreateFields()

    {
        return $this->create_fields;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Get all fields with relation set (model key set on field).
     *
     * @param [string: create/update/both]
     *
     * @return [array] The fields with model key set.

     */
    public function getRelationFields($form = 'create')
    {
        if ($form == 'create') {
            $fields = $this->create_fields;
        } else {
            $fields = $this->update_fields;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }

        $relationFields = [];

        foreach ($fields as $field) {
            if (isset($field['model'])) {
                array_push($relationFields, $field);
            }

            if (isset($field['subfields']) &&
                is_array($field['subfields']) &&
                count($field['subfields'])) {
                foreach ($field['subfields'] as $subfield) {
                    array_push($relationFields, $subfield);
                }
            }
        }

        return $relationFields;
    }

    /**
     * Get all fields with n-n relation set (pivot table is true).
     *
     * @param [string: create/update/both]
     *
     * @return [array] The fields with n-n relationships.

     */
    public function getRelationFieldsWithPivot($form = 'create')
    {
        $all_relation_fields = $this->getRelationFields($form);

        return array_where($all_relation_fields, function ($value, $key) {

            return isset($value['pivot']) && $value['pivot'];
        });
    }

    /**
     * Create the relations for the current model.
     *
     * @param \Illuminate\Database\Eloquent\Model $item The current CRUD model.
     * @param array $data The form data.
     * @param string $form Optional form type. Can be either 'create', 'update' or 'both'. Default is 'create'.
     */
    public function createRelations($item, $data, $form = 'create')
    {
        $this->syncPivot($item, $data, $form);
        $this->createDirectRelations($item, $data, $form);
    }

    /**
     * Sync the declared many-to-many associations through the pivot field.
     *
     * @param \Illuminate\Database\Eloquent\Model $model The current CRUD model.
     * @param array $data The form data.
     * @param string $form Optional form type. Can be either 'create', 'update' or 'both'. Default is 'create'.
     */
    public function syncPivot($model, $data, $form = 'create')
    {
        $fields_with_relationships = $this->getRelationFields($form);

        foreach ($fields_with_relationships as $key => $field) {
            if (isset($field['pivot']) && $field['pivot']) {
                $values = isset($data[$field['name']]) ? $data[$field['name']] : [];
                $model->{$field['name']}()->sync($values);

                if (isset($field['pivotFields'])) {
                    foreach ($field['pivotFields'] as $pivotField) {
                        foreach ($data[$pivotField] as $pivot_id => $pivot_field) {
                            $model->{$field['name']}()->updateExistingPivot($pivot_id, [$pivotField => $pivot_field]);
                        }
                    }
                }
            }

            if (isset($field['morph']) && $field['morph'] && isset($data[$field['name']])) {
                $values = $data[$field['name']];
                $model->{$field['name']}()->sync($values);
            }
        }
    }

    /**
     * Create any existing direct (not n:n) relations for the current model from the form data.
     *
     * @param \Illuminate\Database\Eloquent\Model $item The current CRUD model.
     * @param array $data The form data.
     * @param string $form Optional form type. Can be either 'create', 'update' or 'both'. Default is 'create'.
     */
    private function createDirectRelations($item, $data, $form = 'create')
    {
        $relationData = $this->getRelationDataFromFormData($data, $form);
        $this->createRelationsForItem($item, $relationData);
    }

    /**
     * Create any existing one to one relations for the current model from the relation data.
     *
     * @param \Illuminate\Database\Eloquent\Model $item The current CRUD model.
     * @param array $formattedData The form data.
     */
    private function createRelationsForItem($item, $formattedData)
    {
        if (! isset($formattedData['relations'])) {
            return false;
        }

        foreach ($formattedData['relations'] as $relationMethod => $relationData) {
            $model = $relationData['model'];
            $relation = $item->{$relationMethod}();
            if ($relation instanceof BelongsTo) {
                $modelInstance = $model::find($relationData['values'])->first();
                if ($modelInstance != null) {
                    $relation->associate($modelInstance)->save();
                } else {
                    $relation->dissociate()->save();
                }
            } elseif ($relation instanceof HasOne) {
                if ($item->{$relationMethod} != null) {
                    $item->{$relationMethod}->update([$relation->getForeignKeyName() => $relationData['fallback_id'] ?? null]);

                }

                $modelInstance = $model::find($relationData['values'][$relationMethod]);
                $relation->save($modelInstance);
                $modelInstance = $item->{$relationMethod};
            } elseif ($relation instanceof HasMany) {
                $related_ids = collect($relationData['values'][$relationMethod]);
                $old_ids = $item->{$relationMethod}->pluck($relation->getRelated()->getKeyName());
                $removed = $old_ids->diff($related_ids);
                $added = $related_ids->diff($old_ids);

                $instance = new $model();
                $model::whereIn($instance->getKeyName(), $removed)->update([$relation->getForeignKeyName() => $relationData['fallback_id'] ?? null]);

                $model::whereIn($instance->getKeyName(), $added)->update([$relation->getForeignKeyName() => $item->getKey()]);

                $item = $item->load($relationMethod);
            } else {
                $relationModel = new $model();
                $modelInstance = $relationModel->create($relationData['values']);
                $relation->save($modelInstance);
            }

            if (isset($relationData['relations'])) {
                $this->createRelationsForItem($modelInstance, ['relations' => $relationData['relations']]);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            }
        }
    }

    /**
     * Get a relation data array from the form data.
     * For each relation defined in the fields through the entity attribute, set the model, the parent model and the
     * attribute values. For relations defined with the "dot" notations, this will be used to calculate the depth in the
     * final array (@see \Illuminate\Support\Arr::set() for more).
     *
     * @param array $data The form data.
     * @param string $form Optional form type. Can be either 'create', 'update' or 'both'. Default is 'create'.
     *
     * @return array The formatted relation data.
     */
    private function getRelationDataFromFormData($data, $form = 'create')
    {
        $relationFields = $this->getRelationFields($form);

        $relationData = [];
        foreach ($relationFields as $relationField) {
            $attributeKey = $relationField['name'];
            if (array_key_exists($attributeKey, $data) && empty($relationField['pivot'])) {
                $key = implode('.relations.', explode('.', $relationField['entity']));
                $fieldData = array_get($relationData, 'relations.'.$key, []);

                if (! array_key_exists('model', $fieldData)) {
                    $fieldData['model'] = $relationField['model'];
                }

                if (! array_key_exists('parent', $fieldData)) {
                    $fieldData['parent'] = $this->getRelationModel($relationField['entity'], -1);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                }

                if (array_key_exists('fallback_id', $relationField)) {
                    $fieldData['fallback_id'] = $relationField['fallback_id'];
                }

                $fieldData['values'][$attributeKey] = $data[$attributeKey];

                array_set($relationData, 'relations.'.$key, $fieldData);
            }
        }

        return $relationData;
    }
}


Scrutinizer GitHub App not installed

Pull Request — master (#1453)

Create::syncPivot() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Available Fixes

1		<?php
2
3		namespace Backpack\CRUD\PanelTraits;
4
5		use Illuminate\Database\Eloquent\Model;
6		use Illuminate\Database\Eloquent\Relations\HasOne;
7		use Illuminate\Database\Eloquent\Relations\HasMany;
8		use Illuminate\Database\Eloquent\Relations\BelongsTo;
9
10		trait Create
11		{
12		/*
13		\|--------------------------------------------------------------------------
14		\| CREATE
15		\|--------------------------------------------------------------------------
16		*/
17
18		/**
19		* Insert a row in the database.
20		*
21		* @param [Request] All input values to be inserted.
22		*
23		* @return [Eloquent Collection]
		0 ignored issues – show Documentation introduced 2016-05-18 15:19 UTC by Report Bug Copy Issue Report The doc-type `Eloquent">[Eloquent` could not be parsed: Unknown type name "[" at position 0. [(view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
24		*/
25	5	public function create($data)
		0 ignored issues – show Documentation introduced 2017-08-03 17:04 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
26		{
27	5	$data = $this->decodeJsonCastedAttributes($data, 'create');
		0 ignored issues – show Bug introduced 2017-04-18 10:54 UTC by Report Bug Copy Issue Report It seems like `decodeJsonCastedAttributes()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
28	5	$data = $this->compactFakeFields($data, 'create');
		0 ignored issues – show Bug introduced 2017-04-18 10:54 UTC by Report Bug Copy Issue Report It seems like `compactFakeFields()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
29
30		// omit the n-n relationships when updating the eloquent item
31	5	$nn_relationships = array_pluck($this->getRelationFieldsWithPivot('create'), 'name');
32	5	$item = $this->model->create(array_except($data, $nn_relationships));
		0 ignored issues – show Bug introduced 2017-04-18 11:15 UTC by Report Bug Copy Issue Report The property `model` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
33
34		// if there are any relationships available, also sync those
35	5	$this->createRelations($item, $data);
36
37	5	return $item;
38		}
39
40		/**
41		* Get all fields needed for the ADD NEW ENTRY form.
42		*
43		* @return [array] The fields with attributes and fake attributes.
		0 ignored issues – show Documentation introduced 2016-06-16 14:52 UTC by Report Bug Copy Issue Report The doc-type `[array]` could not be parsed: Unknown type name "" at position 0. [(view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
44		*/
45	23	public function getCreateFields()
		0 ignored issues – show Documentation introduced 2017-08-03 17:04 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
46		{
47	23	return $this->create_fields;
		0 ignored issues – show Bug introduced 2016-06-16 14:52 UTC by Report Bug Copy Issue Report The property `create_fields` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
48		}
49
50		/**
51		* Get all fields with relation set (model key set on field).
52		*
53		* @param [string: create/update/both]
54		*
55		* @return [array] The fields with model key set.
		0 ignored issues – show Documentation introduced 2016-05-18 16:25 UTC by Report Bug Copy Issue Report The doc-type `[array]` could not be parsed: Unknown type name "" at position 0. [(view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
56		*/
57	16	public function getRelationFields($form = 'create')
58		{
59	16	if ($form == 'create') {
60	14	$fields = $this->create_fields;
61		} else {
62	2	$fields = $this->update_fields;
		0 ignored issues – show Bug introduced 2017-04-18 11:15 UTC by Report Bug Copy Issue Report The property `update_fields` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
63		}
64
65	16	$relationFields = [];
66
67	16	foreach ($fields as $field) {
68	15	if (isset($field['model'])) {
69	9	array_push($relationFields, $field);
70		}
71
72	15	if (isset($field['subfields']) &&
73	15	is_array($field['subfields']) &&
74	15	count($field['subfields'])) {
75		foreach ($field['subfields'] as $subfield) {
76	15	array_push($relationFields, $subfield);
77		}
78		}
79		}
80
81	16	return $relationFields;
82		}
83
84		/**
85		* Get all fields with n-n relation set (pivot table is true).
86		*
87		* @param [string: create/update/both]
88		*
89		* @return [array] The fields with n-n relationships.
		0 ignored issues – show Documentation introduced 2016-12-23 13:37 UTC by Report Bug Copy Issue Report The doc-type `[array]` could not be parsed: Unknown type name "" at position 0. [(view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
90		*/
91	8	public function getRelationFieldsWithPivot($form = 'create')
92		{
93	8	$all_relation_fields = $this->getRelationFields($form);
94
95	8	return array_where($all_relation_fields, function ($value, $key) {
		0 ignored issues – show Unused Code introduced 2016-12-23 13:37 UTC by Report Bug Copy Issue Report The parameter `$key` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
96	4	return isset($value['pivot']) && $value['pivot'];
97	8	});
98		}
99
100		/**
101		* Create the relations for the current model.
102		*
103		* @param \Illuminate\Database\Eloquent\Model $item The current CRUD model.
104		* @param array $data The form data.
105		* @param string $form Optional form type. Can be either 'create', 'update' or 'both'. Default is 'create'.
106		*/
107	6	public function createRelations($item, $data, $form = 'create')
108		{
109	6	$this->syncPivot($item, $data, $form);
110	6	$this->createDirectRelations($item, $data, $form);
111	6	}
112
113		/**
114		* Sync the declared many-to-many associations through the pivot field.
115		*
116		* @param \Illuminate\Database\Eloquent\Model $model The current CRUD model.
117		* @param array $data The form data.
118		* @param string $form Optional form type. Can be either 'create', 'update' or 'both'. Default is 'create'.
119		*/
120	9	public function syncPivot($model, $data, $form = 'create')
121		{
122	9	$fields_with_relationships = $this->getRelationFields($form);
123
124	9	foreach ($fields_with_relationships as $key => $field) {
125	5	if (isset($field['pivot']) && $field['pivot']) {
126	4	$values = isset($data[$field['name']]) ? $data[$field['name']] : [];
127	4	$model->{$field['name']}()->sync($values);
128
129	3	if (isset($field['pivotFields'])) {
130		foreach ($field['pivotFields'] as $pivotField) {
131		foreach ($data[$pivotField] as $pivot_id => $pivot_field) {
132		$model->{$field['name']}()->updateExistingPivot($pivot_id, [$pivotField => $pivot_field]);
133		}
134		}
135		}
136		}
137
138	4	if (isset($field['morph']) && $field['morph'] && isset($data[$field['name']])) {
139		$values = $data[$field['name']];
140	4	$model->{$field['name']}()->sync($values);
141		}
142		}
143	8	}
144
145		/**
146		* Create any existing direct (not n:n) relations for the current model from the form data.
147		*
148		* @param \Illuminate\Database\Eloquent\Model $item The current CRUD model.
149		* @param array $data The form data.
150		* @param string $form Optional form type. Can be either 'create', 'update' or 'both'. Default is 'create'.
151		*/
152	6	private function createDirectRelations($item, $data, $form = 'create')
153		{
154	6	$relationData = $this->getRelationDataFromFormData($data, $form);
155	6	$this->createRelationsForItem($item, $relationData);
156	6	}
157
158		/**
159		* Create any existing one to one relations for the current model from the relation data.
160		*
161		* @param \Illuminate\Database\Eloquent\Model $item The current CRUD model.
162		* @param array $formattedData The form data.
163		*/
164	6	private function createRelationsForItem($item, $formattedData)
165		{
166	6	if (! isset($formattedData['relations'])) {
167	4	return false;
168		}
169
170	2	foreach ($formattedData['relations'] as $relationMethod => $relationData) {
171	2	$model = $relationData['model'];
172	2	$relation = $item->{$relationMethod}();
173	2	if ($relation instanceof BelongsTo) {
174	1	$modelInstance = $model::find($relationData['values'])->first();
175	1	if ($modelInstance != null) {
176	1	$relation->associate($modelInstance)->save();
177		} else {
178	1	$relation->dissociate()->save();
179		}
180	1	} elseif ($relation instanceof HasOne) {
181		if ($item->{$relationMethod} != null) {
182		$item->{$relationMethod}->update([$relation->getForeignKeyName() => $relationData['fallback_id'] ?? null]);
		0 ignored issues – show Coding Style introduced 2018-06-09 18:23 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 127 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
183		}
184
185		$modelInstance = $model::find($relationData['values'][$relationMethod]);
186		$relation->save($modelInstance);
187		$modelInstance = $item->{$relationMethod};
188	1	} elseif ($relation instanceof HasMany) {
189	1	$related_ids = collect($relationData['values'][$relationMethod]);
190	1	$old_ids = $item->{$relationMethod}->pluck($relation->getRelated()->getKeyName());
191	1	$removed = $old_ids->diff($related_ids);
192	1	$added = $related_ids->diff($old_ids);
193
194	1	$instance = new $model();
195	1	$model::whereIn($instance->getKeyName(), $removed)->update([$relation->getForeignKeyName() => $relationData['fallback_id'] ?? null]);
		0 ignored issues – show Coding Style introduced 2018-06-09 18:23 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 149 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
196	1	$model::whereIn($instance->getKeyName(), $added)->update([$relation->getForeignKeyName() => $item->getKey()]);
		0 ignored issues – show Coding Style introduced 2018-06-09 18:23 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 126 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
197	1	$item = $item->load($relationMethod);
198		} else {
199		$relationModel = new $model();
200		$modelInstance = $relationModel->create($relationData['values']);
201		$relation->save($modelInstance);
202		}
203
204	2	if (isset($relationData['relations'])) {
205	2	$this->createRelationsForItem($modelInstance, ['relations' => $relationData['relations']]);
		0 ignored issues – show Bug introduced 2018-06-09 18:23 UTC by Report Bug Copy Issue Report The variable `$modelInstance` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
206		}
207		}
208	2	}
209
210		/**
211		* Get a relation data array from the form data.
212		* For each relation defined in the fields through the entity attribute, set the model, the parent model and the
213		* attribute values. For relations defined with the "dot" notations, this will be used to calculate the depth in the
214		* final array (@see \Illuminate\Support\Arr::set() for more).
215		*
216		* @param array $data The form data.
217		* @param string $form Optional form type. Can be either 'create', 'update' or 'both'. Default is 'create'.
218		*
219		* @return array The formatted relation data.
220		*/
221	6	private function getRelationDataFromFormData($data, $form = 'create')
222		{
223	6	$relationFields = $this->getRelationFields($form);
224
225	6	$relationData = [];
226	6	foreach ($relationFields as $relationField) {
227	3	$attributeKey = $relationField['name'];
228	3	if (array_key_exists($attributeKey, $data) && empty($relationField['pivot'])) {
229	2	$key = implode('.relations.', explode('.', $relationField['entity']));
230	2	$fieldData = array_get($relationData, 'relations.'.$key, []);
231
232	2	if (! array_key_exists('model', $fieldData)) {
233	2	$fieldData['model'] = $relationField['model'];
234		}
235
236	2	if (! array_key_exists('parent', $fieldData)) {
237	2	$fieldData['parent'] = $this->getRelationModel($relationField['entity'], -1);
		0 ignored issues – show Bug introduced 2018-03-21 17:24 UTC by Report Bug Copy Issue Report It seems like `getRelationModel()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
238		}
239
240	2	if (array_key_exists('fallback_id', $relationField)) {
241		$fieldData['fallback_id'] = $relationField['fallback_id'];
242		}
243
244	2	$fieldData['values'][$attributeKey] = $data[$attributeKey];
245
246	3	array_set($relationData, 'relations.'.$key, $fieldData);
247		}
248		}
249
250	6	return $relationData;
251		}
252		}
253

Laravel-Backpack / CRUD

Scrutinizer GitHub App not installed

Pull Request — master (#1453)

Create::syncPivot() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Available Fixes

Duplication Side-by-Side

Filter issues like