CrudPanelCreateTest - Code Metrics - Inspection of "Feature select2_many and select2_one" - Laravel-Backpack/CRUD - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1453)

by Oliver

created 2018-06-09 18:52 UTC

CrudPanelCreateTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	353
Duplicated Lines	29.18 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	2
Bugs	2	Features	0

Metric	Value
wmc	17
c	2
b	2
f	0
lcom	1
cbo	4
dl	103
loc	353
rs	10

17 Methods

Rating	Name	Duplication	Size	Complexity
A	testCreate()	0	17	1
A	testCreateWithOneToOneRelationship()	0	4	1
A	testCreateWithOneToManyRelationship()	0	23	1
A	testCreateWithManyToOneRelationship()	0	19	1
A	testCreateWithManyToManyRelationship()	0	18	1
A	testGetRelationFields()	13	13	1
A	testGetRelationFieldsCreateForm()	9	9	1
A	testGetRelationFieldsUpdateForm()	9	9	1
A	testGetRelationFieldsUnknownForm()	0	13	1
A	testGetRelationFieldsDotNotation()	9	9	1
A	testGetRelationFieldsNoRelations()	0	8	1
A	testGetRelationFieldsNoFields()	0	6	1
A	testGetRelationFieldsWithPivot()	9	9	1
A	testGetRelationFieldsWithPivotNoRelations()	0	9	1
A	testSyncPivot()	18	18	1
A	testSyncPivotUnknownData()	18	18	1
A	testSyncPivotUnknownModel()	18	18	1

How to fix Duplicated Code

<?php

namespace Backpack\CRUD\Tests\Unit\CrudPanel;

use Faker\Factory;
use Backpack\CRUD\Tests\Unit\Models\User;
use Backpack\CRUD\Tests\Unit\Models\Article;

class CrudPanelCreateTest extends BaseDBCrudPanelTest
{
    private $nonRelationshipField = [
        'name' => 'field1',
        'label' => 'Field1',
    ];

    private $userInputFieldsNoRelationships = [
        [
            'name' => 'id',
            'type' => 'hidden',
        ], [
            'name' => 'name',
        ], [
            'name' => 'email',
            'type' => 'email',
        ], [
            'name' => 'password',
            'type' => 'password',
        ],
    ];

    private $articleInputFieldsOneToMany = [
        [
            'name' => 'id',
            'type' => 'hidden',
        ], [
            'name' => 'content',
        ], [
            'name' => 'tags',
        ], [
            'label' => 'Author',
            'type' => 'select',
            'name' => 'user_id',
            'entity' => 'user',
            'attribute' => 'name',
        ],
    ];

    private $userInputFieldsManyToMany = [
        [
            'name' => 'id',
            'type' => 'hidden',
        ], [
            'name' => 'name',
        ], [
            'name' => 'email',
            'type' => 'email',
        ], [
            'name' => 'password',
            'type' => 'password',
        ], [
            'label' => 'Roles',
            'type' => 'select_multiple',
            'name' => 'roles',
            'entity' => 'roles',
            'attribute' => 'name',
            'pivot' => true,
        ],
    ];

    private $userInputFieldsDotNotation = [
        [
            'name' => 'id',
            'type' => 'hidden',
        ], [
            'name' => 'name',
        ], [
            'name' => 'email',
            'type' => 'email',
        ], [
            'name' => 'password',
            'type' => 'password',
        ], [
            'label' => 'Roles',
            'type' => 'select_multiple',
            'name' => 'roles',
            'entity' => 'roles',
            'attribute' => 'name',
            'pivot' => true,
        ], [
            'label' => 'Street',
            'name' => 'street',
            'entity' => 'accountDetails.addresses',
            'attribute' => 'street',
        ],
    ];

    private $userInputFieldsManyToOne = [
        [
            'name' => 'id',
            'type' => 'hidden',
        ], [
            'name' => 'name',
        ], [
            'name' => 'email',
            'type' => 'email',
        ], [
            'name' => 'password',
            'type' => 'password',
        ], [
            'label' => 'Roles',
            'type' => 'select_multiple',
            'name' => 'roles',
            'entity' => 'roles',
            'attribute' => 'name',
            'pivot' => true,
        ], [
            'name' => 'articles',
            'type' => 'select2_many',
            'entity' => 'articles',
            'model' => Article::class,
            'attribute' => 'content',
        ],
    ];

    public function testCreate()
    {
        $this->crudPanel->setModel(User::class);
        $this->crudPanel->addFields($this->userInputFieldsNoRelationships);
        $faker = Factory::create();
        $inputData = [
            'name' => $faker->name,
            'email' => $faker->safeEmail,
            'password' => bcrypt($faker->password()),
        ];

        $entry = $this->crudPanel->create($inputData);

        $this->assertInstanceOf(User::class, $entry);
        $this->assertEntryEquals($inputData, $entry);
        $this->assertEmpty($entry->articles);
    }

    public function testCreateWithOneToOneRelationship()
    {
        $this->markTestIncomplete('Not yet implemented');
    }

    public function testCreateWithOneToManyRelationship()
    {
        $this->crudPanel->setModel(Article::class);
        $this->crudPanel->addFields($this->articleInputFieldsOneToMany);
        $faker = Factory::create();
        $inputData = [
            'content' => $faker->text(),
            'tags' => $faker->words(3, true),
            'user_id' => 1,
            'metas' => null,
            'extras' => null,
            'cast_metas' => null,
            'cast_tags' => null,
            'cast_extras' => null,
        ];

        $entry = $this->crudPanel->create($inputData);
        $userEntry = User::find(1);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $article = Article::where('user_id', 1)->with('user')->get()->last();

        $this->assertEntryEquals($inputData, $entry);
        $this->assertEquals($article->toArray(), $entry->toArray());
    }

    public function testCreateWithManyToOneRelationship()
    {
        $this->crudPanel->setModel(User::class);
        $this->crudPanel->addFields($this->userInputFieldsManyToOne);
        $faker = Factory::create();
        $inputData = [
            'name' => $faker->name,
            'email' => $faker->safeEmail,
            'password' => bcrypt($faker->password()),
            'remember_token' => null,
            'roles' => [1, 2],
            'articles' => [1, 2],
        ];

        $entry = $this->crudPanel->create($inputData);

        $this->assertInstanceOf(User::class, $entry);
        $this->assertEntryEquals($inputData, $entry);
    }

    public function testCreateWithManyToManyRelationship()
    {
        $this->crudPanel->setModel(User::class);
        $this->crudPanel->addFields($this->userInputFieldsManyToMany);
        $faker = Factory::create();
        $inputData = [
            'name' => $faker->name,
            'email' => $faker->safeEmail,
            'password' => bcrypt($faker->password()),
            'remember_token' => null,
            'roles' => [1, 2],
        ];

        $entry = $this->crudPanel->create($inputData);

        $this->assertInstanceOf(User::class, $entry);
        $this->assertEntryEquals($inputData, $entry);
    }

    public function testGetRelationFields()

    {
        $this->markTestIncomplete('Not correctly implemented');

        $this->crudPanel->setModel(User::class);
        $this->crudPanel->addFields($this->userInputFieldsManyToMany, 'create');

        // TODO: fix method and documentation. when 'both' is passed as the $form value, the getRelationFields searches
        //       for relationship fields in the update fields.
        $relationFields = $this->crudPanel->getRelationFields('both');

        $this->assertEquals($this->crudPanel->create_fields['roles'], array_last($relationFields));
    }

    public function testGetRelationFieldsCreateForm()

    {
        $this->crudPanel->setModel(User::class);
        $this->crudPanel->addFields($this->userInputFieldsManyToMany, 'create');

        $relationFields = $this->crudPanel->getRelationFields('create');

        $this->assertEquals($this->crudPanel->create_fields['roles'], array_last($relationFields));
    }

    public function testGetRelationFieldsUpdateForm()

    {
        $this->crudPanel->setModel(User::class);
        $this->crudPanel->addFields($this->userInputFieldsManyToMany, 'update');

        $relationFields = $this->crudPanel->getRelationFields('update');

        $this->assertEquals($this->crudPanel->update_fields['roles'], array_last($relationFields));
    }

    public function testGetRelationFieldsUnknownForm()
    {
        $this->markTestIncomplete('Not correctly implemented');

        $this->expectException(\InvalidArgumentException::class);

        $this->crudPanel->setModel(User::class);
        $this->crudPanel->addFields($this->userInputFieldsManyToMany);

        // TODO: this should throw an invalid argument exception but instead it searches for relationship fields in the
        //       update fields.
        $this->crudPanel->getRelationFields('unknownForm');
    }

    public function testGetRelationFieldsDotNotation()

    {
        $this->crudPanel->setModel(User::class);
        $this->crudPanel->addFields($this->userInputFieldsDotNotation, 'create');

        $relationFields = $this->crudPanel->getRelationFields('create');

        $this->assertEquals($this->crudPanel->create_fields['street'], array_last($relationFields));
    }

    public function testGetRelationFieldsNoRelations()
    {
        $this->crudPanel->addField($this->nonRelationshipField);

        $relationFields = $this->crudPanel->getRelationFields();

        $this->assertEmpty($relationFields);
    }

    public function testGetRelationFieldsNoFields()
    {
        $relationFields = $this->crudPanel->getRelationFields();

        $this->assertEmpty($relationFields);
    }

    public function testGetRelationFieldsWithPivot()

    {
        $this->crudPanel->setModel(User::class);
        $this->crudPanel->addFields($this->userInputFieldsDotNotation, 'create');

        $relationFields = $this->crudPanel->getRelationFieldsWithPivot('create');

        $this->assertEquals($this->crudPanel->create_fields['roles'], array_last($relationFields));
    }

    public function testGetRelationFieldsWithPivotNoRelations()
    {
        $this->crudPanel->setModel(User::class);
        $this->crudPanel->addFields($this->nonRelationshipField, 'create');

        $relationFields = $this->crudPanel->getRelationFieldsWithPivot('create');

        $this->assertEmpty($relationFields);
    }

    public function testSyncPivot()

    {
        $this->crudPanel->setModel(User::class);
        $this->crudPanel->addFields($this->userInputFieldsManyToMany);
        $faker = Factory::create();
        $inputData = [
            'name' => $faker->name,
            'email' => $faker->safeEmail,
            'password' => bcrypt($faker->password()),
            'remember_token' => null,
            'roles' => [1, 2],
        ];

        $entry = User::find(1);
        $this->crudPanel->syncPivot($entry, $inputData);

        $this->assertEquals($inputData['roles'], $entry->roles->pluck('id')->toArray());
    }

    public function testSyncPivotUnknownData()

    {
        $this->crudPanel->setModel(User::class);
        $this->crudPanel->addFields($this->nonRelationshipField);
        $faker = Factory::create();
        $inputData = [
            'name' => $faker->name,
            'email' => $faker->safeEmail,
            'password' => bcrypt($faker->password()),
            'remember_token' => null,
            'roles' => [1, 2],
        ];

        $entry = User::find(1);
        $this->crudPanel->syncPivot($entry, $inputData);

        $this->assertEquals(1, $entry->roles->count());
    }

    public function testSyncPivotUnknownModel()

    {
        $this->expectException(\BadMethodCallException::class);

        $this->crudPanel->setModel(User::class);
        $this->crudPanel->addFields($this->userInputFieldsManyToMany);
        $faker = Factory::create();
        $inputData = [
            'name' => $faker->name,
            'email' => $faker->safeEmail,
            'password' => bcrypt($faker->password()),
            'remember_token' => null,
            'roles' => [1, 2],
        ];

        $entry = Article::find(1);
        $this->crudPanel->syncPivot($entry, $inputData);
    }
}


1		<?php
2
3		namespace Backpack\CRUD\Tests\Unit\CrudPanel;
4
5		use Faker\Factory;
6		use Backpack\CRUD\Tests\Unit\Models\User;
7		use Backpack\CRUD\Tests\Unit\Models\Article;
8
9		class CrudPanelCreateTest extends BaseDBCrudPanelTest
10		{
11		private $nonRelationshipField = [
12		'name' => 'field1',
13		'label' => 'Field1',
14		];
15
16		private $userInputFieldsNoRelationships = [
17		[
18		'name' => 'id',
19		'type' => 'hidden',
20		], [
21		'name' => 'name',
22		], [
23		'name' => 'email',
24		'type' => 'email',
25		], [
26		'name' => 'password',
27		'type' => 'password',
28		],
29		];
30
31		private $articleInputFieldsOneToMany = [
32		[
33		'name' => 'id',
34		'type' => 'hidden',
35		], [
36		'name' => 'content',
37		], [
38		'name' => 'tags',
39		], [
40		'label' => 'Author',
41		'type' => 'select',
42		'name' => 'user_id',
43		'entity' => 'user',
44		'attribute' => 'name',
45		],
46		];
47
48		private $userInputFieldsManyToMany = [
49		[
50		'name' => 'id',
51		'type' => 'hidden',
52		], [
53		'name' => 'name',
54		], [
55		'name' => 'email',
56		'type' => 'email',
57		], [
58		'name' => 'password',
59		'type' => 'password',
60		], [
61		'label' => 'Roles',
62		'type' => 'select_multiple',
63		'name' => 'roles',
64		'entity' => 'roles',
65		'attribute' => 'name',
66		'pivot' => true,
67		],
68		];
69
70		private $userInputFieldsDotNotation = [
71		[
72		'name' => 'id',
73		'type' => 'hidden',
74		], [
75		'name' => 'name',
76		], [
77		'name' => 'email',
78		'type' => 'email',
79		], [
80		'name' => 'password',
81		'type' => 'password',
82		], [
83		'label' => 'Roles',
84		'type' => 'select_multiple',
85		'name' => 'roles',
86		'entity' => 'roles',
87		'attribute' => 'name',
88		'pivot' => true,
89		], [
90		'label' => 'Street',
91		'name' => 'street',
92		'entity' => 'accountDetails.addresses',
93		'attribute' => 'street',
94		],
95		];
96
97		private $userInputFieldsManyToOne = [
98		[
99		'name' => 'id',
100		'type' => 'hidden',
101		], [
102		'name' => 'name',
103		], [
104		'name' => 'email',
105		'type' => 'email',
106		], [
107		'name' => 'password',
108		'type' => 'password',
109		], [
110		'label' => 'Roles',
111		'type' => 'select_multiple',
112		'name' => 'roles',
113		'entity' => 'roles',
114		'attribute' => 'name',
115		'pivot' => true,
116		], [
117		'name' => 'articles',
118		'type' => 'select2_many',
119		'entity' => 'articles',
120		'model' => Article::class,
121		'attribute' => 'content',
122		],
123		];
124
125		public function testCreate()
126		{
127		$this->crudPanel->setModel(User::class);
128		$this->crudPanel->addFields($this->userInputFieldsNoRelationships);
129		$faker = Factory::create();
130		$inputData = [
131		'name' => $faker->name,
132		'email' => $faker->safeEmail,
133		'password' => bcrypt($faker->password()),
134		];
135
136		$entry = $this->crudPanel->create($inputData);
137
138		$this->assertInstanceOf(User::class, $entry);
139		$this->assertEntryEquals($inputData, $entry);
140		$this->assertEmpty($entry->articles);
141		}
142
143		public function testCreateWithOneToOneRelationship()
144		{
145		$this->markTestIncomplete('Not yet implemented');
146		}
147
148		public function testCreateWithOneToManyRelationship()
149		{
150		$this->crudPanel->setModel(Article::class);
151		$this->crudPanel->addFields($this->articleInputFieldsOneToMany);
152		$faker = Factory::create();
153		$inputData = [
154		'content' => $faker->text(),
155		'tags' => $faker->words(3, true),
156		'user_id' => 1,
157		'metas' => null,
158		'extras' => null,
159		'cast_metas' => null,
160		'cast_tags' => null,
161		'cast_extras' => null,
162		];
163
164		$entry = $this->crudPanel->create($inputData);
165		$userEntry = User::find(1);
		0 ignored issues – show Unused Code introduced 2018-03-23 05:06 UTC by Report Bug Copy Issue Report `$userEntry` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
166		$article = Article::where('user_id', 1)->with('user')->get()->last();
167
168		$this->assertEntryEquals($inputData, $entry);
169		$this->assertEquals($article->toArray(), $entry->toArray());
170		}
171
172		public function testCreateWithManyToOneRelationship()
173		{
174		$this->crudPanel->setModel(User::class);
175		$this->crudPanel->addFields($this->userInputFieldsManyToOne);
176		$faker = Factory::create();
177		$inputData = [
178		'name' => $faker->name,
179		'email' => $faker->safeEmail,
180		'password' => bcrypt($faker->password()),
181		'remember_token' => null,
182		'roles' => [1, 2],
183		'articles' => [1, 2],
184		];
185
186		$entry = $this->crudPanel->create($inputData);
187
188		$this->assertInstanceOf(User::class, $entry);
189		$this->assertEntryEquals($inputData, $entry);
190		}
191
192		public function testCreateWithManyToManyRelationship()
193		{
194		$this->crudPanel->setModel(User::class);
195		$this->crudPanel->addFields($this->userInputFieldsManyToMany);
196		$faker = Factory::create();
197		$inputData = [
198		'name' => $faker->name,
199		'email' => $faker->safeEmail,
200		'password' => bcrypt($faker->password()),
201		'remember_token' => null,
202		'roles' => [1, 2],
203		];
204
205		$entry = $this->crudPanel->create($inputData);
206
207		$this->assertInstanceOf(User::class, $entry);
208		$this->assertEntryEquals($inputData, $entry);
209		}
210
211	View Code Duplication	public function testGetRelationFields()
		0 ignored issues – show Duplication introduced 2017-09-27 13:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
212		{
213		$this->markTestIncomplete('Not correctly implemented');
214
215		$this->crudPanel->setModel(User::class);
216		$this->crudPanel->addFields($this->userInputFieldsManyToMany, 'create');
217
218		// TODO: fix method and documentation. when 'both' is passed as the $form value, the getRelationFields searches
219		// for relationship fields in the update fields.
220		$relationFields = $this->crudPanel->getRelationFields('both');
221
222		$this->assertEquals($this->crudPanel->create_fields['roles'], array_last($relationFields));
223		}
224
225	View Code Duplication	public function testGetRelationFieldsCreateForm()
		0 ignored issues – show Duplication introduced 2017-09-27 13:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
226		{
227		$this->crudPanel->setModel(User::class);
228		$this->crudPanel->addFields($this->userInputFieldsManyToMany, 'create');
229
230		$relationFields = $this->crudPanel->getRelationFields('create');
231
232		$this->assertEquals($this->crudPanel->create_fields['roles'], array_last($relationFields));
233		}
234
235	View Code Duplication	public function testGetRelationFieldsUpdateForm()
		0 ignored issues – show Duplication introduced 2017-09-27 13:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
236		{
237		$this->crudPanel->setModel(User::class);
238		$this->crudPanel->addFields($this->userInputFieldsManyToMany, 'update');
239
240		$relationFields = $this->crudPanel->getRelationFields('update');
241
242		$this->assertEquals($this->crudPanel->update_fields['roles'], array_last($relationFields));
243		}
244
245		public function testGetRelationFieldsUnknownForm()
246		{
247		$this->markTestIncomplete('Not correctly implemented');
248
249		$this->expectException(\InvalidArgumentException::class);
250
251		$this->crudPanel->setModel(User::class);
252		$this->crudPanel->addFields($this->userInputFieldsManyToMany);
253
254		// TODO: this should throw an invalid argument exception but instead it searches for relationship fields in the
255		// update fields.
256		$this->crudPanel->getRelationFields('unknownForm');
257		}
258
259	View Code Duplication	public function testGetRelationFieldsDotNotation()
		0 ignored issues – show Duplication introduced 2017-09-27 13:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
260		{
261		$this->crudPanel->setModel(User::class);
262		$this->crudPanel->addFields($this->userInputFieldsDotNotation, 'create');
263
264		$relationFields = $this->crudPanel->getRelationFields('create');
265
266		$this->assertEquals($this->crudPanel->create_fields['street'], array_last($relationFields));
267		}
268
269		public function testGetRelationFieldsNoRelations()
270		{
271		$this->crudPanel->addField($this->nonRelationshipField);
272
273		$relationFields = $this->crudPanel->getRelationFields();
274
275		$this->assertEmpty($relationFields);
276		}
277
278		public function testGetRelationFieldsNoFields()
279		{
280		$relationFields = $this->crudPanel->getRelationFields();
281
282		$this->assertEmpty($relationFields);
283		}
284
285	View Code Duplication	public function testGetRelationFieldsWithPivot()
		0 ignored issues – show Duplication introduced 2017-09-27 13:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
286		{
287		$this->crudPanel->setModel(User::class);
288		$this->crudPanel->addFields($this->userInputFieldsDotNotation, 'create');
289
290		$relationFields = $this->crudPanel->getRelationFieldsWithPivot('create');
291
292		$this->assertEquals($this->crudPanel->create_fields['roles'], array_last($relationFields));
293		}
294
295		public function testGetRelationFieldsWithPivotNoRelations()
296		{
297		$this->crudPanel->setModel(User::class);
298		$this->crudPanel->addFields($this->nonRelationshipField, 'create');
299
300		$relationFields = $this->crudPanel->getRelationFieldsWithPivot('create');
301
302		$this->assertEmpty($relationFields);
303		}
304
305	View Code Duplication	public function testSyncPivot()
		0 ignored issues – show Duplication introduced 2017-09-27 13:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
306		{
307		$this->crudPanel->setModel(User::class);
308		$this->crudPanel->addFields($this->userInputFieldsManyToMany);
309		$faker = Factory::create();
310		$inputData = [
311		'name' => $faker->name,
312		'email' => $faker->safeEmail,
313		'password' => bcrypt($faker->password()),
314		'remember_token' => null,
315		'roles' => [1, 2],
316		];
317
318		$entry = User::find(1);
319		$this->crudPanel->syncPivot($entry, $inputData);
320
321		$this->assertEquals($inputData['roles'], $entry->roles->pluck('id')->toArray());
322		}
323
324	View Code Duplication	public function testSyncPivotUnknownData()
		0 ignored issues – show Duplication introduced 2017-09-27 13:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
325		{
326		$this->crudPanel->setModel(User::class);
327		$this->crudPanel->addFields($this->nonRelationshipField);
328		$faker = Factory::create();
329		$inputData = [
330		'name' => $faker->name,
331		'email' => $faker->safeEmail,
332		'password' => bcrypt($faker->password()),
333		'remember_token' => null,
334		'roles' => [1, 2],
335		];
336
337		$entry = User::find(1);
338		$this->crudPanel->syncPivot($entry, $inputData);
339
340		$this->assertEquals(1, $entry->roles->count());
341		}
342
343	View Code Duplication	public function testSyncPivotUnknownModel()
		0 ignored issues – show Duplication introduced 2017-11-06 12:02 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
344		{
345		$this->expectException(\BadMethodCallException::class);
346
347		$this->crudPanel->setModel(User::class);
348		$this->crudPanel->addFields($this->userInputFieldsManyToMany);
349		$faker = Factory::create();
350		$inputData = [
351		'name' => $faker->name,
352		'email' => $faker->safeEmail,
353		'password' => bcrypt($faker->password()),
354		'remember_token' => null,
355		'roles' => [1, 2],
356		];
357
358		$entry = Article::find(1);
359		$this->crudPanel->syncPivot($entry, $inputData);
360		}
361		}
362

Laravel-Backpack / CRUD

Scrutinizer GitHub App not installed

Pull Request — master (#1453)

CrudPanelCreateTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

17 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like