Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — master (#2950)
by Bogdan
08:58
created
src/resources/views/crud/fields/table.blade.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
 <?php
4 4
     $max = isset($field['max']) && (int) $field['max'] > 0 ? $field['max'] : -1;
5 5
     $min = isset($field['min']) && (int) $field['min'] > 0 ? $field['min'] : -1;
6
-    $item_name = strtolower(isset($field['entity_singular']) && ! empty($field['entity_singular']) ? $field['entity_singular'] : $field['label']);
6
+    $item_name = strtolower(isset($field['entity_singular']) && !empty($field['entity_singular']) ? $field['entity_singular'] : $field['label']);
7 7
 
8 8
     $items = old(square_brackets_to_dots($field['name'])) ?? $field['value'] ?? $field['default'] ?? '';
9 9
 
@@ -15,12 +15,12 @@  discard block
 block discarded – undo
15 15
         } else {
16 16
             $items = '[]';
17 17
         }
18
-    } elseif (is_string($items) && ! is_array(json_decode($items))) {
18
+    } elseif (is_string($items) && !is_array(json_decode($items))) {
19 19
         $items = '[]';
20 20
     }
21 21
 
22 22
     // make sure columns are defined
23
-    if (! isset($field['columns'])) {
23
+    if (!isset($field['columns'])) {
24 24
         $field['columns'] = ['value' => 'Value'];
25 25
     }
26 26
 
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/BaseCrudPanelTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
     {
25 25
         parent::setUp();
26 26
 
27
-        $this->app->singleton('crud', function ($app) {
27
+        $this->app->singleton('crud', function($app) {
28 28
             return new CrudPanel($app);
29 29
         });
30 30
         $this->crudPanel = app('crud');
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudFilter.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
      */
81 81
     public function wasNotApplied()
82 82
     {
83
-        return ! $this->applied;
83
+        return !$this->applied;
84 84
     }
85 85
 
86 86
     /**
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
 
102 102
         $input = $input ?? new ParameterBag($this->crud()->getRequest()->all());
103 103
 
104
-        if (! $input->has($this->name)) {
104
+        if (!$input->has($this->name)) {
105 105
             return;
106 106
         }
107 107
 
Please login to merge, or discard this patch.
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -389,10 +389,12 @@
 block discarded – undo
389 389
         return $this->fallbackLogic($value);
390 390
     }
391 391
 
392
-    public function else($value)
392
+    public function else {
393
+        ($value)
393 394
     {
394 395
         return $this->fallbackLogic($value);
395 396
     }
397
+    }
396 398
 
397 399
     // ---------------
398 400
     // PRIVATE METHODS
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Fields.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
      */
63 63
     public function afterField($targetFieldName)
64 64
     {
65
-        $this->transformFields(function ($fields) use ($targetFieldName) {
65
+        $this->transformFields(function($fields) use ($targetFieldName) {
66 66
             return $this->moveField($fields, $targetFieldName, false);
67 67
         });
68 68
     }
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
      */
75 75
     public function beforeField($targetFieldName)
76 76
     {
77
-        $this->transformFields(function ($fields) use ($targetFieldName) {
77
+        $this->transformFields(function($fields) use ($targetFieldName) {
78 78
             return $this->moveField($fields, $targetFieldName, true);
79 79
         });
80 80
     }
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
      */
87 87
     public function makeFirstField()
88 88
     {
89
-        if (! $this->fields()) {
89
+        if (!$this->fields()) {
90 90
             return false;
91 91
         }
92 92
 
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
      */
102 102
     public function removeField($name)
103 103
     {
104
-        $this->transformFields(function ($fields) use ($name) {
104
+        $this->transformFields(function($fields) use ($name) {
105 105
             Arr::forget($fields, $name);
106 106
 
107 107
             return $fields;
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
      */
116 116
     public function removeFields($array_of_names)
117 117
     {
118
-        if (! empty($array_of_names)) {
118
+        if (!empty($array_of_names)) {
119 119
             foreach ($array_of_names as $name) {
120 120
                 $this->removeField($name);
121 121
             }
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
     public function removeAllFields()
129 129
     {
130 130
         $current_fields = $this->getCurrentFields();
131
-        if (! empty($current_fields)) {
131
+        if (!empty($current_fields)) {
132 132
             foreach ($current_fields as $field) {
133 133
                 $this->removeField($field['name']);
134 134
             }
@@ -220,7 +220,7 @@  discard block
 block discarded – undo
220 220
                 $jsonCastables = ['array', 'object', 'json'];
221 221
                 $fieldCasting = $casted_attributes[$field['name']];
222 222
 
223
-                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && ! empty($data[$field['name']]) && ! is_array($data[$field['name']])) {
223
+                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && !empty($data[$field['name']]) && !is_array($data[$field['name']])) {
224 224
                     try {
225 225
                         $data[$field['name']] = json_decode($data[$field['name']]);
226 226
                     } catch (\Exception $e) {
@@ -249,7 +249,7 @@  discard block
 block discarded – undo
249 249
      */
250 250
     public function orderFields($order)
251 251
     {
252
-        $this->transformFields(function ($fields) use ($order) {
252
+        $this->transformFields(function($fields) use ($order) {
253 253
             return $this->applyOrderToFields($fields, $order);
254 254
         });
255 255
     }
@@ -276,7 +276,7 @@  discard block
 block discarded – undo
276 276
     public function hasUploadFields()
277 277
     {
278 278
         $fields = $this->getFields();
279
-        $upload_fields = Arr::where($fields, function ($value, $key) {
279
+        $upload_fields = Arr::where($fields, function($value, $key) {
280 280
             return isset($value['upload']) && $value['upload'] == true;
281 281
         });
282 282
 
@@ -339,7 +339,7 @@  discard block
 block discarded – undo
339 339
         $alreadyLoaded = $this->getLoadedFieldTypes();
340 340
         $type = $this->getFieldTypeWithNamespace($field);
341 341
 
342
-        if (! in_array($type, $this->getLoadedFieldTypes(), true)) {
342
+        if (!in_array($type, $this->getLoadedFieldTypes(), true)) {
343 343
             $alreadyLoaded[] = $type;
344 344
             $this->setLoadedFieldTypes($alreadyLoaded);
345 345
 
@@ -380,7 +380,7 @@  discard block
 block discarded – undo
380 380
      */
381 381
     public function fieldTypeNotLoaded($field)
382 382
     {
383
-        return ! in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
383
+        return !in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
384 384
     }
385 385
 
386 386
     /**
@@ -421,7 +421,7 @@  discard block
 block discarded – undo
421 421
      */
422 422
     public function hasFieldWhere($attribute, $value)
423 423
     {
424
-        $match = Arr::first($this->fields(), function ($field, $fieldKey) use ($attribute, $value) {
424
+        $match = Arr::first($this->fields(), function($field, $fieldKey) use ($attribute, $value) {
425 425
             return isset($field[$attribute]) && $field[$attribute] == $value;
426 426
         });
427 427
 
@@ -437,7 +437,7 @@  discard block
 block discarded – undo
437 437
      */
438 438
     public function firstFieldWhere($attribute, $value)
439 439
     {
440
-        return Arr::first($this->fields(), function ($field, $fieldKey) use ($attribute, $value) {
440
+        return Arr::first($this->fields(), function($field, $fieldKey) use ($attribute, $value) {
441 441
             return isset($field[$attribute]) && $field[$attribute] == $value;
442 442
         });
443 443
     }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Buttons.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
         $otherButtons = collect([]);
26 26
 
27 27
         // we get the buttons that belong to the specified stack
28
-        $stackButtons = $this->buttons()->reject(function ($item) use ($stack, $otherButtons) {
28
+        $stackButtons = $this->buttons()->reject(function($item) use ($stack, $otherButtons) {
29 29
             if ($item->stack != $stack) {
30 30
                 // if the button does not belong to this stack we just add it for merging later
31 31
                 $otherButtons->push($item);
@@ -37,8 +37,8 @@  discard block
 block discarded – undo
37 37
         });
38 38
 
39 39
         // we parse the ordered buttons
40
-        collect($order)->each(function ($btnKey) use ($newButtons, $stackButtons) {
41
-            if (! $button = $stackButtons->where('name', $btnKey)->first()) {
40
+        collect($order)->each(function($btnKey) use ($newButtons, $stackButtons) {
41
+            if (!$button = $stackButtons->where('name', $btnKey)->first()) {
42 42
                 abort(500, 'Button name [«'.$btnKey.'»] not found.');
43 43
             }
44 44
             $newButtons->push($button);
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
         // we add the remaining buttons to the end of the ordered ones
49 49
         if (count($newButtons) < count($stackButtons)) {
50 50
             foreach ($stackButtons as $button) {
51
-                if (! $newButtons->where('name', $button->name)->first()) {
51
+                if (!$newButtons->where('name', $button->name)->first()) {
52 52
                     $newButtons->push($button);
53 53
                 }
54 54
             }
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
          */
115 115
         $button = $this->buttons()->firstWhere('name', $name);
116 116
 
117
-        if (! $button) {
117
+        if (!$button) {
118 118
             abort(500, 'CRUD Button "'.$name.'" not found. Please check the button exists before you modify it.');
119 119
         }
120 120
 
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
      */
136 136
     public function removeButton($name, $stack = null)
137 137
     {
138
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($name, $stack) {
138
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($name, $stack) {
139 139
             return $stack == null ? $button->name == $name : ($button->stack == $stack) && ($button->name == $name);
140 140
         }));
141 141
     }
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
      */
147 147
     public function removeButtons($names, $stack = null)
148 148
     {
149
-        if (! empty($names)) {
149
+        if (!empty($names)) {
150 150
             foreach ($names as $name) {
151 151
                 $this->removeButton($name, $stack);
152 152
             }
@@ -160,14 +160,14 @@  discard block
 block discarded – undo
160 160
 
161 161
     public function removeAllButtonsFromStack($stack)
162 162
     {
163
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($stack) {
163
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($stack) {
164 164
             return $button->stack == $stack;
165 165
         }));
166 166
     }
167 167
 
168 168
     public function removeButtonFromStack($name, $stack)
169 169
     {
170
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($name, $stack) {
170
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($name, $stack) {
171 171
             return $button->name == $name && $button->stack == $stack;
172 172
         }));
173 173
     }
@@ -185,15 +185,15 @@  discard block
 block discarded – undo
185 185
         $destinationButton = $this->firstButtonWhere('name', $destination);
186 186
         $destinationKey = $this->getButtonKey($destination);
187 187
         $newDestinationKey = ($where == 'before' ? $destinationKey : $destinationKey + 1);
188
-        $newButtons = $this->buttons()->filter(function ($value, $key) use ($target) {
188
+        $newButtons = $this->buttons()->filter(function($value, $key) use ($target) {
189 189
             return $value->name != $target;
190 190
         });
191 191
 
192
-        if (! $targetButton) {
192
+        if (!$targetButton) {
193 193
             return;
194 194
         }
195 195
 
196
-        if (! $destinationButton) {
196
+        if (!$destinationButton) {
197 197
             return;
198 198
         }
199 199
 
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
         $lastSlice = $newButtons->slice($newDestinationKey, null);
202 202
 
203 203
         $newButtons = $firstSlice->push($targetButton);
204
-        $lastSlice->each(function ($item, $key) use ($newButtons) {
204
+        $lastSlice->each(function($item, $key) use ($newButtons) {
205 205
             $newButtons->push($item);
206 206
         });
207 207
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudButton.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -388,7 +388,7 @@
 block discarded – undo
388 388
     {
389 389
         $itemExists = $this->collection()->contains('name', $this->name);
390 390
 
391
-        if (! $itemExists) {
391
+        if (!$itemExists) {
392 392
             if ($this->position == 'beginning') {
393 393
                 $this->collection()->prepend($this);
394 394
             } else {
Please login to merge, or discard this patch.
src/helpers.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-if (! function_exists('backpack_url')) {
3
+if (!function_exists('backpack_url')) {
4 4
     /**
5 5
      * Appends the configured backpack prefix and returns
6 6
      * the URL using the standard Laravel helpers.
@@ -11,13 +11,13 @@  discard block
 block discarded – undo
11 11
      */
12 12
     function backpack_url($path = null, $parameters = [], $secure = null)
13 13
     {
14
-        $path = ! $path || (substr($path, 0, 1) == '/') ? $path : '/'.$path;
14
+        $path = !$path || (substr($path, 0, 1) == '/') ? $path : '/'.$path;
15 15
 
16 16
         return url(config('backpack.base.route_prefix', 'admin').$path, $parameters, $secure);
17 17
     }
18 18
 }
19 19
 
20
-if (! function_exists('backpack_authentication_column')) {
20
+if (!function_exists('backpack_authentication_column')) {
21 21
     /**
22 22
      * Return the username column name.
23 23
      * The Laravel default (and Backpack default) is 'email'.
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
     }
31 31
 }
32 32
 
33
-if (! function_exists('backpack_users_have_email')) {
33
+if (!function_exists('backpack_users_have_email')) {
34 34
     /**
35 35
      * Check if the email column is present on the user table.
36 36
      *
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
     }
46 46
 }
47 47
 
48
-if (! function_exists('backpack_avatar_url')) {
48
+if (!function_exists('backpack_avatar_url')) {
49 49
     /**
50 50
      * Returns the avatar URL of a user.
51 51
      *
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
     }
79 79
 }
80 80
 
81
-if (! function_exists('backpack_middleware')) {
81
+if (!function_exists('backpack_middleware')) {
82 82
     /**
83 83
      * Return the key of the middleware used across Backpack.
84 84
      * That middleware checks if the visitor is an admin.
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
     }
94 94
 }
95 95
 
96
-if (! function_exists('backpack_guard_name')) {
96
+if (!function_exists('backpack_guard_name')) {
97 97
     /*
98 98
      * Returns the name of the guard defined
99 99
      * by the application config
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
     }
105 105
 }
106 106
 
107
-if (! function_exists('backpack_auth')) {
107
+if (!function_exists('backpack_auth')) {
108 108
     /*
109 109
      * Returns the user instance if it exists
110 110
      * of the currently authenticated admin
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
     }
117 117
 }
118 118
 
119
-if (! function_exists('backpack_user')) {
119
+if (!function_exists('backpack_user')) {
120 120
     /*
121 121
      * Returns back a user instance without
122 122
      * the admin guard, however allows you
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
     }
129 129
 }
130 130
 
131
-if (! function_exists('mb_ucfirst')) {
131
+if (!function_exists('mb_ucfirst')) {
132 132
     /**
133 133
      * Capitalize the first letter of a string,
134 134
      * even if that string is multi-byte (non-latin alphabet).
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
     }
151 151
 }
152 152
 
153
-if (! function_exists('backpack_view')) {
153
+if (!function_exists('backpack_view')) {
154 154
     /**
155 155
      * Returns a new displayable view based on the configured backpack view namespace.
156 156
      * If that view doesn't exist, it will load the one from the original theme.
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
 
171 171
         $returnView = $theme.$view;
172 172
 
173
-        if (! view()->exists($returnView)) {
173
+        if (!view()->exists($returnView)) {
174 174
             $returnView = $originalTheme.$view;
175 175
         }
176 176
 
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
     }
179 179
 }
180 180
 
181
-if (! function_exists('square_brackets_to_dots')) {
181
+if (!function_exists('square_brackets_to_dots')) {
182 182
     /**
183 183
      * Turns a string from bracket-type array to dot-notation array.
184 184
      * Ex: array[0][property] turns into array.0.property.
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
     }
196 196
 }
197 197
 
198
-if (! function_exists('is_countable')) {
198
+if (!function_exists('is_countable')) {
199 199
     /**
200 200
      * We need this because is_countable was only introduced in PHP 7.3,
201 201
      * and in PHP 7.2 you should check if count() argument is really countable.
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Create.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
     {
83 83
         $all_relation_fields = $this->getRelationFields();
84 84
 
85
-        return Arr::where($all_relation_fields, function ($value, $key) {
85
+        return Arr::where($all_relation_fields, function($value, $key) {
86 86
             return isset($value['pivot']) && $value['pivot'];
87 87
         });
88 88
     }
@@ -161,11 +161,11 @@  discard block
 block discarded – undo
161 161
      */
162 162
     private function createRelationsForItem($item, $formattedData)
163 163
     {
164
-        if (! isset($formattedData['relations'])) {
164
+        if (!isset($formattedData['relations'])) {
165 165
             return false;
166 166
         }
167 167
         foreach ($formattedData['relations'] as $relationMethod => $relationData) {
168
-            if (! isset($relationData['model'])) {
168
+            if (!isset($relationData['model'])) {
169 169
                 continue;
170 170
             }
171 171
             $model = $relationData['model'];
@@ -219,13 +219,13 @@  discard block
 block discarded – undo
219 219
         foreach ($relation_fields as $relation_field) {
220 220
             $attributeKey = $this->parseRelationFieldNamesFromHtml([$relation_field])[0]['name'];
221 221
 
222
-            if (! is_null(Arr::get($data, $attributeKey)) && $relation_field['pivot'] !== true) {
222
+            if (!is_null(Arr::get($data, $attributeKey)) && $relation_field['pivot'] !== true) {
223 223
                 $key = implode('.relations.', explode('.', $this->getOnlyRelationEntity($relation_field)));
224 224
                 $fieldData = Arr::get($relationData, 'relations.'.$key, []);
225
-                if (! array_key_exists('model', $fieldData)) {
225
+                if (!array_key_exists('model', $fieldData)) {
226 226
                     $fieldData['model'] = $relation_field['model'];
227 227
                 }
228
-                if (! array_key_exists('parent', $fieldData)) {
228
+                if (!array_key_exists('parent', $fieldData)) {
229 229
                     $fieldData['parent'] = $this->getRelationModel($attributeKey, -1);
230 230
                 }
231 231
                 $relatedAttribute = Arr::last(explode('.', $attributeKey));
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
 
247 247
         $related_method = Arr::last($entity_array);
248 248
 
249
-        if (! method_exists($relation_model, $related_method)) {
249
+        if (!method_exists($relation_model, $related_method)) {
250 250
             if (count($entity_array) <= 1) {
251 251
                 return $relation_field['entity'];
252 252
             } else {
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Update.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
 
53 53
         foreach ($fields as &$field) {
54 54
             // set the value
55
-            if (! isset($field['value'])) {
55
+            if (!isset($field['value'])) {
56 56
                 if (isset($field['subfields'])) {
57 57
                     $field['value'] = [];
58 58
                     foreach ($field['subfields'] as $subfield) {
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
         }
66 66
 
67 67
         // always have a hidden input for the entry id
68
-        if (! array_key_exists('id', $fields)) {
68
+        if (!array_key_exists('id', $fields)) {
69 69
             $fields['id'] = [
70 70
                 'name'  => $entry->getKeyName(),
71 71
                 'value' => $entry->getKey(),
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
 
92 92
             $relation_array = explode('.', $relational_entity);
93 93
 
94
-            $relatedModel = $relatedModel = array_reduce(array_splice($relation_array, 0, -1), function ($obj, $method) {
94
+            $relatedModel = $relatedModel = array_reduce(array_splice($relation_array, 0, -1), function($obj, $method) {
95 95
                 return $obj->{$method} ? $obj->{$method} : $obj;
96 96
             }, $model);
97 97
 
Please login to merge, or discard this patch.