Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Push — fix-uploaders ( cce3dc...a81c63 )
by Pedro
43:58 queued 29:18
created
src/macros.php 1 patch
Spacing   +21 added lines, -21 removed lines patch added patch discarded remove patch
@@ -19,8 +19,8 @@  discard block
 block discarded – undo
19 19
  *      - when true: `address[street]`
20 20
  *      - when false: `[address][street]`
21 21
  */
22
-if (! Str::hasMacro('dotsToSquareBrackets')) {
23
-    Str::macro('dotsToSquareBrackets', function ($string, $ignore = [], $keyFirst = true) {
22
+if (!Str::hasMacro('dotsToSquareBrackets')) {
23
+    Str::macro('dotsToSquareBrackets', function($string, $ignore = [], $keyFirst = true) {
24 24
         $stringParts = explode('.', $string);
25 25
         $result = '';
26 26
 
@@ -34,8 +34,8 @@  discard block
 block discarded – undo
34 34
         return $result;
35 35
     });
36 36
 }
37
-if (! CrudColumn::hasMacro('withFiles')) {
38
-    CrudColumn::macro('withFiles', function ($uploadDefinition = [], $subfield = null, $registerUploaderEvents = true) {
37
+if (!CrudColumn::hasMacro('withFiles')) {
38
+    CrudColumn::macro('withFiles', function($uploadDefinition = [], $subfield = null, $registerUploaderEvents = true) {
39 39
         $uploadDefinition = is_array($uploadDefinition) ? $uploadDefinition : [];
40 40
         /** @var CrudField|CrudColumn $this */
41 41
         RegisterUploadEvents::handle($this, $uploadDefinition, 'withFiles', $subfield, $registerUploaderEvents);
@@ -44,8 +44,8 @@  discard block
 block discarded – undo
44 44
     });
45 45
 }
46 46
 
47
-if (! CrudField::hasMacro('withFiles')) {
48
-    CrudField::macro('withFiles', function ($uploadDefinition = [], $subfield = null, $registerUploaderEvents = true) {
47
+if (!CrudField::hasMacro('withFiles')) {
48
+    CrudField::macro('withFiles', function($uploadDefinition = [], $subfield = null, $registerUploaderEvents = true) {
49 49
         $uploadDefinition = is_array($uploadDefinition) ? $uploadDefinition : [];
50 50
         /** @var CrudField|CrudColumn $this */
51 51
         RegisterUploadEvents::handle($this, $uploadDefinition, 'withFiles', $subfield, $registerUploaderEvents);
@@ -54,8 +54,8 @@  discard block
 block discarded – undo
54 54
     });
55 55
 }
56 56
 
57
-if (! CrudColumn::hasMacro('linkTo')) {
58
-    CrudColumn::macro('linkTo', function (string|array|Closure $routeOrConfiguration, ?array $parameters = []): static {
57
+if (!CrudColumn::hasMacro('linkTo')) {
58
+    CrudColumn::macro('linkTo', function(string | array | Closure $routeOrConfiguration, ?array $parameters = []): static {
59 59
         $wrapper = $this->attributes['wrapper'] ?? [];
60 60
 
61 61
         // parse the function input to get the actual route and parameters we'll be working with
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
 
69 69
         // if the route is a closure, we'll just call it
70 70
         if ($route instanceof Closure) {
71
-            $wrapper['href'] = function ($crud, $column, $entry, $related_key) use ($route) {
71
+            $wrapper['href'] = function($crud, $column, $entry, $related_key) use ($route) {
72 72
                 return $route($entry, $related_key, $column, $crud);
73 73
             };
74 74
             $this->wrapper($wrapper);
@@ -77,13 +77,13 @@  discard block
 block discarded – undo
77 77
         }
78 78
 
79 79
         // if the route doesn't exist, we'll throw an exception
80
-        if (! $routeInstance = Route::getRoutes()->getByName($route)) {
80
+        if (!$routeInstance = Route::getRoutes()->getByName($route)) {
81 81
             throw new \Exception("Route [{$route}] not found while building the link for column [{$this->attributes['name']}].");
82 82
         }
83 83
 
84 84
         // calculate the parameters we'll be using for the route() call
85 85
         // (eg. if there's only one parameter and user didn't provide it, we'll assume it's the entry's related key)
86
-        $parameters = (function () use ($parameters, $routeInstance, $route) {
86
+        $parameters = (function() use ($parameters, $routeInstance, $route) {
87 87
             $expectedParameters = $routeInstance->parameterNames();
88 88
 
89 89
             if (count($expectedParameters) === 0) {
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
             if (count($autoInferedParameter) > 1) {
95 95
                 throw new \Exception("Route [{$route}] expects parameters [".implode(', ', $expectedParameters)."]. Insuficient parameters provided in column: [{$this->attributes['name']}].");
96 96
             }
97
-            $autoInferedParameter = current($autoInferedParameter) ? [current($autoInferedParameter) => function ($entry, $related_key, $column, $crud) {
97
+            $autoInferedParameter = current($autoInferedParameter) ? [current($autoInferedParameter) => function($entry, $related_key, $column, $crud) {
98 98
                 $entity = $crud->isAttributeInRelationString($column) ? Str::before($column['entity'], '.') : $column['entity'];
99 99
 
100 100
                 return $related_key ?? $entry->{$entity}?->getKey();
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
         })();
105 105
 
106 106
         // set up the wrapper href attribute
107
-        $wrapper['href'] = function ($crud, $column, $entry, $related_key) use ($route, $parameters) {
107
+        $wrapper['href'] = function($crud, $column, $entry, $related_key) use ($route, $parameters) {
108 108
             // if the parameter is callable, we'll call it
109 109
             $parameters = collect($parameters)->map(fn ($item) => is_callable($item) ? $item($entry, $related_key, $column, $crud) : $item)->toArray();
110 110
 
@@ -117,17 +117,17 @@  discard block
 block discarded – undo
117 117
     });
118 118
 }
119 119
 
120
-if (! CrudColumn::hasMacro('linkToShow')) {
121
-    CrudColumn::macro('linkToShow', function (): static {
120
+if (!CrudColumn::hasMacro('linkToShow')) {
121
+    CrudColumn::macro('linkToShow', function(): static {
122 122
         $name = $this->attributes['name'];
123 123
         $entity = $this->attributes['entity'] ?? null;
124 124
         $route = "$entity.show";
125 125
 
126
-        if (! $entity) {
126
+        if (!$entity) {
127 127
             throw new \Exception("Entity not found while building the link for column [{$name}].");
128 128
         }
129 129
 
130
-        if (! Route::getRoutes()->getByName($route)) {
130
+        if (!Route::getRoutes()->getByName($route)) {
131 131
             throw new \Exception("Route '{$route}' not found while building the link for column [{$name}].");
132 132
         }
133 133
 
@@ -138,8 +138,8 @@  discard block
 block discarded – undo
138 138
     });
139 139
 }
140 140
 
141
-if (! CrudColumn::hasMacro('linkTarget')) {
142
-    CrudColumn::macro('linkTarget', function (string $target = '_self'): static {
141
+if (!CrudColumn::hasMacro('linkTarget')) {
142
+    CrudColumn::macro('linkTarget', function(string $target = '_self'): static {
143 143
         $this->wrapper([
144 144
             ...$this->attributes['wrapper'] ?? [],
145 145
             'target' => $target,
@@ -155,8 +155,8 @@  discard block
 block discarded – undo
155 155
  *
156 156
  * It will go to the given CrudController and get the setupRoutes() method on it.
157 157
  */
158
-if (! Route::hasMacro('crud')) {
159
-    Route::macro('crud', function ($name, $controller) {
158
+if (!Route::hasMacro('crud')) {
159
+    Route::macro('crud', function($name, $controller) {
160 160
         // put together the route name prefix,
161 161
         // as passed to the Route::group() statements
162 162
         $routeName = '';
Please login to merge, or discard this patch.
src/routes/backpack/custom.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,5 +15,5 @@
 block discarded – undo
15 15
         (array) config('backpack.base.middleware_key', 'admin')
16 16
     ),
17 17
     'namespace' => 'App\Http\Controllers\Admin',
18
-], function () { // custom admin routes
18
+], function() { // custom admin routes
19 19
 }); // this should be the absolute last line of this file
Please login to merge, or discard this patch.
src/routes/backpack/base.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
         'middleware' => config('backpack.base.web_middleware', 'web'),
19 19
         'prefix' => config('backpack.base.route_prefix'),
20 20
     ],
21
-    function () {
21
+    function() {
22 22
         // if not otherwise configured, setup the auth routes
23 23
         if (config('backpack.base.setup_auth_routes')) {
24 24
             // Authentication Routes...
Please login to merge, or discard this patch.
src/routes/backpack/testing.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@
 block discarded – undo
15 15
     (array) config('backpack.base.middleware_key', 'admin'),
16 16
     'prefix' => config('backpack.base.route_prefix', 'admin'),
17 17
 ],
18
-    function () {
18
+    function() {
19 19
         Route::crud('users', 'Backpack\CRUD\Tests\Config\Http\Controllers\UserCrudController');
20 20
     }
21 21
 );
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Update.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         }
48 48
 
49 49
         // always have a hidden input for the entry id
50
-        if (! array_key_exists('id', $fields)) {
50
+        if (!array_key_exists('id', $fields)) {
51 51
             $fields['id'] = [
52 52
                 'name' => $entry->getKeyName(),
53 53
                 'value' => $entry->getKey(),
@@ -72,12 +72,12 @@  discard block
 block discarded – undo
72 72
         $fieldEntity = $field['entity'] ?? false;
73 73
         $fakeField = $field['fake'] ?? false;
74 74
 
75
-        if ($fieldEntity && ! $fakeField) {
75
+        if ($fieldEntity && !$fakeField) {
76 76
             return $this->getModelAttributeValueFromRelationship($model, $field);
77 77
         }
78 78
 
79 79
         if ($this->holdsMultipleInputs($field['name'])) {
80
-            $result = array_map(function ($item) use ($model) {
80
+            $result = array_map(function($item) use ($model) {
81 81
                 return $model->{$item};
82 82
             }, explode(',', $field['name']));
83 83
 
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
     {
100 100
         [$relatedModel, $relationMethod] = $this->getModelAndMethodFromEntity($model, $field);
101 101
 
102
-        if (! method_exists($relatedModel, $relationMethod)) {
102
+        if (!method_exists($relatedModel, $relationMethod)) {
103 103
             return $relatedModel->{$relationMethod};
104 104
         }
105 105
 
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
                     $model = $this->setupRelatedModelLocale($model);
119 119
                     // when subfields are NOT set we don't need to get any more values
120 120
                     // we just return the plain models as we only need the ids
121
-                    if (! isset($field['subfields'])) {
121
+                    if (!isset($field['subfields'])) {
122 122
                         $result->push($model);
123 123
 
124 124
                         continue;
@@ -146,13 +146,13 @@  discard block
 block discarded – undo
146 146
                 break;
147 147
             case 'HasOne':
148 148
             case 'MorphOne':
149
-                if (! method_exists($relatedModel, $relationMethod)) {
149
+                if (!method_exists($relatedModel, $relationMethod)) {
150 150
                     return;
151 151
                 }
152 152
 
153 153
                 $model = $relatedModel->{$relationMethod};
154 154
 
155
-                if (! $model) {
155
+                if (!$model) {
156 156
                     return;
157 157
                 }
158 158
 
@@ -233,7 +233,7 @@  discard block
 block discarded – undo
233 233
 
234 234
         $relationArray = explode('.', $relationEntity);
235 235
 
236
-        $relatedModel = array_reduce(array_splice($relationArray, 0, -1), function ($obj, $method) {
236
+        $relatedModel = array_reduce(array_splice($relationArray, 0, -1), function($obj, $method) {
237 237
             // if the string ends with `_id` we strip it out
238 238
             $method = Str::endsWith($method, '_id') ? Str::replaceLast('_id', '', $method) : $method;
239 239
 
@@ -260,7 +260,7 @@  discard block
 block discarded – undo
260 260
             // if the subfield name does not contain a dot we just need to check
261 261
             // if it has subfields and return the result accordingly.
262 262
             foreach ((array) $subfield['name'] as $name) {
263
-                if (! Str::contains($name, '.')) {
263
+                if (!Str::contains($name, '.')) {
264 264
                     // when subfields are present, $relatedModel->{$name} returns a model instance
265 265
                     // otherwise returns the model attribute.
266 266
                     if ($relatedModel->{$name}) {
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/ListOperation.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
             'operation' => 'list',
28 28
         ]);
29 29
 
30
-        if (! isset($this->setupDetailsRowRoute) || $this->setupDetailsRowRoute === true) {
30
+        if (!isset($this->setupDetailsRowRoute) || $this->setupDetailsRowRoute === true) {
31 31
             Route::get($segment.'/{id}/details', [
32 32
                 'as' => $routeName.'.showDetailsRow',
33 33
                 'uses' => $controller.'@showDetailsRow',
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
     {
44 44
         $this->crud->allowAccess('list');
45 45
 
46
-        $this->crud->operation('list', function () {
46
+        $this->crud->operation('list', function() {
47 47
             $this->crud->loadDefaultOperationSettingsFromConfig();
48 48
         });
49 49
     }
Please login to merge, or discard this patch.
tests/BaseTestClass.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@
 block discarded – undo
23 23
             (array) config('backpack.base.middleware_key', 'admin'),
24 24
             'prefix' => config('backpack.base.route_prefix', 'admin'),
25 25
         ],
26
-            function () {
26
+            function() {
27 27
                 Route::get('articles/{id}/show/{detail}', ['as' => 'article.show.detail', 'action' => 'Backpack\CRUD\Tests\config\Http\Controllers\ArticleCrudController@detail']);
28 28
                 Route::crud('users', 'Backpack\CRUD\Tests\config\Http\Controllers\UserCrudController');
29 29
                 Route::crud('articles', 'Backpack\CRUD\Tests\config\Http\Controllers\ArticleCrudController');
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelCreateTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -605,7 +605,7 @@  discard block
 block discarded – undo
605 605
 
606 606
     public function testCreateBelongsToFake()
607 607
     {
608
-        $belongsToField = [   // select_grouped
608
+        $belongsToField = [// select_grouped
609 609
             'label' => 'Select_grouped',
610 610
             'type' => 'select_grouped', //https://github.com/Laravel-Backpack/CRUD/issues/502
611 611
             'name' => 'bang_relation_field',
@@ -741,7 +741,7 @@  discard block
 block discarded – undo
741 741
                 'nickname' => 'i_have_has_one',
742 742
                 'profile_picture' => 'ohh my picture 1.jpg',
743 743
                 'article' => 1,
744
-                'addresses' => [ // HasOne is tested in other test function
744
+                'addresses' => [// HasOne is tested in other test function
745 745
                     [
746 746
                         'city' => 2,
747 747
                         'street' => 'test',
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelValidationTest.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
             'password' => 'test',
46 46
         ]);
47 47
 
48
-        $request->setRouteResolver(function () use ($request) {
48
+        $request->setRouteResolver(function() use ($request) {
49 49
             return (new Route('POST', 'users', ['Backpack\CRUD\Tests\Config\Http\Controllers\UserCrudController', 'create']))->bind($request);
50 50
         });
51 51
 
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
             'email' => '',
86 86
         ]);
87 87
 
88
-        $request->setRouteResolver(function () use ($request) {
88
+        $request->setRouteResolver(function() use ($request) {
89 89
             return (new Route('POST', 'users', ['Backpack\CRUD\Tests\Config\Http\Controllers\UserCrudController', 'create']))->bind($request);
90 90
         });
91 91
 
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
             'password' => 'test',
126 126
         ]);
127 127
 
128
-        $request->setRouteResolver(function () use ($request) {
128
+        $request->setRouteResolver(function() use ($request) {
129 129
             return (new Route('POST', 'users', ['Backpack\CRUD\Tests\Config\Http\Controllers\UserCrudController', 'create']))->bind($request);
130 130
         });
131 131
 
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
             'name' => 'test',
248 248
         ]);
249 249
 
250
-        $request->setRouteResolver(function () use ($request) {
250
+        $request->setRouteResolver(function() use ($request) {
251 251
             return (new Route('POST', 'users', ['Backpack\CRUD\Tests\Config\Http\Controllers\UserCrudController', 'create']))->bind($request);
252 252
         });
253 253
 
Please login to merge, or discard this patch.