Laravel-Backpack / CRUD

tests/Unit/CrudPanel/BaseCrudPanelTest.php

Spacing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
     {
         parent::setUp();
 
-        $this->app->singleton('crud', function ($app) {
+        $this->app->singleton('crud', function($app) {
             return new CrudPanel($app);
         });
         $this->crudPanel = app('crud');

src/app/Library/CrudPanel/CrudFilter.php

Braces +3 added lines, -1 removed lines

@@ -389,10 +389,12 @@
         return $this->fallbackLogic($value);
     }
 
-    public function else($value)
+    public function else {
+        ($value)
     {
         return $this->fallbackLogic($value);
     }
+    }
 
     // ---------------
     // PRIVATE METHODS

Spacing +5 added lines, -5 removed lines

@@ -26,7 +26,7 @@ 
 
     public function __construct($options, $values, $logic, $fallbackLogic)
     {
-        if (! backpack_pro()) {
+        if (!backpack_pro()) {
             throw new BackpackProRequiredException('Filter');
         }
         // if filter exists
@@ -89,7 +89,7 @@ 
      */
     public function wasNotApplied()
     {
-        return ! $this->applied;
+        return !$this->applied;
     }
 
     /**
@@ -110,7 +110,7 @@ 
 
         $input = $input ?? new ParameterBag($this->crud()->getRequest()->all());
 
-        if (! $input->has($this->name)) {
+        if (!$input->has($this->name)) {
             // if fallback logic was supplied and is a closure
             if (is_callable($this->fallbackLogic)) {
                 return ($this->fallbackLogic)();
@@ -152,7 +152,7 @@ 
             $namespaces = array_merge([$this->viewNamespace], $namespaces);
         }
 
-        return array_map(function ($item) use ($type) {
+        return array_map(function($item) use ($type) {
             return $item.'.'.$type;
         }, $namespaces);
     }
@@ -314,7 +314,7 @@ 
      */
     public function values($value)
     {
-        $this->values = (! is_string($value) && is_callable($value)) ? $value() : $value;
+        $this->values = (!is_string($value) && is_callable($value)) ? $value() : $value;
 
         return $this->save();
     }

src/app/Library/CrudPanel/Traits/Buttons.php

Spacing +13 added lines, -13 removed lines

@@ -25,7 +25,7 @@ 
         $otherButtons = collect([]);
 
         // we get the buttons that belong to the specified stack
-        $stackButtons = $this->buttons()->reject(function ($item) use ($stack, $otherButtons) {
+        $stackButtons = $this->buttons()->reject(function($item) use ($stack, $otherButtons) {
             if ($item->stack != $stack) {
                 // if the button does not belong to this stack we just add it for merging later
                 $otherButtons->push($item);
@@ -37,8 +37,8 @@ 
         });
 
         // we parse the ordered buttons
-        collect($order)->each(function ($btnKey) use ($newButtons, $stackButtons) {
-            if (! $button = $stackButtons->where('name', $btnKey)->first()) {
+        collect($order)->each(function($btnKey) use ($newButtons, $stackButtons) {
+            if (!$button = $stackButtons->where('name', $btnKey)->first()) {
                 abort(500, 'Button name [«'.$btnKey.'»] not found.');
             }
             $newButtons->push($button);
@@ -48,7 +48,7 @@ 
         // we add the remaining buttons to the end of the ordered ones
         if (count($newButtons) < count($stackButtons)) {
             foreach ($stackButtons as $button) {
-                if (! $newButtons->where('name', $button->name)->first()) {
+                if (!$newButtons->where('name', $button->name)->first()) {
                     $newButtons->push($button);
                 }
             }
@@ -114,7 +114,7 @@ 
          */
         $button = $this->buttons()->firstWhere('name', $name);
 
-        if (! $button) {
+        if (!$button) {
             abort(500, 'CRUD Button "'.$name.'" not found. Please check the button exists before you modify it.');
         }
 
@@ -135,7 +135,7 @@ 
      */
     public function removeButton($name, $stack = null)
     {
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($name, $stack) {
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($name, $stack) {
             return $stack == null ? $button->name == $name : ($button->stack == $stack) && ($button->name == $name);
         }));
     }
@@ -146,7 +146,7 @@ 
      */
     public function removeButtons($names, $stack = null)
     {
-        if (! empty($names)) {
+        if (!empty($names)) {
             foreach ($names as $name) {
                 $this->removeButton($name, $stack);
             }
@@ -160,14 +160,14 @@ 
 
     public function removeAllButtonsFromStack($stack)
     {
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($stack) {
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($stack) {
             return $button->stack == $stack;
         }));
     }
 
     public function removeButtonFromStack($name, $stack)
     {
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($name, $stack) {
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($name, $stack) {
             return $button->name == $name && $button->stack == $stack;
         }));
     }
@@ -185,15 +185,15 @@ 
         $destinationButton = $this->firstButtonWhere('name', $destination);
         $destinationKey = $this->getButtonKey($destination);
         $newDestinationKey = ($where == 'before' ? $destinationKey : $destinationKey + 1);
-        $newButtons = $this->buttons()->filter(function ($value, $key) use ($target) {
+        $newButtons = $this->buttons()->filter(function($value, $key) use ($target) {
             return $value->name != $target;
         });
 
-        if (! $targetButton) {
+        if (!$targetButton) {
             return;
         }
 
-        if (! $destinationButton) {
+        if (!$destinationButton) {
             return;
         }
 
@@ -201,7 +201,7 @@ 
         $lastSlice = $newButtons->slice($newDestinationKey, null);
 
         $newButtons = $firstSlice->push($targetButton);
-        $lastSlice->each(function ($item, $key) use ($newButtons) {
+        $lastSlice->each(function($item, $key) use ($newButtons) {
             $newButtons->push($item);
         });
 

src/app/Library/CrudPanel/Traits/Filters.php

Spacing +10 added lines, -10 removed lines

@@ -72,7 +72,7 @@ 
         $this->enableFilters();
 
         // check if another filter with the same name exists
-        if (! isset($options['name'])) {
+        if (!isset($options['name'])) {
             abort(500, 'All your filters need names.');
         }
 
@@ -120,7 +120,7 @@ 
     {
         $unappliedFilters = $this->filters()->where('applied', false);
         if ($unappliedFilters->count()) {
-            $unappliedFilters->each(function ($filter) {
+            $unappliedFilters->each(function($filter) {
                 $filter->apply();
             });
         }
@@ -170,7 +170,7 @@ 
     {
         $filter = $this->filters()->firstWhere('name', $name);
 
-        if (! $filter) {
+        if (!$filter) {
             abort(500, 'CRUD Filter "'.$name.'" not found. Please check the filter exists before you modify it.');
         }
 
@@ -185,7 +185,7 @@ 
 
     public function replaceFilter($name, $newFilter)
     {
-        $newFilters = $this->filters()->map(function ($filter, $key) use ($name, $newFilter) {
+        $newFilters = $this->filters()->map(function($filter, $key) use ($name, $newFilter) {
             if ($filter->name != $name) {
                 return $filter;
             }
@@ -198,7 +198,7 @@ 
 
     public function removeFilter($name)
     {
-        $strippedCollection = $this->filters()->reject(function ($filter) use ($name) {
+        $strippedCollection = $this->filters()->reject(function($filter) use ($name) {
             return $filter->name == $name;
         });
 
@@ -241,7 +241,7 @@ 
      */
     public function makeFirstFilter()
     {
-        if (! $this->filters()) {
+        if (!$this->filters()) {
             return false;
         }
 
@@ -271,15 +271,15 @@ 
         $destinationFilter = $this->firstFilterWhere('name', $destination);
         $destinationKey = $this->getFilterKey($destination);
         $newDestinationKey = ($where == 'before' ? $destinationKey : $destinationKey + 1);
-        $newFilters = $this->filters()->filter(function ($value, $key) use ($target) {
+        $newFilters = $this->filters()->filter(function($value, $key) use ($target) {
             return $value->name != $target;
         });
 
-        if (! $targetFilter) {
+        if (!$targetFilter) {
             return;
         }
 
-        if (! $destinationFilter) {
+        if (!$destinationFilter) {
             return;
         }
 
@@ -287,7 +287,7 @@ 
         $lastSlice = $newFilters->slice($newDestinationKey, null);
 
         $newFilters = $firstSlice->push($targetFilter);
-        $lastSlice->each(function ($item, $key) use ($newFilters) {
+        $lastSlice->each(function($item, $key) use ($newFilters) {
             $newFilters->push($item);
         });
 

src/routes/backpack/custom.php

Spacing +1 added lines, -1 removed lines

@@ -13,5 +13,5 @@
         (array) config('backpack.base.middleware_key', 'admin')
     ),
     'namespace'  => 'App\Http\Controllers\Admin',
-], function () { // custom admin routes
+], function() { // custom admin routes
 }); // this should be the absolute last line of this file

tests/config/database/migrations/2017_09_08_000001_create_addresses_table.php

Spacing +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
      */
     public function up()
     {
-        Schema::create('addresses', function (Blueprint $table) {
+        Schema::create('addresses', function(Blueprint $table) {
             $table->increments('id');
             $table->integer('account_details_id')->unsigned();
             $table->string('city')->nullable();

src/app/Library/CrudPanel/Traits/ColumnsProtectedMethods.php

Spacing +7 added lines, -8 removed lines

@@ -49,7 +49,7 @@ 
             $column = ['name' => $column];
         }
 
-        if (is_array($column) && ! isset($column['name'])) {
+        if (is_array($column) && !isset($column['name'])) {
             $column['name'] = 'anonymous_column_'.Str::random(5);
         }
 
@@ -65,7 +65,7 @@ 
      */
     protected function makeSureColumnHasLabel($column)
     {
-        if (! isset($column['label'])) {
+        if (!isset($column['label'])) {
             $column['label'] = mb_ucfirst($this->makeLabel($column['name']));
         }
 
@@ -146,7 +146,7 @@ 
      */
     protected function makeSureColumnHasKey($column)
     {
-        if (! isset($column['key'])) {
+        if (!isset($column['key'])) {
             $column['key'] = str_replace('.', '__', $column['name']);
         }
 
@@ -164,7 +164,7 @@ 
      */
     protected function makeSureColumnHasWrapper($column)
     {
-        if (! isset($column['wrapper'])) {
+        if (!isset($column['wrapper'])) {
             $column['wrapper'] = [];
         }
 
@@ -255,7 +255,7 @@ 
     {
         // if this is a relation type field and no corresponding model was specified,
         // get it from the relation method defined in the main model
-        if (isset($column['entity']) && $column['entity'] !== false && ! isset($column['model'])) {
+        if (isset($column['entity']) && $column['entity'] !== false && !isset($column['model'])) {
             $column['model'] = $this->getRelationModel($column['entity']);
         }
 
@@ -276,8 +276,7 @@ 
         $columnsArray = $this->columns();
 
         if (array_key_exists($targetColumnName, $columnsArray)) {
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) :
-                array_search($targetColumnName, array_keys($columnsArray)) + 1;
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) : array_search($targetColumnName, array_keys($columnsArray)) + 1;
 
             $element = array_pop($columnsArray);
             $beginningPart = array_slice($columnsArray, 0, $targetColumnPosition, true);
@@ -299,7 +298,7 @@ 
     {
         static $cache = [];
 
-        if (! $this->driverIsSql()) {
+        if (!$this->driverIsSql()) {
             return true;
         }
 

src/app/Http/Controllers/Operations/ShowOperation.php

Spacing +6 added lines, -6 removed lines

@@ -30,25 +30,25 @@
         $this->crud->allowAccess('show');
         $this->crud->setOperationSetting('setFromDb', true);
 
-        $this->crud->operation('show', function () {
+        $this->crud->operation('show', function() {
             $this->crud->loadDefaultOperationSettingsFromConfig();
 
-            if (! method_exists($this, 'setupShowOperation')) {
+            if (!method_exists($this, 'setupShowOperation')) {
                 $this->autoSetupShowOperation();
             }
         });
 
-        $this->crud->operation('list', function () {
+        $this->crud->operation('list', function() {
             $this->crud->addButton('line', 'show', 'view', 'crud::buttons.show', 'beginning');
         });
 
-        $this->crud->operation(['create', 'update'], function () {
+        $this->crud->operation(['create', 'update'], function() {
             $this->crud->addSaveAction([
                 'name' => 'save_and_preview',
-                'visible' => function ($crud) {
+                'visible' => function($crud) {
                     return $crud->hasAccess('show');
                 },
-                'redirect' => function ($crud, $request, $itemId = null) {
+                'redirect' => function($crud, $request, $itemId = null) {
                     $itemId = $itemId ?: $request->input('id');
                     $redirectUrl = $crud->route.'/'.$itemId.'/show';
                     if ($request->has('_locale')) {

src/resources/views/crud/fields/checklist_dependency.blade.php

Indentation +24 added lines, -24 removed lines

@@ -33,35 +33,35 @@
         $old_primary_dependency = old_empty_or_null($primary_dependency['name'], false) ?? false;
         $old_secondary_dependency = old_empty_or_null($secondary_dependency['name'], false) ?? false;
 
-      //for update form, get initial state of the entity
-      if (isset($id) && $id) {
+        //for update form, get initial state of the entity
+        if (isset($id) && $id) {
 
         //get entity with relations for primary dependency
-          $entity_dependencies = $entity_model->with($primary_dependency['entity'])
-          ->with($primary_dependency['entity'].'.'.$primary_dependency['entity_secondary'])
-          ->find($id);
+            $entity_dependencies = $entity_model->with($primary_dependency['entity'])
+            ->with($primary_dependency['entity'].'.'.$primary_dependency['entity_secondary'])
+            ->find($id);
 
-          $secondaries_from_primary = [];
+            $secondaries_from_primary = [];
 
-          //convert relation in array
-          $primary_array = $entity_dependencies->{$primary_dependency['entity']}->toArray();
+            //convert relation in array
+            $primary_array = $entity_dependencies->{$primary_dependency['entity']}->toArray();
 
-          $secondary_ids = [];
-          //create secondary dependency from primary relation, used to check what checkbox must be checked from second checklist
-          if ($old_primary_dependency) {
-              foreach ($old_primary_dependency as $primary_item) {
-                  foreach ($dependencyArray[$primary_item] as $second_item) {
-                      $secondary_ids[$second_item] = $second_item;
-                  }
-              }
-          } else { //create dependencies from relation if not from validate error
-              foreach ($primary_array as $primary_item) {
-                  foreach ($primary_item[$secondary_dependency['entity']] as $second_item) {
-                      $secondary_ids[$second_item['id']] = $second_item['id'];
-                  }
-              }
-          }
-      }
+            $secondary_ids = [];
+            //create secondary dependency from primary relation, used to check what checkbox must be checked from second checklist
+            if ($old_primary_dependency) {
+                foreach ($old_primary_dependency as $primary_item) {
+                    foreach ($dependencyArray[$primary_item] as $second_item) {
+                        $secondary_ids[$second_item] = $second_item;
+                    }
+                }
+            } else { //create dependencies from relation if not from validate error
+                foreach ($primary_array as $primary_item) {
+                    foreach ($primary_item[$secondary_dependency['entity']] as $second_item) {
+                        $secondary_ids[$second_item['id']] = $second_item['id'];
+                    }
+                }
+            }
+        }
 
         //json encode of dependency matrix
         $dependencyJson = json_encode($dependencyArray);