Backpack\CRUD\app\Console\Commands\Update

Complexity

Total Complexity

4

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	runConsoleCommand()	0	14	3
A	handle()	0	3	1

<?php

namespace Backpack\CRUD\app\Console\Commands;

use Illuminate\Console\Command;
use Symfony\Component\Process\Exception\ProcessFailedException;
use Symfony\Component\Process\Process;

class Update extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'backpack:update';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Publish new CSS and JS assets (will override existing ones).';

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        $this->runConsoleCommand(['php', 'artisan', 'vendor:publish', '--provider=Backpack\CRUD\BackpackServiceProvider', '--tag=public', '--force']);

array('php', 'artisan', 'vendor:publish', '--provider=Backpack\CRUD\BackpackServiceProvider', '--tag=public', '--force') of type array<integer,string> is incompatible with the type string expected by parameter $command of Backpack\CRUD\app\Console\Commands\Update::runConsoleCommand().

    }

    /**
     * Run a shell command in a separate process.
     *
     * @param  string  $command  Text to be executed.
     * @return void
     */
    private function runConsoleCommand($command)
    {
        $process = new Process($command, null, null, null, 60, null);

The call to Symfony\Component\Process\Process::__construct() has too many arguments starting with null.

$command of type string is incompatible with the type array expected by parameter $command of Symfony\Component\Process\Process::__construct().

        $process->run(function ($type, $buffer) {
            if (Process::ERR === $type) {
                $this->line($buffer);
            } else {
                $this->line($buffer);
            }
        });

        // executes after the command finishes
        if (! $process->isSuccessful()) {
            throw new ProcessFailedException($process);
        }
    }
}