Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Failed
Push — v4dot1 ( d0147e...2219a0 )
by
unknown
05:44
created
src/app/Library/CrudPanel/Traits/Buttons.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
         $otherButtons = collect([]);
25 25
 
26 26
         // we get the buttons that belong to the specified stack
27
-        $stackButtons = $this->buttons()->reject(function ($item) use ($stack, $otherButtons) {
27
+        $stackButtons = $this->buttons()->reject(function($item) use ($stack, $otherButtons) {
28 28
             if ($item->stack != $stack) {
29 29
                 // if the button does not belong to this stack we just add it for merging later
30 30
                 $otherButtons->push($item);
@@ -36,8 +36,8 @@  discard block
 block discarded – undo
36 36
         });
37 37
 
38 38
         // we parse the ordered buttons
39
-        collect($order)->each(function ($btnKey) use ($newButtons, $stackButtons) {
40
-            if (! $button = $stackButtons->where('name', $btnKey)->first()) {
39
+        collect($order)->each(function($btnKey) use ($newButtons, $stackButtons) {
40
+            if (!$button = $stackButtons->where('name', $btnKey)->first()) {
41 41
                 abort(500, 'Button name [«'.$btnKey.'»] not found.');
42 42
             }
43 43
             $newButtons->push($button);
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         // we add the remaining buttons to the end of the ordered ones
48 48
         if (count($newButtons) < count($stackButtons)) {
49 49
             foreach ($stackButtons as $button) {
50
-                if (! $newButtons->where('name', $button->name)->first()) {
50
+                if (!$newButtons->where('name', $button->name)->first()) {
51 51
                     $newButtons->push($button);
52 52
                 }
53 53
             }
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
          */
137 137
         $button = $this->buttons()->firstWhere('name', $name);
138 138
 
139
-        if (! $button) {
139
+        if (!$button) {
140 140
             abort(500, 'CRUD Button "'.$name.'" not found. Please check the button exists before you modify it.');
141 141
         }
142 142
 
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
157 157
      */
158 158
     public function removeButton($name, $stack = null)
159 159
     {
160
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($name, $stack) {
160
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($name, $stack) {
161 161
             return $stack == null ? $button->name == $name : ($button->stack == $stack) && ($button->name == $name);
162 162
         }));
163 163
     }
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
      */
169 169
     public function removeButtons($names, $stack = null)
170 170
     {
171
-        if (! empty($names)) {
171
+        if (!empty($names)) {
172 172
             foreach ($names as $name) {
173 173
                 $this->removeButton($name, $stack);
174 174
             }
@@ -182,14 +182,14 @@  discard block
 block discarded – undo
182 182
 
183 183
     public function removeAllButtonsFromStack($stack)
184 184
     {
185
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($stack) {
185
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($stack) {
186 186
             return $button->stack == $stack;
187 187
         }));
188 188
     }
189 189
 
190 190
     public function removeButtonFromStack($name, $stack)
191 191
     {
192
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($name, $stack) {
192
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($name, $stack) {
193 193
             return $button->name == $name && $button->stack == $stack;
194 194
         }));
195 195
     }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Settings.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@
 block discarded – undo
57 57
      */
58 58
     public function settings()
59 59
     {
60
-        return Arr::sort($this->settings, function ($value, $key) {
60
+        return Arr::sort($this->settings, function($value, $key) {
61 61
             return $key;
62 62
         });
63 63
     }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Fields.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
      */
62 62
     public function afterField($targetFieldName)
63 63
     {
64
-        $this->transformFields(function ($fields) use ($targetFieldName) {
64
+        $this->transformFields(function($fields) use ($targetFieldName) {
65 65
             return $this->moveField($fields, $targetFieldName, false);
66 66
         });
67 67
     }
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
      */
74 74
     public function beforeField($targetFieldName)
75 75
     {
76
-        $this->transformFields(function ($fields) use ($targetFieldName) {
76
+        $this->transformFields(function($fields) use ($targetFieldName) {
77 77
             return $this->moveField($fields, $targetFieldName, true);
78 78
         });
79 79
     }
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
      */
86 86
     public function removeField($name)
87 87
     {
88
-        $this->transformFields(function ($fields) use ($name) {
88
+        $this->transformFields(function($fields) use ($name) {
89 89
             Arr::forget($fields, $name);
90 90
 
91 91
             return $fields;
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
      */
100 100
     public function removeFields($array_of_names)
101 101
     {
102
-        if (! empty($array_of_names)) {
102
+        if (!empty($array_of_names)) {
103 103
             foreach ($array_of_names as $name) {
104 104
                 $this->removeField($name);
105 105
             }
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
     public function removeAllFields()
113 113
     {
114 114
         $current_fields = $this->getCurrentFields();
115
-        if (! empty($current_fields)) {
115
+        if (!empty($current_fields)) {
116 116
             foreach ($current_fields as $field) {
117 117
                 $this->removeField($field['name']);
118 118
             }
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
186 186
                 $jsonCastables = ['array', 'object', 'json'];
187 187
                 $fieldCasting = $casted_attributes[$field['name']];
188 188
 
189
-                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && ! empty($data[$field['name']]) && ! is_array($data[$field['name']])) {
189
+                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && !empty($data[$field['name']]) && !is_array($data[$field['name']])) {
190 190
                     try {
191 191
                         $data[$field['name']] = json_decode($data[$field['name']]);
192 192
                     } catch (\Exception $e) {
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
      */
216 216
     public function orderFields($order)
217 217
     {
218
-        $this->transformFields(function ($fields) use ($order) {
218
+        $this->transformFields(function($fields) use ($order) {
219 219
             return $this->applyOrderToFields($fields, $order);
220 220
         });
221 221
     }
@@ -242,7 +242,7 @@  discard block
 block discarded – undo
242 242
     public function hasUploadFields()
243 243
     {
244 244
         $fields = $this->getFields();
245
-        $upload_fields = Arr::where($fields, function ($value, $key) {
245
+        $upload_fields = Arr::where($fields, function($value, $key) {
246 246
             return isset($value['upload']) && $value['upload'] == true;
247 247
         });
248 248
 
@@ -305,7 +305,7 @@  discard block
 block discarded – undo
305 305
         $alreadyLoaded = $this->getLoadedFieldTypes();
306 306
         $type = $this->getFieldTypeWithNamespace($field);
307 307
 
308
-        if (! in_array($type, $this->getLoadedFieldTypes(), true)) {
308
+        if (!in_array($type, $this->getLoadedFieldTypes(), true)) {
309 309
             $alreadyLoaded[] = $type;
310 310
             $this->setLoadedFieldTypes($alreadyLoaded);
311 311
 
@@ -346,7 +346,7 @@  discard block
 block discarded – undo
346 346
      */
347 347
     public function fieldTypeNotLoaded($field)
348 348
     {
349
-        return ! in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
349
+        return !in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
350 350
     }
351 351
 
352 352
     /**
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Create.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
     {
83 83
         $all_relation_fields = $this->getRelationFields();
84 84
 
85
-        return Arr::where($all_relation_fields, function ($value, $key) {
85
+        return Arr::where($all_relation_fields, function($value, $key) {
86 86
             return isset($value['pivot']) && $value['pivot'];
87 87
         });
88 88
     }
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
157 157
      */
158 158
     private function createRelationsForItem($item, $formattedData)
159 159
     {
160
-        if (! isset($formattedData['relations'])) {
160
+        if (!isset($formattedData['relations'])) {
161 161
             return false;
162 162
         }
163 163
 
@@ -212,11 +212,11 @@  discard block
 block discarded – undo
212 212
                 $key = implode('.relations.', explode('.', $relationField['entity']));
213 213
                 $fieldData = Arr::get($relationData, 'relations.'.$key, []);
214 214
 
215
-                if (! array_key_exists('model', $fieldData)) {
215
+                if (!array_key_exists('model', $fieldData)) {
216 216
                     $fieldData['model'] = $relationField['model'];
217 217
                 }
218 218
 
219
-                if (! array_key_exists('parent', $fieldData)) {
219
+                if (!array_key_exists('parent', $fieldData)) {
220 220
                     $fieldData['parent'] = $this->getRelationModel($relationField['entity'], -1);
221 221
                 }
222 222
 
Please login to merge, or discard this patch.
tests/Unit/Http/CrudControllerTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@
 block discarded – undo
21 21
         $app['router']->get('users/{id}/edit', "$controller@edit");
22 22
         $app['router']->put('users/{id}', "$controller@update");
23 23
 
24
-        $app->singleton('crud', function ($app) {
24
+        $app->singleton('crud', function($app) {
25 25
             return new CrudPanel($app);
26 26
         });
27 27
     }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudPanel.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -100,11 +100,11 @@  discard block
 block discarded – undo
100 100
      */
101 101
     public function setModel($model_namespace)
102 102
     {
103
-        if (! class_exists($model_namespace)) {
103
+        if (!class_exists($model_namespace)) {
104 104
             throw new \Exception('The model does not exist.', 500);
105 105
         }
106 106
 
107
-        if (! method_exists($model_namespace, 'hasCrudTrait')) {
107
+        if (!method_exists($model_namespace, 'hasCrudTrait')) {
108 108
             throw new \Exception('Please use CrudTrait on the model.', 500);
109 109
         }
110 110
 
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
     {
168 168
         $complete_route = $route.'.index';
169 169
 
170
-        if (! \Route::has($complete_route)) {
170
+        if (!\Route::has($complete_route)) {
171 171
             throw new \Exception('There are no routes for this route name.', 404);
172 172
         }
173 173
 
@@ -268,7 +268,7 @@  discard block
 block discarded – undo
268 268
      */
269 269
     public function getFirstOfItsTypeInArray($type, $array)
270 270
     {
271
-        return Arr::first($array, function ($item) use ($type) {
271
+        return Arr::first($array, function($item) use ($type) {
272 272
             return $item['type'] == $type;
273 273
         });
274 274
     }
@@ -285,8 +285,8 @@  discard block
 block discarded – undo
285 285
 
286 286
     public function sync($type, $fields, $attributes)
287 287
     {
288
-        if (! empty($this->{$type})) {
289
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
288
+        if (!empty($this->{$type})) {
289
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
290 290
                 if (in_array($field['name'], (array) $fields)) {
291 291
                     $field = array_merge($field, $attributes);
292 292
                 }
@@ -317,15 +317,15 @@  discard block
 block discarded – undo
317 317
     {
318 318
         $relationArray = explode('.', $relationString);
319 319
 
320
-        if (! isset($length)) {
320
+        if (!isset($length)) {
321 321
             $length = count($relationArray);
322 322
         }
323 323
 
324
-        if (! isset($model)) {
324
+        if (!isset($model)) {
325 325
             $model = $this->model;
326 326
         }
327 327
 
328
-        $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
328
+        $result = array_reduce(array_splice($relationArray, 0, $length), function($obj, $method) {
329 329
             return $obj->$method()->getRelated();
330 330
         }, $model);
331 331
 
@@ -350,7 +350,7 @@  discard block
 block discarded – undo
350 350
         $attributes = [];
351 351
         foreach ($endModels as $model => $entries) {
352 352
             $modelKey = (new $model())->getKeyName();
353
-            if (is_array($entries) && ! isset($entries[$attribute])) {
353
+            if (is_array($entries) && !isset($entries[$attribute])) {
354 354
                 foreach ($entries as $entry) {
355 355
                     $attributes[$entry[$modelKey]] = $entry[$attribute];
356 356
                 }
@@ -381,21 +381,21 @@  discard block
 block discarded – undo
381 381
         $currentResults = [];
382 382
 
383 383
         $results = [];
384
-        if (! is_null($relation)) {
385
-            if ($relation instanceof Collection && ! $relation->isEmpty()) {
384
+        if (!is_null($relation)) {
385
+            if ($relation instanceof Collection && !$relation->isEmpty()) {
386 386
                 $currentResults[get_class($relation->first())] = $relation->toArray();
387
-            } elseif (is_array($relation) && ! empty($relation)) {
387
+            } elseif (is_array($relation) && !empty($relation)) {
388 388
                 $currentResults[get_class($relation->first())] = $relation;
389 389
             } else {
390 390
                 //relation must be App\Models\Article or App\Models\Category
391
-                if (! $relation instanceof Collection && ! empty($relation)) {
391
+                if (!$relation instanceof Collection && !empty($relation)) {
392 392
                     $currentResults[get_class($relation)] = $relation->toArray();
393 393
                 }
394 394
             }
395 395
 
396 396
             array_shift($relationArray);
397 397
 
398
-            if (! empty($relationArray)) {
398
+            if (!empty($relationArray)) {
399 399
                 foreach ($currentResults as $model => $currentResult) {
400 400
                     $results[$model] = array_merge($results[$model], $this->getRelatedEntries($currentResult, implode('.', $relationArray)));
401 401
                 }
Please login to merge, or discard this patch.
src/resources/views/crud/columns/multidimensional_array.blade.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
     }
19 19
     $lastKey = array_key_last($list[$column['visible_key']]);
20 20
 }
21
-if (! empty($column['wrapper'])) {
21
+if (!empty($column['wrapper'])) {
22 22
     $column['wrapper']['element'] = $column['wrapper']['element'] ?? 'a';
23 23
 }
24 24
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/FieldsProtectedMethods.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -93,9 +93,9 @@
 block discarded – undo
93 93
         // if there's a column in the db for this field name
94 94
         // most likely it doesn't need 'entity', UNLESS it's a foreign key
95 95
         // TODO: make this work
96
-         if ($relation_method = $this->checkIfFieldNameBelongsToAnyRelation($field['name'])) {
97
-             $field['entity'] = $relation_method['entity'];
98
-         }
96
+            if ($relation_method = $this->checkIfFieldNameBelongsToAnyRelation($field['name'])) {
97
+                $field['entity'] = $relation_method['entity'];
98
+            }
99 99
 
100 100
         return $field;
101 101
     }
Please login to merge, or discard this patch.
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
             return ['name' => $field];
42 42
         }
43 43
 
44
-        if (is_array($field) && ! isset($field['name'])) {
44
+        if (is_array($field) && !isset($field['name'])) {
45 45
             abort(500, 'All fields must have their name defined');
46 46
         }
47 47
 
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
         // if there's a method on the model with this name
71 71
         if (method_exists($this->model, $field['name'])) {
72 72
 
73
-            if($this->model->checkIfMethodReturnRelation($field['name'])) {
73
+            if ($this->model->checkIfMethodReturnRelation($field['name'])) {
74 74
                 $field['entity'] = $field['name'];
75 75
             }
76 76
             return $field;
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
             $possibleMethodName = Str::replaceLast('_id', '', $field['name']);
84 84
 
85 85
             if (method_exists($this->model, $possibleMethodName)) {
86
-                if($this->model->checkIfMethodReturnRelation($field['name'])) {
86
+                if ($this->model->checkIfMethodReturnRelation($field['name'])) {
87 87
                     $field['entity'] = $possibleMethodName;
88 88
                 }
89 89
                 return $field;
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
     protected function makeSureFieldHasRelationshipData($field)
104 104
     {
105 105
         // only do this if "entity" is defined on the field
106
-        if (! isset($field['entity'])) {
106
+        if (!isset($field['entity'])) {
107 107
             return $field;
108 108
         }
109 109
 
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
     {
123 123
         // if this is a relation type field and no corresponding model was specified,
124 124
         // get it from the relation method defined in the main model
125
-        if (isset($field['entity']) && ! isset($field['model'])) {
125
+        if (isset($field['entity']) && !isset($field['model'])) {
126 126
             $field['model'] = $this->getRelationModel($field['entity']);
127 127
         }
128 128
 
@@ -133,8 +133,8 @@  discard block
 block discarded – undo
133 133
     {
134 134
         // if there's a model defined, but no attribute
135 135
         // guess an attribute using the indentifiableAttribute functionality in CrudTrait
136
-        if (isset($field['model']) && ! isset($field['attribute'])) {
137
-            $field['attribute'] = call_user_func([(new $field['model']),'identifiableAttribute']);
136
+        if (isset($field['model']) && !isset($field['attribute'])) {
137
+            $field['attribute'] = call_user_func([(new $field['model']), 'identifiableAttribute']);
138 138
         }
139 139
 
140 140
         return $field;
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
      */
150 150
     protected function makeSureFieldHasLabel($field)
151 151
     {
152
-        if (! isset($field['label'])) {
152
+        if (!isset($field['label'])) {
153 153
             $name = is_array($field['name']) ? $field['name'][0] : $field['name'];
154 154
             $name = str_replace('_id', '', $name);
155 155
             $field['label'] = mb_ucfirst(str_replace('_', ' ', $name));
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
      */
168 168
     protected function makeSureFieldHasType($field)
169 169
     {
170
-        if (! isset($field['type'])) {
170
+        if (!isset($field['type'])) {
171 171
             $field['type'] = $this->inferFieldTypeFromDbColumnType($field['name']);
172 172
         }
173 173
 
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
     {
185 185
         // if a tab was mentioned, we should enable it
186 186
         if (isset($field['tab'])) {
187
-            if (! $this->tabsEnabled()) {
187
+            if (!$this->tabsEnabled()) {
188 188
                 $this->enableTabs();
189 189
             }
190 190
         }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Relationships.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
         }
25 25
 
26 26
         if (in_array($fieldName, array_column($relations, 'name'))) {
27
-            return array_filter($relations, function ($arr) use ($fieldName) {
27
+            return array_filter($relations, function($arr) use ($fieldName) {
28 28
                 if (isset($arr['name'])) {
29 29
                     return $arr['name'] == $fieldName;
30 30
                 }
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
             }
53 53
             return false;
54 54
 
55
-        }catch(\Exception $e) {
55
+        } catch (\Exception $e) {
56 56
             return false;
57 57
         }
58 58
     }
Please login to merge, or discard this patch.
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
             }
53 53
             return false;
54 54
 
55
-        }catch(\Exception $e) {
55
+        } catch(\Exception $e) {
56 56
             return false;
57 57
         }
58 58
     }
Please login to merge, or discard this patch.