Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Push — fix-uploaders ( a7ecbc...1c3162 )
by Pedro
12:45
created
src/app/Library/Uploaders/Uploader.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
 
26 26
     private bool $deleteWhenEntryIsDeleted = true;
27 27
 
28
-    private bool|string $attachedToFakeField = false;
28
+    private bool | string $attachedToFakeField = false;
29 29
 
30 30
     /**
31 31
      * Cloud disks have the ability to generate temporary URLs to files, should we do it?
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
     /*******************************
63 63
      * Static methods
64 64
      *******************************/
65
-    public static function for(array $crudObject, array $definition): UploaderInterface
65
+    public static function for (array $crudObject, array $definition): UploaderInterface
66 66
     {
67 67
         return new static($crudObject, $definition);
68 68
     }
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
     public function deleteUploadedFiles(Model $entry): void
104 104
     {
105 105
         
106
-        if (! in_array(SoftDeletes::class, class_uses_recursive($entry), true)) {
106
+        if (!in_array(SoftDeletes::class, class_uses_recursive($entry), true)) {
107 107
             $this->performFileDeletion($entry);
108 108
 
109 109
             return;
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
 
180 180
     public function getPreviousFiles(Model $entry): mixed
181 181
     {
182
-        if (! $this->attachedToFakeField) {
182
+        if (!$this->attachedToFakeField) {
183 183
             return $this->getOriginalValue($entry);
184 184
         }
185 185
         $value = $this->getOriginalValue($entry, $this->attachedToFakeField);
@@ -198,7 +198,7 @@  discard block
 block discarded – undo
198 198
         return $this->attachedToFakeField !== false;
199 199
     }
200 200
 
201
-    public function getFakeAttribute(): bool|string
201
+    public function getFakeAttribute(): bool | string
202 202
     {
203 203
         return $this->attachedToFakeField;
204 204
     }
@@ -220,7 +220,7 @@  discard block
 block discarded – undo
220 220
         return $this;
221 221
     }
222 222
 
223
-    public function fake(bool|string $isFake): self
223
+    public function fake(bool | string $isFake): self
224 224
     {
225 225
         $this->attachedToFakeField = $isFake;
226 226
 
@@ -251,7 +251,7 @@  discard block
 block discarded – undo
251 251
         }
252 252
 
253 253
         if ($this->handleMultipleFiles) {
254
-            if (! isset($entry->getCasts()[$this->getName()]) && is_string($value)) {
254
+            if (!isset($entry->getCasts()[$this->getName()]) && is_string($value)) {
255 255
                 $entry->{$this->getAttributeName()} = json_decode($value, true);
256 256
             }
257 257
 
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
 
266 266
     private function deleteFiles(Model $entry)
267 267
     {
268
-        if (! $this->shouldDeleteFiles()) {
268
+        if (!$this->shouldDeleteFiles()) {
269 269
             return;
270 270
         }
271 271
 
@@ -300,7 +300,7 @@  discard block
 block discarded – undo
300 300
 
301 301
     private function performFileDeletion(Model $entry)
302 302
     {
303
-        if (! $this->handleRepeatableFiles && $this->deleteWhenEntryIsDeleted) {
303
+        if (!$this->handleRepeatableFiles && $this->deleteWhenEntryIsDeleted) {
304 304
             $this->deleteFiles($entry);
305 305
 
306 306
             return;
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
 
330 330
         $previousValue = $entry->getOriginal($field);
331 331
 
332
-        if (! $previousValue) {
332
+        if (!$previousValue) {
333 333
             return $previousValue;
334 334
         }
335 335
 
Please login to merge, or discard this patch.
src/app/Library/Uploaders/Support/RegisterUploadEvents.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -14,18 +14,18 @@  discard block
 block discarded – undo
14 14
     private string $crudObjectType;
15 15
 
16 16
     public function __construct(
17
-        private readonly CrudField|CrudColumn $crudObject,
17
+        private readonly CrudField | CrudColumn $crudObject,
18 18
         private readonly array $uploaderConfiguration,
19 19
         private readonly string $macro
20 20
         ) {
21 21
         $this->crudObjectType = is_a($crudObject, CrudField::class) ? 'field' : (is_a($crudObject, CrudColumn::class) ? 'column' : null);
22 22
 
23
-        if (! $this->crudObjectType) {
23
+        if (!$this->crudObjectType) {
24 24
             abort(500, 'Upload handlers only work for CrudField and CrudColumn classes.');
25 25
         }
26 26
     }
27 27
 
28
-    public static function handle(CrudField|CrudColumn $crudObject, array $uploaderConfiguration, string $macro, ?array $subfield = null, ?bool $registerModelEvents = true): void
28
+    public static function handle(CrudField | CrudColumn $crudObject, array $uploaderConfiguration, string $macro, ?array $subfield = null, ?bool $registerModelEvents = true): void
29 29
     {
30 30
         $instance = new self($crudObject, $uploaderConfiguration, $macro);
31 31
 
@@ -35,9 +35,9 @@  discard block
 block discarded – undo
35 35
     /*******************************
36 36
      * Private methods - implementation
37 37
      *******************************/
38
-    private function registerEvents(array|null $subfield = [], ?bool $registerModelEvents = true): void
38
+    private function registerEvents(array | null $subfield = [], ?bool $registerModelEvents = true): void
39 39
     {
40
-        if (! empty($subfield)) {
40
+        if (!empty($subfield)) {
41 41
             $this->registerSubfieldEvent($subfield, $registerModelEvents);
42 42
 
43 43
             return;
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
         }
83 83
 
84 84
         $subfields = collect($this->crudObject->getAttributes()['subfields']);
85
-        $subfields = $subfields->map(function ($item) use ($subfield, $uploader) {
85
+        $subfields = $subfields->map(function($item) use ($subfield, $uploader) {
86 86
             if ($item['name'] === $subfield['name']) {
87 87
                 $item['upload'] = true;
88 88
                 $item['disk'] = $uploader->getDisk();
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
         }
113 113
 
114 114
         if ($this->crudObjectType === 'field') {
115
-            $model::saving(function ($entry) use ($uploader) {
115
+            $model::saving(function($entry) use ($uploader) {
116 116
                 $entry = $uploader->storeUploadedFiles($entry);
117 117
             });
118 118
         }
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
             // is not called in pivot models when loading the relations.
126 126
             $retrieveModel = $this->getModelForRetrieveEvent($model, $uploader);
127 127
 
128
-            $retrieveModel::retrieved(function ($entry) use ($uploader) {
128
+            $retrieveModel::retrieved(function($entry) use ($uploader) {
129 129
                 if ($entry->translationEnabled()) {
130 130
                     $locale = request('_locale', app()->getLocale());
131 131
                     if (in_array($locale, array_keys($entry->getAvailableLocales()))) {
@@ -136,14 +136,14 @@  discard block
 block discarded – undo
136 136
             });
137 137
         }
138 138
 
139
-        $model::deleting(function ($entry) use ($uploader) {
139
+        $model::deleting(function($entry) use ($uploader) {
140 140
             $uploader->deleteUploadedFiles($entry);
141 141
         });
142 142
 
143 143
         // if the uploader is a relationship and handles repeatable files, we will also register the deleting event on the
144 144
         // parent model. that way we can control the deletion of the files when the parent model is deleted.
145 145
         if ($uploader->isRelationship() && $uploader->handleRepeatableFiles) {
146
-            app('crud')->model::deleting(function ($entry) use ($uploader) {
146
+            app('crud')->model::deleting(function($entry) use ($uploader) {
147 147
                 $uploader->deleteUploadedFiles($entry);
148 148
             });
149 149
         }
@@ -165,18 +165,18 @@  discard block
 block discarded – undo
165 165
     {
166 166
         $hasCustomUploader = isset($uploaderConfiguration['uploader']);
167 167
 
168
-        if ($hasCustomUploader && ! is_a($uploaderConfiguration['uploader'], UploaderInterface::class, true)) {
168
+        if ($hasCustomUploader && !is_a($uploaderConfiguration['uploader'], UploaderInterface::class, true)) {
169 169
             throw new Exception('Invalid uploader class provided for '.$this->crudObjectType.' type: '.$crudObject['type']);
170 170
         }
171 171
 
172 172
         if ($hasCustomUploader) {
173
-            return $uploaderConfiguration['uploader']::for($crudObject, $uploaderConfiguration);
173
+            return $uploaderConfiguration['uploader']::for ($crudObject, $uploaderConfiguration);
174 174
         }
175 175
 
176 176
         $uploader = app('UploadersRepository')->hasUploadFor($crudObject['type'], $this->macro);
177 177
 
178 178
         if ($uploader) {
179
-            return app('UploadersRepository')->getUploadFor($crudObject['type'], $this->macro)::for($crudObject, $uploaderConfiguration);
179
+            return app('UploadersRepository')->getUploadFor($crudObject['type'], $this->macro)::for ($crudObject, $uploaderConfiguration);
180 180
         }
181 181
 
182 182
         throw new Exception('Undefined upload type for '.$this->crudObjectType.' type: '.$crudObject['type']);
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
 
198 198
     private function getSubfieldModel(array $subfield, UploaderInterface $uploader)
199 199
     {
200
-        if (! $uploader->isRelationship()) {
200
+        if (!$uploader->isRelationship()) {
201 201
             return $subfield['baseModel'] ?? get_class(app('crud')->getModel());
202 202
         }
203 203
 
@@ -210,7 +210,7 @@  discard block
 block discarded – undo
210 210
 
211 211
     private function getModelForRetrieveEvent(string $model, UploaderInterface $uploader)
212 212
     {
213
-        if (! $uploader->isRelationship()) {
213
+        if (!$uploader->isRelationship()) {
214 214
             return $model;
215 215
         }
216 216
 
Please login to merge, or discard this patch.
src/app/Library/Uploaders/SingleBase64Image.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
         $value = $value ?? CRUD::getRequest()->get($this->getName());
16 16
         $previousImage = $this->getPreviousFiles($entry);
17 17
 
18
-        if (! $value && $previousImage) {
18
+        if (!$value && $previousImage) {
19 19
             Storage::disk($this->getDisk())->delete($previousImage);
20 20
 
21 21
             return null;
@@ -68,6 +68,6 @@  discard block
 block discarded – undo
68 68
 
69 69
     public function shouldKeepPreviousValueUnchanged(Model $entry, $entryValue): bool
70 70
     {
71
-        return $entry->exists && is_string($entryValue) && ! Str::startsWith($entryValue, 'data:image');
71
+        return $entry->exists && is_string($entryValue) && !Str::startsWith($entryValue, 'data:image');
72 72
     }
73 73
 }
Please login to merge, or discard this patch.
src/app/Library/Uploaders/Support/Traits/HandleRepeatableUploads.php 1 patch
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
 {
19 19
     public bool $handleRepeatableFiles = false;
20 20
 
21
-    public null|string $repeatableContainerName = null;
21
+    public null | string $repeatableContainerName = null;
22 22
 
23 23
     /*******************************
24 24
      * Setters - fluently configure the uploader
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
     /*******************************
36 36
      * Getters
37 37
      *******************************/
38
-    public function getRepeatableContainerName(): null|string
38
+    public function getRepeatableContainerName(): null | string
39 39
     {
40 40
         return $this->repeatableContainerName;
41 41
     }
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
         $value = $this->mergeValuesRecursive($values, $files);
56 56
 
57 57
         if ($this->isRelationship()) {
58
-            if($value->isEmpty()) {
58
+            if ($value->isEmpty()) {
59 59
                 return $entry;
60 60
             }
61 61
             return $this->processRelationshipRepeatableUploaders($entry);
@@ -161,7 +161,7 @@  discard block
 block discarded – undo
161 161
         foreach (app('UploadersRepository')->getRepeatableUploadersFor($this->getRepeatableContainerName()) as $uploader) {
162 162
             $uploadedValues = $uploader->uploadRepeatableFiles($values->pluck($uploader->getAttributeName())->toArray(), $this->getPreviousRepeatableValues($entry, $uploader));
163 163
 
164
-            $values = $values->map(function ($item, $key) use ($uploadedValues, $uploader) {
164
+            $values = $values->map(function($item, $key) use ($uploadedValues, $uploader) {
165 165
                 $item[$uploader->getAttributeName()] = $uploadedValues[$key] ?? null;
166 166
 
167 167
                 return $item;
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
 
193 193
         $values = $entry->{$this->getRepeatableContainerName()};
194 194
         $values = is_string($values) ? json_decode($values, true) : $values;
195
-        $values = array_map(function ($item) use ($repeatableUploaders) {
195
+        $values = array_map(function($item) use ($repeatableUploaders) {
196 196
             foreach ($repeatableUploaders as $upload) {
197 197
                 $item[$upload->getAttributeName()] = $this->getValuesWithPathStripped($item, $upload);
198 198
             }
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
 
208 208
     private function retrieveRepeatableRelationFiles(Model $entry)
209 209
     {
210
-        switch($this->getRepeatableRelationType()) {
210
+        switch ($this->getRepeatableRelationType()) {
211 211
             case 'BelongsToMany':
212 212
             case 'MorphToMany':
213 213
                 $pivotClass = app('crud')->getModel()->{$this->getUploaderSubfield()['baseEntity']}()->getPivotClass();
@@ -260,12 +260,12 @@  discard block
 block discarded – undo
260 260
         $repeatableValues ??= collect($entry->{$this->getRepeatableContainerName()});
261 261
 
262 262
         foreach (app('UploadersRepository')->getRepeatableUploadersFor($this->getRepeatableContainerName()) as $upload) {
263
-            if (! $upload->shouldDeleteFiles()) {
263
+            if (!$upload->shouldDeleteFiles()) {
264 264
                 continue;
265 265
             }
266 266
             $values = $repeatableValues->pluck($upload->getName())->toArray();
267 267
             foreach ($values as $value) {
268
-                if (! $value) {
268
+                if (!$value) {
269 269
                     continue;
270 270
                 }
271 271
 
@@ -288,7 +288,7 @@  discard block
 block discarded – undo
288 288
     /**
289 289
      * Given two multidimensional arrays/collections, merge them recursively.
290 290
      */
291
-    protected function mergeValuesRecursive(array|Collection $array1, array|Collection $array2): array|Collection
291
+    protected function mergeValuesRecursive(array | Collection $array1, array | Collection $array2): array | Collection
292 292
     {
293 293
         $merged = $array1;
294 294
         foreach ($array2 as $key => &$value) {
@@ -310,7 +310,7 @@  discard block
 block discarded – undo
310 310
     {
311 311
         $items = CRUD::getRequest()->input('_order_'.$this->getRepeatableContainerName()) ?? [];
312 312
 
313
-        array_walk($items, function (&$key, $value) {
313
+        array_walk($items, function(&$key, $value) {
314 314
             $requestValue = $key[$this->getName()] ?? null;
315 315
             $key = $this->handleMultipleFiles ? (is_string($requestValue) ? explode(',', $requestValue) : $requestValue) : $requestValue;
316 316
         });
@@ -322,22 +322,22 @@  discard block
 block discarded – undo
322 322
     {
323 323
         $previousValues = $entry->getOriginal($uploader->getRepeatableContainerName());
324 324
 
325
-        if (! is_array($previousValues)) {
325
+        if (!is_array($previousValues)) {
326 326
             $previousValues = json_decode($previousValues, true);
327 327
         }
328 328
 
329
-        if (! empty($previousValues)) {
329
+        if (!empty($previousValues)) {
330 330
             $previousValues = array_column($previousValues, $uploader->getName());
331 331
         }
332 332
 
333 333
         return $previousValues ?? [];
334 334
     }
335 335
 
336
-    private function getValuesWithPathStripped(array|string|null $item, UploaderInterface $uploader)
336
+    private function getValuesWithPathStripped(array | string | null $item, UploaderInterface $uploader)
337 337
     {
338 338
         $uploadedValues = $item[$uploader->getName()] ?? null;
339 339
         if (is_array($uploadedValues)) {
340
-            return array_map(function ($value) use ($uploader) {
340
+            return array_map(function($value) use ($uploader) {
341 341
                 return $uploader->getValueWithoutPath($value);
342 342
             }, $uploadedValues);
343 343
         }
@@ -347,8 +347,8 @@  discard block
 block discarded – undo
347 347
 
348 348
     private function deleteRelationshipFiles(Model $entry): void
349 349
     {
350
-        if (! is_a($entry, Pivot::class, true) &&
351
-            ! $entry->relationLoaded($this->getRepeatableContainerName()) && 
350
+        if (!is_a($entry, Pivot::class, true) &&
351
+            !$entry->relationLoaded($this->getRepeatableContainerName()) && 
352 352
             method_exists($entry, $this->getRepeatableContainerName())
353 353
             ) { 
354 354
             $entry->loadMissing($this->getRepeatableContainerName());
@@ -382,9 +382,9 @@  discard block
 block discarded – undo
382 382
         }
383 383
     }
384 384
 
385
-    private function deletePivotFiles(Pivot|Model $entry)
385
+    private function deletePivotFiles(Pivot | Model $entry)
386 386
     {
387
-        if (! is_a($entry, Pivot::class, true)) {
387
+        if (!is_a($entry, Pivot::class, true)) {
388 388
             $pivots = $entry->{$this->getRepeatableContainerName()};
389 389
             foreach ($pivots as $pivot) {
390 390
                 $this->deletePivotModelFiles($pivot);
@@ -393,24 +393,24 @@  discard block
 block discarded – undo
393 393
         }
394 394
 
395 395
         $pivotAttributes = $entry->getAttributes();
396
-        $connectedPivot = $entry->pivotParent->{$this->getRepeatableContainerName()}->where(function ($item) use ($pivotAttributes) {
396
+        $connectedPivot = $entry->pivotParent->{$this->getRepeatableContainerName()}->where(function($item) use ($pivotAttributes) {
397 397
             $itemPivotAttributes = $item->pivot->only(array_keys($pivotAttributes));
398 398
 
399 399
             return $itemPivotAttributes === $pivotAttributes;
400 400
         })->first();
401 401
 
402
-        if (! $connectedPivot) {
402
+        if (!$connectedPivot) {
403 403
             return;
404 404
         }
405 405
 
406 406
         $this->deletePivotModelFiles($connectedPivot);
407 407
     }
408 408
 
409
-    private function deletePivotModelFiles(Pivot|Model $entry)
409
+    private function deletePivotModelFiles(Pivot | Model $entry)
410 410
     {
411 411
         $files = $entry->getOriginal()['pivot_'.$this->getAttributeName()];
412 412
 
413
-        if (! $files) {
413
+        if (!$files) {
414 414
             return;
415 415
         }
416 416
 
Please login to merge, or discard this patch.