Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — master (#3200)
by Cristian
16:03
created
src/app/Library/CrudPanel/Traits/SaveActions.php 1 patch
Spacing   +16 added lines, -17 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
         $higherAction = $this->getSaveActionByOrder(1);
29 29
 
30 30
         //if there is an higher action and that action is not the backpack default higher one `save_and_back` we return it.
31
-        if (! empty($higherAction) && key($higherAction) !== 'save_and_back') {
31
+        if (!empty($higherAction) && key($higherAction) !== 'save_and_back') {
32 32
             return key($higherAction);
33 33
         }
34 34
 
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
      */
48 48
     public function getSaveActionByOrder($order)
49 49
     {
50
-        return array_filter($this->getOperationSetting('save_actions'), function ($arr) use ($order) {
50
+        return array_filter($this->getOperationSetting('save_actions'), function($arr) use ($order) {
51 51
             return $arr['order'] == $order;
52 52
         });
53 53
     }
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
         $orderCounter = $this->getOperationSetting('save_actions') !== null ? (count($this->getOperationSetting('save_actions')) + 1) : 1;
82 82
         //check for some mandatory fields
83 83
         $saveAction['name'] ?? abort(500, 'Please define save action name.');
84
-        $saveAction['redirect'] = $saveAction['redirect'] ?? function ($crud, $request, $itemId) {
84
+        $saveAction['redirect'] = $saveAction['redirect'] ?? function($crud, $request, $itemId) {
85 85
             return $request->has('http_referrer') ? $request->get('http_referrer') : $crud->route;
86 86
         };
87 87
         $saveAction['visible'] = $saveAction['visible'] ?? true;
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
 
91 91
         $actions = $this->getOperationSetting('save_actions') ?? [];
92 92
 
93
-        if (! in_array($saveAction['name'], $actions)) {
93
+        if (!in_array($saveAction['name'], $actions)) {
94 94
             $actions[$saveAction['name']] = $saveAction;
95 95
         }
96 96
 
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
     public function orderSaveAction(string $saveAction, int $wantedOrder)
108 108
     {
109 109
         $actions = $this->getOperationSetting('save_actions') ?? [];
110
-        if (! empty($actions)) {
110
+        if (!empty($actions)) {
111 111
             $replaceOrder = isset($actions[$saveAction]) ? $actions[$saveAction]['order'] : count($actions) + 1;
112 112
 
113 113
             foreach ($actions as $key => $sv) {
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
     public function orderSaveActions(array $saveActions)
202 202
     {
203 203
         foreach ($saveActions as $sv => $order) {
204
-            if (! is_int($order)) {
204
+            if (!is_int($order)) {
205 205
                 $this->orderSaveAction($order, $sv + 1);
206 206
             } else {
207 207
                 $this->orderSaveAction($sv, $order);
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
     {
219 219
         $actions = $this->getOperationSetting('save_actions') ?? [];
220 220
 
221
-        uasort($actions, function ($a, $b) {
221
+        uasort($actions, function($a, $b) {
222 222
             return $a['order'] <=> $b['order'];
223 223
         });
224 224
 
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
240 240
             }
241 241
         }
242 242
 
243
-        return array_filter($actions, function ($action) {
243
+        return array_filter($actions, function($action) {
244 244
             return $action['visible'] == true;
245 245
         }, ARRAY_FILTER_USE_BOTH);
246 246
     }
@@ -304,8 +304,7 @@  discard block
 block discarded – undo
304 304
      */
305 305
     public function setSaveAction($forceSaveAction = null)
306 306
     {
307
-        $saveAction = $forceSaveAction ?:
308
-            \Request::input('save_action', $this->getFallBackSaveAction());
307
+        $saveAction = $forceSaveAction ?: \Request::input('save_action', $this->getFallBackSaveAction());
309 308
 
310 309
         $showBubble = $this->getOperationSetting('showSaveActionChange') ?? config('backpack.crud.operations.'.$this->getCurrentOperation().'.showSaveActionChange') ?? true;
311 310
 
@@ -373,20 +372,20 @@  discard block
 block discarded – undo
373 372
         $defaultSaveActions = [
374 373
             [
375 374
                 'name' => 'save_and_back',
376
-                'visible' => function ($crud) {
375
+                'visible' => function($crud) {
377 376
                     return $crud->hasAccess('list');
378 377
                 },
379
-                'redirect' => function ($crud, $request, $itemId = null) {
378
+                'redirect' => function($crud, $request, $itemId = null) {
380 379
                     return $request->has('http_referrer') ? $request->get('http_referrer') : $crud->route;
381 380
                 },
382 381
                 'button_text' => trans('backpack::crud.save_action_save_and_back'),
383 382
             ],
384 383
             [
385 384
                 'name' => 'save_and_edit',
386
-                'visible' => function ($crud) {
385
+                'visible' => function($crud) {
387 386
                     return $crud->hasAccess('update');
388 387
                 },
389
-                'redirect' => function ($crud, $request, $itemId = null) {
388
+                'redirect' => function($crud, $request, $itemId = null) {
390 389
                     $itemId = $itemId ?: $request->input('id');
391 390
                     $redirectUrl = $crud->route.'/'.$itemId.'/edit';
392 391
                     if ($request->has('locale')) {
@@ -398,17 +397,17 @@  discard block
 block discarded – undo
398 397
 
399 398
                     return $redirectUrl;
400 399
                 },
401
-                'referrer_url' => function ($crud, $request, $itemId) {
400
+                'referrer_url' => function($crud, $request, $itemId) {
402 401
                     return url($crud->route.'/'.$itemId.'/edit');
403 402
                 },
404 403
                 'button_text' => trans('backpack::crud.save_action_save_and_edit'),
405 404
             ],
406 405
             [
407 406
                 'name' => 'save_and_new',
408
-                'visible' => function ($crud) {
407
+                'visible' => function($crud) {
409 408
                     return $crud->hasAccess('create');
410 409
                 },
411
-                'redirect' => function ($crud, $request, $itemId = null) {
410
+                'redirect' => function($crud, $request, $itemId = null) {
412 411
                     return $this->route.'/create';
413 412
                 },
414 413
                 'button_text' => trans('backpack::crud.save_action_save_and_new'),
Please login to merge, or discard this patch.
src/LicenseCheck.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
             return;
29 29
         }
30 30
 
31
-        if (! $this->validCode(config('backpack.base.license_code'))) {
31
+        if (!$this->validCode(config('backpack.base.license_code'))) {
32 32
             \Alert::add('warning', "<strong>You're using unlicensed software.</strong> Please ask your web developer to <a target='_blank' class='alert-link text-white' href='http://backpackforlaravel.com'>purchase a license code</a> to hide this message.");
33 33
         }
34 34
     }
@@ -46,6 +46,6 @@  discard block
 block discarded – undo
46 46
      */
47 47
     private function validCode($j)
48 48
     {
49
-        $k = str_replace('-', '', $j); $s = substr($k, 0, 8); $c = substr($k, 8, 2); $a = substr($k, 10, 2); $l = substr($k, 12, 2); $p = substr($k, 14, 2); $n = substr($k, 16, 2); $m = substr($k, 18, 2); $z = substr($k, 20, 24); $w = 'ADEFHKLMVWXYZ146'; $x = $s; for ($i = 0; $i < strlen($w); $i++) { $r = $w[$i]; $x = str_replace($r, '-', $x); } $x = str_replace('-', '', $x); if ($x != '') { return false; } if (substr_count($j, '-') != 5) { return false; } $e = substr(hexdec(hash('crc32b', substr($k, 0, 20))), -4); if ($z !== $e) { return false; } $o = strrev(substr(preg_replace('/[0-9]+/', '', strtoupper(sha1($a.'sand('.$s.')'.$n.'tos()'))), 2, 2)); if ($m !== $o) { return false; } $o2 = substr(((int)preg_replace('/[^0-9]/','', $s.$c)==0 ? 8310 : (int)preg_replace('/[^0-9]/','', $s.$c) )*9971, -2);if ($a !== $o2) {return false;} return true; 
49
+        $k = str_replace('-', '', $j); $s = substr($k, 0, 8); $c = substr($k, 8, 2); $a = substr($k, 10, 2); $l = substr($k, 12, 2); $p = substr($k, 14, 2); $n = substr($k, 16, 2); $m = substr($k, 18, 2); $z = substr($k, 20, 24); $w = 'ADEFHKLMVWXYZ146'; $x = $s; for ($i = 0; $i < strlen($w); $i++) { $r = $w[$i]; $x = str_replace($r, '-', $x); } $x = str_replace('-', '', $x); if ($x != '') { return false; } if (substr_count($j, '-') != 5) { return false; } $e = substr(hexdec(hash('crc32b', substr($k, 0, 20))), -4); if ($z !== $e) { return false; } $o = strrev(substr(preg_replace('/[0-9]+/', '', strtoupper(sha1($a.'sand('.$s.')'.$n.'tos()'))), 2, 2)); if ($m !== $o) { return false; } $o2 = substr(((int) preg_replace('/[^0-9]/', '', $s.$c) == 0 ? 8310 : (int) preg_replace('/[^0-9]/', '', $s.$c)) * 9971, -2); if ($a !== $o2) {return false; } return true; 
50 50
     }
51 51
 }
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/ListOperation.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
     {
42 42
         $this->crud->allowAccess('list');
43 43
 
44
-        $this->crud->operation('list', function () {
44
+        $this->crud->operation('list', function() {
45 45
             $this->crud->loadDefaultOperationSettingsFromConfig();
46 46
         });
47 47
     }
@@ -114,8 +114,8 @@  discard block
 block discarded – undo
114 114
         // if there was an order set, this will be the last one (after all others were applied)
115 115
         $orderBy = $this->crud->query->getQuery()->orders;
116 116
         $hasOrderByPrimaryKey = false;
117
-        collect($orderBy)->each(function ($item, $key) use ($hasOrderByPrimaryKey) {
118
-            if (! isset($item['column'])) {
117
+        collect($orderBy)->each(function($item, $key) use ($hasOrderByPrimaryKey) {
118
+            if (!isset($item['column'])) {
119 119
                 return false;
120 120
             }
121 121
 
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
                 return false;
126 126
             }
127 127
         });
128
-        if (! $hasOrderByPrimaryKey) {
128
+        if (!$hasOrderByPrimaryKey) {
129 129
             $this->crud->query->orderByRaw($this->crud->model->getTableWithPrefix().'.'.$this->crud->model->getKeyName().' DESC');
130 130
         }
131 131
 
Please login to merge, or discard this patch.
src/routes/backpack/custom.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,5 +13,5 @@
 block discarded – undo
13 13
         (array) config('backpack.base.middleware_key', 'admin')
14 14
     ),
15 15
     'namespace'  => 'App\Http\Controllers\Admin',
16
-], function () { // custom admin routes
16
+], function() { // custom admin routes
17 17
 }); // this should be the absolute last line of this file
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudFilter.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
      */
85 85
     public function wasNotApplied()
86 86
     {
87
-        return ! $this->applied;
87
+        return !$this->applied;
88 88
     }
89 89
 
90 90
     /**
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
 
106 106
         $input = $input ?? new ParameterBag($this->crud()->getRequest()->all());
107 107
 
108
-        if (! $input->has($this->name)) {
108
+        if (!$input->has($this->name)) {
109 109
             // if fallback logic was supplied and is a closure
110 110
             if (is_callable($this->fallbackLogic)) {
111 111
                 return ($this->fallbackLogic)();
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Create.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
     {
87 87
         $all_relation_fields = $this->getRelationFields();
88 88
 
89
-        return Arr::where($all_relation_fields, function ($value, $key) {
89
+        return Arr::where($all_relation_fields, function($value, $key) {
90 90
             return isset($value['pivot']) && $value['pivot'];
91 91
         });
92 92
     }
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
     {
101 101
         $all_relation_fields = $this->getRelationFields();
102 102
 
103
-        return Arr::where($all_relation_fields, function ($value, $key) {
103
+        return Arr::where($all_relation_fields, function($value, $key) {
104 104
             return isset($value['type']) && $value['type'] && $value['type'] == 'repeatable';
105 105
         });
106 106
     }
@@ -179,11 +179,11 @@  discard block
 block discarded – undo
179 179
      */
180 180
     private function createRelationsForItem($item, $formattedData)
181 181
     {
182
-        if (! isset($formattedData['relations'])) {
182
+        if (!isset($formattedData['relations'])) {
183 183
             return false;
184 184
         }
185 185
         foreach ($formattedData['relations'] as $relationMethod => $relationData) {
186
-            if (! isset($relationData['model'])) {
186
+            if (!isset($relationData['model'])) {
187 187
                 continue;
188 188
             }
189 189
             $model = $relationData['model'];
@@ -254,13 +254,13 @@  discard block
 block discarded – undo
254 254
         foreach ($relation_fields as $relation_field) {
255 255
             $attributeKey = $this->parseRelationFieldNamesFromHtml([$relation_field])[0]['name'];
256 256
 
257
-            if (! is_null(Arr::get($data, $attributeKey)) && isset($relation_field['pivot']) && $relation_field['pivot'] !== true) {
257
+            if (!is_null(Arr::get($data, $attributeKey)) && isset($relation_field['pivot']) && $relation_field['pivot'] !== true) {
258 258
                 $key = implode('.relations.', explode('.', $this->getOnlyRelationEntity($relation_field)));
259 259
                 $fieldData = Arr::get($relationData, 'relations.'.$key, []);
260
-                if (! array_key_exists('model', $fieldData)) {
260
+                if (!array_key_exists('model', $fieldData)) {
261 261
                     $fieldData['model'] = $relation_field['model'];
262 262
                 }
263
-                if (! array_key_exists('parent', $fieldData)) {
263
+                if (!array_key_exists('parent', $fieldData)) {
264 264
                     $fieldData['parent'] = $this->getRelationModel($attributeKey, -1);
265 265
                 }
266 266
                 $relatedAttribute = Arr::last(explode('.', $attributeKey));
@@ -281,7 +281,7 @@  discard block
 block discarded – undo
281 281
 
282 282
         $related_method = Arr::last($entity_array);
283 283
 
284
-        if (! method_exists($relation_model, $related_method)) {
284
+        if (!method_exists($relation_model, $related_method)) {
285 285
             if (count($entity_array) <= 1) {
286 286
                 return $relation_field['entity'];
287 287
             } else {
Please login to merge, or discard this patch.