Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Failed
Pull Request — main (#4778)
by Pedro
25:44 queued 10:58
created
src/app/Library/CrudPanel/Traits/Read.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
      */
57 57
     public function getEntry($id)
58 58
     {
59
-        if (! $this->entry) {
59
+        if (!$this->entry) {
60 60
             $this->entry = $this->getModelWithCrudPanelQuery()->findOrFail($id);
61 61
             $this->entry = $this->entry->withFakes();
62 62
         }
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
      */
74 74
     public function getEntryWithLocale($id)
75 75
     {
76
-        if (! $this->entry) {
76
+        if (!$this->entry) {
77 77
             $this->entry = $this->getEntry($id);
78 78
         }
79 79
 
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
      */
163 163
     public function enableDetailsRow()
164 164
     {
165
-        if (! backpack_pro()) {
165
+        if (!backpack_pro()) {
166 166
             throw new BackpackProRequiredException('Details row');
167 167
         }
168 168
 
@@ -261,7 +261,7 @@  discard block
 block discarded – undo
261 261
                 // we will apply the same labels as the values to the menu if developer didn't
262 262
                 $this->abortIfInvalidPageLength($menu[0]);
263 263
 
264
-                if (! isset($menu[1]) || ! is_array($menu[1])) {
264
+                if (!isset($menu[1]) || !is_array($menu[1])) {
265 265
                     $menu[1] = $menu[0];
266 266
                 }
267 267
             } else {
@@ -349,7 +349,7 @@  discard block
 block discarded – undo
349 349
      */
350 350
     public function enableExportButtons()
351 351
     {
352
-        if (! backpack_pro()) {
352
+        if (!backpack_pro()) {
353 353
             throw new BackpackProRequiredException('Export buttons');
354 354
         }
355 355
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/AutoSet.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -14,8 +14,8 @@  discard block
 block discarded – undo
14 14
     {
15 15
         $this->getDbColumnTypes();
16 16
 
17
-        array_map(function ($field) use ($setFields, $setColumns) {
18
-            if ($setFields && ! isset($this->getCleanStateFields()[$field])) {
17
+        array_map(function($field) use ($setFields, $setColumns) {
18
+            if ($setFields && !isset($this->getCleanStateFields()[$field])) {
19 19
                 $this->addField([
20 20
                     'name'       => $field,
21 21
                     'label'      => $this->makeLabel($field),
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
                 ]);
29 29
             }
30 30
 
31
-            if ($setColumns && ! in_array($field, $this->model->getHidden()) && ! isset($this->columns()[$field])) {
31
+            if ($setColumns && !in_array($field, $this->model->getHidden()) && !isset($this->columns()[$field])) {
32 32
                 $this->addColumn([
33 33
                     'name'    => $field,
34 34
                     'label'   => $this->makeLabel($field),
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
     {
51 51
         $dbColumnTypes = [];
52 52
 
53
-        if (! $this->driverIsSql()) {
53
+        if (!$this->driverIsSql()) {
54 54
             return $dbColumnTypes;
55 55
         }
56 56
 
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
 
116 116
         $dbColumnTypes = $this->getDbColumnTypes();
117 117
 
118
-        if (! isset($dbColumnTypes[$fieldName])) {
118
+        if (!isset($dbColumnTypes[$fieldName])) {
119 119
             return 'text';
120 120
         }
121 121
 
@@ -212,12 +212,12 @@  discard block
 block discarded – undo
212 212
     {
213 213
         $fillable = $this->model->getFillable();
214 214
 
215
-        if (! $this->driverIsSql()) {
215
+        if (!$this->driverIsSql()) {
216 216
             $columns = $fillable;
217 217
         } else {
218 218
             // Automatically-set columns should be both in the database, and in the $fillable variable on the Eloquent Model
219 219
             $columns = $this->model::getDbTableSchema()->getColumnsNames();
220
-            if (! empty($fillable)) {
220
+            if (!empty($fillable)) {
221 221
                 $columns = array_intersect($columns, $fillable);
222 222
             }
223 223
         }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Columns.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
      */
114 114
     public function makeFirstColumn()
115 115
     {
116
-        if (! $this->columns()) {
116
+        if (!$this->columns()) {
117 117
             return false;
118 118
         }
119 119
 
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
157 157
      */
158 158
     public function removeColumns($columns)
159 159
     {
160
-        if (! empty($columns)) {
160
+        if (!empty($columns)) {
161 161
             foreach ($columns as $columnKey) {
162 162
                 $this->removeColumn($columnKey);
163 163
             }
@@ -251,8 +251,8 @@  discard block
 block discarded – undo
251 251
     {
252 252
         $columns = $this->columns();
253 253
 
254
-        return collect($columns)->pluck('entity')->reject(function ($value, $key) {
255
-            return ! $value;
254
+        return collect($columns)->pluck('entity')->reject(function($value, $key) {
255
+            return !$value;
256 256
         })->toArray();
257 257
     }
258 258
 
@@ -326,7 +326,7 @@  discard block
 block discarded – undo
326 326
      */
327 327
     public function hasColumnWhere($attribute, $value)
328 328
     {
329
-        $match = Arr::first($this->columns(), function ($column, $columnKey) use ($attribute, $value) {
329
+        $match = Arr::first($this->columns(), function($column, $columnKey) use ($attribute, $value) {
330 330
             return isset($column[$attribute]) && $column[$attribute] == $value;
331 331
         });
332 332
 
@@ -342,7 +342,7 @@  discard block
 block discarded – undo
342 342
      */
343 343
     public function firstColumnWhere($attribute, $value)
344 344
     {
345
-        return Arr::first($this->columns(), function ($column, $columnKey) use ($attribute, $value) {
345
+        return Arr::first($this->columns(), function($column, $columnKey) use ($attribute, $value) {
346 346
             return isset($column[$attribute]) && $column[$attribute] == $value;
347 347
         });
348 348
     }
@@ -374,7 +374,7 @@  discard block
 block discarded – undo
374 374
 
375 375
         // if there's a model defined, but no attribute
376 376
         // guess an attribute using the identifiableAttribute functionality in CrudTrait
377
-        if (isset($column['model']) && ! isset($column['attribute']) && method_exists($column['model'], 'identifiableAttribute')) {
377
+        if (isset($column['model']) && !isset($column['attribute']) && method_exists($column['model'], 'identifiableAttribute')) {
378 378
             $column['attribute'] = (new $column['model'])->identifiableAttribute();
379 379
         }
380 380
 
@@ -399,8 +399,8 @@  discard block
 block discarded – undo
399 399
      */
400 400
     public function countColumnsWithoutActions()
401 401
     {
402
-        return collect($this->columns())->filter(function ($column, $key) {
403
-            return ! isset($column['hasActions']) || $column['hasActions'] == false;
402
+        return collect($this->columns())->filter(function($column, $key) {
403
+            return !isset($column['hasActions']) || $column['hasActions'] == false;
404 404
         })->count();
405 405
     }
406 406
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/MorphRelationships.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
     {
67 67
         if (isset($field['relation_type']) && $field['relation_type'] === 'MorphTo') {
68 68
             [$morphTypeFieldName, $morphIdFieldName] = $this->getMorphToFieldNames($field['name']);
69
-            if (! $this->hasFieldWhere('name', $morphTypeFieldName) || ! $this->hasFieldWhere('name', $morphIdFieldName)) {
69
+            if (!$this->hasFieldWhere('name', $morphTypeFieldName) || !$this->hasFieldWhere('name', $morphIdFieldName)) {
70 70
                 // create the morph fields in the crud panel
71 71
                 $field = $this->createMorphToRelationFields($field, $morphTypeFieldName, $morphIdFieldName);
72 72
                 foreach ($field['morphOptions'] ?? [] as $morphOption) {
@@ -97,8 +97,8 @@  discard block
 block discarded – undo
97 97
         [$morphTypeFieldName, $morphIdFieldName] = $this->getMorphToFieldNames($fieldName);
98 98
 
99 99
         // check if the morph field where we are about to add the options have the proper fields setup
100
-        if (! in_array($morphTypeFieldName, array_column($morphField['subfields'], 'name')) ||
101
-            ! in_array($morphIdFieldName, array_column($morphField['subfields'], 'name'))) {
100
+        if (!in_array($morphTypeFieldName, array_column($morphField['subfields'], 'name')) ||
101
+            !in_array($morphIdFieldName, array_column($morphField['subfields'], 'name'))) {
102 102
             throw new \Exception('Trying to add morphOptions to a non morph field. Check if field and relation name matches.');
103 103
         }
104 104
         // split the subfields into morphable_type and morphable_id fields.
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
         } else {
154 154
             // in case it's not a model and is a string representing the model in the morphMap
155 155
             // check if that string exists in the morphMap, otherwise abort.
156
-            if (! array_key_exists($key, $morphMap)) {
156
+            if (!array_key_exists($key, $morphMap)) {
157 157
                 throw new \Exception('Unknown morph type «'.$key.'», that name was not found in the morphMap.');
158 158
             }
159 159
             // check if the key already exists
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/FakeFields.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
                             if (array_key_exists($subfieldName, $requestInput) && $isSubfieldFake) {
50 50
                                 $this->addCompactedField($requestInput, $subfieldName, $subFakeFieldKey);
51 51
 
52
-                                if (! in_array($subFakeFieldKey, $compactedFakeFields)) {
52
+                                if (!in_array($subFakeFieldKey, $compactedFakeFields)) {
53 53
                                     $compactedFakeFields[] = $subFakeFieldKey;
54 54
                                 }
55 55
                             }
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
                 if (array_key_exists($fieldName, $requestInput) && $isFakeField) {
62 62
                     $this->addCompactedField($requestInput, $fieldName, $fakeFieldKey);
63 63
 
64
-                    if (! in_array($fakeFieldKey, $compactedFakeFields)) {
64
+                    if (!in_array($fakeFieldKey, $compactedFakeFields)) {
65 65
                         $compactedFakeFields[] = $fakeFieldKey;
66 66
                     }
67 67
                 }
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
 
71 71
         // json_encode all fake_value columns if applicable in the database, so they can be properly stored and interpreted
72 72
         foreach ($compactedFakeFields as $value) {
73
-            if (! (property_exists($model, 'translatable') && in_array($value, $model->getTranslatableAttributes(), true)) && $model->shouldEncodeFake($value)) {
73
+            if (!(property_exists($model, 'translatable') && in_array($value, $model->getTranslatableAttributes(), true)) && $model->shouldEncodeFake($value)) {
74 74
                 $requestInput[$value] = json_encode($requestInput[$value]);
75 75
             }
76 76
         }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Input.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
         }
99 99
 
100 100
         //remove fields that are not in the submitted form input
101
-        $relationFields = array_filter($relationFields, function ($field) use ($input) {
101
+        $relationFields = array_filter($relationFields, function($field) use ($input) {
102 102
             return Arr::has($input, $field['name']) || isset($input[$field['name']]) || Arr::has($input, Str::afterLast($field['name'], '.'));
103 103
         });
104 104
 
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
 
178 178
             // when using dot notation if relationMethod is not set we are sure we want to exclude those relations.
179 179
             if ($this->getOnlyRelationEntity($field) !== $field['entity']) {
180
-                if (! $relationMethod) {
180
+                if (!$relationMethod) {
181 181
                     $excludedFields[] = $nameToExclude;
182 182
                 }
183 183
 
@@ -191,8 +191,8 @@  discard block
 block discarded – undo
191 191
             }
192 192
         }
193 193
 
194
-        return Arr::where($input, function ($item, $key) use ($excludedFields) {
195
-            return ! in_array($key, $excludedFields);
194
+        return Arr::where($input, function($item, $key) use ($excludedFields) {
195
+            return !in_array($key, $excludedFields);
196 196
         });
197 197
     }
198 198
 }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudField.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -245,7 +245,7 @@
 block discarded – undo
245 245
         // append the field name to the rule name of validationMessages array.
246 246
         // eg: ['required => 'This field is required']
247 247
         // will be transformed into: ['field_name.required' => 'This field is required]
248
-        $this->crud()->setValidationFromArray([], array_merge(...array_map(function ($rule, $message) {
248
+        $this->crud()->setValidationFromArray([], array_merge(...array_map(function($rule, $message) {
249 249
             return [$this->attributes['name'].'.'.$rule => $message];
250 250
         }, array_keys($messages), $messages)));
251 251
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudPanel.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -109,11 +109,11 @@  discard block
 block discarded – undo
109 109
      */
110 110
     public function setModel($model_namespace)
111 111
     {
112
-        if (! class_exists($model_namespace)) {
112
+        if (!class_exists($model_namespace)) {
113 113
             throw new \Exception('The model does not exist.', 500);
114 114
         }
115 115
 
116
-        if (! method_exists($model_namespace, 'hasCrudTrait')) {
116
+        if (!method_exists($model_namespace, 'hasCrudTrait')) {
117 117
             throw new \Exception('Please use CrudTrait on the model.', 500);
118 118
         }
119 119
 
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
 
205 205
         $complete_route = $route.'.index';
206 206
 
207
-        if (! \Route::has($complete_route)) {
207
+        if (!\Route::has($complete_route)) {
208 208
             throw new \Exception('There are no routes for this route name.', 404);
209 209
         }
210 210
 
@@ -302,7 +302,7 @@  discard block
 block discarded – undo
302 302
      */
303 303
     public function getFirstOfItsTypeInArray($type, $array)
304 304
     {
305
-        return Arr::first($array, function ($item) use ($type) {
305
+        return Arr::first($array, function($item) use ($type) {
306 306
             return $item['type'] == $type;
307 307
         });
308 308
     }
@@ -319,8 +319,8 @@  discard block
 block discarded – undo
319 319
 
320 320
     public function sync($type, $fields, $attributes)
321 321
     {
322
-        if (! empty($this->{$type})) {
323
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
322
+        if (!empty($this->{$type})) {
323
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
324 324
                 if (in_array($field['name'], (array) $fields)) {
325 325
                     $field = array_merge($field, $attributes);
326 326
                 }
@@ -350,15 +350,15 @@  discard block
 block discarded – undo
350 350
     {
351 351
         $relationArray = explode('.', $relationString);
352 352
 
353
-        if (! isset($length)) {
353
+        if (!isset($length)) {
354 354
             $length = count($relationArray);
355 355
         }
356 356
 
357
-        if (! isset($model)) {
357
+        if (!isset($model)) {
358 358
             $model = $this->model;
359 359
         }
360 360
 
361
-        $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
361
+        $result = array_reduce(array_splice($relationArray, 0, $length), function($obj, $method) {
362 362
             try {
363 363
                 $result = $obj->$method();
364 364
 
@@ -393,7 +393,7 @@  discard block
 block discarded – undo
393 393
             if (is_array($entries)) {
394 394
                 //if attribute does not exist in main array we have more than one entry OR the attribute
395 395
                 //is an acessor that is not in $appends property of model.
396
-                if (! isset($entries[$attribute])) {
396
+                if (!isset($entries[$attribute])) {
397 397
                     //we first check if we don't have the attribute because it's an acessor that is not in appends.
398 398
                     if ($model_instance->hasGetMutator($attribute) && isset($entries[$modelKey])) {
399 399
                         $entry_in_database = $model_instance->find($entries[$modelKey]);
@@ -432,21 +432,21 @@  discard block
 block discarded – undo
432 432
      */
433 433
     public function parseTranslatableAttributes($model, $attribute, $value)
434 434
     {
435
-        if (! method_exists($model, 'isTranslatableAttribute')) {
435
+        if (!method_exists($model, 'isTranslatableAttribute')) {
436 436
             return $value;
437 437
         }
438 438
 
439
-        if (! $model->isTranslatableAttribute($attribute)) {
439
+        if (!$model->isTranslatableAttribute($attribute)) {
440 440
             return $value;
441 441
         }
442 442
 
443
-        if (! is_array($value)) {
443
+        if (!is_array($value)) {
444 444
             $decodedAttribute = json_decode($value, true);
445 445
         } else {
446 446
             $decodedAttribute = $value;
447 447
         }
448 448
 
449
-        if (is_array($decodedAttribute) && ! empty($decodedAttribute)) {
449
+        if (is_array($decodedAttribute) && !empty($decodedAttribute)) {
450 450
             if (isset($decodedAttribute[app()->getLocale()])) {
451 451
                 return $decodedAttribute[app()->getLocale()];
452 452
             } else {
@@ -472,7 +472,7 @@  discard block
 block discarded – undo
472 472
         $relation = $model->{$firstRelationName};
473 473
 
474 474
         $results = [];
475
-        if (! is_null($relation)) {
475
+        if (!is_null($relation)) {
476 476
             if ($relation instanceof Collection) {
477 477
                 $currentResults = $relation->all();
478 478
             } elseif (is_array($relation)) {
@@ -485,7 +485,7 @@  discard block
 block discarded – undo
485 485
 
486 486
             array_shift($relationArray);
487 487
 
488
-            if (! empty($relationArray)) {
488
+            if (!empty($relationArray)) {
489 489
                 foreach ($currentResults as $currentResult) {
490 490
                     $results = array_merge_recursive($results, $this->getRelatedEntries($currentResult, implode('.', $relationArray)));
491 491
                 }
Please login to merge, or discard this patch.
src/app/Library/Database/DatabaseSchema.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -32,12 +32,12 @@  discard block
 block discarded – undo
32 32
      */
33 33
     private static function generateDatabaseSchema(string $connection, string $table)
34 34
     {
35
-        if (! isset(self::$schema[$connection])) {
35
+        if (!isset(self::$schema[$connection])) {
36 36
             $rawTables = DB::connection($connection)->getDoctrineSchemaManager()->createSchema();
37 37
             self::$schema[$connection] = self::mapTables($rawTables);
38 38
         } else {
39 39
             // check for a specific table in case it was created after schema had been generated.
40
-            if (! isset(self::$schema[$connection][$table])) {
40
+            if (!isset(self::$schema[$connection][$table])) {
41 41
                 self::$schema[$connection][$table] = DB::connection($connection)->getDoctrineSchemaManager()->listTableDetails($table);
42 42
             }
43 43
         }
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
      */
52 52
     private static function mapTables($rawTables)
53 53
     {
54
-        return LazyCollection::make($rawTables->getTables())->mapWithKeys(function ($table, $key) {
54
+        return LazyCollection::make($rawTables->getTables())->mapWithKeys(function($table, $key) {
55 55
             return [$table->getName() => $table];
56 56
         })->toArray();
57 57
     }
Please login to merge, or discard this patch.