Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Failed
Pull Request — main (#4778)
by Pedro
25:44 queued 10:58
created
src/app/Models/Traits/HasUploadFields.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
     {
81 81
         $originalModelValue = $this->getOriginal()[$attribute_name] ?? [];
82 82
 
83
-        if (! is_array($originalModelValue)) {
83
+        if (!is_array($originalModelValue)) {
84 84
             $attribute_value = json_decode($originalModelValue, true) ?? [];
85 85
         } else {
86 86
             $attribute_value = $originalModelValue;
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
         if ($files_to_clear) {
94 94
             foreach ($files_to_clear as $key => $filename) {
95 95
                 \Storage::disk($disk)->delete($filename);
96
-                $attribute_value = Arr::where($attribute_value, function ($value, $key) use ($filename) {
96
+                $attribute_value = Arr::where($attribute_value, function($value, $key) use ($filename) {
97 97
                     return $value != $filename;
98 98
                 });
99 99
             }
Please login to merge, or discard this patch.
src/app/Library/Widget.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
157 157
             }
158 158
         }
159 159
         $type = $this->type;
160
-        $paths = array_map(function ($item) use ($type) {
160
+        $paths = array_map(function($item) use ($type) {
161 161
             return $item.'.'.$type;
162 162
         }, ViewNamespaces::getWithFallbackFor('widgets', 'backpack.base.component_view_namespaces.widgets'));
163 163
 
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
             }
168 168
         }
169 169
         // if no view exists, in any of the directories above... no bueno
170
-        if (! backpack_pro()) {
170
+        if (!backpack_pro()) {
171 171
             throw new BackpackProRequiredException('Cannot find the widget view: '.$this->type.'. Please check for typos.'.(backpack_pro() ? '' : ' If you are trying to use a PRO widget, please first purchase and install the backpack/pro addon from backpackforlaravel.com'), 1);
172 172
         }
173 173
         abort(500, 'Cannot find the view for «'.$this->type.'» widget type. Please check for typos.');
@@ -253,7 +253,7 @@  discard block
 block discarded – undo
253 253
     {
254 254
         $itemExists = $this->collection()->contains('name', $this->attributes['name']);
255 255
 
256
-        if (! $itemExists) {
256
+        if (!$itemExists) {
257 257
             $this->collection()->put($this->attributes['name'], $this);
258 258
         } else {
259 259
             $this->collection()[$this->name] = $this;
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudButton.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -275,7 +275,7 @@  discard block
 block discarded – undo
275 275
     private function getViewPathsWithFallbacks()
276 276
     {
277 277
         $type = $this->name;
278
-        $paths = array_map(function ($item) use ($type) {
278
+        $paths = array_map(function($item) use ($type) {
279 279
             return $item.'.'.$type;
280 280
         }, ViewNamespaces::getFor('buttons'));
281 281
 
@@ -441,7 +441,7 @@  discard block
 block discarded – undo
441 441
     {
442 442
         $itemExists = $this->collection()->contains('name', $this->name);
443 443
 
444
-        if (! $itemExists) {
444
+        if (!$itemExists) {
445 445
             if ($this->position == 'beginning') {
446 446
                 $this->collection()->prepend($this);
447 447
             } else {
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudColumn.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@
 block discarded – undo
75 75
      */
76 76
     public function key(string $key)
77 77
     {
78
-        if (! isset($this->attributes['name'])) {
78
+        if (!isset($this->attributes['name'])) {
79 79
             abort(500, 'Column name must be defined before changing the key.');
80 80
         }
81 81
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Update.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
         }
48 48
 
49 49
         // always have a hidden input for the entry id
50
-        if (! array_key_exists('id', $fields)) {
50
+        if (!array_key_exists('id', $fields)) {
51 51
             $fields['id'] = [
52 52
                 'name'  => $entry->getKeyName(),
53 53
                 'value' => $entry->getKey(),
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
         $fieldEntity = $field['entity'] ?? false;
73 73
         $fakeField = $field['fake'] ?? false;
74 74
 
75
-        if ($fieldEntity && ! $fakeField) {
75
+        if ($fieldEntity && !$fakeField) {
76 76
             return $this->getModelAttributeValueFromRelationship($model, $field);
77 77
         }
78 78
 
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
     {
103 103
         [$relatedModel, $relationMethod] = $this->getModelAndMethodFromEntity($model, $field);
104 104
 
105
-        if (! method_exists($relatedModel, $relationMethod)) {
105
+        if (!method_exists($relatedModel, $relationMethod)) {
106 106
             return $relatedModel->{$relationMethod};
107 107
         }
108 108
 
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
                     $model = $this->setupRelatedModelLocale($model);
122 122
                     // when subfields are NOT set we don't need to get any more values
123 123
                     // we just return the plain models as we only need the ids
124
-                    if (! isset($field['subfields'])) {
124
+                    if (!isset($field['subfields'])) {
125 125
                         $result->push($model);
126 126
                         continue;
127 127
                     }
@@ -148,13 +148,13 @@  discard block
 block discarded – undo
148 148
                 break;
149 149
             case 'HasOne':
150 150
             case 'MorphOne':
151
-                if (! method_exists($relatedModel, $relationMethod)) {
151
+                if (!method_exists($relatedModel, $relationMethod)) {
152 152
                     return;
153 153
                 }
154 154
 
155 155
                 $model = $relatedModel->{$relationMethod};
156 156
 
157
-                if (! $model) {
157
+                if (!$model) {
158 158
                     return;
159 159
                 }
160 160
 
@@ -235,7 +235,7 @@  discard block
 block discarded – undo
235 235
 
236 236
         $relationArray = explode('.', $relationEntity);
237 237
 
238
-        $relatedModel = array_reduce(array_splice($relationArray, 0, -1), function ($obj, $method) {
238
+        $relatedModel = array_reduce(array_splice($relationArray, 0, -1), function($obj, $method) {
239 239
             // if the string ends with `_id` we strip it out
240 240
             $method = Str::endsWith($method, '_id') ? Str::replaceLast('_id', '', $method) : $method;
241 241
 
@@ -262,7 +262,7 @@  discard block
 block discarded – undo
262 262
             // if the subfield name does not contain a dot we just need to check
263 263
             // if it has subfields and return the result accordingly.
264 264
             foreach ((array) $subfield['name'] as $name) {
265
-                if (! Str::contains($name, '.')) {
265
+                if (!Str::contains($name, '.')) {
266 266
                     // when subfields are present, $relatedModel->{$name} returns a model instance
267 267
                     // otherwise returns the model attribute.
268 268
                     if ($relatedModel->{$name}) {
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/SaveActions.php 1 patch
Spacing   +16 added lines, -17 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
         $higherAction = $this->getSaveActionByOrder(1);
29 29
 
30 30
         //if there is an higher action and that action is not the backpack default higher one `save_and_back` we return it.
31
-        if (! empty($higherAction) && key($higherAction) !== 'save_and_back') {
31
+        if (!empty($higherAction) && key($higherAction) !== 'save_and_back') {
32 32
             return key($higherAction);
33 33
         }
34 34
 
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
      */
48 48
     public function getSaveActionByOrder($order)
49 49
     {
50
-        return array_filter($this->getOperationSetting('save_actions'), function ($arr) use ($order) {
50
+        return array_filter($this->getOperationSetting('save_actions'), function($arr) use ($order) {
51 51
             return $arr['order'] == $order;
52 52
         });
53 53
     }
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
         $orderCounter = $this->getOperationSetting('save_actions') !== null ? (count($this->getOperationSetting('save_actions')) + 1) : 1;
82 82
         //check for some mandatory fields
83 83
         $saveAction['name'] ?? abort(500, 'Please define save action name.');
84
-        $saveAction['redirect'] = $saveAction['redirect'] ?? function ($crud, $request, $itemId) {
84
+        $saveAction['redirect'] = $saveAction['redirect'] ?? function($crud, $request, $itemId) {
85 85
             return $request->has('_http_referrer') ? $request->get('_http_referrer') : $crud->route;
86 86
         };
87 87
         $saveAction['visible'] = $saveAction['visible'] ?? true;
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
 
91 91
         $actions = $this->getOperationSetting('save_actions') ?? [];
92 92
 
93
-        if (! in_array($saveAction['name'], $actions)) {
93
+        if (!in_array($saveAction['name'], $actions)) {
94 94
             $actions[$saveAction['name']] = $saveAction;
95 95
         }
96 96
 
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
     public function orderSaveAction(string $saveAction, int $wantedOrder)
108 108
     {
109 109
         $actions = $this->getOperationSetting('save_actions') ?? [];
110
-        if (! empty($actions)) {
110
+        if (!empty($actions)) {
111 111
             $replaceOrder = isset($actions[$saveAction]) ? $actions[$saveAction]['order'] : count($actions) + 1;
112 112
 
113 113
             foreach ($actions as $key => $sv) {
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
     public function orderSaveActions(array $saveActions)
202 202
     {
203 203
         foreach ($saveActions as $sv => $order) {
204
-            if (! is_int($order)) {
204
+            if (!is_int($order)) {
205 205
                 $this->orderSaveAction($order, $sv + 1);
206 206
             } else {
207 207
                 $this->orderSaveAction($sv, $order);
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
     {
219 219
         $actions = $this->getOperationSetting('save_actions') ?? [];
220 220
 
221
-        uasort($actions, function ($a, $b) {
221
+        uasort($actions, function($a, $b) {
222 222
             return $a['order'] <=> $b['order'];
223 223
         });
224 224
 
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
240 240
             }
241 241
         }
242 242
 
243
-        return array_filter($actions, function ($action) {
243
+        return array_filter($actions, function($action) {
244 244
             return $action['visible'] == true;
245 245
         }, ARRAY_FILTER_USE_BOTH);
246 246
     }
@@ -303,8 +303,7 @@  discard block
 block discarded – undo
303 303
      */
304 304
     public function setSaveAction($forceSaveAction = null)
305 305
     {
306
-        $saveAction = $forceSaveAction ?:
307
-            \Request::input('_save_action', $this->getFallBackSaveAction());
306
+        $saveAction = $forceSaveAction ?: \Request::input('_save_action', $this->getFallBackSaveAction());
308 307
 
309 308
         $showBubble = $this->getOperationSetting('showSaveActionChange') ?? config('backpack.crud.operations.'.$this->getCurrentOperation().'.showSaveActionChange') ?? true;
310 309
 
@@ -371,20 +370,20 @@  discard block
 block discarded – undo
371 370
         $defaultSaveActions = [
372 371
             [
373 372
                 'name' => 'save_and_back',
374
-                'visible' => function ($crud) {
373
+                'visible' => function($crud) {
375 374
                     return $crud->hasAccess('list');
376 375
                 },
377
-                'redirect' => function ($crud, $request, $itemId = null) {
376
+                'redirect' => function($crud, $request, $itemId = null) {
378 377
                     return $request->request->has('_http_referrer') ? $request->request->get('_http_referrer') : $crud->route;
379 378
                 },
380 379
                 'button_text' => trans('backpack::crud.save_action_save_and_back'),
381 380
             ],
382 381
             [
383 382
                 'name' => 'save_and_edit',
384
-                'visible' => function ($crud) {
383
+                'visible' => function($crud) {
385 384
                     return $crud->hasAccess('update');
386 385
                 },
387
-                'redirect' => function ($crud, $request, $itemId = null) {
386
+                'redirect' => function($crud, $request, $itemId = null) {
388 387
                     $itemId = $itemId ?: $request->request->get('id');
389 388
                     $redirectUrl = $crud->route.'/'.$itemId.'/edit';
390 389
                     if ($request->request->has('_locale')) {
@@ -396,17 +395,17 @@  discard block
 block discarded – undo
396 395
 
397 396
                     return $redirectUrl;
398 397
                 },
399
-                'referrer_url' => function ($crud, $request, $itemId) {
398
+                'referrer_url' => function($crud, $request, $itemId) {
400 399
                     return url($crud->route.'/'.$itemId.'/edit');
401 400
                 },
402 401
                 'button_text' => trans('backpack::crud.save_action_save_and_edit'),
403 402
             ],
404 403
             [
405 404
                 'name' => 'save_and_new',
406
-                'visible' => function ($crud) {
405
+                'visible' => function($crud) {
407 406
                     return $crud->hasAccess('create');
408 407
                 },
409
-                'redirect' => function ($crud, $request, $itemId = null) {
408
+                'redirect' => function($crud, $request, $itemId = null) {
410 409
                     return $this->route.'/create';
411 410
                 },
412 411
                 'button_text' => trans('backpack::crud.save_action_save_and_new'),
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Create.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
                     // - a single dimensional array: [1,2,3]
112 112
                     // - an array of arrays: [[1][2][3]]
113 113
                     // if is as single dimensional array we can only attach.
114
-                    if ($relationValues === null || ! is_multidimensional_array($relationValues)) {
114
+                    if ($relationValues === null || !is_multidimensional_array($relationValues)) {
115 115
                         $this->attachManyRelation($item, $relation, $relationDetails, $relationValues);
116 116
                     } else {
117 117
                         $this->createManyEntries($item, $relation, $relationMethod, $relationDetails);
@@ -275,7 +275,7 @@  discard block
 block discarded – undo
275 275
 
276 276
         // if column is not nullable in database, and there is no column default (null),
277 277
         // we will delete the entry from the database, otherwise it will throw and ugly DB error.
278
-        if (! $relationColumnIsNullable && $dbColumnDefault === null) {
278
+        if (!$relationColumnIsNullable && $dbColumnDefault === null) {
279 279
             return $removedEntries->lazy()->each->delete();
280 280
         }
281 281
 
@@ -320,7 +320,7 @@  discard block
 block discarded – undo
320 320
         }
321 321
 
322 322
         // use the collection of sent ids to match against database ids, delete the ones not found in the submitted ids.
323
-        if (! empty($relatedItemsSent)) {
323
+        if (!empty($relatedItemsSent)) {
324 324
             // we perform the cleanup of removed database items
325 325
             $entry->{$relationMethod}()->whereNotIn($relatedModelLocalKey, $relatedItemsSent)->lazy()->each->delete();
326 326
         }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/FieldsProtectedMethods.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
      */
70 70
     public function overwriteFieldNameFromDotNotationToArray($field)
71 71
     {
72
-        if (! is_array($field['name']) && strpos($field['name'], '.') !== false) {
72
+        if (!is_array($field['name']) && strpos($field['name'], '.') !== false) {
73 73
             $entity_array = explode('.', $field['name']);
74 74
             $name_string = '';
75 75
 
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
             return ['name' => $field];
116 116
         }
117 117
 
118
-        if (is_array($field) && ! isset($field['name'])) {
118
+        if (is_array($field) && !isset($field['name'])) {
119 119
             abort(500, 'All fields must have their name defined');
120 120
         }
121 121
 
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
         }
193 193
         // if there's a model defined, but no attribute
194 194
         // guess an attribute using the identifiableAttribute functionality in CrudTrait
195
-        if (isset($field['model']) && ! isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
195
+        if (isset($field['model']) && !isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
196 196
             $field['attribute'] = (new $field['model']())->identifiableAttribute();
197 197
         }
198 198
 
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
208 208
      */
209 209
     protected function makeSureFieldHasLabel($field)
210 210
     {
211
-        if (! isset($field['label'])) {
211
+        if (!isset($field['label'])) {
212 212
             $name = is_array($field['name']) ? $field['name'][0] : $field['name'];
213 213
             $name = str_replace('_id', '', $name);
214 214
             $field['label'] = mb_ucfirst(str_replace('_', ' ', $name));
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
226 226
      */
227 227
     protected function makeSureFieldHasType($field)
228 228
     {
229
-        if (! isset($field['type'])) {
229
+        if (!isset($field['type'])) {
230 230
             $field['type'] = isset($field['relation_type']) ? $this->inferFieldTypeFromRelationType($field['relation_type']) : $this->inferFieldTypeFromDbColumnType($field['name']);
231 231
         }
232 232
 
@@ -263,7 +263,7 @@  discard block
 block discarded – undo
263 263
      */
264 264
     protected function makeSureSubfieldsHaveNecessaryAttributes($field)
265 265
     {
266
-        if (! isset($field['subfields'])) {
266
+        if (!isset($field['subfields'])) {
267 267
             return $field;
268 268
         }
269 269
 
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
 
280 280
             $subfield['parentFieldName'] = is_array($field['name']) ? false : $field['name'];
281 281
 
282
-            if (! isset($field['model'])) {
282
+            if (!isset($field['model'])) {
283 283
                 // we're inside a simple 'repeatable' with no model/relationship, so
284 284
                 // we assume all subfields are supposed to be text fields
285 285
                 $subfield['type'] = $subfield['type'] ?? 'text';
@@ -331,7 +331,7 @@  discard block
 block discarded – undo
331 331
     {
332 332
         // if a tab was mentioned, we should enable it
333 333
         if (isset($field['tab'])) {
334
-            if (! $this->tabsEnabled()) {
334
+            if (!$this->tabsEnabled()) {
335 335
                 $this->enableTabs();
336 336
             }
337 337
         }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Views.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -299,7 +299,7 @@  discard block
 block discarded – undo
299 299
         }
300 300
         // otherwise, loop through all the possible view namespaces
301 301
         // until you find a view that exists
302
-        $paths = array_map(function ($item) use ($viewPath) {
302
+        $paths = array_map(function($item) use ($viewPath) {
303 303
             return $item.'.'.$viewPath;
304 304
         }, ViewNamespaces::getFor('fields'));
305 305
 
@@ -310,7 +310,7 @@  discard block
 block discarded – undo
310 310
         }
311 311
 
312 312
         // if no view exists, in any of the directories above... no bueno
313
-        if (! backpack_pro()) {
313
+        if (!backpack_pro()) {
314 314
             throw new BackpackProRequiredException('Cannot find the field view: '.$viewPath.'. Please check for typos.'.(backpack_pro() ? '' : ' If you are trying to use a PRO field, please first purchase and install the backpack/pro addon from backpackforlaravel.com'), 1);
315 315
         }
316 316
         abort(500, "Cannot find '{$viewPath}' field view in any of the regular locations.");
Please login to merge, or discard this patch.