Backpack\CRUD\Tests\Unit\CrudPanel\CrudPanelMacroTest

Complexity

Total Complexity

3

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	testThrowsErrorIfMacroExists()	0	11	2
A	testItCanRegisterMacro()	0	7	1

<?php

namespace Backpack\CRUD\Tests\Unit\CrudPanel;

/**
 * @covers Backpack\CRUD\app\Library\CrudPanel\Traits\Macroable
 */
class CrudPanelMacroTest extends BaseCrudPanelTest
{
    public function testItCanRegisterMacro()
    {
        $this->crudPanel::macro('validMacro', function () {
            return true;
        });

        $this->assertTrue($this->crudPanel->validMacro());

The method validMacro() does not exist on Backpack\CRUD\app\Library\CrudPanel\CrudPanel. Since you implemented __call, consider adding a @method annotation.

    }

    public function testThrowsErrorIfMacroExists()
    {
        try {
            $this->crudPanel::macro('setModel', function () {
                return true;
            });
        } catch (\Throwable $e) {

Consider adding a comment why this CATCH block is empty.

        }
        $this->assertEquals(
          new \Symfony\Component\HttpKernel\Exception\HttpException(500, 'Cannot register \'setModel\' macro. \'setModel()\' already exists on Backpack\CRUD\app\Library\CrudPanel\CrudPanel'),
          $e

The variable $e does not seem to be defined for all execution paths leading up to this point.

      );
    }
}