Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Failed
Push — update-column-priority-on-move ( f811f1 )
by Pedro
14:10
created
src/app/Library/CrudPanel/Traits/SaveActions.php 1 patch
Spacing   +15 added lines, -16 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
         $higherAction = $this->getSaveActionByOrder(1);
29 29
 
30 30
         //if there is an higher action and that action is not the backpack default higher one `save_and_back` we return it.
31
-        if (! empty($higherAction) && key($higherAction) !== 'save_and_back') {
31
+        if (!empty($higherAction) && key($higherAction) !== 'save_and_back') {
32 32
             return key($higherAction);
33 33
         }
34 34
 
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
      */
48 48
     public function getSaveActionByOrder($order)
49 49
     {
50
-        return array_filter($this->getOperationSetting('save_actions') ?? [], function ($arr) use ($order) {
50
+        return array_filter($this->getOperationSetting('save_actions') ?? [], function($arr) use ($order) {
51 51
             return $arr['order'] == $order;
52 52
         });
53 53
     }
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
 
89 89
         $actions = $this->getOperationSetting('save_actions') ?? [];
90 90
 
91
-        if (! in_array($saveAction['name'], $actions)) {
91
+        if (!in_array($saveAction['name'], $actions)) {
92 92
             $actions[$saveAction['name']] = $saveAction;
93 93
         }
94 94
 
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
     public function orderSaveAction(string $saveAction, int $wantedOrder)
106 106
     {
107 107
         $actions = $this->getOperationSetting('save_actions') ?? [];
108
-        if (! empty($actions)) {
108
+        if (!empty($actions)) {
109 109
             $replaceOrder = isset($actions[$saveAction]) ? $actions[$saveAction]['order'] : count($actions) + 1;
110 110
 
111 111
             foreach ($actions as $key => $sv) {
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
199 199
     public function orderSaveActions(array $saveActions)
200 200
     {
201 201
         foreach ($saveActions as $sv => $order) {
202
-            if (! is_int($order)) {
202
+            if (!is_int($order)) {
203 203
                 $this->orderSaveAction($order, $sv + 1);
204 204
             } else {
205 205
                 $this->orderSaveAction($sv, $order);
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
     {
217 217
         $actions = $this->getOperationSetting('save_actions') ?? [];
218 218
 
219
-        uasort($actions, function ($a, $b) {
219
+        uasort($actions, function($a, $b) {
220 220
             return $a['order'] <=> $b['order'];
221 221
         });
222 222
 
@@ -238,7 +238,7 @@  discard block
 block discarded – undo
238 238
             }
239 239
         }
240 240
 
241
-        return array_filter($actions, function ($action) {
241
+        return array_filter($actions, function($action) {
242 242
             return $action['visible'] == true;
243 243
         }, ARRAY_FILTER_USE_BOTH);
244 244
     }
@@ -300,8 +300,7 @@  discard block
 block discarded – undo
300 300
      */
301 301
     public function setSaveAction($forceSaveAction = null)
302 302
     {
303
-        $saveAction = $forceSaveAction ?:
304
-            $this->getRequest()->input('_save_action', $this->getFallBackSaveAction());
303
+        $saveAction = $forceSaveAction ?: $this->getRequest()->input('_save_action', $this->getFallBackSaveAction());
305 304
 
306 305
         $showBubble = $this->getOperationSetting('showSaveActionChange') ?? config('backpack.crud.operations.'.$this->getCurrentOperation().'.showSaveActionChange') ?? true;
307 306
 
@@ -369,20 +368,20 @@  discard block
 block discarded – undo
369 368
         $defaultSaveActions = [
370 369
             [
371 370
                 'name' => 'save_and_back',
372
-                'visible' => function ($crud) {
371
+                'visible' => function($crud) {
373 372
                     return $crud->hasAccess('list');
374 373
                 },
375
-                'redirect' => function ($crud, $request, $itemId = null) {
374
+                'redirect' => function($crud, $request, $itemId = null) {
376 375
                     return $request->has('_http_referrer') ? $request->get('_http_referrer') : $crud->route;
377 376
                 },
378 377
                 'button_text' => trans('backpack::crud.save_action_save_and_back'),
379 378
             ],
380 379
             [
381 380
                 'name' => 'save_and_edit',
382
-                'visible' => function ($crud) {
381
+                'visible' => function($crud) {
383 382
                     return $crud->hasAccess('update');
384 383
                 },
385
-                'redirect' => function ($crud, $request, $itemId = null) {
384
+                'redirect' => function($crud, $request, $itemId = null) {
386 385
                     $itemId = $itemId ?: $request->get('id');
387 386
                     $redirectUrl = $crud->route.'/'.$itemId.'/edit';
388 387
                     if ($request->has('_locale')) {
@@ -394,17 +393,17 @@  discard block
 block discarded – undo
394 393
 
395 394
                     return $redirectUrl;
396 395
                 },
397
-                'referrer_url' => function ($crud, $request, $itemId) {
396
+                'referrer_url' => function($crud, $request, $itemId) {
398 397
                     return url($crud->route.'/'.$itemId.'/edit');
399 398
                 },
400 399
                 'button_text' => trans('backpack::crud.save_action_save_and_edit'),
401 400
             ],
402 401
             [
403 402
                 'name' => 'save_and_new',
404
-                'visible' => function ($crud) {
403
+                'visible' => function($crud) {
405 404
                     return $crud->hasAccess('create');
406 405
                 },
407
-                'redirect' => function ($crud, $request, $itemId = null) {
406
+                'redirect' => function($crud, $request, $itemId = null) {
408 407
                     return $this->route.'/create';
409 408
                 },
410 409
                 'button_text' => trans('backpack::crud.save_action_save_and_new'),
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelCreateTest.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -818,7 +818,7 @@  discard block
 block discarded – undo
818 818
 
819 819
     public function testCreateBelongsToFake()
820 820
     {
821
-        $belongsToField = [   // select_grouped
821
+        $belongsToField = [// select_grouped
822 822
             'label' => 'Select_grouped',
823 823
             'type' => 'select_grouped', //https://github.com/Laravel-Backpack/CRUD/issues/502
824 824
             'name' => 'bang_relation_field',
@@ -954,7 +954,7 @@  discard block
 block discarded – undo
954 954
                 'nickname' => 'i_have_has_one',
955 955
                 'profile_picture' => 'ohh my picture 1.jpg',
956 956
                 'article' => 1,
957
-                'addresses' => [ // HasOne is tested in other test function
957
+                'addresses' => [// HasOne is tested in other test function
958 958
                     [
959 959
                         'city' => 2,
960 960
                         'street' => 'test',
@@ -1707,23 +1707,23 @@  discard block
 block discarded – undo
1707 1707
         $this->crudPanel->addField([
1708 1708
             'name' => 'name',
1709 1709
             'events' => [
1710
-                'created' => function ($entry) {
1710
+                'created' => function($entry) {
1711 1711
                 },
1712
-                'creating' => function ($entry) {
1712
+                'creating' => function($entry) {
1713 1713
                     $entry->email = '[email protected]';
1714 1714
                     $entry->password = Hash::make('password');
1715 1715
                 },
1716
-                'saving' => function ($entry) {
1716
+                'saving' => function($entry) {
1717 1717
                 },
1718
-                'saved' => function ($entry) {
1718
+                'saved' => function($entry) {
1719 1719
                 },
1720
-                'updating' => function ($entry) {
1720
+                'updating' => function($entry) {
1721 1721
                 },
1722
-                'updated' => function ($entry) {
1722
+                'updated' => function($entry) {
1723 1723
                 },
1724
-                'deleting' => function ($entry) {
1724
+                'deleting' => function($entry) {
1725 1725
                 },
1726
-                'deleted' => function ($entry) {
1726
+                'deleted' => function($entry) {
1727 1727
                 },
1728 1728
             ],
1729 1729
         ]);
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelSearchTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
         $this->crudPanel->addColumn([
91 91
             'name' => 'test',
92 92
             'type' => 'my_custom_type',
93
-            'searchLogic' => function ($query, $column, $searchTerm) {
93
+            'searchLogic' => function($query, $column, $searchTerm) {
94 94
                 $query->where($column['name'], 'like', "%{$searchTerm}%");
95 95
             },
96 96
             'tableColumn' => true,
@@ -225,7 +225,7 @@  discard block
 block discarded – undo
225 225
             'name' => 'name',
226 226
             'type' => 'text',
227 227
             'tableColumn' => true,
228
-            'orderLogic' => function ($query, $column, $searchTerm) {
228
+            'orderLogic' => function($query, $column, $searchTerm) {
229 229
                 $query->orderBy('name', 'asc');
230 230
             },
231 231
         ]);
@@ -244,7 +244,7 @@  discard block
 block discarded – undo
244 244
             'name' => 'name',
245 245
             'type' => 'text',
246 246
             'tableColumn' => true,
247
-            'orderLogic' => function ($query, $column, $searchTerm) {
247
+            'orderLogic' => function($query, $column, $searchTerm) {
248 248
                 $query->orderBy('id', 'asc');
249 249
             },
250 250
         ]);
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/ColumnsProtectedMethods.php 1 patch
Spacing   +9 added lines, -10 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
             return ['name' => Str::replace(' ', '', $column)];
51 51
         }
52 52
 
53
-        if (is_array($column) && ! isset($column['name'])) {
53
+        if (is_array($column) && !isset($column['name'])) {
54 54
             $column['name'] = 'anonymous_column_'.Str::random(5);
55 55
         }
56 56
 
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
      */
69 69
     protected function makeSureColumnHasLabel($column)
70 70
     {
71
-        if (! isset($column['label'])) {
71
+        if (!isset($column['label'])) {
72 72
             $column['label'] = mb_ucfirst($this->makeLabel($column['name']));
73 73
         }
74 74
 
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
      */
154 154
     protected function makeSureColumnHasKey($column)
155 155
     {
156
-        if (! isset($column['key'])) {
156
+        if (!isset($column['key'])) {
157 157
             $column['key'] = str_replace('.', '__', $column['name']);
158 158
         }
159 159
 
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
      */
171 171
     protected function makeSureColumnHasWrapper($column)
172 172
     {
173
-        if (! isset($column['wrapper'])) {
173
+        if (!isset($column['wrapper'])) {
174 174
             $column['wrapper'] = [];
175 175
         }
176 176
 
@@ -255,7 +255,7 @@  discard block
 block discarded – undo
255 255
     {
256 256
         // if this is a relation type field and no corresponding model was specified,
257 257
         // get it from the relation method defined in the main model
258
-        if (isset($column['entity']) && $column['entity'] !== false && ! isset($column['model'])) {
258
+        if (isset($column['entity']) && $column['entity'] !== false && !isset($column['model'])) {
259 259
             $column['model'] = $this->getRelationModel($column['entity']);
260 260
         }
261 261
 
@@ -292,12 +292,11 @@  discard block
 block discarded – undo
292 292
         $columnsArray = $this->columns();
293 293
 
294 294
         if (array_key_exists($targetColumnName, $columnsArray)) {
295
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) :
296
-                array_search($targetColumnName, array_keys($columnsArray)) + 1;
295
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) : array_search($targetColumnName, array_keys($columnsArray)) + 1;
297 296
 
298 297
             $element = array_pop($columnsArray);
299 298
 
300
-            if($element['priority'] === count($columnsArray)) {
299
+            if ($element['priority'] === count($columnsArray)) {
301 300
                 // the priority was most likely auto-set as it corresponds to the column array count
302 301
                 // update the priority to the target column position
303 302
                 $element['priority'] = $targetColumnPosition;
@@ -322,7 +321,7 @@  discard block
 block discarded – undo
322 321
     {
323 322
         static $cache = [];
324 323
 
325
-        if (! $this->driverIsSql()) {
324
+        if (!$this->driverIsSql()) {
326 325
             return true;
327 326
         }
328 327
 
@@ -338,7 +337,7 @@  discard block
 block discarded – undo
338 337
     /**
339 338
      * Prepare the column attributes and add it to operation settings.
340 339
      */
341
-    private function prepareAttributesAndAddColumn(array|string $column): CrudColumn
340
+    private function prepareAttributesAndAddColumn(array | string $column): CrudColumn
342 341
     {
343 342
         $column = $this->makeSureColumnHasNeededAttributes($column);
344 343
         $this->addColumnToOperationSettings($column);
Please login to merge, or discard this patch.