Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — main (#5646)
by Pedro
14:42
created
src/app/Library/CrudPanel/Traits/Update.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
         }
59 59
 
60 60
         // always have a hidden input for the entry id
61
-        if (! array_key_exists('id', $fields)) {
61
+        if (!array_key_exists('id', $fields)) {
62 62
             $fields['id'] = [
63 63
                 'name' => $entry->getKeyName(),
64 64
                 'value' => $entry->getKey(),
@@ -83,12 +83,12 @@  discard block
 block discarded – undo
83 83
         $fieldEntity = $field['entity'] ?? false;
84 84
         $fakeField = $field['fake'] ?? false;
85 85
 
86
-        if ($fieldEntity && ! $fakeField) {
86
+        if ($fieldEntity && !$fakeField) {
87 87
             return $this->getModelAttributeValueFromRelationship($model, $field);
88 88
         }
89 89
 
90 90
         if ($this->holdsMultipleInputs($field['name'])) {
91
-            $result = array_map(function ($item) use ($model) {
91
+            $result = array_map(function($item) use ($model) {
92 92
                 return $model->{$item};
93 93
             }, explode(',', $field['name']));
94 94
 
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
     {
111 111
         [$relatedModel, $relationMethod] = $this->getModelAndMethodFromEntity($model, $field);
112 112
 
113
-        if (! method_exists($relatedModel, $relationMethod) && ! $relatedModel->isRelation($relationMethod)) {
113
+        if (!method_exists($relatedModel, $relationMethod) && !$relatedModel->isRelation($relationMethod)) {
114 114
             return $relatedModel->{$relationMethod};
115 115
         }
116 116
 
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
                     $model = $this->setLocaleOnModel($model);
130 130
                     // when subfields are NOT set we don't need to get any more values
131 131
                     // we just return the plain models as we only need the ids
132
-                    if (! isset($field['subfields'])) {
132
+                    if (!isset($field['subfields'])) {
133 133
                         $result->push($model);
134 134
 
135 135
                         continue;
@@ -157,13 +157,13 @@  discard block
 block discarded – undo
157 157
                 break;
158 158
             case 'HasOne':
159 159
             case 'MorphOne':
160
-                if (! method_exists($relatedModel, $relationMethod) && ! $relatedModel->isRelation($relationMethod)) {
160
+                if (!method_exists($relatedModel, $relationMethod) && !$relatedModel->isRelation($relationMethod)) {
161 161
                     return;
162 162
                 }
163 163
 
164 164
                 $model = $relatedModel->{$relationMethod};
165 165
 
166
-                if (! $model) {
166
+                if (!$model) {
167 167
                     return;
168 168
                 }
169 169
 
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
226 226
 
227 227
         $relationArray = explode('.', $relationEntity);
228 228
 
229
-        $relatedModel = array_reduce(array_splice($relationArray, 0, -1), function ($obj, $method) {
229
+        $relatedModel = array_reduce(array_splice($relationArray, 0, -1), function($obj, $method) {
230 230
             // if the string ends with `_id` we strip it out
231 231
             $method = Str::endsWith($method, '_id') ? Str::replaceLast('_id', '', $method) : $method;
232 232
 
@@ -253,7 +253,7 @@  discard block
 block discarded – undo
253 253
             // if the subfield name does not contain a dot we just need to check
254 254
             // if it has subfields and return the result accordingly.
255 255
             foreach ((array) $subfield['name'] as $name) {
256
-                if (! Str::contains($name, '.')) {
256
+                if (!Str::contains($name, '.')) {
257 257
                     // when subfields are present, $relatedModel->{$name} returns a model instance
258 258
                     // otherwise returns the model attribute.
259 259
                     if ($relatedModel->{$name} && isset($subfield['subfields'])) {
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Relationships.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
         $model = $this->getRelationModel($entity, -1);
66 66
         $lastSegmentAfterDot = Str::of($field['entity'])->afterLast('.');
67 67
 
68
-        if (! method_exists($model, $lastSegmentAfterDot)) {
68
+        if (!method_exists($model, $lastSegmentAfterDot)) {
69 69
             return (string) Str::of($field['entity'])->beforeLast('.');
70 70
         }
71 71
 
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
 
87 87
         return collect($this->getCleanStateFields())
88 88
             ->whereIn('relation_type', $relation_types)
89
-            ->filter(function ($item) use ($nested) {
89
+            ->filter(function($item) use ($nested) {
90 90
                 if ($nested) {
91 91
                     return true;
92 92
                 }
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
130 130
      */
131 131
     private function getRelationFieldsWithoutRelationType($relations, $fields = [])
132 132
     {
133
-        if (! is_array($relations)) {
133
+        if (!is_array($relations)) {
134 134
             $relations = [$relations];
135 135
         }
136 136
 
@@ -139,8 +139,8 @@  discard block
 block discarded – undo
139 139
         }
140 140
 
141 141
         foreach ($relations as $relation) {
142
-            $fields = array_filter($fields, function ($field) use ($relation) {
143
-                if (! isset($field['relation_type'])) {
142
+            $fields = array_filter($fields, function($field) use ($relation) {
143
+                if (!isset($field['relation_type'])) {
144 144
                     return false;
145 145
                 }
146 146
 
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
174 174
                     $fields = array_merge($field['subfields'], $fields);
175 175
                 }
176 176
             }
177
-            $fields = array_filter($fields, function ($field) {
177
+            $fields = array_filter($fields, function($field) {
178 178
                 return isset($field['relation_type']) && $field['relation_type'] === 'BelongsTo';
179 179
             });
180 180
         }
@@ -241,8 +241,8 @@  discard block
 block discarded – undo
241 241
     {
242 242
         $all_relation_fields = $this->getRelationFields();
243 243
 
244
-        return Arr::where($all_relation_fields, function ($value, $key) {
245
-            return isset($value['pivot']) && ! $value['pivot'];
244
+        return Arr::where($all_relation_fields, function($value, $key) {
245
+            return isset($value['pivot']) && !$value['pivot'];
246 246
         });
247 247
     }
248 248
 
@@ -255,7 +255,7 @@  discard block
 block discarded – undo
255 255
     {
256 256
         $all_relation_fields = $this->getRelationFields();
257 257
 
258
-        return Arr::where($all_relation_fields, function ($value, $key) {
258
+        return Arr::where($all_relation_fields, function($value, $key) {
259 259
             return isset($value['pivot']) && $value['pivot'];
260 260
         });
261 261
     }
@@ -325,7 +325,7 @@  discard block
 block discarded – undo
325 325
      */
326 326
     private function modelMethodIsRelationship($model, $method)
327 327
     {
328
-        if (! method_exists($model, $method) && $model->isRelation($method)) {
328
+        if (!method_exists($model, $method) && $model->isRelation($method)) {
329 329
             return $method;
330 330
         }
331 331
 
@@ -337,7 +337,7 @@  discard block
 block discarded – undo
337 337
         }
338 338
 
339 339
         // relationships are always public methods.
340
-        if (! $methodReflection->isPublic()) {
340
+        if (!$methodReflection->isPublic()) {
341 341
             return false;
342 342
         }
343 343
 
@@ -364,7 +364,7 @@  discard block
 block discarded – undo
364 364
      */
365 365
     public function isAttributeInRelationString(array $field): bool
366 366
     {
367
-        if (! str_contains($field['entity'], '.')) {
367
+        if (!str_contains($field['entity'], '.')) {
368 368
             return false;
369 369
         }
370 370
 
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelCreateTest.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
 
170 170
     public function testCreateWithOneToOneDynamicRelationship()
171 171
     {
172
-        User::resolveRelationUsing('dynamicRelation', function ($user) {
172
+        User::resolveRelationUsing('dynamicRelation', function($user) {
173 173
             return $user->hasOne(\Backpack\CRUD\Tests\config\Models\AccountDetails::class);
174 174
         });
175 175
         $this->crudPanel->setModel(User::class);
@@ -280,7 +280,7 @@  discard block
 block discarded – undo
280 280
 
281 281
     public function testCreateWithOneToManyDynamicRelationship()
282 282
     {
283
-        Article::resolveRelationUsing('dynamicRelation', function ($article) {
283
+        Article::resolveRelationUsing('dynamicRelation', function($article) {
284 284
             return $article->belongsTo(\Backpack\CRUD\Tests\config\Models\User::class, 'user_id');
285 285
         });
286 286
 
@@ -343,7 +343,7 @@  discard block
 block discarded – undo
343 343
 
344 344
     public function testCreateWithManyToManyDynamicRelationship()
345 345
     {
346
-        User::resolveRelationUsing('dynamicRelation', function ($user) {
346
+        User::resolveRelationUsing('dynamicRelation', function($user) {
347 347
             return $user->belongsToMany(\Backpack\CRUD\Tests\config\Models\Role::class, 'user_role');
348 348
         });
349 349
 
@@ -685,7 +685,7 @@  discard block
 block discarded – undo
685 685
 
686 686
     public function testBelongsToManyWithPivotDataDynamicRelationship()
687 687
     {
688
-        User::resolveRelationUsing('dynamicRelation', function ($user) {
688
+        User::resolveRelationUsing('dynamicRelation', function($user) {
689 689
             return $user->belongsToMany(\Backpack\CRUD\Tests\config\Models\Article::class, 'articles_user')->withPivot(['notes', 'start_date', 'end_date']);
690 690
         });
691 691
 
@@ -794,7 +794,7 @@  discard block
 block discarded – undo
794 794
 
795 795
     public function testBelongsToManyWithMultipleSameRelationIdAndPivotDataDynamicRelationship()
796 796
     {
797
-        User::resolveRelationUsing('dynamicRelation', function ($user) {
797
+        User::resolveRelationUsing('dynamicRelation', function($user) {
798 798
             return $user->belongsToMany(\Backpack\CRUD\Tests\config\Models\Article::class, 'articles_user')->withPivot(['notes', 'start_date', 'end_date', 'id'])->using('Backpack\CRUD\Tests\config\Models\SuperArticlePivot');
799 799
         });
800 800
 
@@ -1046,7 +1046,7 @@  discard block
 block discarded – undo
1046 1046
 
1047 1047
     public function testCreateBelongsToFake()
1048 1048
     {
1049
-        $belongsToField = [   // select_grouped
1049
+        $belongsToField = [// select_grouped
1050 1050
             'label' => 'Select_grouped',
1051 1051
             'type' => 'select_grouped', //https://github.com/Laravel-Backpack/CRUD/issues/502
1052 1052
             'name' => 'bang_relation_field',
@@ -1182,7 +1182,7 @@  discard block
 block discarded – undo
1182 1182
                 'nickname' => 'i_have_has_one',
1183 1183
                 'profile_picture' => 'ohh my picture 1.jpg',
1184 1184
                 'article' => 1,
1185
-                'addresses' => [ // HasOne is tested in other test function
1185
+                'addresses' => [// HasOne is tested in other test function
1186 1186
                     [
1187 1187
                         'city' => 2,
1188 1188
                         'street' => 'test',
@@ -1974,23 +1974,23 @@  discard block
 block discarded – undo
1974 1974
         $this->crudPanel->addField([
1975 1975
             'name' => 'name',
1976 1976
             'events' => [
1977
-                'created' => function ($entry) {
1977
+                'created' => function($entry) {
1978 1978
                 },
1979
-                'creating' => function ($entry) {
1979
+                'creating' => function($entry) {
1980 1980
                     $entry->email = '[email protected]';
1981 1981
                     $entry->password = Hash::make('password');
1982 1982
                 },
1983
-                'saving' => function ($entry) {
1983
+                'saving' => function($entry) {
1984 1984
                 },
1985
-                'saved' => function ($entry) {
1985
+                'saved' => function($entry) {
1986 1986
                 },
1987
-                'updating' => function ($entry) {
1987
+                'updating' => function($entry) {
1988 1988
                 },
1989
-                'updated' => function ($entry) {
1989
+                'updated' => function($entry) {
1990 1990
                 },
1991
-                'deleting' => function ($entry) {
1991
+                'deleting' => function($entry) {
1992 1992
                 },
1993
-                'deleted' => function ($entry) {
1993
+                'deleted' => function($entry) {
1994 1994
                 },
1995 1995
             ],
1996 1996
         ]);
@@ -2013,7 +2013,7 @@  discard block
 block discarded – undo
2013 2013
 
2014 2014
     public function testItCanCreateDynamicRelationships()
2015 2015
     {
2016
-        User::resolveRelationUsing('dynamicRelation', function ($user) {
2016
+        User::resolveRelationUsing('dynamicRelation', function($user) {
2017 2017
             return $user->belongsTo(\Backpack\CRUD\Tests\config\Models\Bang::class, 'bang_relation_field');
2018 2018
         });
2019 2019
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Create.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
                     // - a single dimensional array: [1,2,3]
125 125
                     // - an array of arrays: [[1][2][3]]
126 126
                     // if is as single dimensional array we can only attach.
127
-                    if ($relationValues === null || ! is_multidimensional_array($relationValues)) {
127
+                    if ($relationValues === null || !is_multidimensional_array($relationValues)) {
128 128
                         $this->attachManyRelation($item, $relation, $relationDetails, $relationValues);
129 129
                     } else {
130 130
                         $this->createManyEntries($item, $relation, $relationMethod, $relationDetails);
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
 
147 147
                             $toDelete = array_diff($dbValues, $sentIds);
148 148
 
149
-                            if (! empty($toDelete)) {
149
+                            if (!empty($toDelete)) {
150 150
                                 foreach ($toDelete as $id) {
151 151
                                     $relation->newPivot()->where($keyName, $id)->delete();
152 152
                                 }
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
         }
189 189
     }
190 190
 
191
-    private function preparePivotAttributesForSave(array $attributes, BelongsToMany|MorphToMany $relation, string|int $relatedItemKey, $pivotKeyName, $relationMethod): array
191
+    private function preparePivotAttributesForSave(array $attributes, BelongsToMany | MorphToMany $relation, string | int $relatedItemKey, $pivotKeyName, $relationMethod): array
192 192
     {
193 193
         $attributes[$relation->getForeignPivotKeyName()] = $relatedItemKey;
194 194
         $attributes[$relation->getRelatedPivotKeyName()] = $attributes[$relationMethod];
@@ -334,7 +334,7 @@  discard block
 block discarded – undo
334 334
         }
335 335
         // if column is not nullable in database, and there is no column default (null),
336 336
         // we will delete the entry from the database, otherwise it will throw and ugly DB error.
337
-        if (! $relationColumnIsNullable && $dbColumnDefault === null) {
337
+        if (!$relationColumnIsNullable && $dbColumnDefault === null) {
338 338
             return $removedEntries->lazy()->each->delete();
339 339
         }
340 340
 
@@ -379,7 +379,7 @@  discard block
 block discarded – undo
379 379
         }
380 380
 
381 381
         // use the collection of sent ids to match against database ids, delete the ones not found in the submitted ids.
382
-        if (! empty($relatedItemsSent)) {
382
+        if (!empty($relatedItemsSent)) {
383 383
             // we perform the cleanup of removed database items
384 384
             $entry->{$relationMethod}()->whereNotIn($relatedModelLocalKey, $relatedItemsSent)->lazy()->each->delete();
385 385
         }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Access.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@  discard block
 block discarded – undo
10 10
     /**
11 11
      * Set an operation as having access using the Settings API.
12 12
      */
13
-    public function allowAccess(array|string $operation): bool
13
+    public function allowAccess(array | string $operation): bool
14 14
     {
15 15
         foreach ((array) $operation as $op) {
16 16
             $this->set($op.'.access', true);
@@ -22,13 +22,13 @@  discard block
 block discarded – undo
22 22
     /**
23 23
      * Disable the access to a certain operation, or the current one.
24 24
      */
25
-    public function denyAccess(array|string $operation): bool
25
+    public function denyAccess(array | string $operation): bool
26 26
     {
27 27
         foreach ((array) $operation as $op) {
28 28
             $this->set($op.'.access', false);
29 29
         }
30 30
 
31
-        return ! $this->hasAccessToAny($operation);
31
+        return !$this->hasAccessToAny($operation);
32 32
     }
33 33
 
34 34
     /**
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
     /**
53 53
      * Check if any operations are allowed for a Crud Panel. Return false if not.
54 54
      */
55
-    public function hasAccessToAny(array|string $operation_array, ?Model $entry = null): bool
55
+    public function hasAccessToAny(array | string $operation_array, ?Model $entry = null): bool
56 56
     {
57 57
         foreach ((array) $operation_array as $key => $operation) {
58 58
             if ($this->hasAccess($operation, $entry) == true) {
@@ -66,10 +66,10 @@  discard block
 block discarded – undo
66 66
     /**
67 67
      * Check if all operations are allowed for a Crud Panel. Return false if not.
68 68
      */
69
-    public function hasAccessToAll(array|string $operation_array, ?Model $entry = null): bool
69
+    public function hasAccessToAll(array | string $operation_array, ?Model $entry = null): bool
70 70
     {
71 71
         foreach ((array) $operation_array as $key => $operation) {
72
-            if (! $this->hasAccess($operation, $entry)) {
72
+            if (!$this->hasAccess($operation, $entry)) {
73 73
                 return false;
74 74
             }
75 75
         }
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
      */
85 85
     public function hasAccessOrFail(string $operation, ?Model $entry = null): bool
86 86
     {
87
-        if (! $this->hasAccess($operation, $entry)) {
87
+        if (!$this->hasAccess($operation, $entry)) {
88 88
             throw new AccessDeniedException(trans('backpack::crud.unauthorized_access', ['access' => $operation]), 403);
89 89
         }
90 90
 
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
      * Get an operation's access condition, if set. A condition
96 96
      * can be anything, but usually a boolean or a callable.
97 97
      */
98
-    public function getAccessCondition(string $operation): bool|callable|null
98
+    public function getAccessCondition(string $operation): bool | callable | null
99 99
     {
100 100
         return $this->get($operation.'.access');
101 101
     }
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
     /**
104 104
      * Set the condition under which an operation is allowed for a Crud Panel.
105 105
      */
106
-    public function setAccessCondition(array|string $operation, bool|callable|null $condition): void
106
+    public function setAccessCondition(array | string $operation, bool | callable | null $condition): void
107 107
     {
108 108
         foreach ((array) $operation as $op) {
109 109
             $this->set($op.'.access', $condition);
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
      * Allow access only to operations in the array.
132 132
      * By denying access to all other operations.
133 133
      */
134
-    public function allowAccessOnlyTo(array|string $operation): void
134
+    public function allowAccessOnlyTo(array | string $operation): void
135 135
     {
136 136
         $this->denyAllAccess();
137 137
         $this->allowAccess($operation);
Please login to merge, or discard this patch.