Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — master (#2508)
by Cristian
11:55
created
src/app/Library/CrudPanel/Traits/Relationships.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
         }
25 25
 
26 26
         if (in_array($fieldName, array_column($relations, 'name'))) {
27
-            return array_filter($relations, function ($arr) use ($fieldName) {
27
+            return array_filter($relations, function($arr) use ($fieldName) {
28 28
                 if (isset($arr['name'])) {
29 29
                     return $arr['name'] == $fieldName;
30 30
                 }
Please login to merge, or discard this patch.
tests/Unit/Http/CrudControllerTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@
 block discarded – undo
21 21
         $app['router']->get('users/{id}/edit', "$controller@edit");
22 22
         $app['router']->put('users/{id}', "$controller@update");
23 23
 
24
-        $app->singleton('crud', function ($app) {
24
+        $app->singleton('crud', function($app) {
25 25
             return new CrudPanel($app);
26 26
         });
27 27
     }
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/FetchOperation.php 1 patch
Spacing   +4 added lines, -6 removed lines patch added patch discarded remove patch
@@ -45,8 +45,8 @@  discard block
 block discarded – undo
45 45
         // otherwise assume the arguments are actually the configuration array
46 46
         $config = [];
47 47
 
48
-        if (! is_array($arg)) {
49
-            if (! class_exists($arg)) {
48
+        if (!is_array($arg)) {
49
+            if (!class_exists($arg)) {
50 50
                 return response()->json(['error' => 'Class: '.$arg.' does not exists'], 500);
51 51
             }
52 52
             $config['model'] = $arg;
@@ -66,8 +66,7 @@  discard block
 block discarded – undo
66 66
 
67 67
         if ($search_string === false) {
68 68
             return ($config['paginate'] !== false) ?
69
-            $config['query']->paginate($config['paginate']) :
70
-            $config['query']->get();
69
+            $config['query']->paginate($config['paginate']) : $config['query']->get();
71 70
         }
72 71
 
73 72
         $textColumnTypes = ['string', 'json_string', 'text'];
@@ -85,7 +84,6 @@  discard block
 block discarded – undo
85 84
 
86 85
         // return the results with or without pagination
87 86
         return ($config['paginate'] !== false) ?
88
-                    $config['query']->paginate($config['paginate']) :
89
-                    $config['query']->get();
87
+                    $config['query']->paginate($config['paginate']) : $config['query']->get();
90 88
     }
91 89
 }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudPanel.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -100,11 +100,11 @@  discard block
 block discarded – undo
100 100
      */
101 101
     public function setModel($model_namespace)
102 102
     {
103
-        if (! class_exists($model_namespace)) {
103
+        if (!class_exists($model_namespace)) {
104 104
             throw new \Exception('The model does not exist.', 500);
105 105
         }
106 106
 
107
-        if (! method_exists($model_namespace, 'hasCrudTrait')) {
107
+        if (!method_exists($model_namespace, 'hasCrudTrait')) {
108 108
             throw new \Exception('Please use CrudTrait on the model.', 500);
109 109
         }
110 110
 
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
     {
168 168
         $complete_route = $route.'.index';
169 169
 
170
-        if (! \Route::has($complete_route)) {
170
+        if (!\Route::has($complete_route)) {
171 171
             throw new \Exception('There are no routes for this route name.', 404);
172 172
         }
173 173
 
@@ -268,7 +268,7 @@  discard block
 block discarded – undo
268 268
      */
269 269
     public function getFirstOfItsTypeInArray($type, $array)
270 270
     {
271
-        return Arr::first($array, function ($item) use ($type) {
271
+        return Arr::first($array, function($item) use ($type) {
272 272
             return $item['type'] == $type;
273 273
         });
274 274
     }
@@ -285,8 +285,8 @@  discard block
 block discarded – undo
285 285
 
286 286
     public function sync($type, $fields, $attributes)
287 287
     {
288
-        if (! empty($this->{$type})) {
289
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
288
+        if (!empty($this->{$type})) {
289
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
290 290
                 if (in_array($field['name'], (array) $fields)) {
291 291
                     $field = array_merge($field, $attributes);
292 292
                 }
@@ -317,15 +317,15 @@  discard block
 block discarded – undo
317 317
     {
318 318
         $relationArray = explode('.', $relationString);
319 319
 
320
-        if (! isset($length)) {
320
+        if (!isset($length)) {
321 321
             $length = count($relationArray);
322 322
         }
323 323
 
324
-        if (! isset($model)) {
324
+        if (!isset($model)) {
325 325
             $model = $this->model;
326 326
         }
327 327
 
328
-        $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
328
+        $result = array_reduce(array_splice($relationArray, 0, $length), function($obj, $method) {
329 329
             return $obj->$method()->getRelated();
330 330
         }, $model);
331 331
 
@@ -350,7 +350,7 @@  discard block
 block discarded – undo
350 350
         $attributes = [];
351 351
         foreach ($endModels as $model => $entries) {
352 352
             $modelKey = (new $model())->getKeyName();
353
-            if (is_array($entries) && ! isset($entries[$attribute])) {
353
+            if (is_array($entries) && !isset($entries[$attribute])) {
354 354
                 foreach ($entries as $entry) {
355 355
                     $attributes[$entry[$modelKey]] = $entry[$attribute];
356 356
                 }
@@ -381,21 +381,21 @@  discard block
 block discarded – undo
381 381
         $currentResults = [];
382 382
 
383 383
         $results = [];
384
-        if (! is_null($relation)) {
385
-            if ($relation instanceof Collection && ! $relation->isEmpty()) {
384
+        if (!is_null($relation)) {
385
+            if ($relation instanceof Collection && !$relation->isEmpty()) {
386 386
                 $currentResults[get_class($relation->first())] = $relation->toArray();
387
-            } elseif (is_array($relation) && ! empty($relation)) {
387
+            } elseif (is_array($relation) && !empty($relation)) {
388 388
                 $currentResults[get_class($relation->first())] = $relation;
389 389
             } else {
390 390
                 //relation must be App\Models\Article or App\Models\Category
391
-                if (! $relation instanceof Collection && ! empty($relation)) {
391
+                if (!$relation instanceof Collection && !empty($relation)) {
392 392
                     $currentResults[get_class($relation)] = $relation->toArray();
393 393
                 }
394 394
             }
395 395
 
396 396
             array_shift($relationArray);
397 397
 
398
-            if (! empty($relationArray)) {
398
+            if (!empty($relationArray)) {
399 399
                 foreach ($currentResults as $model => $currentResult) {
400 400
                     $results[$model] = array_merge($results[$model], $this->getRelatedEntries($currentResult, implode('.', $relationArray)));
401 401
                 }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/ColumnsProtectedMethods.php 1 patch
Spacing   +8 added lines, -9 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
 
51 51
         // make sure the column has a priority in terms of visibility
52 52
         // if no priority has been defined, use the order in the array plus one
53
-        if (! array_key_exists('priority', $column)) {
53
+        if (!array_key_exists('priority', $column)) {
54 54
             $position_in_columns_array = (int) array_search($column['key'], array_keys($this->columns()));
55 55
             $allColumns[$column['key']]['priority'] = $position_in_columns_array + 1;
56 56
         }
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
             $column = ['name' => $column];
72 72
         }
73 73
 
74
-        if (is_array($column) && ! isset($column['name'])) {
74
+        if (is_array($column) && !isset($column['name'])) {
75 75
             $column['name'] = 'anonymous_column_'.Str::random(5);
76 76
         }
77 77
 
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
      */
88 88
     protected function makeSureColumnHasLabel($column)
89 89
     {
90
-        if (! isset($column['label'])) {
90
+        if (!isset($column['label'])) {
91 91
             $column['label'] = mb_ucfirst($this->makeLabel($column['name']));
92 92
         }
93 93
 
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
      */
103 103
     protected function makeSureColumnHasType($column)
104 104
     {
105
-        if (! isset($column['type'])) {
105
+        if (!isset($column['type'])) {
106 106
             $column['type'] = 'text';
107 107
         }
108 108
 
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
      */
120 120
     protected function makeSureColumnHasKey($column)
121 121
     {
122
-        if (! isset($column['key'])) {
122
+        if (!isset($column['key'])) {
123 123
             $column['key'] = str_replace('.', '__', $column['name']);
124 124
         }
125 125
 
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
      */
138 138
     protected function makeSureColumnHasWrapper($column)
139 139
     {
140
-        if (! isset($column['wrapper'])) {
140
+        if (!isset($column['wrapper'])) {
141 141
             $column['wrapper'] = [];
142 142
         }
143 143
 
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
     {
156 156
         // if this is a relation type field and no corresponding model was specified,
157 157
         // get it from the relation method defined in the main model
158
-        if (isset($column['entity']) && ! isset($column['model'])) {
158
+        if (isset($column['entity']) && !isset($column['model'])) {
159 159
             $column['model'] = $this->getRelationModel($column['entity']);
160 160
         }
161 161
 
@@ -176,8 +176,7 @@  discard block
 block discarded – undo
176 176
         $columnsArray = $this->columns();
177 177
 
178 178
         if (array_key_exists($targetColumnName, $columnsArray)) {
179
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) :
180
-                array_search($targetColumnName, array_keys($columnsArray)) + 1;
179
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) : array_search($targetColumnName, array_keys($columnsArray)) + 1;
181 180
 
182 181
             $element = array_pop($columnsArray);
183 182
             $beginningPart = array_slice($columnsArray, 0, $targetColumnPosition, true);
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/FieldsProtectedMethods.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
             return ['name' => $field];
42 42
         }
43 43
 
44
-        if (is_array($field) && ! isset($field['name'])) {
44
+        if (is_array($field) && !isset($field['name'])) {
45 45
             abort(500, 'All fields must have their name defined');
46 46
         }
47 47
 
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
     protected function makeSureFieldHasRelationshipData($field)
104 104
     {
105 105
         // only do this if "entity" is defined on the field
106
-        if (! isset($field['entity'])) {
106
+        if (!isset($field['entity'])) {
107 107
             return $field;
108 108
         }
109 109
 
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
     {
123 123
         // if this is a relation type field and no corresponding model was specified,
124 124
         // get it from the relation method defined in the main model
125
-        if (isset($field['entity']) && ! isset($field['model'])) {
125
+        if (isset($field['entity']) && !isset($field['model'])) {
126 126
             $field['model'] = $this->getRelationModel($field['entity']);
127 127
         }
128 128
 
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
     {
134 134
         // if there's a model defined, but no attribute
135 135
         // guess an attribute using the indentifiableAttribute functionality in CrudTrait
136
-        if (isset($field['model']) && ! isset($field['attribute'])) {
136
+        if (isset($field['model']) && !isset($field['attribute'])) {
137 137
             $field['attribute'] = call_user_func([(new $field['model']), 'identifiableAttribute']);
138 138
         }
139 139
 
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
      */
150 150
     protected function makeSureFieldHasLabel($field)
151 151
     {
152
-        if (! isset($field['label'])) {
152
+        if (!isset($field['label'])) {
153 153
             $name = is_array($field['name']) ? $field['name'][0] : $field['name'];
154 154
             $name = str_replace('_id', '', $name);
155 155
             $field['label'] = mb_ucfirst(str_replace('_', ' ', $name));
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
      */
168 168
     protected function makeSureFieldHasType($field)
169 169
     {
170
-        if (! isset($field['type'])) {
170
+        if (!isset($field['type'])) {
171 171
             $field['type'] = $this->inferFieldTypeFromDbColumnType($field['name']);
172 172
         }
173 173
 
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
     {
185 185
         // if a tab was mentioned, we should enable it
186 186
         if (isset($field['tab'])) {
187
-            if (! $this->tabsEnabled()) {
187
+            if (!$this->tabsEnabled()) {
188 188
                 $this->enableTabs();
189 189
             }
190 190
         }
Please login to merge, or discard this patch.