Laravel-Backpack / CRUD

src/app/Library/CrudPanel/CrudPanel.php

Spacing +12 added lines, -12 removed lines

@@ -69,7 +69,7 @@ 
      */
     public function setRequest($request = null)
     {
-        if (! $request) {
+        if (!$request) {
             $request = \Request::instance();
         }
         $this->request = $request;
@@ -89,11 +89,11 @@ 
      */
     public function setModel($model_namespace)
     {
-        if (! class_exists($model_namespace)) {
+        if (!class_exists($model_namespace)) {
             throw new \Exception('The model does not exist.', 500);
         }
 
-        if (! method_exists($model_namespace, 'hasCrudTrait')) {
+        if (!method_exists($model_namespace, 'hasCrudTrait')) {
             throw new \Exception('Please use CrudTrait on the model.', 500);
         }
 
@@ -156,7 +156,7 @@ 
     {
         $complete_route = $route.'.index';
 
-        if (! \Route::has($complete_route)) {
+        if (!\Route::has($complete_route)) {
             throw new \Exception('There are no routes for this route name.', 404);
         }
 
@@ -257,7 +257,7 @@ 
      */
     public function getFirstOfItsTypeInArray($type, $array)
     {
-        return array_first($array, function ($item) use ($type) {
+        return array_first($array, function($item) use ($type) {
             return $item['type'] == $type;
         });
     }
@@ -274,8 +274,8 @@ 
 
     public function sync($type, $fields, $attributes)
     {
-        if (! empty($this->{$type})) {
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
+        if (!empty($this->{$type})) {
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
                 if (in_array($field['name'], (array) $fields)) {
                     $field = array_merge($field, $attributes);
                 }
@@ -306,15 +306,15 @@ 
     {
         $relationArray = explode('.', $relationString);
 
-        if (! isset($length)) {
+        if (!isset($length)) {
             $length = count($relationArray);
         }
 
-        if (! isset($model)) {
+        if (!isset($model)) {
             $model = $this->model;
         }
 
-        $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
+        $result = array_reduce(array_splice($relationArray, 0, $length), function($obj, $method) {
             return $obj->$method()->getRelated();
         }, $model);
 
@@ -364,7 +364,7 @@ 
         $relation = $model->{$firstRelationName};
 
         $results = [];
-        if (! empty($relation)) {
+        if (!empty($relation)) {
             if ($relation instanceof Collection) {
                 $currentResults = $relation->toArray();
             } else {
@@ -373,7 +373,7 @@ 
 
             array_shift($relationArray);
 
-            if (! empty($relationArray)) {
+            if (!empty($relationArray)) {
                 foreach ($currentResults as $currentResult) {
                     $results = array_merge($results, $this->getRelationModelInstances($currentResult, implode('.', $relationArray)));
                 }

src/app/Library/CrudPanel/Traits/Fields.php

Doc Comments +2 added lines, -4 removed lines

@@ -326,8 +326,6 @@ 
      * Check if the create/update form has upload fields.
      * Upload fields are the ones that have "upload" => true defined on them.
      *
-     * @param string   $form create/update/both - defaults to 'both'
-     * @param bool|int $id   id of the entity - defaults to false
      *
      * @return bool
      */
@@ -358,7 +356,7 @@ 
     /**
      * Set an array of field type names as already loaded for the current operation.
      *
-     * @param array $fieldTypes
+     * @param string[] $fieldTypes
      */
     public function setLoadedFieldTypes($fieldTypes)
     {
@@ -369,7 +367,7 @@ 
      * Get a namespaced version of the field type name.
      * Appends the 'view_namespace' attribute of the field to the `type', using dot notation.
      *
-     * @param  array $field Field array
+     * @param  string $field Field array
      * @return string Namespaced version of the field type name. Ex: 'text', 'custom.view.path.text'
      */
     public function getFieldTypeWithNamespace($field)

Spacing +14 added lines, -14 removed lines

@@ -37,24 +37,24 @@ 
 
         // if this is a relation type field and no corresponding model was specified, get it from the relation method
         // defined in the main model
-        if (isset($newField['entity']) && ! isset($newField['model'])) {
+        if (isset($newField['entity']) && !isset($newField['model'])) {
             $newField['model'] = $this->getRelationModel($newField['entity']);
         }
 
         // if the label is missing, we should set it
-        if (! isset($newField['label'])) {
+        if (!isset($newField['label'])) {
             $label = is_array($newField['name']) ? $newField['name'][0] : $newField['name'];
             $newField['label'] = mb_ucfirst(str_replace('_', ' ', $label));
         }
 
         // if the field type is missing, we should set it
-        if (! isset($newField['type'])) {
+        if (!isset($newField['type'])) {
             $newField['type'] = $this->getFieldTypeFromDbColumnType($newField['name']);
         }
 
         // if a tab was mentioned, we should enable it
         if (isset($newField['tab'])) {
-            if (! $this->tabsEnabled()) {
+            if (!$this->tabsEnabled()) {
                 $this->enableTabs();
             }
         }
@@ -88,7 +88,7 @@ 
      */
     public function afterField($targetFieldName)
     {
-        $this->transformFields(function ($fields) use ($targetFieldName) {
+        $this->transformFields(function($fields) use ($targetFieldName) {
             return $this->moveField($fields, $targetFieldName, false);
         });
     }
@@ -100,7 +100,7 @@ 
      */
     public function beforeField($targetFieldName)
     {
-        $this->transformFields(function ($fields) use ($targetFieldName) {
+        $this->transformFields(function($fields) use ($targetFieldName) {
             return $this->moveField($fields, $targetFieldName, true);
         });
     }
@@ -142,7 +142,7 @@ 
      */
     public function removeField($name)
     {
-        $this->transformFields(function ($fields) use ($name) {
+        $this->transformFields(function($fields) use ($name) {
             array_forget($fields, $name);
 
             return $fields;
@@ -156,7 +156,7 @@ 
      */
     public function removeFields($array_of_names)
     {
-        if (! empty($array_of_names)) {
+        if (!empty($array_of_names)) {
             foreach ($array_of_names as $name) {
                 $this->removeField($name);
             }
@@ -169,7 +169,7 @@ 
     public function removeAllFields()
     {
         $current_fields = $this->getCurrentFields();
-        if (! empty($current_fields)) {
+        if (!empty($current_fields)) {
             foreach ($current_fields as $field) {
                 $this->removeField($field['name']);
             }
@@ -243,7 +243,7 @@ 
                 $jsonCastables = ['array', 'object', 'json'];
                 $fieldCasting = $casted_attributes[$field['name']];
 
-                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && ! empty($data[$field['name']]) && ! is_array($data[$field['name']])) {
+                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && !empty($data[$field['name']]) && !is_array($data[$field['name']])) {
                     try {
                         $data[$field['name']] = json_decode($data[$field['name']]);
                     } catch (\Exception $e) {
@@ -272,7 +272,7 @@ 
      */
     public function orderFields($order)
     {
-        $this->transformFields(function ($fields) use ($order) {
+        $this->transformFields(function($fields) use ($order) {
             return $this->applyOrderToFields($fields, $order);
         });
     }
@@ -335,7 +335,7 @@ 
     public function hasUploadFields()
     {
         $fields = $this->getFields();
-        $upload_fields = array_where($fields, function ($value, $key) {
+        $upload_fields = array_where($fields, function($value, $key) {
             return isset($value['upload']) && $value['upload'] == true;
         });
 
@@ -395,7 +395,7 @@ 
         $alreadyLoaded = $this->getLoadedFieldTypes();
         $type = $this->getFieldTypeWithNamespace($field);
 
-        if (! in_array($type, $this->getLoadedFieldTypes(), true)) {
+        if (!in_array($type, $this->getLoadedFieldTypes(), true)) {
             $alreadyLoaded[] = $type;
             $this->setLoadedFieldTypes($alreadyLoaded);
 
@@ -436,7 +436,7 @@ 
      */
     public function fieldTypeNotLoaded($field)
     {
-        return ! in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
+        return !in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
     }
 
     /**

src/app/Console/Commands/Install.php

Doc Comments +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
     /**
      * Execute the console command.
      *
-     * @return mixed Command-line output
+     * @return false|null Command-line output
      */
     public function handle()
     {

Spacing +3 added lines, -3 removed lines

@@ -88,7 +88,7 @@ 
                     $createUploadDirectoryCommand = 'mkdir -p public/uploads';
                     break;
                 case '\\': // windows
-                    if (! file_exists('public\uploads')) {
+                    if (!file_exists('public\uploads')) {
                         $createUploadDirectoryCommand = 'mkdir public\uploads';
                     }
                     break;
@@ -133,7 +133,7 @@ 
         $this->echo('info', $beforeNotice ? ' '.$beforeNotice : $command);
 
         $process = new Process($command, null, null, null, $this->option('timeout'));
-        $process->run(function ($type, $buffer) {
+        $process->run(function($type, $buffer) {
             if (Process::ERR === $type) {
                 $this->echo('comment', $buffer);
             } else {
@@ -142,7 +142,7 @@ 
         });
 
         // executes after the command finishes
-        if (! $process->isSuccessful()) {
+        if (!$process->isSuccessful()) {
             throw new ProcessFailedException($process);
         }
 

src/app/Http/Controllers/Auth/LoginController.php

Doc Comments +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
      *
      * @param \Illuminate\Http\Request $request
      *
-     * @return mixed
+     * @return \Illuminate\Http\RedirectResponse
      */
     protected function loggedOut(Request $request)
     {

src/app/Library/CrudPanel/Traits/Buttons.php

Spacing +9 added lines, -9 removed lines

@@ -20,18 +20,18 @@ 
     {
         $newBtns = collect([]);
 
-        $this->buttons()->each(function ($btn) use ($stack, $newBtns) {
+        $this->buttons()->each(function($btn) use ($stack, $newBtns) {
             if ($btn->stack != $stack) {
                 $newBtns->push($btn);
             }
         });
 
-        collect($buttons)->each(function ($btnKey) use ($newBtns) {
-            $btnInstance = $this->buttons()->filter(function ($btn) use ($btnKey) {
+        collect($buttons)->each(function($btnKey) use ($newBtns) {
+            $btnInstance = $this->buttons()->filter(function($btn) use ($btnKey) {
                 return $btn->name == $btnKey;
             })->first();
             
-            if (! $btnInstance) {
+            if (!$btnInstance) {
                 abort(500, 'Sorry, button cannot be found');
             }
 
@@ -121,7 +121,7 @@ 
          */
         $button = $this->buttons()->firstWhere('name', $name);
 
-        if (! $button) {
+        if (!$button) {
             abort(500, 'CRUD Button "'.$name.'" not found. Please check the button exists before you modify it.');
         }
 
@@ -142,7 +142,7 @@ 
      */
     public function removeButton($name, $stack = null)
     {
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($name, $stack) {
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($name, $stack) {
             return $stack == null ? $button->name == $name : ($button->stack == $stack) && ($button->name == $name);
         }));
     }
@@ -153,7 +153,7 @@ 
      */
     public function removeButtons($names, $stack = null)
     {
-        if (! empty($names)) {
+        if (!empty($names)) {
             foreach ($names as $name) {
                 $this->removeButton($name, $stack);
             }
@@ -167,14 +167,14 @@ 
 
     public function removeAllButtonsFromStack($stack)
     {
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($stack) {
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($stack) {
             return $button->stack == $stack;
         }));
     }
 
     public function removeButtonFromStack($name, $stack)
     {
-        $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($name, $stack) {
+        $this->setOperationSetting('buttons', $this->buttons()->reject(function($button) use ($name, $stack) {
             return $button->name == $name && $button->stack == $stack;
         }));
     }

Doc Comments +14 added lines, -2 removed lines

@@ -14,7 +14,7 @@ 
      * Reorder buttons to the CRUD table view.
      *
      * @param string      $stack           Stack where the buttons belongs. Options: top, line, bottom.
-     * @param array       $buttons         Name of the buttons. ['update', 'delete', 'show']
+     * @param string[]       $buttons         Name of the buttons. ['update', 'delete', 'show']
      */
     public function reorderButtons($stack, $buttons)
     {
@@ -91,6 +91,9 @@ 
         $this->addButton($stack, $name, 'model_function', $model_function_name, $position);
     }
 
+    /**
+     * @param string $view
+     */
     public function addButtonFromView($stack, $name, $view, $position = false)
     {
         $view = 'crud::buttons.'.$view;
@@ -148,7 +151,7 @@ 
     }
 
     /**
-     * @param array       $names Button names
+     * @param string[]       $names Button names
      * @param string|null $stack Optional stack name.
      */
     public function removeButtons($names, $stack = null)
@@ -165,6 +168,9 @@ 
         $this->setOperationSetting('buttons', collect());
     }
 
+    /**
+     * @param string $stack
+     */
     public function removeAllButtonsFromStack($stack)
     {
         $this->setOperationSetting('buttons', $this->buttons()->reject(function ($button) use ($stack) {
@@ -187,6 +193,12 @@ 
     public $type = 'view';
     public $content;
 
+    /**
+     * @param string $stack
+     * @param string $name
+     * @param string $type
+     * @param string $content
+     */
     public function __construct($stack, $name, $type, $content)
     {
         $this->stack = $stack;

src/resources/views/crud/columns/select_from_array.blade.php

Spacing +1 added lines, -1 removed lines

@@ -10,7 +10,7 @@
                 $array_of_values = [];
 
                 foreach ($values as $key => $value) {
-                    if (! is_null($value)) {
+                    if (!is_null($value)) {
                         $array_of_values[] = $column['options'][$value] ?? $value;
                     } else {
                         echo '-';