Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — master (#3208)
by Cristian
29:43 queued 10:51
created
src/app/Library/CrudPanel/Traits/Filters.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
         $this->enableFilters();
73 73
 
74 74
         // check if another filter with the same name exists
75
-        if (! isset($options['name'])) {
75
+        if (!isset($options['name'])) {
76 76
             abort(500, 'All your filters need names.');
77 77
         }
78 78
 
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
     {
121 121
         $unappliedFilters = $this->filters()->where('applied', false);
122 122
         if ($unappliedFilters->count()) {
123
-            $unappliedFilters->each(function ($filter) {
123
+            $unappliedFilters->each(function($filter) {
124 124
                 $filter->apply();
125 125
             });
126 126
         }
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
     {
171 171
         $filter = $this->filters()->firstWhere('name', $name);
172 172
 
173
-        if (! $filter) {
173
+        if (!$filter) {
174 174
             abort(500, 'CRUD Filter "'.$name.'" not found. Please check the filter exists before you modify it.');
175 175
         }
176 176
 
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
 
186 186
     public function replaceFilter($name, $newFilter)
187 187
     {
188
-        $newFilters = $this->filters()->map(function ($filter, $key) use ($name, $newFilter) {
188
+        $newFilters = $this->filters()->map(function($filter, $key) use ($name, $newFilter) {
189 189
             if ($filter->name != $name) {
190 190
                 return $filter;
191 191
             }
@@ -198,7 +198,7 @@  discard block
 block discarded – undo
198 198
 
199 199
     public function removeFilter($name)
200 200
     {
201
-        $strippedCollection = $this->filters()->reject(function ($filter) use ($name) {
201
+        $strippedCollection = $this->filters()->reject(function($filter) use ($name) {
202 202
             return $filter->name == $name;
203 203
         });
204 204
 
@@ -241,7 +241,7 @@  discard block
 block discarded – undo
241 241
      */
242 242
     public function makeFirstFilter()
243 243
     {
244
-        if (! $this->filters()) {
244
+        if (!$this->filters()) {
245 245
             return false;
246 246
         }
247 247
 
@@ -271,15 +271,15 @@  discard block
 block discarded – undo
271 271
         $destinationFilter = $this->firstFilterWhere('name', $destination);
272 272
         $destinationKey = $this->getFilterKey($destination);
273 273
         $newDestinationKey = ($where == 'before' ? $destinationKey : $destinationKey + 1);
274
-        $newFilters = $this->filters()->filter(function ($value, $key) use ($target) {
274
+        $newFilters = $this->filters()->filter(function($value, $key) use ($target) {
275 275
             return $value->name != $target;
276 276
         });
277 277
 
278
-        if (! $targetFilter) {
278
+        if (!$targetFilter) {
279 279
             return;
280 280
         }
281 281
 
282
-        if (! $destinationFilter) {
282
+        if (!$destinationFilter) {
283 283
             return;
284 284
         }
285 285
 
@@ -287,7 +287,7 @@  discard block
 block discarded – undo
287 287
         $lastSlice = $newFilters->slice($newDestinationKey, null);
288 288
 
289 289
         $newFilters = $firstSlice->push($targetFilter);
290
-        $lastSlice->each(function ($item, $key) use ($newFilters) {
290
+        $lastSlice->each(function($item, $key) use ($newFilters) {
291 291
             $newFilters->push($item);
292 292
         });
293 293
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/SaveActions.php 1 patch
Spacing   +16 added lines, -17 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
         $higherAction = $this->getSaveActionByOrder(1);
29 29
 
30 30
         //if there is an higher action and that action is not the backpack default higher one `save_and_back` we return it.
31
-        if (! empty($higherAction) && key($higherAction) !== 'save_and_back') {
31
+        if (!empty($higherAction) && key($higherAction) !== 'save_and_back') {
32 32
             return key($higherAction);
33 33
         }
34 34
 
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
      */
48 48
     public function getSaveActionByOrder($order)
49 49
     {
50
-        return array_filter($this->getOperationSetting('save_actions'), function ($arr) use ($order) {
50
+        return array_filter($this->getOperationSetting('save_actions'), function($arr) use ($order) {
51 51
             return $arr['order'] == $order;
52 52
         });
53 53
     }
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
         $orderCounter = $this->getOperationSetting('save_actions') !== null ? (count($this->getOperationSetting('save_actions')) + 1) : 1;
82 82
         //check for some mandatory fields
83 83
         $saveAction['name'] ?? abort(500, 'Please define save action name.');
84
-        $saveAction['redirect'] = $saveAction['redirect'] ?? function ($crud, $request, $itemId) {
84
+        $saveAction['redirect'] = $saveAction['redirect'] ?? function($crud, $request, $itemId) {
85 85
             return $request->has('http_referrer') ? $request->get('http_referrer') : $crud->route;
86 86
         };
87 87
         $saveAction['visible'] = $saveAction['visible'] ?? true;
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
 
91 91
         $actions = $this->getOperationSetting('save_actions') ?? [];
92 92
 
93
-        if (! in_array($saveAction['name'], $actions)) {
93
+        if (!in_array($saveAction['name'], $actions)) {
94 94
             $actions[$saveAction['name']] = $saveAction;
95 95
         }
96 96
 
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
     public function orderSaveAction(string $saveAction, int $wantedOrder)
108 108
     {
109 109
         $actions = $this->getOperationSetting('save_actions') ?? [];
110
-        if (! empty($actions)) {
110
+        if (!empty($actions)) {
111 111
             $replaceOrder = isset($actions[$saveAction]) ? $actions[$saveAction]['order'] : count($actions) + 1;
112 112
 
113 113
             foreach ($actions as $key => $sv) {
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
     public function orderSaveActions(array $saveActions)
202 202
     {
203 203
         foreach ($saveActions as $sv => $order) {
204
-            if (! is_int($order)) {
204
+            if (!is_int($order)) {
205 205
                 $this->orderSaveAction($order, $sv + 1);
206 206
             } else {
207 207
                 $this->orderSaveAction($sv, $order);
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
     {
219 219
         $actions = $this->getOperationSetting('save_actions') ?? [];
220 220
 
221
-        uasort($actions, function ($a, $b) {
221
+        uasort($actions, function($a, $b) {
222 222
             return $a['order'] <=> $b['order'];
223 223
         });
224 224
 
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
240 240
             }
241 241
         }
242 242
 
243
-        return array_filter($actions, function ($action) {
243
+        return array_filter($actions, function($action) {
244 244
             return $action['visible'] == true;
245 245
         }, ARRAY_FILTER_USE_BOTH);
246 246
     }
@@ -304,8 +304,7 @@  discard block
 block discarded – undo
304 304
      */
305 305
     public function setSaveAction($forceSaveAction = null)
306 306
     {
307
-        $saveAction = $forceSaveAction ?:
308
-            \Request::input('save_action', $this->getFallBackSaveAction());
307
+        $saveAction = $forceSaveAction ?: \Request::input('save_action', $this->getFallBackSaveAction());
309 308
 
310 309
         $showBubble = $this->getOperationSetting('showSaveActionChange') ?? config('backpack.crud.operations.'.$this->getCurrentOperation().'.showSaveActionChange') ?? true;
311 310
 
@@ -373,20 +372,20 @@  discard block
 block discarded – undo
373 372
         $defaultSaveActions = [
374 373
             [
375 374
                 'name' => 'save_and_back',
376
-                'visible' => function ($crud) {
375
+                'visible' => function($crud) {
377 376
                     return $crud->hasAccess('list');
378 377
                 },
379
-                'redirect' => function ($crud, $request, $itemId = null) {
378
+                'redirect' => function($crud, $request, $itemId = null) {
380 379
                     return $request->has('http_referrer') ? $request->get('http_referrer') : $crud->route;
381 380
                 },
382 381
                 'button_text' => trans('backpack::crud.save_action_save_and_back'),
383 382
             ],
384 383
             [
385 384
                 'name' => 'save_and_edit',
386
-                'visible' => function ($crud) {
385
+                'visible' => function($crud) {
387 386
                     return $crud->hasAccess('update');
388 387
                 },
389
-                'redirect' => function ($crud, $request, $itemId = null) {
388
+                'redirect' => function($crud, $request, $itemId = null) {
390 389
                     $itemId = $itemId ?: $request->input('id');
391 390
                     $redirectUrl = $crud->route.'/'.$itemId.'/edit';
392 391
                     if ($request->has('locale')) {
@@ -398,17 +397,17 @@  discard block
 block discarded – undo
398 397
 
399 398
                     return $redirectUrl;
400 399
                 },
401
-                'referrer_url' => function ($crud, $request, $itemId) {
400
+                'referrer_url' => function($crud, $request, $itemId) {
402 401
                     return url($crud->route.'/'.$itemId.'/edit');
403 402
                 },
404 403
                 'button_text' => trans('backpack::crud.save_action_save_and_edit'),
405 404
             ],
406 405
             [
407 406
                 'name' => 'save_and_new',
408
-                'visible' => function ($crud) {
407
+                'visible' => function($crud) {
409 408
                     return $crud->hasAccess('create');
410 409
                 },
411
-                'redirect' => function ($crud, $request, $itemId = null) {
410
+                'redirect' => function($crud, $request, $itemId = null) {
412 411
                     return $this->route.'/create';
413 412
                 },
414 413
                 'button_text' => trans('backpack::crud.save_action_save_and_new'),
Please login to merge, or discard this patch.
src/LicenseCheck.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
             return;
29 29
         }
30 30
 
31
-        if (! $this->validCode(config('backpack.base.license_code'))) {
31
+        if (!$this->validCode(config('backpack.base.license_code'))) {
32 32
             \Alert::add('warning', "<strong>You're using unlicensed software.</strong> Please ask your web developer to <a target='_blank' class='alert-link text-white' href='http://backpackforlaravel.com'>purchase a license code</a> to hide this message.");
33 33
         }
34 34
     }
@@ -46,6 +46,6 @@  discard block
 block discarded – undo
46 46
      */
47 47
     private function validCode($j)
48 48
     {
49
-        $k = str_replace('-', '', $j); $s = substr($k, 0, 8); $c = substr($k, 8, 2); $a = substr($k, 10, 2); $l = substr($k, 12, 2); $p = substr($k, 14, 2); $n = substr($k, 16, 2); $m = substr($k, 18, 2); $z = substr($k, 20, 24); $w = 'ADEFHKLMVWXYZ146'; $x = $s; for ($i = 0; $i < strlen($w); $i++) { $r = $w[$i]; $x = str_replace($r, '-', $x); } $x = str_replace('-', '', $x); if ($x != '') { return false; } if (substr_count($j, '-') != 5) { return false; } $e = substr(hexdec(hash('crc32b', substr($k, 0, 20))), -4); if ($z !== $e) { return false; } $o = strrev(substr(preg_replace('/[0-9]+/', '', strtoupper(sha1($a.'sand('.$s.')'.$n.'tos()'))), 2, 2)); if ($m !== $o) { return false; } $o2 = substr(((int)preg_replace('/[^0-9]/','', $s.$c)==0 ? 8310 : (int)preg_replace('/[^0-9]/','', $s.$c) )*9971, -2);if ($a !== $o2) {return false;} return true; 
49
+        $k = str_replace('-', '', $j); $s = substr($k, 0, 8); $c = substr($k, 8, 2); $a = substr($k, 10, 2); $l = substr($k, 12, 2); $p = substr($k, 14, 2); $n = substr($k, 16, 2); $m = substr($k, 18, 2); $z = substr($k, 20, 24); $w = 'ADEFHKLMVWXYZ146'; $x = $s; for ($i = 0; $i < strlen($w); $i++) { $r = $w[$i]; $x = str_replace($r, '-', $x); } $x = str_replace('-', '', $x); if ($x != '') { return false; } if (substr_count($j, '-') != 5) { return false; } $e = substr(hexdec(hash('crc32b', substr($k, 0, 20))), -4); if ($z !== $e) { return false; } $o = strrev(substr(preg_replace('/[0-9]+/', '', strtoupper(sha1($a.'sand('.$s.')'.$n.'tos()'))), 2, 2)); if ($m !== $o) { return false; } $o2 = substr(((int) preg_replace('/[^0-9]/', '', $s.$c) == 0 ? 8310 : (int) preg_replace('/[^0-9]/', '', $s.$c)) * 9971, -2); if ($a !== $o2) {return false; } return true; 
50 50
     }
51 51
 }
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/ListOperation.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
     {
42 42
         $this->crud->allowAccess('list');
43 43
 
44
-        $this->crud->operation('list', function () {
44
+        $this->crud->operation('list', function() {
45 45
             $this->crud->loadDefaultOperationSettingsFromConfig();
46 46
         });
47 47
     }
@@ -114,8 +114,8 @@  discard block
 block discarded – undo
114 114
         // if there was an order set, this will be the last one (after all others were applied)
115 115
         $orderBy = $this->crud->query->getQuery()->orders;
116 116
         $hasOrderByPrimaryKey = false;
117
-        collect($orderBy)->each(function ($item, $key) use ($hasOrderByPrimaryKey) {
118
-            if (! isset($item['column'])) {
117
+        collect($orderBy)->each(function($item, $key) use ($hasOrderByPrimaryKey) {
118
+            if (!isset($item['column'])) {
119 119
                 return false;
120 120
             }
121 121
 
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
                 return false;
126 126
             }
127 127
         });
128
-        if (! $hasOrderByPrimaryKey) {
128
+        if (!$hasOrderByPrimaryKey) {
129 129
             $this->crud->query->orderByRaw($this->crud->model->getTableWithPrefix().'.'.$this->crud->model->getKeyName().' DESC');
130 130
         }
131 131
 
Please login to merge, or discard this patch.
src/routes/backpack/custom.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,5 +13,5 @@
 block discarded – undo
13 13
         (array) config('backpack.base.middleware_key', 'admin')
14 14
     ),
15 15
     'namespace'  => 'App\Http\Controllers\Admin',
16
-], function () { // custom admin routes
16
+], function() { // custom admin routes
17 17
 }); // this should be the absolute last line of this file
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Columns.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
      */
115 115
     public function makeFirstColumn()
116 116
     {
117
-        if (! $this->columns()) {
117
+        if (!$this->columns()) {
118 118
             return false;
119 119
         }
120 120
 
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
      */
160 160
     public function removeColumns($columns)
161 161
     {
162
-        if (! empty($columns)) {
162
+        if (!empty($columns)) {
163 163
             foreach ($columns as $columnKey) {
164 164
                 $this->removeColumn($columnKey);
165 165
             }
@@ -252,7 +252,7 @@  discard block
 block discarded – undo
252 252
     {
253 253
         $columns = $this->columns();
254 254
 
255
-        return collect($columns)->pluck('entity')->reject(function ($value, $key) {
255
+        return collect($columns)->pluck('entity')->reject(function($value, $key) {
256 256
             return $value == null;
257 257
         })->toArray();
258 258
     }
@@ -329,7 +329,7 @@  discard block
 block discarded – undo
329 329
      */
330 330
     public function hasColumnWhere($attribute, $value)
331 331
     {
332
-        $match = Arr::first($this->columns(), function ($column, $columnKey) use ($attribute, $value) {
332
+        $match = Arr::first($this->columns(), function($column, $columnKey) use ($attribute, $value) {
333 333
             return isset($column[$attribute]) && $column[$attribute] == $value;
334 334
         });
335 335
 
@@ -345,7 +345,7 @@  discard block
 block discarded – undo
345 345
      */
346 346
     public function firstColumnWhere($attribute, $value)
347 347
     {
348
-        return Arr::first($this->columns(), function ($column, $columnKey) use ($attribute, $value) {
348
+        return Arr::first($this->columns(), function($column, $columnKey) use ($attribute, $value) {
349 349
             return isset($column[$attribute]) && $column[$attribute] == $value;
350 350
         });
351 351
     }
@@ -379,7 +379,7 @@  discard block
 block discarded – undo
379 379
 
380 380
         // check if it's a method on the model,
381 381
         // that means it's a relationship
382
-        if (! $columnExistsInDb && method_exists($this->model, $column['name'])) {
382
+        if (!$columnExistsInDb && method_exists($this->model, $column['name'])) {
383 383
             $relatedModel = $this->model->{$column['name']}()->getRelated();
384 384
             $column['entity'] = $column['name'];
385 385
             $column['model'] = get_class($relatedModel);
@@ -398,8 +398,8 @@  discard block
 block discarded – undo
398 398
      */
399 399
     public function countColumnsWithoutActions()
400 400
     {
401
-        return collect($this->columns())->filter(function ($column, $key) {
402
-            return ! isset($column['hasActions']) || $column['hasActions'] == false;
401
+        return collect($this->columns())->filter(function($column, $key) {
402
+            return !isset($column['hasActions']) || $column['hasActions'] == false;
403 403
         })->count();
404 404
     }
405 405
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/ColumnsProtectedMethods.php 1 patch
Spacing   +8 added lines, -9 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
             $column = ['name' => $column];
50 50
         }
51 51
 
52
-        if (is_array($column) && ! isset($column['name'])) {
52
+        if (is_array($column) && !isset($column['name'])) {
53 53
             $column['name'] = 'anonymous_column_'.Str::random(5);
54 54
         }
55 55
 
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
      */
66 66
     protected function makeSureColumnHasLabel($column)
67 67
     {
68
-        if (! isset($column['label'])) {
68
+        if (!isset($column['label'])) {
69 69
             $column['label'] = mb_ucfirst($this->makeLabel($column['name']));
70 70
         }
71 71
 
@@ -82,11 +82,11 @@  discard block
 block discarded – undo
82 82
     {
83 83
         // if it's got a method on the model with the same name
84 84
         // then it should be a relationship
85
-        if (! isset($column['type']) && method_exists($this->model, $column['name'])) {
85
+        if (!isset($column['type']) && method_exists($this->model, $column['name'])) {
86 86
             $column['type'] = 'relationship';
87 87
         }
88 88
 
89
-        if (! isset($column['type'])) {
89
+        if (!isset($column['type'])) {
90 90
             $column['type'] = 'text';
91 91
         }
92 92
 
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
      */
104 104
     protected function makeSureColumnHasKey($column)
105 105
     {
106
-        if (! isset($column['key'])) {
106
+        if (!isset($column['key'])) {
107 107
             $column['key'] = str_replace('.', '__', $column['name']);
108 108
         }
109 109
 
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
      */
122 122
     protected function makeSureColumnHasWrapper($column)
123 123
     {
124
-        if (! isset($column['wrapper'])) {
124
+        if (!isset($column['wrapper'])) {
125 125
             $column['wrapper'] = [];
126 126
         }
127 127
 
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
     {
140 140
         // if this is a relation type field and no corresponding model was specified,
141 141
         // get it from the relation method defined in the main model
142
-        if (isset($column['entity']) && ! isset($column['model'])) {
142
+        if (isset($column['entity']) && !isset($column['model'])) {
143 143
             $column['model'] = $this->getRelationModel($column['entity']);
144 144
         }
145 145
 
@@ -160,8 +160,7 @@  discard block
 block discarded – undo
160 160
         $columnsArray = $this->columns();
161 161
 
162 162
         if (array_key_exists($targetColumnName, $columnsArray)) {
163
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) :
164
-                array_search($targetColumnName, array_keys($columnsArray)) + 1;
163
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) : array_search($targetColumnName, array_keys($columnsArray)) + 1;
165 164
 
166 165
             $element = array_pop($columnsArray);
167 166
             $beginningPart = array_slice($columnsArray, 0, $targetColumnPosition, true);
Please login to merge, or discard this patch.