Backpack\CRUD\app\Http\Controllers\CrudFeatures\SaveActions

Complexity

Total Complexity

16

Size/Duplication

Total Lines	85
Duplicated Lines	14.12 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	2
Bugs	1	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
B	getSaveAction()	12	30	4
A	setSaveAction()	0	14	3
B	performSaveAction()	0	20	5
A	getSaveActionButtonName()	0	15	4

<?php

namespace Backpack\CRUD\app\Http\Controllers\CrudFeatures;

//save_and_back save_and_edit save_and_new
trait SaveActions
{
    public function getSaveAction()
    {
        $saveAction = session('save_action', config('backback.crud.default_save_action', 'save_and_back'));
        $saveOptions = [];
        $saveCurrent = [
            'value' => $saveAction,
            'label' => $this->getSaveActionButtonName($saveAction),
        ];

        switch ($saveAction) {
            case 'save_and_edit':

This code seems to be duplicated across your project.

                $saveOptions['save_and_back'] = $this->getSaveActionButtonName('save_and_back');
                $saveOptions['save_and_new'] = $this->getSaveActionButtonName('save_and_new');
                break;
            case 'save_and_new':

This code seems to be duplicated across your project.

                $saveOptions['save_and_back'] = $this->getSaveActionButtonName('save_and_back');
                $saveOptions['save_and_edit'] = $this->getSaveActionButtonName('save_and_edit');
                break;
            case 'save_and_black':
            default:

This code seems to be duplicated across your project.

                $saveOptions['save_and_edit'] = $this->getSaveActionButtonName('save_and_edit');
                $saveOptions['save_and_new'] = $this->getSaveActionButtonName('save_and_new');
                break;
        }

        return [
            'active' => $saveCurrent,
            'options' => $saveOptions,
        ];
    }

    public function setSaveAction($forceSaveAction = null)
    {
        if ($forceSaveAction) {
            $saveAction = $forceSaveAction;
        } else {
            $saveAction = \Request::input('save_action', config('backback.crud.default_save_action', 'save_and_back'));
        }

        if (session('save_action', 'save_and_back') !== $saveAction) {
            \Alert::info(trans('backpack::crud.save_action_changed_notification'))->flash();
        }

        session(['save_action' => $saveAction]);
    }

    public function performSaveAction($itemId = null)
    {
        $saveAction = \Request::input('save_action', config('backback.crud.default_save_action', 'save_and_back'));
        $itemId = $itemId ? $itemId : \Request::input('id');

        switch ($saveAction) {
            case 'save_and_new':
                $redirectUrl = $this->crud->route.'/create';

The property crud does not exist. Did you maybe forget to declare it?

                break;
            case 'save_and_edit':
                $redirectUrl = $this->crud->route.'/'.$itemId.'/edit';
                break;
            case 'save_and_back':
            default:
                $redirectUrl = $this->crud->route;
                break;
        }

        return \Redirect::to($redirectUrl);
    }

    private function getSaveActionButtonName($actionValue = 'save_and_black')
    {
        switch ($actionValue) {
            case 'save_and_edit':
                return trans('backpack::crud.save_action_save_and_edit');
                break;

break is not strictly necessary here and could be removed.

            case 'save_and_new':
                return trans('backpack::crud.save_action_save_and_new');
                break;

break is not strictly necessary here and could be removed.

            case 'save_and_back':
            default:
                return trans('backpack::crud.save_action_save_and_back');
                break;

break is not strictly necessary here and could be removed.

        }
    }
}