Laravel-Backpack / CRUD

src/app/Models/Traits/CrudTrait.php

Spacing +6 added lines, -6 removed lines

@@ -72,7 +72,7 @@ 
             //check if column exists in database
             $conn->getDoctrineColumn($table, $column_name);
 
-            return ! $conn->getDoctrineColumn($table, $column_name)->getNotnull();
+            return !$conn->getDoctrineColumn($table, $column_name)->getNotnull();
         } catch (Exception $e) {
             return true;
         }
@@ -92,7 +92,7 @@ 
     public function addFakes($columns = ['extras'])
     {
         foreach ($columns as $key => $column) {
-            if (! isset($this->attributes[$column])) {
+            if (!isset($this->attributes[$column])) {
                 continue;
             }
 
@@ -141,7 +141,7 @@ 
      */
     public function shouldDecodeFake($column)
     {
-        return ! in_array($column, array_keys($this->casts));
+        return !in_array($column, array_keys($this->casts));
     }
 
     /**
@@ -153,7 +153,7 @@ 
      */
     public function shouldEncodeFake($column)
     {
-        return ! in_array($column, array_keys($this->casts));
+        return !in_array($column, array_keys($this->casts));
     }
 
     /*
@@ -227,7 +227,7 @@ 
     public function uploadMultipleFilesToDisk($value, $attribute_name, $disk, $destination_path)
     {
         $request = \Request::instance();
-        if (! is_array($this->{$attribute_name})) {
+        if (!is_array($this->{$attribute_name})) {
             $attribute_value = json_decode($this->{$attribute_name}, true) ?? [];
         } else {
             $attribute_value = $this->{$attribute_name};
@@ -239,7 +239,7 @@ 
         if ($files_to_clear) {
             foreach ($files_to_clear as $key => $filename) {
                 \Storage::disk($disk)->delete($filename);
-                $attribute_value = array_where($attribute_value, function ($value, $key) use ($filename) {
+                $attribute_value = array_where($attribute_value, function($value, $key) use ($filename) {
                     return $value != $filename;
                 });
             }

Doc Comments +1 added lines, -2 removed lines

@@ -59,7 +59,6 @@ 
     /**
      * Register aditional types in doctrine schema manager for the current connection.
      *
-     * @param Model $instance
      * @return DB
      */
     public static function getConnectionWithExtraTypeMappings()
@@ -168,7 +167,7 @@ 
      *
      * @param array $columns - the database columns that contain the JSONs
      *
-     * @return Model
+     * @return CrudTrait
      */
     public function withFakes($columns = [])
     {

tests/Unit/Http/CrudControllerTest.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -2,8 +2,8 @@
 
 namespace Backpack\CRUD\Tests\Unit\Http;
 
-use Backpack\CRUD\app\Library\CrudPanel\CrudPanel;
 use Backpack\CRUD\Tests\BaseTest;
+use Backpack\CRUD\app\Library\CrudPanel\CrudPanel;
 
 class CrudControllerTest extends BaseTest
 {

Spacing +1 added lines, -1 removed lines

@@ -19,7 +19,7 @@
         $controller = '\Backpack\CRUD\Tests\Unit\Http\Controllers\UserCrudController';
         $app['router']->get('users/{id}/edit', "$controller@edit");
         $app['router']->put('users/{id}', "$controller@update");
-        $app->singleton('crud', function ($app) {
+        $app->singleton('crud', function($app) {
             return new CrudPanel($app);
         });
     }

src/app/Library/CrudPanel/CrudPanel.php

Spacing +12 added lines, -12 removed lines

@@ -69,7 +69,7 @@ 
      */
     public function setRequest($request = null)
     {
-        if (! $request) {
+        if (!$request) {
             $request = \Request::instance();
         }
         $this->request = $request;
@@ -89,11 +89,11 @@ 
      */
     public function setModel($model_namespace)
     {
-        if (! class_exists($model_namespace)) {
+        if (!class_exists($model_namespace)) {
             throw new \Exception('The model does not exist.', 500);
         }
 
-        if (! method_exists($model_namespace, 'hasCrudTrait')) {
+        if (!method_exists($model_namespace, 'hasCrudTrait')) {
             throw new \Exception('Please use CrudTrait on the model.', 500);
         }
 
@@ -156,7 +156,7 @@ 
     {
         $complete_route = $route.'.index';
 
-        if (! \Route::has($complete_route)) {
+        if (!\Route::has($complete_route)) {
             throw new \Exception('There are no routes for this route name.', 404);
         }
 
@@ -257,7 +257,7 @@ 
      */
     public function getFirstOfItsTypeInArray($type, $array)
     {
-        return array_first($array, function ($item) use ($type) {
+        return array_first($array, function($item) use ($type) {
             return $item['type'] == $type;
         });
     }
@@ -274,8 +274,8 @@ 
 
     public function sync($type, $fields, $attributes)
     {
-        if (! empty($this->{$type})) {
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
+        if (!empty($this->{$type})) {
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
                 if (in_array($field['name'], (array) $fields)) {
                     $field = array_merge($field, $attributes);
                 }
@@ -306,15 +306,15 @@ 
     {
         $relationArray = explode('.', $relationString);
 
-        if (! isset($length)) {
+        if (!isset($length)) {
             $length = count($relationArray);
         }
 
-        if (! isset($model)) {
+        if (!isset($model)) {
             $model = $this->model;
         }
 
-        $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
+        $result = array_reduce(array_splice($relationArray, 0, $length), function($obj, $method) {
             return $obj->$method()->getRelated();
         }, $model);
 
@@ -364,7 +364,7 @@ 
         $relation = $model->{$firstRelationName};
 
         $results = [];
-        if (! empty($relation)) {
+        if (!empty($relation)) {
             if ($relation instanceof Collection) {
                 $currentResults = $relation->toArray();
             } else {
@@ -373,7 +373,7 @@ 
 
             array_shift($relationArray);
 
-            if (! empty($relationArray)) {
+            if (!empty($relationArray)) {
                 foreach ($currentResults as $currentResult) {
                     $results = array_merge($results, $this->getRelationModelInstances($currentResult, implode('.', $relationArray)));
                 }

src/app/Library/CrudPanel/Traits/Fields.php

Doc Comments +2 added lines, -4 removed lines

@@ -326,8 +326,6 @@ 
      * Check if the create/update form has upload fields.
      * Upload fields are the ones that have "upload" => true defined on them.
      *
-     * @param string   $form create/update/both - defaults to 'both'
-     * @param bool|int $id   id of the entity - defaults to false
      *
      * @return bool
      */
@@ -358,7 +356,7 @@ 
     /**
      * Set an array of field type names as already loaded for the current operation.
      *
-     * @param array $fieldTypes
+     * @param string[] $fieldTypes
      */
     public function setLoadedFieldTypes($fieldTypes)
     {
@@ -369,7 +367,7 @@ 
      * Get a namespaced version of the field type name.
      * Appends the 'view_namespace' attribute of the field to the `type', using dot notation.
      *
-     * @param  array $field Field array
+     * @param  string $field Field array
      * @return string Namespaced version of the field type name. Ex: 'text', 'custom.view.path.text'
      */
     public function getFieldTypeWithNamespace($field)

Spacing +14 added lines, -14 removed lines

@@ -37,24 +37,24 @@ 
 
         // if this is a relation type field and no corresponding model was specified, get it from the relation method
         // defined in the main model
-        if (isset($newField['entity']) && ! isset($newField['model'])) {
+        if (isset($newField['entity']) && !isset($newField['model'])) {
             $newField['model'] = $this->getRelationModel($newField['entity']);
         }
 
         // if the label is missing, we should set it
-        if (! isset($newField['label'])) {
+        if (!isset($newField['label'])) {
             $label = is_array($newField['name']) ? $newField['name'][0] : $newField['name'];
             $newField['label'] = mb_ucfirst(str_replace('_', ' ', $label));
         }
 
         // if the field type is missing, we should set it
-        if (! isset($newField['type'])) {
+        if (!isset($newField['type'])) {
             $newField['type'] = $this->getFieldTypeFromDbColumnType($newField['name']);
         }
 
         // if a tab was mentioned, we should enable it
         if (isset($newField['tab'])) {
-            if (! $this->tabsEnabled()) {
+            if (!$this->tabsEnabled()) {
                 $this->enableTabs();
             }
         }
@@ -88,7 +88,7 @@ 
      */
     public function afterField($targetFieldName)
     {
-        $this->transformFields(function ($fields) use ($targetFieldName) {
+        $this->transformFields(function($fields) use ($targetFieldName) {
             return $this->moveField($fields, $targetFieldName, false);
         });
     }
@@ -100,7 +100,7 @@ 
      */
     public function beforeField($targetFieldName)
     {
-        $this->transformFields(function ($fields) use ($targetFieldName) {
+        $this->transformFields(function($fields) use ($targetFieldName) {
             return $this->moveField($fields, $targetFieldName, true);
         });
     }
@@ -142,7 +142,7 @@ 
      */
     public function removeField($name)
     {
-        $this->transformFields(function ($fields) use ($name) {
+        $this->transformFields(function($fields) use ($name) {
             array_forget($fields, $name);
 
             return $fields;
@@ -156,7 +156,7 @@ 
      */
     public function removeFields($array_of_names)
     {
-        if (! empty($array_of_names)) {
+        if (!empty($array_of_names)) {
             foreach ($array_of_names as $name) {
                 $this->removeField($name);
             }
@@ -169,7 +169,7 @@ 
     public function removeAllFields()
     {
         $current_fields = $this->getCurrentFields();
-        if (! empty($current_fields)) {
+        if (!empty($current_fields)) {
             foreach ($current_fields as $field) {
                 $this->removeField($field['name']);
             }
@@ -243,7 +243,7 @@ 
                 $jsonCastables = ['array', 'object', 'json'];
                 $fieldCasting = $casted_attributes[$field['name']];
 
-                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && ! empty($data[$field['name']]) && ! is_array($data[$field['name']])) {
+                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && !empty($data[$field['name']]) && !is_array($data[$field['name']])) {
                     try {
                         $data[$field['name']] = json_decode($data[$field['name']]);
                     } catch (\Exception $e) {
@@ -272,7 +272,7 @@ 
      */
     public function orderFields($order)
     {
-        $this->transformFields(function ($fields) use ($order) {
+        $this->transformFields(function($fields) use ($order) {
             return $this->applyOrderToFields($fields, $order);
         });
     }
@@ -335,7 +335,7 @@ 
     public function hasUploadFields()
     {
         $fields = $this->getFields();
-        $upload_fields = array_where($fields, function ($value, $key) {
+        $upload_fields = array_where($fields, function($value, $key) {
             return isset($value['upload']) && $value['upload'] == true;
         });
 
@@ -395,7 +395,7 @@ 
         $alreadyLoaded = $this->getLoadedFieldTypes();
         $type = $this->getFieldTypeWithNamespace($field);
 
-        if (! in_array($type, $this->getLoadedFieldTypes(), true)) {
+        if (!in_array($type, $this->getLoadedFieldTypes(), true)) {
             $alreadyLoaded[] = $type;
             $this->setLoadedFieldTypes($alreadyLoaded);
 
@@ -436,7 +436,7 @@ 
      */
     public function fieldTypeNotLoaded($field)
     {
-        return ! in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
+        return !in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
     }
 
     /**

src/app/Console/Commands/Install.php

Doc Comments +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
     /**
      * Execute the console command.
      *
-     * @return mixed Command-line output
+     * @return false|null Command-line output
      */
     public function handle()
     {

Spacing +3 added lines, -3 removed lines

@@ -88,7 +88,7 @@ 
                     $createUploadDirectoryCommand = 'mkdir -p public/uploads';
                     break;
                 case '\\': // windows
-                    if (! file_exists('public\uploads')) {
+                    if (!file_exists('public\uploads')) {
                         $createUploadDirectoryCommand = 'mkdir public\uploads';
                     }
                     break;
@@ -133,7 +133,7 @@ 
         $this->echo('info', $beforeNotice ? ' '.$beforeNotice : $command);
 
         $process = new Process($command, null, null, null, $this->option('timeout'));
-        $process->run(function ($type, $buffer) {
+        $process->run(function($type, $buffer) {
             if (Process::ERR === $type) {
                 $this->echo('comment', $buffer);
             } else {
@@ -142,7 +142,7 @@ 
         });
 
         // executes after the command finishes
-        if (! $process->isSuccessful()) {
+        if (!$process->isSuccessful()) {
             throw new ProcessFailedException($process);
         }
 

src/app/Http/Controllers/Auth/LoginController.php

Doc Comments +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
      *
      * @param \Illuminate\Http\Request $request
      *
-     * @return mixed
+     * @return \Illuminate\Http\RedirectResponse
      */
     protected function loggedOut(Request $request)
     {

src/app/Models/Traits/HasIdentifiableAttribute.php

Spacing +1 added lines, -1 removed lines

@@ -62,7 +62,7 @@
         // we get the first column from database
         // that is NOT indexed (usually primary, foreign keys)
         foreach ($columns as $columnName => $columnProperties) {
-            if (! in_array($columnName, $indexedColumns)) {
+            if (!in_array($columnName, $indexedColumns)) {
 
                 //check for convention "field<_id>" in case developer didn't add foreign key constraints.
                 if (strpos($columnName, '_id') !== false) {

src/app/Http/Controllers/Operations/FetchOperation.php

Spacing +2 added lines, -2 removed lines

@@ -45,8 +45,8 @@
         // otherwise assume the arguments are actually the configuration array
         $config = [];
 
-        if (! is_array($arg)) {
-            if (! class_exists($arg)) {
+        if (!is_array($arg)) {
+            if (!class_exists($arg)) {
                 return response()->json(['error' => 'Class: '.$arg.' does not exists'], 500);
             }
             $config['model'] = $arg;