Laravel-Backpack / CRUD

src/resources/lang/ar/crud.php

Indentation +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
     |
     */
 
- return [
+    return [
     'infoFiltered' => '(filtered from _MAX_ total entries)',
     'thousands' => ',',
     'admin' => 'المشرف',

src/public/ckeditor/samples/old/assets/posteddata.php

Spacing +2 added lines, -2 removed lines

@@ -25,9 +25,9 @@
 		</thead>

 <?php
 
-if (! empty($_POST)) {
+if (!empty($_POST)) {
     foreach ($_POST as $key => $value) {
-        if ((! is_string($value) && ! is_numeric($value)) || ! is_string($key)) {
+        if ((!is_string($value) && !is_numeric($value)) || !is_string($key)) {
             continue;
         }
 

src/PanelTraits/Access.php

Spacing +3 added lines, -3 removed lines

@@ -33,7 +33,7 @@ 
      */
     public function hasAccess($permission)
     {
-        if (! in_array($permission, $this->access)) {
+        if (!in_array($permission, $this->access)) {
             return false;
         }
 
@@ -68,7 +68,7 @@ 
     public function hasAccessToAll($permission_array)
     {
         foreach ($permission_array as $key => $permission) {
-            if (! in_array($permission, $this->access)) {
+            if (!in_array($permission, $this->access)) {
                 return false;
             }
         }
@@ -86,7 +86,7 @@ 
      */
     public function hasAccessOrFail($permission)
     {
-        if (! in_array($permission, $this->access)) {
+        if (!in_array($permission, $this->access)) {
             throw new AccessDeniedException(trans('backpack::crud.unauthorized_access', ['access' => $permission]));
         }
 

Doc Comments +6 added lines

@@ -14,11 +14,17 @@
     |--------------------------------------------------------------------------
     */
 
+    /**
+     * @param string $access
+     */
     public function allowAccess($access)
     {
         return $this->access = array_merge(array_diff((array) $access, $this->access), $this->access);
     }
 
+    /**
+     * @param string $access
+     */
     public function denyAccess($access)
     {
         return $this->access = array_diff($this->access, (array) $access);

src/app/Console/Commands/Install.php

Spacing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
                     $this->executeProcess('mkdir -p public/uploads');
                     break;
                 case '\\': // windows
-                    if (! file_exists('public\uploads')) {
+                    if (!file_exists('public\uploads')) {
                         $this->executeProcess('mkdir public\uploads');
                     }
                     break;

Doc Comments +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
     /**
      * Execute the console command.
      *
-     * @return mixed
+     * @return false|null
      */
     public function handle()
     {

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace Backpack\CRUD\app\Console\Commands;
 
-use Illuminate\Console\Command;
 use Backpack\Base\app\Console\Commands\Install as BaseInstall;
 
 class Install extends BaseInstall

src/app/Console/Commands/Publish.php

Spacing +2 added lines, -2 removed lines

@@ -73,7 +73,7 @@ 
         $sourceFile = $this->sourcePath.$file.'.blade.php';
         $copiedFile = $this->destinationPath.$file.'.blade.php';
 
-        if (! file_exists($sourceFile)) {
+        if (!file_exists($sourceFile)) {
             return $this->error(
                 'Cannot find source view file at '
                 .$sourceFile.
@@ -93,7 +93,7 @@ 
             if ($canCopy) {
                 $path = pathinfo($copiedFile);
 
-                if (! file_exists($path['dirname'])) {
+                if (!file_exists($path['dirname'])) {
                     mkdir($path['dirname'], 0755, true);
                 }
 

src/PanelTraits/Search.php

Spacing +4 added lines, -4 removed lines

@@ -19,9 +19,9 @@ 
      */
     public function applySearchTerm($searchTerm)
     {
-        return $this->query->where(function ($query) use ($searchTerm) {
+        return $this->query->where(function($query) use ($searchTerm) {
             foreach ($this->getColumns() as $column) {
-                if (! isset($column['type'])) {
+                if (!isset($column['type'])) {
                     abort(400, 'Missing column type when trying to apply search term.');
                 }
 
@@ -60,7 +60,7 @@ 
 
                 case 'select':
                 case 'select_multiple':
-                    $query->orWhereHas($column['entity'], function ($q) use ($column, $searchTerm) {
+                    $query->orWhereHas($column['entity'], function($q) use ($column, $searchTerm) {
                         $q->where($column['attribute'], 'like', '%'.$searchTerm.'%');
                     });
                     break;
@@ -177,7 +177,7 @@ 
      */
     private function renderCellView($view, $column, $entry, $rowNumber = false)
     {
-        if (! view()->exists($view)) {
+        if (!view()->exists($view)) {
             $view = 'crud::columns.text'; // fallback to text column
         }
 

Doc Comments +2 added lines, -1 removed lines

@@ -35,6 +35,7 @@ 
 
     /**
      * Apply the search logic for each CRUD column.
+     * @param string $searchTerm
      */
     public function applySearchLogicForColumn($query, $column, $searchTerm)
     {
@@ -230,7 +231,7 @@ 
      *
      * @param string   $view
      * @param array    $column
-     * @param object   $entry
+     * @param \Illuminate\Database\Eloquent\Model   $entry
      * @param bool|int $rowNumber The number shown to the user as row number (index)
      *
      * @return string

Unused Use Statements +1 added lines, -1 removed lines

@@ -2,8 +2,8 @@
 
 namespace Backpack\CRUD\PanelTraits;
 
-use Validator;
 use Carbon\Carbon;
+use Validator;
 
 trait Search
 {

Indentation +4 added lines, -4 removed lines

@@ -210,10 +210,10 @@
         // add the details_row button to the first column
         if ($this->get('list.detailsRow')) {
             $details_row_button = \View::make('crud::columns.details_row_button')
-                                           ->with('crud', $this)
-                                           ->with('entry', $entry)
-                                           ->with('row_number', $rowNumber)
-                                           ->render();
+                                            ->with('crud', $this)
+                                            ->with('entry', $entry)
+                                            ->with('row_number', $rowNumber)
+                                            ->render();
             $row_items[0] = $details_row_button.$row_items[0];
         }
 

src/CrudUsageStats.php

Doc Comments +2 added lines, -2 removed lines

@@ -10,7 +10,7 @@ 
      * Check if the application is running in normal conditions
      * (production env, not in console, not in unit tests).
      *
-     * @return void
+     * @return boolean
      */
     private function runningInProduction()
     {
@@ -86,7 +86,7 @@ 
      * @param  string $method  HTTP Method to use for the request.
      * @param  string $url     URL to point the request at.
      * @param  array $payload  The data you want sent to the URL.
-     * @return void
+     * @return boolean
      */
     private function makeCurlRequest($method, $url, $payload)
     {

Spacing +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
     private function sendUsageStats()
     {
         // only send usage stats in production
-        if (! $this->runningInProduction()) {
+        if (!$this->runningInProduction()) {
             return;
         }
 

src/PanelTraits/Columns.php

Doc Comments +3 added lines, -3 removed lines

@@ -143,7 +143,7 @@ 
     /**
      * Move the most recently added column after the given target column.
      *
-     * @param string|array $targetColumn The target column name or array.
+     * @param string $targetColumn The target column name or array.
      */
     public function afterColumn($targetColumn)
     {
@@ -162,7 +162,7 @@ 
 
     /**
      * Move this column to be first in the columns list.
-     * @return bool|null
+     * @return false|null
      */
     public function makeFirstColumn()
     {
@@ -281,7 +281,7 @@ 
     /**
      * Change attributes for multiple columns.
      *
-     * @param array $columns
+     * @param string[] $columns
      * @param array $attributes
      */
     public function setColumnsDetails($columns, $attributes)

Spacing +16 added lines, -17 removed lines

@@ -68,7 +68,7 @@ 
     public function addColumn($column)
     {
         // if a string was passed, not an array, change it to an array
-        if (! is_array($column)) {
+        if (!is_array($column)) {
             $column = ['name' => $column];
         }
 
@@ -76,7 +76,7 @@ 
         $column_with_details = $this->addDefaultLabel($column);
 
         // make sure the column has a name
-        if (! array_key_exists('name', $column_with_details)) {
+        if (!array_key_exists('name', $column_with_details)) {
             $column_with_details['name'] = 'anonymous_column_'.str_random(5);
         }
 
@@ -84,27 +84,27 @@ 
         $columnExistsInDb = $this->hasColumn($this->model->getTable(), $column_with_details['name']);
 
         // make sure the column has a type
-        if (! array_key_exists('type', $column_with_details)) {
+        if (!array_key_exists('type', $column_with_details)) {
             $column_with_details['type'] = 'text';
         }
 
         // make sure the column has a key
-        if (! array_key_exists('key', $column_with_details)) {
+        if (!array_key_exists('key', $column_with_details)) {
             $column_with_details['key'] = $column_with_details['name'];
         }
 
         // make sure the column has a tableColumn boolean
-        if (! array_key_exists('tableColumn', $column_with_details)) {
+        if (!array_key_exists('tableColumn', $column_with_details)) {
             $column_with_details['tableColumn'] = $columnExistsInDb ? true : false;
         }
 
         // make sure the column has a orderable boolean
-        if (! array_key_exists('orderable', $column_with_details)) {
+        if (!array_key_exists('orderable', $column_with_details)) {
             $column_with_details['orderable'] = $columnExistsInDb ? true : false;
         }
 
         // make sure the column has a searchLogic
-        if (! array_key_exists('searchLogic', $column_with_details)) {
+        if (!array_key_exists('searchLogic', $column_with_details)) {
             $column_with_details['searchLogic'] = $columnExistsInDb ? true : false;
         }
 
@@ -112,14 +112,14 @@ 
 
         // make sure the column has a priority in terms of visibility
         // if no priority has been defined, use the order in the array plus one
-        if (! array_key_exists('priority', $column_with_details)) {
+        if (!array_key_exists('priority', $column_with_details)) {
             $position_in_columns_array = (int) array_search($column_with_details['key'], array_keys($this->columns));
             $this->columns[$column_with_details['key']]['priority'] = $position_in_columns_array + 1;
         }
 
         // if this is a relation type field and no corresponding model was specified, get it from the relation method
         // defined in the main model
-        if (isset($column_with_details['entity']) && ! isset($column_with_details['model'])) {
+        if (isset($column_with_details['entity']) && !isset($column_with_details['model'])) {
             $column_with_details['model'] = $this->getRelationModel($column_with_details['entity']);
         }
 
@@ -166,7 +166,7 @@ 
      */
     public function makeFirstColumn()
     {
-        if (! $this->columns) {
+        if (!$this->columns) {
             return false;
         }
 
@@ -187,8 +187,7 @@ 
         $targetColumnName = is_array($targetColumn) ? $targetColumn['name'] : $targetColumn;
 
         if (array_key_exists($targetColumnName, $this->columns)) {
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($this->columns)) :
-                array_search($targetColumnName, array_keys($this->columns)) + 1;
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($this->columns)) : array_search($targetColumnName, array_keys($this->columns)) + 1;
 
             $element = array_pop($this->columns);
             $beginningPart = array_slice($this->columns, 0, $targetColumnPosition, true);
@@ -225,7 +224,7 @@ 
      */
     public function addDefaultLabel($array)
     {
-        if (! array_key_exists('label', (array) $array) && array_key_exists('name', (array) $array)) {
+        if (!array_key_exists('label', (array) $array) && array_key_exists('name', (array) $array)) {
             $array = array_merge(['label' => mb_ucfirst($this->makeLabel($array['name']))], $array);
 
             return $array;
@@ -251,7 +250,7 @@ 
      */
     public function removeColumns($columns)
     {
-        if (! empty($columns)) {
+        if (!empty($columns)) {
             foreach ($columns as $columnName) {
                 $this->removeColumn($columnName);
             }
@@ -273,8 +272,8 @@ 
      */
     public function remove($entity, $fields)
     {
-        return array_values(array_filter($this->{$entity}, function ($field) use ($fields) {
-            return ! in_array($field['name'], (array) $fields);
+        return array_values(array_filter($this->{$entity}, function($field) use ($fields) {
+            return !in_array($field['name'], (array) $fields);
         }));
     }
 
@@ -331,7 +330,7 @@ 
     {
         $columns = $this->getColumns();
 
-        return collect($columns)->pluck('entity')->reject(function ($value, $key) {
+        return collect($columns)->pluck('entity')->reject(function($value, $key) {
             return $value == null;
         })->toArray();
     }

tests/Unit/CrudPanel/CrudPanelTabsTest.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -2,8 +2,8 @@
 
 namespace Backpack\CRUD\Tests\Unit\CrudPanel;
 
-use Illuminate\Support\Facades\DB;
 use Backpack\CRUD\Tests\Unit\Models\Article;
+use Illuminate\Support\Facades\DB;
 
 class CrudPanelTabsTest extends BaseDBCrudPanelTest
 {