Backpack\CRUD\CrudTrait::uploadImageToDisk()

Complexity

Conditions	34
Paths	2144

Size

Total Lines	149
Code Lines	92

Duplication

Lines	50
Ratio	33.56 %

Importance

Changes	2
Bugs	2	Features	0

<?php
    public function uploadImageToDisk($value, $attribute_name, $disk, $destination_path, $variations = null)

The parameter $attribute_name is not named in camelCase.

The parameter $destination_path is not named in camelCase.

    {
        if (! $variations || ! is_array($variations)) {
            $variations = ['original' => null, 'thumb' => [150, 150]];
        }

        //Needed for the original image
        if (! array_key_exists('original', $variations)) {
            $variations['original'] = null;
        }

        //Needed for admin thumbnails
        if (! array_key_exists('thumb', $variations)) {
            $variations['thumb'] = [150, 150];
        }

        $request = \Request::instance();

        //We need to setup the disk paths as they're handled differently
        //depending if you need a public path or internal storage
        $disk_config = config('filesystems.disks.'.$disk);
        $disk_root = $disk_config['root'];

        //if the disk is public, we need to know the public path
        if ($disk_config['visibility'] == 'public') {

This code seems to be duplicated across your project.

            $public_path = str_replace(public_path(), '', $disk_root);
        } else {
            $public_path = $disk_root;
        }

        // if a new file is uploaded, delete the file from the disk
        if (($request->hasFile($attribute_name) || starts_with($value, 'data:image')) && $this->{$attribute_name}) {
            foreach ($variations as $variant => $dimensions) {

This code seems to be duplicated across your project.

                $variant_name = str_replace('-original', '-'.$variant, $this->{$attribute_name});
                \Storage::disk($disk)->delete($variant_name);
            }
            $this->attributes[$attribute_name] = null;
        }

        // if the file input is empty, delete the file from the disk
        if (empty($value)) {
            foreach ($variations as $variant => $dimensions) {

This code seems to be duplicated across your project.

                $variant_name = str_replace('-original', '-'.$variant, $this->{$attribute_name});
                \Storage::disk($disk)->delete($variant_name);
            }

            return $this->attributes[$attribute_name] = null;
        }

        // if a new file is uploaded, store it on disk and its filename in the database
        if ($request->hasFile($attribute_name) && $request->file($attribute_name)->isValid()) {

            // 1. Generate a new file name
            $file = $request->file($attribute_name);
            $new_file_name = md5($file->getClientOriginalName().time());
            $new_file = $new_file_name.'.'.$file->getClientOriginalExtension();

            // 2. Move the new file to the correct path
            $file_path = $file->storeAs($destination_path, $new_file, $disk);
            $image_variations = [];

            // 3. but only if they have the ability to crop/handle images
            if (class_exists('\Intervention\Image\ImageManagerStatic')) {
                $img = \Intervention\Image\ImageManagerStatic::make($file);
                foreach ($variations as $variant => $dimensions) {
                    $variant_name = $new_file_name.'-'.$variant.'.'.$file->getClientOriginalExtension();
                    $variant_file = $destination_path.'/'.$variant_name;

                    if ($dimensions) {

This code seems to be duplicated across your project.

                        $width = $dimensions[0];
                        $height = $dimensions[1];

                        if ($img->width() > $width || $img->height() > $height) {
                            $img->resize($width, $height, function ($constraint) {
                                $constraint->aspectRatio();
                            })
                            ->save($disk_root.'/'.$variant_file);
                        } else {
                            $img->save($disk_root.'/'.$variant_file);
                        }

                        $image_variations[$variant] = $public_path.'/'.$variant_file;
                    } else {
                        $image_variations['original'] = $public_path.'/'.$file_path;
                    }
                }
            } else {
                $image_variations['original'] = $public_path.'/'.$file_path;
                $image_variations['thumb'] = $public_path.'/'.$file_path;
            }

            // 3. Save the complete path to the database
            $this->attributes[$attribute_name] = $image_variations['original'];
        } elseif (starts_with($value, 'data:image')) {
            $img = \Intervention\Image\ImageManagerStatic::make($value);
            $new_file_name = md5($value.time());

            if (! \Illuminate\Support\Facades\File::exists($disk_root.'/'.trim($destination_path, '/'))) {
                \Illuminate\Support\Facades\File::makeDirectory($disk_root.'/'.trim($destination_path, '/'), 0775, true);

This line exceeds maximum limit of 120 characters; contains 121 characters

            }

            foreach ($variations as $variant => $dimensions) {
                switch ($img->mime()) {
                    case 'image/bmp':
                    case 'image/ief':
                    case 'image/jpeg':
                    case 'image/pipeg':
                    case 'image/tiff':
                    case 'image/x-jps':
                        $extension = '.jpg';
                        break;
                    case 'image/gif':
                        $extension = '.gif';
                        break;
                    case 'image/x-icon':
                    case 'image/png':
                        $extension = '.png';
                        break;
                    default:
                        $extension = '.jpg';
                        break;
                }

                $variant_name = $new_file_name.'-'.$variant.$extension;
                $variant_file = $destination_path.'/'.$variant_name;

                if ($dimensions) {

This code seems to be duplicated across your project.

                    $width = $dimensions[0];
                    $height = $dimensions[1];

                    if ($img->width() > $width || $img->height() > $height) {
                        $img->resize($width, $height, function ($constraint) {
                            $constraint->aspectRatio();
                        })
                        ->save($disk_root.'/'.$variant_file);
                    } else {
                        $img->save($disk_root.'/'.$variant_file);
                    }

                    $image_variations[$variant] = $public_path.'/'.$variant_file;

$image_variations was never initialized. Although not strictly required by PHP, it is generally a good practice to add $image_variations = array(); before regardless.

                } else {
                    $img->save($disk_root.'/'.$variant_file);
                    $image_variations['original'] = $variant_file;

The variable $image_variations does not seem to be defined for all execution paths leading up to this point.

                }
            }

            $this->attributes[$attribute_name] = $image_variations['original'];
        }
    }