Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Pull Request — master (#943)
by Pascal
02:48
created
src/app/Http/Controllers/CrudFeatures/Revisions.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@
 block discarded – undo
41 41
         $this->crud->hasAccessOrFail('revisions');
42 42
 
43 43
         $revisionId = \Request::input('revision_id', false);
44
-        if (! $revisionId) {
44
+        if (!$revisionId) {
45 45
             abort(500, 'Can\'t restore revision without revision_id');
46 46
         } else {
47 47
             $this->crud->restoreRevision($id, $revisionId); // do the update
Please login to merge, or discard this patch.
src/app/Http/Controllers/CrudController.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -27,12 +27,12 @@  discard block
 block discarded – undo
27 27
 
28 28
     public function __construct()
29 29
     {
30
-        if (! $this->crud) {
30
+        if (!$this->crud) {
31 31
             $this->crud = app()->make(CrudPanel::class);
32 32
 
33 33
             // call the setup function inside this closure to also have the request there
34 34
             // this way, developers can use things stored in session (auth variables, etc)
35
-            $this->middleware(function ($request, $next) {
35
+            $this->middleware(function($request, $next) {
36 36
                 $this->request = $request;
37 37
                 $this->crud->request = $request;
38 38
                 $this->setup();
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
         $this->data['title'] = ucfirst($this->crud->entity_name_plural);
63 63
 
64 64
         // get all entries if AJAX is not enabled
65
-        if (! $this->data['crud']->ajaxTable()) {
65
+        if (!$this->data['crud']->ajaxTable()) {
66 66
             $this->data['entries'] = $this->data['crud']->getEntries();
67 67
         }
68 68
 
Please login to merge, or discard this patch.
src/resources/views/fields/checklist_dependency.blade.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
         }
25 25
 
26 26
       //for update form, get initial state of the entity
27
-      if( isset($id) && $id ){
27
+      if (isset($id) && $id) {
28 28
 
29 29
         //get entity with relations for primary dependency
30 30
         $entity_dependencies = $entity_model->with($primary_dependency['entity'])
Please login to merge, or discard this patch.
src/CrudServiceProvider.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
      */
75 75
     public function register()
76 76
     {
77
-        $this->app->bind('CRUD', function ($app) {
77
+        $this->app->bind('CRUD', function($app) {
78 78
             return new CRUD($app);
79 79
         });
80 80
 
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
         $loader->alias('Image', \Intervention\Image\Facades\Image::class);
93 93
 
94 94
         // map the elfinder prefix
95
-        if (! \Config::get('elfinder.route.prefix')) {
95
+        if (!\Config::get('elfinder.route.prefix')) {
96 96
             \Config::set('elfinder.route.prefix', \Config::get('backpack.base.route_prefix').'/elfinder');
97 97
         }
98 98
     }
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
     {
113 113
         $crudPubPath = public_path('vendor/backpack/crud');
114 114
 
115
-        if (! is_dir($crudPubPath)) {
115
+        if (!is_dir($crudPubPath)) {
116 116
             return true;
117 117
         }
118 118
 
Please login to merge, or discard this patch.
src/PanelTraits/Filters.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@  discard block
 block discarded – undo
10 10
 
11 11
     public function filtersEnabled()
12 12
     {
13
-        return ! is_array($this->filters);
13
+        return !is_array($this->filters);
14 14
     }
15 15
 
16 16
     public function filtersDisabled()
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
         $this->enableFilters();
55 55
 
56 56
         // check if another filter with the same name exists
57
-        if (! isset($options['name'])) {
57
+        if (!isset($options['name'])) {
58 58
             abort(500, 'All your filters need names.');
59 59
         }
60 60
         if ($this->filters->contains('name', $options['name'])) {
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
 
132 132
     public function removeFilter($name)
133 133
     {
134
-        $this->filters = $this->filters->reject(function ($filter) use ($name) {
134
+        $this->filters = $this->filters->reject(function($filter) use ($name) {
135 135
             return $filter->name == $name;
136 136
         });
137 137
     }
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
         $this->type = $options['type'];
202 202
         $this->label = $options['label'];
203 203
 
204
-        if (! isset($options['placeholder'])) {
204
+        if (!isset($options['placeholder'])) {
205 205
             $this->placeholder = '';
206 206
         } else {
207 207
             $this->placeholder = $options['placeholder'];
@@ -218,16 +218,16 @@  discard block
 block discarded – undo
218 218
 
219 219
     public function checkOptionsIntegrity($options)
220 220
     {
221
-        if (! isset($options['name'])) {
221
+        if (!isset($options['name'])) {
222 222
             abort(500, 'Please make sure all your filters have names.');
223 223
         }
224
-        if (! isset($options['type'])) {
224
+        if (!isset($options['type'])) {
225 225
             abort(500, 'Please make sure all your filters have types.');
226 226
         }
227
-        if (! \View::exists('crud::filters.'.$options['type'])) {
227
+        if (!\View::exists('crud::filters.'.$options['type'])) {
228 228
             abort(500, 'No filter view named "'.$options['type'].'.blade.php" was found.');
229 229
         }
230
-        if (! isset($options['label'])) {
230
+        if (!isset($options['label'])) {
231 231
             abort(500, 'Please make sure all your filters have labels.');
232 232
         }
233 233
     }
Please login to merge, or discard this patch.
src/PanelTraits/Tabs.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
 
30 30
     public function tabsDisabled()
31 31
     {
32
-        return ! $this->tabsEnabled;
32
+        return !$this->tabsEnabled;
33 33
     }
34 34
 
35 35
     public function setTabsType($type)
@@ -92,13 +92,13 @@  discard block
 block discarded – undo
92 92
         if ($this->tabExists($label)) {
93 93
             $all_fields = $this->getCurrentFields();
94 94
 
95
-            $fields_for_current_tab = collect($all_fields)->filter(function ($value, $key) use ($label) {
95
+            $fields_for_current_tab = collect($all_fields)->filter(function($value, $key) use ($label) {
96 96
                 return isset($value['tab']) && $value['tab'] == $label;
97 97
             });
98 98
 
99 99
             if ($this->isLastTab($label)) {
100
-                $fields_without_a_tab = collect($all_fields)->filter(function ($value, $key) {
101
-                    return ! isset($value['tab']);
100
+                $fields_without_a_tab = collect($all_fields)->filter(function($value, $key) {
101
+                    return !isset($value['tab']);
102 102
                 });
103 103
 
104 104
                 $fields_for_current_tab = $fields_for_current_tab->merge($fields_without_a_tab);
@@ -116,11 +116,11 @@  discard block
 block discarded – undo
116 116
         $fields = $this->getCurrentFields();
117 117
 
118 118
         $fields_with_tabs = collect($fields)
119
-            ->filter(function ($value, $key) {
119
+            ->filter(function($value, $key) {
120 120
                 return isset($value['tab']);
121 121
             })
122
-            ->each(function ($value, $key) use (&$tabs) {
123
-                if (! in_array($value['tab'], $tabs)) {
122
+            ->each(function($value, $key) use (&$tabs) {
123
+                if (!in_array($value['tab'], $tabs)) {
124 124
                     $tabs[] = $value['tab'];
125 125
                 }
126 126
             });
Please login to merge, or discard this patch.
src/PanelTraits/Read.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
      */
20 20
     public function getEntry($id)
21 21
     {
22
-        if (! $this->entry) {
22
+        if (!$this->entry) {
23 23
             $this->entry = $this->model->findOrFail($id);
24 24
             $this->entry = $this->entry->withFakes();
25 25
         }
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
     public function hasUploadFields($form, $id = false)
95 95
     {
96 96
         $fields = $this->getFields($form, $id);
97
-        $upload_fields = array_where($fields, function ($value, $key) {
97
+        $upload_fields = array_where($fields, function($value, $key) {
98 98
             return isset($value['upload']) && $value['upload'] == true;
99 99
         });
100 100
 
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
      */
193 193
     public function getCellView($column, $entry)
194 194
     {
195
-        if (! isset($column['type'])) {
195
+        if (!isset($column['type'])) {
196 196
             return \View::make('crud::columns.text')->with('crud', $this)->with('column', $column)->with('entry', $entry)->render();
197 197
         } else {
198 198
             if (view()->exists('vendor.backpack.crud.columns.'.$column['type'])) {
Please login to merge, or discard this patch.
src/resources/views/fields/date_range.blade.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -3,15 +3,15 @@
 block discarded – undo
3 3
 <?php
4 4
     // if the column has been cast to Carbon or Date (using attribute casting)
5 5
     // get the value as a date string
6
-    if ( isset($entry) && ($entry->{$field['start_name']} instanceof \Carbon\Carbon || $entry->{$field['start_name']} instanceof \Jenssegers\Date\Date) ) {
7
-        $start_name = $entry->{$field['start_name']}->format( 'Y-m-d H:i:s' );
6
+    if (isset($entry) && ($entry->{$field['start_name']} instanceof \Carbon\Carbon || $entry->{$field['start_name']} instanceof \Jenssegers\Date\Date)) {
7
+        $start_name = $entry->{$field['start_name']}->format('Y-m-d H:i:s');
8 8
     } else {
9 9
         $start_name = null;
10 10
     }
11 11
 
12 12
     //Do the same as the above but for the range end field
13
-    if ( isset($entry) && ($entry->{$field['end_name']} instanceof \Carbon\Carbon || $entry->{$field['end_name']} instanceof \Jenssegers\Date\Date) ) {
14
-        $end_name = $entry->{$field['end_name']}->format( 'Y-m-d H:i:s' );
13
+    if (isset($entry) && ($entry->{$field['end_name']} instanceof \Carbon\Carbon || $entry->{$field['end_name']} instanceof \Jenssegers\Date\Date)) {
14
+        $end_name = $entry->{$field['end_name']}->format('Y-m-d H:i:s');
15 15
     } else {
16 16
         $end_name = null;
17 17
     }
Please login to merge, or discard this patch.
src/PanelTraits/AutoSet.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
     {
17 17
         $this->getDbColumnTypes();
18 18
 
19
-        array_map(function ($field) {
19
+        array_map(function($field) {
20 20
             // $this->labels[$field] = $this->makeLabel($field);
21 21
 
22 22
             $new_field = [
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
             $this->create_fields[$field] = $new_field;
31 31
             $this->update_fields[$field] = $new_field;
32 32
 
33
-            if (! in_array($field, $this->model->getHidden())) {
33
+            if (!in_array($field, $this->model->getHidden())) {
34 34
                 $this->columns[] = [
35 35
                     'name'  => $field,
36 36
                     'label' => ucfirst($field),
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
      */
68 68
     public function getFieldTypeFromDbColumnType($field)
69 69
     {
70
-        if (! array_key_exists($field, $this->db_column_types)) {
70
+        if (!array_key_exists($field, $this->db_column_types)) {
71 71
             return 'text';
72 72
         }
73 73
 
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
         $columns = $this->model->getConnection()->getSchemaBuilder()->getColumnListing($this->model->getTable());
149 149
         $fillable = $this->model->getFillable();
150 150
 
151
-        if (! empty($fillable)) {
151
+        if (!empty($fillable)) {
152 152
             $columns = array_intersect($columns, $fillable);
153 153
         }
154 154
 
Please login to merge, or discard this patch.