Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — next (#5733)
by
unknown
17:40 queued 03:05
created
src/app/Library/CrudPanel/Traits/FieldsProtectedMethods.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
             return ['name' => Str::replace(' ', '', $field)];
116 116
         }
117 117
 
118
-        if (is_array($field) && ! isset($field['name'])) {
118
+        if (is_array($field) && !isset($field['name'])) {
119 119
             abort(500, 'All fields must have their name defined', ['developer-error-exception']);
120 120
         }
121 121
 
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
193 193
         }
194 194
         // if there's a model defined, but no attribute
195 195
         // guess an attribute using the identifiableAttribute functionality in CrudTrait
196
-        if (isset($field['model']) && ! isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
196
+        if (isset($field['model']) && !isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
197 197
             $field['attribute'] = (new $field['model']())->identifiableAttribute();
198 198
         }
199 199
 
@@ -209,7 +209,7 @@  discard block
 block discarded – undo
209 209
      */
210 210
     protected function makeSureFieldHasLabel($field)
211 211
     {
212
-        if (! isset($field['label'])) {
212
+        if (!isset($field['label'])) {
213 213
             $name = str_replace(',', ' ', $field['name']);
214 214
             $name = str_replace('_id', '', $name);
215 215
             $field['label'] = mb_ucfirst(str_replace('_', ' ', $name));
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
227 227
      */
228 228
     protected function makeSureFieldHasType($field)
229 229
     {
230
-        if (! isset($field['type'])) {
230
+        if (!isset($field['type'])) {
231 231
             $field['type'] = isset($field['relation_type']) ? $this->inferFieldTypeFromRelationType($field['relation_type']) : $this->inferFieldTypeFromDbColumnType($field['name']);
232 232
         }
233 233
 
@@ -260,16 +260,16 @@  discard block
 block discarded – undo
260 260
      */
261 261
     protected function makeSureSubfieldsHaveNecessaryAttributes($field)
262 262
     {
263
-        if (! isset($field['subfields']) || ! is_array($field['subfields'])) {
263
+        if (!isset($field['subfields']) || !is_array($field['subfields'])) {
264 264
             return $field;
265 265
         }
266 266
 
267
-        if (! is_multidimensional_array($field['subfields'], true)) {
267
+        if (!is_multidimensional_array($field['subfields'], true)) {
268 268
             abort(500, 'Subfields of «'.$field['name'].'» are malformed. Make sure you provide an array of subfields.', ['developer-error-exception']);
269 269
         }
270 270
 
271 271
         foreach ($field['subfields'] as $key => $subfield) {
272
-            if (empty($subfield) || ! isset($subfield['name'])) {
272
+            if (empty($subfield) || !isset($subfield['name'])) {
273 273
                 abort(500, 'A subfield of «'.$field['name'].'» is malformed. Subfield attribute name can\'t be empty.', ['developer-error-exception']);
274 274
             }
275 275
 
@@ -284,7 +284,7 @@  discard block
 block discarded – undo
284 284
             $subfield['baseFieldName'] = is_array($subfield['name']) ? implode(',', $subfield['name']) : $subfield['name'];
285 285
             $subfield['baseFieldName'] = Str::afterLast($subfield['baseFieldName'], '.');
286 286
 
287
-            if (! isset($field['model'])) {
287
+            if (!isset($field['model'])) {
288 288
                 // we're inside a simple 'repeatable' with no model/relationship, so
289 289
                 // we assume all subfields are supposed to be text fields
290 290
                 $subfield['type'] = $subfield['type'] ?? 'text';
@@ -309,11 +309,11 @@  discard block
 block discarded – undo
309 309
                 case 'BelongsToMany':
310 310
                     $pivotSelectorField = static::getPivotFieldStructure($field);
311 311
 
312
-                    $pivot = Arr::where($field['subfields'], function ($item) use ($pivotSelectorField) {
312
+                    $pivot = Arr::where($field['subfields'], function($item) use ($pivotSelectorField) {
313 313
                         return $item['name'] === $pivotSelectorField['name'];
314 314
                     });
315 315
 
316
-                    if (! empty($pivot)) {
316
+                    if (!empty($pivot)) {
317 317
                         break;
318 318
                     }
319 319
 
@@ -337,11 +337,11 @@  discard block
 block discarded – undo
337 337
                     $entity = isset($field['baseEntity']) ? $field['baseEntity'].'.'.$field['entity'] : $field['entity'];
338 338
                     $relationInstance = $this->getRelationInstance(['entity' => $entity]);
339 339
 
340
-                    $localKeyField = Arr::where($field['subfields'], function ($item) use ($relationInstance) {
340
+                    $localKeyField = Arr::where($field['subfields'], function($item) use ($relationInstance) {
341 341
                         return $item['name'] === $relationInstance->getRelated()->getKeyName();
342 342
                     });
343 343
 
344
-                    if (! empty($localKeyField)) {
344
+                    if (!empty($localKeyField)) {
345 345
                         break;
346 346
                     }
347 347
 
@@ -366,7 +366,7 @@  discard block
 block discarded – undo
366 366
     {
367 367
         // if a tab was mentioned, we should enable it
368 368
         if (isset($field['tab'])) {
369
-            if (! $this->tabsEnabled()) {
369
+            if (!$this->tabsEnabled()) {
370 370
                 $this->enableTabs();
371 371
             }
372 372
         }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudColumn.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
      */
88 88
     public function key(string $key)
89 89
     {
90
-        if (! isset($this->attributes['name'])) {
90
+        if (!isset($this->attributes['name'])) {
91 91
             abort(500, 'Column name must be defined before changing the key.', ['developer-error-exception']);
92 92
         }
93 93
 
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
      */
180 180
     public function subfields($subfields)
181 181
     {
182
-        $callAttributeMacro = ! isset($this->attributes['subfields']);
182
+        $callAttributeMacro = !isset($this->attributes['subfields']);
183 183
         $this->attributes['subfields'] = $subfields;
184 184
         $this->attributes = $this->crud()->makeSureColumnHasNeededAttributes($this->attributes);
185 185
         if ($callAttributeMacro) {
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/CreateOperation.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,11 +36,11 @@
 block discarded – undo
36 36
     {
37 37
         $this->crud->allowAccess('create');
38 38
 
39
-        LifecycleHook::hookInto('create:before_setup', function () {
39
+        LifecycleHook::hookInto('create:before_setup', function() {
40 40
             $this->crud->setupDefaultSaveActions();
41 41
         });
42 42
 
43
-        LifecycleHook::hookInto('list:before_setup', function () {
43
+        LifecycleHook::hookInto('list:before_setup', function() {
44 44
             $this->crud->addButton('top', 'create', 'view', 'crud::buttons.create');
45 45
         });
46 46
     }
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/ShowOperation.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -31,25 +31,25 @@
 block discarded – undo
31 31
         $this->crud->allowAccess('show');
32 32
         $this->crud->setOperationSetting('setFromDb', true);
33 33
 
34
-        LifecycleHook::hookInto('show:before_setup', function () {
34
+        LifecycleHook::hookInto('show:before_setup', function() {
35 35
             $this->crud->loadDefaultOperationSettingsFromConfig();
36 36
 
37
-            if (! method_exists($this, 'setupShowOperation')) {
37
+            if (!method_exists($this, 'setupShowOperation')) {
38 38
                 $this->autoSetupShowOperation();
39 39
             }
40 40
         });
41 41
 
42
-        LifecycleHook::hookInto(['list:before_setup'], function () {
42
+        LifecycleHook::hookInto(['list:before_setup'], function() {
43 43
             $this->crud->addButton('line', 'show', 'view', 'crud::buttons.show', 'beginning');
44 44
         });
45 45
 
46
-        LifecycleHook::hookInto(['create:before_setup', 'update:before_setup'], function () {
46
+        LifecycleHook::hookInto(['create:before_setup', 'update:before_setup'], function() {
47 47
             $this->crud->addSaveAction([
48 48
                 'name' => 'save_and_preview',
49
-                'visible' => function ($crud) {
49
+                'visible' => function($crud) {
50 50
                     return $crud->hasAccess('show');
51 51
                 },
52
-                'redirect' => function ($crud, $request, $itemId = null) {
52
+                'redirect' => function($crud, $request, $itemId = null) {
53 53
                     $itemId = $itemId ?: $request->input('id');
54 54
                     $redirectUrl = $crud->route.'/'.$itemId.'/show';
55 55
                     if ($request->has('_locale')) {
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/UpdateOperation.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
     {
37 37
         $this->crud->allowAccess('update');
38 38
 
39
-        LifecycleHook::hookInto('update:before_setup', function () {
39
+        LifecycleHook::hookInto('update:before_setup', function() {
40 40
             $this->crud->loadDefaultOperationSettingsFromConfig();
41 41
 
42 42
             if ($this->crud->getModel()->translationEnabled()) {
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
             $this->crud->setupDefaultSaveActions();
51 51
         });
52 52
 
53
-        LifecycleHook::hookInto(['list:before_setup', 'show:before_setup'], function () {
53
+        LifecycleHook::hookInto(['list:before_setup', 'show:before_setup'], function() {
54 54
             $this->crud->addButton('line', 'update', 'view', 'crud::buttons.update', 'end');
55 55
         });
56 56
     }
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/ReorderOperation.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
         $this->crud->set('reorder.enabled', true);
38 38
         $this->crud->allowAccess('reorder');
39 39
 
40
-        LifecycleHook::hookInto('reorder:before_setup', function () {
40
+        LifecycleHook::hookInto('reorder:before_setup', function() {
41 41
             $this->crud->loadDefaultOperationSettingsFromConfig();
42 42
             $this->crud->setOperationSetting('reorderColumnNames', [
43 43
                 'parent_id' => 'parent_id',
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
             ]);
48 48
         });
49 49
 
50
-        LifecycleHook::hookInto('list:before_setup', function () {
50
+        LifecycleHook::hookInto('list:before_setup', function() {
51 51
             $this->crud->addButton('top', 'reorder', 'view', 'crud::buttons.reorder');
52 52
         });
53 53
     }
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
     {
64 64
         $this->crud->hasAccessOrFail('reorder');
65 65
 
66
-        if (! $this->crud->isReorderEnabled()) {
66
+        if (!$this->crud->isReorderEnabled()) {
67 67
             abort(403, 'Reorder is disabled.');
68 68
         }
69 69
 
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/DeleteOperation.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -30,11 +30,11 @@
 block discarded – undo
30 30
     {
31 31
         $this->crud->allowAccess('delete');
32 32
 
33
-        LifecycleHook::hookInto('delete:before_setup', function () {
33
+        LifecycleHook::hookInto('delete:before_setup', function() {
34 34
             $this->crud->loadDefaultOperationSettingsFromConfig();
35 35
         });
36 36
 
37
-        LifecycleHook::hookInto(['list:before_setup', 'show:before_setup'], function () {
37
+        LifecycleHook::hookInto(['list:before_setup', 'show:before_setup'], function() {
38 38
             $this->crud->addButton('line', 'delete', 'view', 'crud::buttons.delete', 'end');
39 39
         });
40 40
     }
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/Concerns/HasForm.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
         // Access
40 40
         $this->crud->allowAccess($operationName);
41 41
 
42
-        LifecycleHook::hookInto($operationName.':before_setup', function () use ($operationName) {
42
+        LifecycleHook::hookInto($operationName.':before_setup', function() use ($operationName) {
43 43
             // if the backpack.operations.{operationName} config exists, use that one
44 44
             // otherwise, use the generic backpack.operations.form config
45 45
             if (config()->has('backpack.operations.'.$operationName)) {
@@ -51,17 +51,17 @@  discard block
 block discarded – undo
51 51
             // add a reasonable "save and back" save action
52 52
             $this->crud->addSaveAction([
53 53
                 'name' => 'save_and_back',
54
-                'visible' => function ($crud) use ($operationName) {
54
+                'visible' => function($crud) use ($operationName) {
55 55
                     return $crud->hasAccess($operationName);
56 56
                 },
57
-                'redirect' => function ($crud, $request, $itemId = null) {
57
+                'redirect' => function($crud, $request, $itemId = null) {
58 58
                     return $request->request->has('_http_referrer') ? $request->request->get('_http_referrer') : $crud->route;
59 59
                 },
60 60
                 'button_text' => trans('backpack::crud.save_action_save_and_back'),
61 61
             ]);
62 62
         });
63 63
 
64
-        LifecycleHook::hookInto(['list:before_setup', 'show:before_setup'], function () use ($operationName, $buttonStack, $buttonMeta) {
64
+        LifecycleHook::hookInto(['list:before_setup', 'show:before_setup'], function() use ($operationName, $buttonStack, $buttonMeta) {
65 65
             $this->crud->button($operationName)->view('crud::buttons.quick')->stack($buttonStack)->meta($buttonMeta);
66 66
         });
67 67
     }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Hooks/LifecycleHooks.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -6,7 +6,7 @@  discard block
 block discarded – undo
6 6
 {
7 7
     public array $hooks = [];
8 8
 
9
-    public function hookInto(string|array $hooks, callable $callback): void
9
+    public function hookInto(string | array $hooks, callable $callback): void
10 10
     {
11 11
         $hooks = is_array($hooks) ? $hooks : [$hooks];
12 12
         foreach ($hooks as $hook) {
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
         }
15 15
     }
16 16
 
17
-    public function trigger(string|array $hooks, array $parameters = []): void
17
+    public function trigger(string | array $hooks, array $parameters = []): void
18 18
     {
19 19
         $hooks = is_array($hooks) ? $hooks : [$hooks];
20 20
         foreach ($hooks as $hook) {
Please login to merge, or discard this patch.