Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Pull Request — master (#487)
by Julien
03:21
created
src/resources/views/fields/date_range.blade.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -3,13 +3,13 @@
 block discarded – undo
3 3
 <?php
4 4
     // if the column has been cast to Carbon or Date (using attribute casting)
5 5
     // get the value as a date string
6
-    if (isset($field['value']) && ( $field['value'] instanceof \Carbon\Carbon || $field['value'] instanceof \Jenssegers\Date\Date )) {
7
-        $field['value'] = $field['value']->format( 'Y-m-d H:i:s' );
6
+    if (isset($field['value']) && ($field['value'] instanceof \Carbon\Carbon || $field['value'] instanceof \Jenssegers\Date\Date)) {
7
+        $field['value'] = $field['value']->format('Y-m-d H:i:s');
8 8
     }
9 9
 
10 10
     //Do the same as the above but for the range end field
11
-    if ( isset($entry) && ($entry->{$field['end_name']} instanceof \Carbon\Carbon || $entry->{$field['end_name']} instanceof \Jenssegers\Date\Date) ) {
12
-        $end_name = $entry->{$field['end_name']}->format( 'Y-m-d H:i:s' );
11
+    if (isset($entry) && ($entry->{$field['end_name']} instanceof \Carbon\Carbon || $entry->{$field['end_name']} instanceof \Jenssegers\Date\Date)) {
12
+        $end_name = $entry->{$field['end_name']}->format('Y-m-d H:i:s');
13 13
     } else {
14 14
         $end_name = null;
15 15
     }
Please login to merge, or discard this patch.
src/CrudServiceProvider.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace Backpack\CRUD;
4 4
 
5
-use Route;
6 5
 use Illuminate\Support\ServiceProvider;
7 6
 
8 7
 class CrudServiceProvider extends ServiceProvider
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
      */
75 75
     public function register()
76 76
     {
77
-        $this->app->bind('CRUD', function ($app) {
77
+        $this->app->bind('CRUD', function($app) {
78 78
             return new CRUD($app);
79 79
         });
80 80
 
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
         $loader->alias('Image', \Intervention\Image\Facades\Image::class);
93 93
 
94 94
         // map the elfinder prefix
95
-        if (! \Config::get('elfinder.route.prefix')) {
95
+        if (!\Config::get('elfinder.route.prefix')) {
96 96
             \Config::set('elfinder.route.prefix', \Config::get('backpack.base.route_prefix').'/elfinder');
97 97
         }
98 98
     }
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
     {
113 113
         $crudPubPath = public_path('vendor/backpack/crud');
114 114
 
115
-        if (! is_dir($crudPubPath)) {
115
+        if (!is_dir($crudPubPath)) {
116 116
             return true;
117 117
         }
118 118
 
Please login to merge, or discard this patch.
src/resources/views/fields/checklist_dependency.blade.php 2 patches
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -23,13 +23,13 @@
 block discarded – undo
23 23
             }
24 24
         }
25 25
 
26
-      //for update form, get initial state of the entity
27
-      if( isset($id) && $id ){
26
+        //for update form, get initial state of the entity
27
+        if( isset($id) && $id ){
28 28
 
29 29
         //get entity with relations for primary dependency
30 30
         $entity_dependencies = $entity_model->with($primary_dependency['entity'])
31
-          ->with($primary_dependency['entity'].'.'.$primary_dependency['entity_secondary'])
32
-          ->find($id);
31
+            ->with($primary_dependency['entity'].'.'.$primary_dependency['entity_secondary'])
32
+            ->find($id);
33 33
 
34 34
             $secondaries_from_primary = [];
35 35
 
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
         }
25 25
 
26 26
       //for update form, get initial state of the entity
27
-      if( isset($id) && $id ){
27
+      if (isset($id) && $id) {
28 28
 
29 29
         //get entity with relations for primary dependency
30 30
         $entity_dependencies = $entity_model->with($primary_dependency['entity'])
Please login to merge, or discard this patch.
src/app/Http/Controllers/CrudFeatures/AjaxTable.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
 
15 15
         // create an array with the names of the searchable columns
16 16
         $columns = collect($this->crud->columns)
17
-                    ->reject(function ($column, $key) {
17
+                    ->reject(function($column, $key) {
18 18
                         // the select_multiple columns are not searchable
19 19
                         return isset($column['type']) && $column['type'] == 'select_multiple';
20 20
                     })
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
         $dataTable = new \LiveControl\EloquentDataTable\DataTable($this->crud->query, $columns);
28 28
 
29 29
         // make the datatable use the column types instead of just echoing the text
30
-        $dataTable->setFormatRowFunction(function ($entry) {
30
+        $dataTable->setFormatRowFunction(function($entry) {
31 31
             // get the actual HTML for each row's cell
32 32
             $row_items = $this->crud->getRowViews($entry, $this->crud);
33 33
 
Please login to merge, or discard this patch.
src/PanelTraits/Fields.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -24,18 +24,18 @@  discard block
 block discarded – undo
24 24
         }
25 25
 
26 26
         // if the label is missing, we should set it
27
-        if (! isset($complete_field_array['label'])) {
27
+        if (!isset($complete_field_array['label'])) {
28 28
             $complete_field_array['label'] = ucfirst($complete_field_array['name']);
29 29
         }
30 30
 
31 31
         // if the field type is missing, we should set it
32
-        if (! isset($complete_field_array['type'])) {
32
+        if (!isset($complete_field_array['type'])) {
33 33
             $complete_field_array['type'] = $this->getFieldTypeFromDbColumnType($complete_field_array['name']);
34 34
         }
35 35
 
36 36
         // if a tab was mentioned, we should enable it
37 37
         if (isset($complete_field_array['tab'])) {
38
-            if (! $this->tabsEnabled()) {
38
+            if (!$this->tabsEnabled()) {
39 39
                 $this->enableTabs();
40 40
             }
41 41
         }
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
      */
147 147
     public function removeFields($array_of_names, $form = 'both')
148 148
     {
149
-        if (! empty($array_of_names)) {
149
+        if (!empty($array_of_names)) {
150 150
             foreach ($array_of_names as $name) {
151 151
                 $this->removeField($name, $form);
152 152
             }
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
208 208
                 $jsonCastables = ['array', 'object', 'json'];
209 209
                 $fieldCasting = $casted_attributes[$field['name']];
210 210
 
211
-                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && ! empty($data[$field['name']]) && ! is_array($data[$field['name']])) {
211
+                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && !empty($data[$field['name']]) && !is_array($data[$field['name']])) {
212 212
                     try {
213 213
                         $data[$field['name']] = json_decode($data[$field['name']]);
214 214
                     } catch (Exception $e) {
Please login to merge, or discard this patch.
src/PanelTraits/Tabs.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
 
30 30
     public function tabsDisabled()
31 31
     {
32
-        return ! $this->tabsEnabled;
32
+        return !$this->tabsEnabled;
33 33
     }
34 34
 
35 35
     public function setTabsType($type)
@@ -97,13 +97,13 @@  discard block
 block discarded – undo
97 97
         if ($this->boxExists($boxLabel) && $this->tabExists($boxLabel, $tabLabel)) {
98 98
             $boxFields = $this->getBoxFields($boxLabel);
99 99
 
100
-            $fields_for_current_tab = collect($boxFields)->filter(function ($value, $key) use ($tabLabel) {
100
+            $fields_for_current_tab = collect($boxFields)->filter(function($value, $key) use ($tabLabel) {
101 101
                 return isset($value['tab']) && $value['tab'] == $tabLabel;
102 102
             });
103 103
 
104 104
             if ($this->isLastTab($boxLabel, $tabLabel)) {
105
-                $fields_without_a_tab = collect($boxFields)->filter(function ($value, $key) {
106
-                    return ! isset($value['tab']);
105
+                $fields_without_a_tab = collect($boxFields)->filter(function($value, $key) {
106
+                    return !isset($value['tab']);
107 107
                 });
108 108
 
109 109
                 $fields_for_current_tab = $fields_for_current_tab->merge($fields_without_a_tab);
@@ -121,11 +121,11 @@  discard block
 block discarded – undo
121 121
         $fields = $this->getBoxFields($boxLabel);
122 122
 
123 123
         $fields_with_tabs = collect($fields)
124
-            ->filter(function ($value, $key) {
124
+            ->filter(function($value, $key) {
125 125
                 return isset($value['tab']);
126 126
             })
127
-            ->each(function ($value, $key) use (&$tabs) {
128
-                if (! in_array($value['tab'], $tabs)) {
127
+            ->each(function($value, $key) use (&$tabs) {
128
+                if (!in_array($value['tab'], $tabs)) {
129 129
                     $tabs[] = $value['tab'];
130 130
                 }
131 131
             });
Please login to merge, or discard this patch.
src/PanelTraits/Boxes.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
 
29 29
     public function sideBoxesDisabled()
30 30
     {
31
-        return ! $this->sideBoxesEnabled;
31
+        return !$this->sideBoxesEnabled;
32 32
     }
33 33
 
34 34
     public function boxExists($label)
@@ -59,13 +59,13 @@  discard block
 block discarded – undo
59 59
         if ($this->boxExists($label)) {
60 60
             $all_fields = $this->getCurrentFields();
61 61
 
62
-            $fields_for_current_box = collect($all_fields)->filter(function ($value, $key) use ($label) {
62
+            $fields_for_current_box = collect($all_fields)->filter(function($value, $key) use ($label) {
63 63
                 return isset($value['box']) && $value['box'] == $label;
64 64
             });
65 65
 
66 66
             if ($this->isLastBox($label)) {
67
-                $fields_without_a_box = collect($all_fields)->filter(function ($value, $key) {
68
-                    return ! isset($value['box']);
67
+                $fields_without_a_box = collect($all_fields)->filter(function($value, $key) {
68
+                    return !isset($value['box']);
69 69
                 });
70 70
 
71 71
                 $fields_for_current_box = $fields_for_current_box->merge($fields_without_a_box);
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
         $this->boxesOptions[$label] = $options;
83 83
 
84 84
         // if a "side" box was mentioned, we should enable it
85
-        if (! empty($options['side'])) {
85
+        if (!empty($options['side'])) {
86 86
             $this->enableSideBoxes();
87 87
         }
88 88
     }
@@ -112,12 +112,12 @@  discard block
 block discarded – undo
112 112
         $fields = $this->getCurrentFields();
113 113
 
114 114
         $fields_with_boxes = collect($fields)
115
-            ->filter(function ($value, $key) {
115
+            ->filter(function($value, $key) {
116 116
                 return isset($value['box']);
117 117
             })
118
-            ->each(function ($value, $key) use (&$boxes, $columnFilter) {
119
-                if (! isset($columnFilter) || ($columnFilter === 'side' xor ! $this->getBoxOptions($value['box'])['side'])) {
120
-                    if (! in_array($value['box'], $boxes)) {
118
+            ->each(function($value, $key) use (&$boxes, $columnFilter) {
119
+                if (!isset($columnFilter) || ($columnFilter === 'side' xor !$this->getBoxOptions($value['box'])['side'])) {
120
+                    if (!in_array($value['box'], $boxes)) {
121 121
                         $boxes[] = $value['box'];
122 122
                     }
123 123
                 }
Please login to merge, or discard this patch.