Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Pull Request — master (#487)
by Julien
03:21
created
src/PanelTraits/Filters.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@  discard block
 block discarded – undo
10 10
 
11 11
     public function filtersEnabled()
12 12
     {
13
-        return ! is_array($this->filters);
13
+        return !is_array($this->filters);
14 14
     }
15 15
 
16 16
     public function filtersDisabled()
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
         $this->enableFilters();
55 55
 
56 56
         // check if another filter with the same name exists
57
-        if (! isset($options['name'])) {
57
+        if (!isset($options['name'])) {
58 58
             abort(500, 'All your filters need names.');
59 59
         }
60 60
         if ($this->filters->contains('name', $options['name'])) {
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
 
132 132
     public function removeFilter($name)
133 133
     {
134
-        $this->filters = $this->filters->reject(function ($filter) use ($name) {
134
+        $this->filters = $this->filters->reject(function($filter) use ($name) {
135 135
             return $filter->name == $name;
136 136
         });
137 137
     }
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
         $this->type = $options['type'];
202 202
         $this->label = $options['label'];
203 203
 
204
-        if (! isset($options['placeholder'])) {
204
+        if (!isset($options['placeholder'])) {
205 205
             $this->placeholder = '';
206 206
         } else {
207 207
             $this->placeholder = $options['placeholder'];
@@ -218,16 +218,16 @@  discard block
 block discarded – undo
218 218
 
219 219
     public function checkOptionsIntegrity($options)
220 220
     {
221
-        if (! isset($options['name'])) {
221
+        if (!isset($options['name'])) {
222 222
             abort(500, 'Please make sure all your filters have names.');
223 223
         }
224
-        if (! isset($options['type'])) {
224
+        if (!isset($options['type'])) {
225 225
             abort(500, 'Please make sure all your filters have types.');
226 226
         }
227
-        if (! \View::exists('crud::filters.'.$options['type'])) {
227
+        if (!\View::exists('crud::filters.'.$options['type'])) {
228 228
             abort(500, 'No filter view named "'.$options['type'].'.blade.php" was found.');
229 229
         }
230
-        if (! isset($options['label'])) {
230
+        if (!isset($options['label'])) {
231 231
             abort(500, 'Please make sure all your filters have labels.');
232 232
         }
233 233
     }
Please login to merge, or discard this patch.
src/PanelTraits/Fields.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -24,18 +24,18 @@  discard block
 block discarded – undo
24 24
         }
25 25
 
26 26
         // if the label is missing, we should set it
27
-        if (! isset($complete_field_array['label'])) {
27
+        if (!isset($complete_field_array['label'])) {
28 28
             $complete_field_array['label'] = ucfirst($complete_field_array['name']);
29 29
         }
30 30
 
31 31
         // if the field type is missing, we should set it
32
-        if (! isset($complete_field_array['type'])) {
32
+        if (!isset($complete_field_array['type'])) {
33 33
             $complete_field_array['type'] = $this->getFieldTypeFromDbColumnType($complete_field_array['name']);
34 34
         }
35 35
 
36 36
         // if a tab was mentioned, we should enable it
37 37
         if (isset($complete_field_array['tab'])) {
38
-            if (! $this->tabsEnabled()) {
38
+            if (!$this->tabsEnabled()) {
39 39
                 $this->enableTabs();
40 40
             }
41 41
         }
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
      */
147 147
     public function removeFields($array_of_names, $form = 'both')
148 148
     {
149
-        if (! empty($array_of_names)) {
149
+        if (!empty($array_of_names)) {
150 150
             foreach ($array_of_names as $name) {
151 151
                 $this->removeField($name, $form);
152 152
             }
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
208 208
                 $jsonCastables = ['array', 'object', 'json'];
209 209
                 $fieldCasting = $casted_attributes[$field['name']];
210 210
 
211
-                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && ! empty($data[$field['name']]) && ! is_array($data[$field['name']])) {
211
+                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && !empty($data[$field['name']]) && !is_array($data[$field['name']])) {
212 212
                     try {
213 213
                         $data[$field['name']] = json_decode($data[$field['name']]);
214 214
                     } catch (Exception $e) {
Please login to merge, or discard this patch.
src/PanelTraits/Tabs.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
 
30 30
     public function tabsDisabled()
31 31
     {
32
-        return ! $this->tabsEnabled;
32
+        return !$this->tabsEnabled;
33 33
     }
34 34
 
35 35
     public function setTabsType($type)
@@ -97,13 +97,13 @@  discard block
 block discarded – undo
97 97
         if ($this->boxExists($boxLabel) && $this->tabExists($boxLabel, $tabLabel)) {
98 98
             $boxFields = $this->getBoxFields($boxLabel);
99 99
 
100
-            $fields_for_current_tab = collect($boxFields)->filter(function ($value, $key) use ($tabLabel) {
100
+            $fields_for_current_tab = collect($boxFields)->filter(function($value, $key) use ($tabLabel) {
101 101
                 return isset($value['tab']) && $value['tab'] == $tabLabel;
102 102
             });
103 103
 
104 104
             if ($this->isLastTab($boxLabel, $tabLabel)) {
105
-                $fields_without_a_tab = collect($boxFields)->filter(function ($value, $key) {
106
-                    return ! isset($value['tab']);
105
+                $fields_without_a_tab = collect($boxFields)->filter(function($value, $key) {
106
+                    return !isset($value['tab']);
107 107
                 });
108 108
 
109 109
                 $fields_for_current_tab = $fields_for_current_tab->merge($fields_without_a_tab);
@@ -121,11 +121,11 @@  discard block
 block discarded – undo
121 121
         $fields = $this->getBoxFields($boxLabel);
122 122
 
123 123
         $fields_with_tabs = collect($fields)
124
-            ->filter(function ($value, $key) {
124
+            ->filter(function($value, $key) {
125 125
                 return isset($value['tab']);
126 126
             })
127
-            ->each(function ($value, $key) use (&$tabs) {
128
-                if (! in_array($value['tab'], $tabs)) {
127
+            ->each(function($value, $key) use (&$tabs) {
128
+                if (!in_array($value['tab'], $tabs)) {
129 129
                     $tabs[] = $value['tab'];
130 130
                 }
131 131
             });
Please login to merge, or discard this patch.
src/PanelTraits/Boxes.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
 
29 29
     public function sideBoxesDisabled()
30 30
     {
31
-        return ! $this->sideBoxesEnabled;
31
+        return !$this->sideBoxesEnabled;
32 32
     }
33 33
 
34 34
     public function boxExists($label)
@@ -59,13 +59,13 @@  discard block
 block discarded – undo
59 59
         if ($this->boxExists($label)) {
60 60
             $all_fields = $this->getCurrentFields();
61 61
 
62
-            $fields_for_current_box = collect($all_fields)->filter(function ($value, $key) use ($label) {
62
+            $fields_for_current_box = collect($all_fields)->filter(function($value, $key) use ($label) {
63 63
                 return isset($value['box']) && $value['box'] == $label;
64 64
             });
65 65
 
66 66
             if ($this->isLastBox($label)) {
67
-                $fields_without_a_box = collect($all_fields)->filter(function ($value, $key) {
68
-                    return ! isset($value['box']);
67
+                $fields_without_a_box = collect($all_fields)->filter(function($value, $key) {
68
+                    return !isset($value['box']);
69 69
                 });
70 70
 
71 71
                 $fields_for_current_box = $fields_for_current_box->merge($fields_without_a_box);
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
         $this->boxesOptions[$label] = $options;
83 83
 
84 84
         // if a "side" box was mentioned, we should enable it
85
-        if (! empty($options['side'])) {
85
+        if (!empty($options['side'])) {
86 86
             $this->enableSideBoxes();
87 87
         }
88 88
     }
@@ -112,12 +112,12 @@  discard block
 block discarded – undo
112 112
         $fields = $this->getCurrentFields();
113 113
 
114 114
         $fields_with_boxes = collect($fields)
115
-            ->filter(function ($value, $key) {
115
+            ->filter(function($value, $key) {
116 116
                 return isset($value['box']);
117 117
             })
118
-            ->each(function ($value, $key) use (&$boxes, $columnFilter) {
119
-                if (! isset($columnFilter) || ($columnFilter === 'side' xor ! $this->getBoxOptions($value['box'])['side'])) {
120
-                    if (! in_array($value['box'], $boxes)) {
118
+            ->each(function($value, $key) use (&$boxes, $columnFilter) {
119
+                if (!isset($columnFilter) || ($columnFilter === 'side' xor !$this->getBoxOptions($value['box'])['side'])) {
120
+                    if (!in_array($value['box'], $boxes)) {
121 121
                         $boxes[] = $value['box'];
122 122
                     }
123 123
                 }
Please login to merge, or discard this patch.