Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Pull Request — master (#1504)
by Thomas
07:11 queued 03:32
created
src/resources/views/fields/date_picker.blade.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -3,11 +3,11 @@
 block discarded – undo
3 3
 <?php
4 4
     // if the column has been cast to Carbon or Date (using attribute casting)
5 5
     // get the value as a date string
6
-    if (isset($field['value']) && ( $field['value'] instanceof \Carbon\Carbon || $field['value'] instanceof \Jenssegers\Date\Date )) {
6
+    if (isset($field['value']) && ($field['value'] instanceof \Carbon\Carbon || $field['value'] instanceof \Jenssegers\Date\Date)) {
7 7
         $field['value'] = $field['value']->format('Y-m-d');
8 8
     }
9 9
 
10
-    $field_language = isset($field['date_picker_options']['language'])?$field['date_picker_options']['language']:\App::getLocale();
10
+    $field_language = isset($field['date_picker_options']['language']) ? $field['date_picker_options']['language'] : \App::getLocale();
11 11
 ?>
12 12
 
13 13
 <div @include('crud::inc.field_wrapper_attributes') >
Please login to merge, or discard this patch.
src/resources/views/fields/table.blade.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,7 @@
 block discarded – undo
5 5
     $min = isset($field['min']) && (int) $field['min'] > 0 ? $field['min'] : -1;
6 6
     $item_name = strtolower(isset($field['entity_singular']) && !empty($field['entity_singular']) ? $field['entity_singular'] : $field['label']);
7 7
 
8
-    $items = old($field['name']) ? (old($field['name'])) : (isset($field['value']) ? ($field['value']) : (isset($field['default']) ? ($field['default']) : '' ));
8
+    $items = old($field['name']) ? (old($field['name'])) : (isset($field['value']) ? ($field['value']) : (isset($field['default']) ? ($field['default']) : ''));
9 9
 
10 10
     // make sure not matter the attribute casting
11 11
     // the $items variable contains a properly defined JSON
Please login to merge, or discard this patch.
src/resources/views/reorder.blade.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -76,10 +76,10 @@
 block discarded – undo
76 76
                 <ol class="sortable">
77 77
                 <?php
78 78
                     $all_entries = collect($entries->all())->sortBy('lft')->keyBy($crud->getModel()->getKeyName());
79
-                    $root_entries = $all_entries->filter(function ($item) {
79
+                    $root_entries = $all_entries->filter(function($item) {
80 80
                         return $item->parent_id == 0;
81 81
                     });
82
-                    foreach ($root_entries as $key => $entry){
82
+                    foreach ($root_entries as $key => $entry) {
83 83
                         $root_entries[$key] = tree_element($entry, $key, $all_entries, $crud);
84 84
                     }
85 85
                 ?>
Please login to merge, or discard this patch.
src/ModelTraits/SpatieTranslatable/SluggableObserver.php 1 patch
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -2,8 +2,8 @@
 block discarded – undo
2 2
 
3 3
 namespace Backpack\CRUD\ModelTraits\SpatieTranslatable;
4 4
 
5
-use Illuminate\Database\Eloquent\Model;
6 5
 use Illuminate\Contracts\Events\Dispatcher;
6
+use Illuminate\Database\Eloquent\Model;
7 7
 
8 8
 class SluggableObserver extends \Cviebrock\EloquentSluggable\SluggableObserver
9 9
 {
Please login to merge, or discard this patch.
src/ModelTraits/SpatieTranslatable/Sluggable.php 3 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@
 block discarded – undo
47 47
         $separator = $config['separator'];
48 48
         $attribute = $attribute.'->'.$this->getLocale();
49 49
 
50
-        return $query->where(function (Builder $q) use ($attribute, $slug, $separator) {
50
+        return $query->where(function(Builder $q) use ($attribute, $slug, $separator) {
51 51
             $q->where($attribute, '=', $slug)
52 52
                 ->orWhere($attribute, 'LIKE', $slug.$separator.'%');
53 53
         });
Please login to merge, or discard this patch.
Unused Use Statements   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -2,9 +2,9 @@
 block discarded – undo
2 2
 
3 3
 namespace Backpack\CRUD\ModelTraits\SpatieTranslatable;
4 4
 
5
-use Illuminate\Database\Eloquent\Model;
6
-use Illuminate\Database\Eloquent\Builder;
7 5
 use Cviebrock\EloquentSluggable\Sluggable as OriginalSluggable;
6
+use Illuminate\Database\Eloquent\Builder;
7
+use Illuminate\Database\Eloquent\Model;
8 8
 
9 9
 trait Sluggable
10 10
 {
Please login to merge, or discard this patch.
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,6 @@
 block discarded – undo
37 37
      * Query scope for finding "similar" slugs, used to determine uniqueness.
38 38
      *
39 39
      * @param \Illuminate\Database\Eloquent\Builder $query
40
-     * @param \Illuminate\Database\Eloquent\Model $model
41 40
      * @param string $attribute
42 41
      * @param array $config
43 42
      * @param string $slug
Please login to merge, or discard this patch.
src/ModelTraits/SpatieTranslatable/HasTranslations.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
      */
25 25
     public function getAttributeValue($key)
26 26
     {
27
-        if (! $this->isTranslatableAttribute($key)) {
27
+        if (!$this->isTranslatableAttribute($key)) {
28 28
             return parent::getAttributeValue($key);
29 29
         }
30 30
 
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
      */
73 73
     public function update(array $attributes = [], array $options = [])
74 74
     {
75
-        if (! $this->exists) {
75
+        if (!$this->exists) {
76 76
             return false;
77 77
         }
78 78
 
Please login to merge, or discard this patch.
src/app/Http/Controllers/CrudFeatures/Revisions.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@
 block discarded – undo
41 41
         $this->crud->hasAccessOrFail('revisions');
42 42
 
43 43
         $revisionId = \Request::input('revision_id', false);
44
-        if (! $revisionId) {
44
+        if (!$revisionId) {
45 45
             abort(500, 'Can\'t restore revision without revision_id');
46 46
         } else {
47 47
             $this->crud->restoreRevision($id, $revisionId); // do the update
Please login to merge, or discard this patch.
src/CrudServiceProvider.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace Backpack\CRUD;
4 4
 
5
-use Route;
6 5
 use Illuminate\Support\ServiceProvider;
7 6
 
8 7
 class CrudServiceProvider extends ServiceProvider
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
      */
77 77
     public function register()
78 78
     {
79
-        $this->app->bind('CRUD', function ($app) {
79
+        $this->app->bind('CRUD', function($app) {
80 80
             return new CRUD($app);
81 81
         });
82 82
 
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
         $this->commands($this->commands);
92 92
 
93 93
         // map the elfinder prefix
94
-        if (! \Config::get('elfinder.route.prefix')) {
94
+        if (!\Config::get('elfinder.route.prefix')) {
95 95
             \Config::set('elfinder.route.prefix', \Config::get('backpack.base.route_prefix').'/elfinder');
96 96
         }
97 97
     }
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
     {
112 112
         $crudPubPath = public_path('vendor/backpack/crud');
113 113
 
114
-        if (! is_dir($crudPubPath)) {
114
+        if (!is_dir($crudPubPath)) {
115 115
             return true;
116 116
         }
117 117
 
Please login to merge, or discard this patch.
src/resources/views/fields/checklist_dependency.blade.php 2 patches
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -23,13 +23,13 @@
 block discarded – undo
23 23
             }
24 24
         }
25 25
 
26
-      //for update form, get initial state of the entity
27
-      if( isset($id) && $id ){
26
+        //for update form, get initial state of the entity
27
+        if( isset($id) && $id ){
28 28
 
29 29
         //get entity with relations for primary dependency
30 30
         $entity_dependencies = $entity_model->with($primary_dependency['entity'])
31
-          ->with($primary_dependency['entity'].'.'.$primary_dependency['entity_secondary'])
32
-          ->find($id);
31
+            ->with($primary_dependency['entity'].'.'.$primary_dependency['entity_secondary'])
32
+            ->find($id);
33 33
 
34 34
             $secondaries_from_primary = [];
35 35
 
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
         }
25 25
 
26 26
       //for update form, get initial state of the entity
27
-      if( isset($id) && $id ){
27
+      if (isset($id) && $id) {
28 28
 
29 29
         //get entity with relations for primary dependency
30 30
         $entity_dependencies = $entity_model->with($primary_dependency['entity'])
Please login to merge, or discard this patch.