ConfirmsPasswords::confirm() - Code Metrics - Inspection of "Merge branch 'add-support-for-laravel-7' of https:..." - Laravel-Backpack/CRUD - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6a87fb...a42a1b )

by Cristian

created 2020-03-04 06:48 UTC

ConfirmsPasswords::confirm() A

↳ Parent: ConfirmsPasswords

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
nc	2
nop	1
dl	0
loc	10
rs	9.9332
c	0
b	0
f	0

<?php

namespace Backpack\CRUD\app\Library\Auth;

use Illuminate\Http\Request;
use Illuminate\Http\Response;

trait ConfirmsPasswords
{
    use RedirectsUsers;

    /**
     * Display the password confirmation view.
     *
     * @return \Illuminate\Http\Response

     */
    public function showConfirmForm()
    {
        return view('auth.passwords.confirm');
    }

    /**
     * Confirm the given user's password.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return \Illuminate\Http\RedirectResponse|\Illuminate\Http\JsonResponse

     */
    public function confirm(Request $request)
    {
        $request->validate($this->rules(), $this->validationErrorMessages());

        $this->resetPasswordConfirmationTimeout($request);

        return $request->wantsJson()
                    ? new Response('', 204)
                    : redirect()->intended($this->redirectPath());
    }

    /**
     * Reset the password confirmation timeout.
     *
     * @param  \Illuminate\Http\Request  $request
     * @return void
     */
    protected function resetPasswordConfirmationTimeout(Request $request)
    {
        $request->session()->put('auth.password_confirmed_at', time());

    }

    /**
     * Get the password confirmation validation rules.
     *
     * @return array

     */
    protected function rules()
    {
        return [
            'password' => 'required|password',
        ];
    }

    /**
     * Get the password confirmation validation error messages.
     *
     * @return array
     */
    protected function validationErrorMessages()
    {
        return [];
    }
}


1			<?php
2
3			namespace Backpack\CRUD\app\Library\Auth;
4
5			use Illuminate\Http\Request;
6			use Illuminate\Http\Response;
7
8			trait ConfirmsPasswords
9			{
10			use RedirectsUsers;
11
12			/**
13			* Display the password confirmation view.
14			*
15			* @return \Illuminate\Http\Response
			0 ignored issues – show Documentation introduced 2020-03-04 06:41 UTC by Report Bug Copy Issue Report Should the return type not be `\Illuminate\View\View\|\I...\Contracts\View\Factory`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
16			*/
17			public function showConfirmForm()
18			{
19			return view('auth.passwords.confirm');
20			}
21
22			/**
23			* Confirm the given user's password.
24			*
25			* @param \Illuminate\Http\Request $request
26			* @return \Illuminate\Http\RedirectResponse\|\Illuminate\Http\JsonResponse
			0 ignored issues – show Documentation introduced 2020-03-04 06:41 UTC by Report Bug Copy Issue Report Should the return type not be `Response\|\Illuminate\Http\RedirectResponse`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
27			*/
28			public function confirm(Request $request)
29			{
30			$request->validate($this->rules(), $this->validationErrorMessages());
31
32			$this->resetPasswordConfirmationTimeout($request);
33
34			return $request->wantsJson()
35			? new Response('', 204)
36			: redirect()->intended($this->redirectPath());
37			}
38
39			/**
40			* Reset the password confirmation timeout.
41			*
42			* @param \Illuminate\Http\Request $request
43			* @return void
44			*/
45			protected function resetPasswordConfirmationTimeout(Request $request)
46			{
47			$request->session()->put('auth.password_confirmed_at', time());
			0 ignored issues – show Bug introduced 2020-03-04 06:41 UTC by Report Bug Copy Issue Report The method `put()` does not seem to exist on `object<Symfony\Component...ssion\SessionInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
48			}
49
50			/**
51			* Get the password confirmation validation rules.
52			*
53			* @return array
			0 ignored issues – show Documentation introduced 2020-03-04 06:41 UTC by Report Bug Copy Issue Report Consider making the return type a bit more specific; maybe use `array<string,string>`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
54			*/
55			protected function rules()
56			{
57			return [
58			'password' => 'required\|password',
59			];
60			}
61
62			/**
63			* Get the password confirmation validation error messages.
64			*
65			* @return array
66			*/
67			protected function validationErrorMessages()
68			{
69			return [];
70			}
71			}
72

Laravel-Backpack / CRUD

Scrutinizer GitHub App not installed

Push — master ( 6a87fb...a42a1b )

ConfirmsPasswords::confirm() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like