We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
10 | trait SendsPasswordResetEmails |
||
11 | { |
||
12 | /** |
||
13 | * Display the form to request a password reset link. |
||
14 | * |
||
15 | * @return \Illuminate\Http\Response |
||
|
|||
16 | */ |
||
17 | public function showLinkRequestForm() |
||
21 | |||
22 | /** |
||
23 | * Send a reset link to the given user. |
||
24 | * |
||
25 | * @param \Illuminate\Http\Request $request |
||
26 | * @return \Illuminate\Http\RedirectResponse|\Illuminate\Http\JsonResponse |
||
27 | */ |
||
28 | public function sendResetLinkEmail(Request $request) |
||
43 | |||
44 | /** |
||
45 | * Validate the email for the given request. |
||
46 | * |
||
47 | * @param \Illuminate\Http\Request $request |
||
48 | * @return void |
||
49 | */ |
||
50 | protected function validateEmail(Request $request) |
||
54 | |||
55 | /** |
||
56 | * Get the needed authentication credentials from the request. |
||
57 | * |
||
58 | * @param \Illuminate\Http\Request $request |
||
59 | * @return array |
||
60 | */ |
||
61 | protected function credentials(Request $request) |
||
65 | |||
66 | /** |
||
67 | * Get the response for a successful password reset link. |
||
68 | * |
||
69 | * @param \Illuminate\Http\Request $request |
||
70 | * @param string $response |
||
71 | * @return \Illuminate\Http\RedirectResponse|\Illuminate\Http\JsonResponse |
||
72 | */ |
||
73 | protected function sendResetLinkResponse(Request $request, $response) |
||
79 | |||
80 | /** |
||
81 | * Get the response for a failed password reset link. |
||
82 | * |
||
83 | * @param \Illuminate\Http\Request $request |
||
84 | * @param string $response |
||
85 | * @return \Illuminate\Http\RedirectResponse|\Illuminate\Http\JsonResponse |
||
86 | */ |
||
87 | View Code Duplication | protected function sendResetLinkFailedResponse(Request $request, $response) |
|
99 | |||
100 | /** |
||
101 | * Get the broker to be used during password reset. |
||
102 | * |
||
103 | * @return \Illuminate\Contracts\Auth\PasswordBroker |
||
104 | */ |
||
105 | public function broker() |
||
109 | } |
||
110 |
This check compares the return type specified in the
@return
annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch.