Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — main (#5715)
by Pedro
15:17
created
tests/Unit/CrudPanel/CrudPanelValidationTest.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
             'password' => 'test',
46 46
         ]);
47 47
 
48
-        $request->setRouteResolver(function () use ($request) {
48
+        $request->setRouteResolver(function() use ($request) {
49 49
             return (new Route('POST', 'users', ['Backpack\CRUD\Tests\Config\Http\Controllers\UserCrudController', 'create']))->bind($request);
50 50
         });
51 51
 
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
             'email' => '',
86 86
         ]);
87 87
 
88
-        $request->setRouteResolver(function () use ($request) {
88
+        $request->setRouteResolver(function() use ($request) {
89 89
             return (new Route('POST', 'users', ['Backpack\CRUD\Tests\Config\Http\Controllers\UserCrudController', 'create']))->bind($request);
90 90
         });
91 91
 
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
             'password' => 'test',
126 126
         ]);
127 127
 
128
-        $request->setRouteResolver(function () use ($request) {
128
+        $request->setRouteResolver(function() use ($request) {
129 129
             return (new Route('POST', 'users', ['Backpack\CRUD\Tests\Config\Http\Controllers\UserCrudController', 'create']))->bind($request);
130 130
         });
131 131
 
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
             'name' => 'test',
248 248
         ]);
249 249
 
250
-        $request->setRouteResolver(function () use ($request) {
250
+        $request->setRouteResolver(function() use ($request) {
251 251
             return (new Route('POST', 'users', ['Backpack\CRUD\Tests\Config\Http\Controllers\UserCrudController', 'create']))->bind($request);
252 252
         });
253 253
 
Please login to merge, or discard this patch.
src/ThemeServiceProvider.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
     protected string $packageName = 'theme-name';
15 15
     protected array $commands = [];
16 16
     protected bool $theme = true;
17
-    protected null|string $componentsNamespace = null;
17
+    protected null | string $componentsNamespace = null;
18 18
 
19 19
     /**
20 20
      * -------------------------
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
         }
146 146
 
147 147
         // Registering package commands.
148
-        if (! empty($this->commands)) {
148
+        if (!empty($this->commands)) {
149 149
             $this->commands($this->commands);
150 150
         }
151 151
     }
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
240 240
     protected function packageDirectoryExistsAndIsNotEmpty($name)
241 241
     {
242 242
         // check if directory exists
243
-        if (! is_dir($this->getPath().'/'.$name)) {
243
+        if (!is_dir($this->getPath().'/'.$name)) {
244 244
             return false;
245 245
         }
246 246
 
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
     public function registerPackageBladeComponents()
266 266
     {
267 267
         if ($this->componentsNamespace) {
268
-            $this->app->afterResolving(BladeCompiler::class, function () {
268
+            $this->app->afterResolving(BladeCompiler::class, function() {
269 269
                 Blade::componentNamespace($this->componentsNamespace, $this->packageName);
270 270
             });
271 271
         }
Please login to merge, or discard this patch.
src/app/Library/Database/Table.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
 
23 23
                 public function getNotnull()
24 24
                 {
25
-                    return ! $this->column['nullable'];
25
+                    return !$this->column['nullable'];
26 26
                 }
27 27
 
28 28
                 public function getDefault()
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/AutoSet.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -14,8 +14,8 @@  discard block
 block discarded – undo
14 14
     {
15 15
         $this->getDbColumnTypes();
16 16
 
17
-        array_map(function ($field) use ($setFields, $setColumns) {
18
-            if ($setFields && ! isset($this->getCleanStateFields()[$field])) {
17
+        array_map(function($field) use ($setFields, $setColumns) {
18
+            if ($setFields && !isset($this->getCleanStateFields()[$field])) {
19 19
                 $this->addField([
20 20
                     'name' => $field,
21 21
                     'label' => $this->makeLabel($field),
@@ -28,7 +28,7 @@  discard block
 block discarded – undo
28 28
                 ]);
29 29
             }
30 30
 
31
-            if ($setColumns && ! in_array($field, $this->model->getHidden()) && ! isset($this->columns()[$field])) {
31
+            if ($setColumns && !in_array($field, $this->model->getHidden()) && !isset($this->columns()[$field])) {
32 32
                 $this->addColumn([
33 33
                     'name' => $field,
34 34
                     'label' => $this->makeLabel($field),
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
     {
51 51
         $dbColumnTypes = [];
52 52
 
53
-        if (! $this->driverIsSql()) {
53
+        if (!$this->driverIsSql()) {
54 54
             return $dbColumnTypes;
55 55
         }
56 56
         $dbColumns = $this->getDbTableColumns();
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
 
116 116
         $dbColumnTypes = $this->getDbColumnTypes();
117 117
 
118
-        if (! isset($dbColumnTypes[$fieldName])) {
118
+        if (!isset($dbColumnTypes[$fieldName])) {
119 119
             return 'text';
120 120
         }
121 121
 
@@ -210,12 +210,12 @@  discard block
 block discarded – undo
210 210
     {
211 211
         $fillable = $this->model->getFillable();
212 212
 
213
-        if (! $this->driverIsSql()) {
213
+        if (!$this->driverIsSql()) {
214 214
             $columns = $fillable;
215 215
         } else {
216 216
             // Automatically-set columns should be both in the database, and in the $fillable variable on the Eloquent Model
217 217
             $columns = $this->model::getDbTableSchema()->getColumnsNames();
218
-            if (! empty($fillable)) {
218
+            if (!empty($fillable)) {
219 219
                 $columns = array_intersect($columns, $fillable);
220 220
             }
221 221
         }
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelAutoSetTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -848,7 +848,7 @@
 block discarded – undo
848 848
 
849 849
     public function testSetDoctrineTypesMapping()
850 850
     {
851
-        if (! method_exists($this->crudPanel->getModel()->getConnection(), 'getDoctrineConnection')) {
851
+        if (!method_exists($this->crudPanel->getModel()->getConnection(), 'getDoctrineConnection')) {
852 852
             $this->markTestSkipped('This test is only for Laravel 10, Laravel 11 does not have dbal as a dependency anymore');
853 853
         }
854 854
 
Please login to merge, or discard this patch.
src/app/Models/Traits/HasRelationshipFields.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
     {
23 23
         $connection = DB::connection($this->getConnectionName());
24 24
 
25
-        if (! method_exists($connection, 'getDoctrineSchemaManager')) {
25
+        if (!method_exists($connection, 'getDoctrineSchemaManager')) {
26 26
             return $connection;
27 27
         }
28 28
 
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
         if (self::isSqlConnection()) {
36 36
             $platform = $connection->getDoctrineSchemaManager()->getDatabasePlatform();
37 37
             foreach ($types as $type_key => $type_value) {
38
-                if (! $platform->hasDoctrineTypeMappingFor($type_key)) {
38
+                if (!$platform->hasDoctrineTypeMappingFor($type_key)) {
39 39
                     $platform->registerDoctrineTypeMapping($type_key, $type_value);
40 40
                 }
41 41
             }
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
      */
66 66
     public function getColumnType($columnName)
67 67
     {
68
-        if (! self::isSqlConnection()) {
68
+        if (!self::isSqlConnection()) {
69 69
             return 'text';
70 70
         }
71 71
 
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
      */
81 81
     public static function isColumnNullable($columnName)
82 82
     {
83
-        if (! self::isSqlConnection()) {
83
+        if (!self::isSqlConnection()) {
84 84
             return true;
85 85
         }
86 86
 
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
      */
96 96
     public static function dbColumnHasDefault($columnName)
97 97
     {
98
-        if (! self::isSqlConnection()) {
98
+        if (!self::isSqlConnection()) {
99 99
             return false;
100 100
         }
101 101
 
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
      */
111 111
     public static function getDbColumnDefault($columnName)
112 112
     {
113
-        if (! self::isSqlConnection()) {
113
+        if (!self::isSqlConnection()) {
114 114
             return false;
115 115
         }
116 116
 
Please login to merge, or discard this patch.
src/app/Library/Database/TableSchema.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
     public function getColumnsNames()
21 21
     {
22 22
         return array_values(
23
-            array_map(function ($item) {
23
+            array_map(function($item) {
24 24
                 return $item->getName();
25 25
             }, $this->getColumns())
26 26
         );
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
      */
35 35
     public function getColumnType(string $columnName)
36 36
     {
37
-        if (! $this->schemaExists() || ! $this->schema->hasColumn($columnName)) {
37
+        if (!$this->schemaExists() || !$this->schema->hasColumn($columnName)) {
38 38
             return 'varchar';
39 39
         }
40 40
 
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
      */
52 52
     public function hasColumn($columnName)
53 53
     {
54
-        if (! $this->schemaExists()) {
54
+        if (!$this->schemaExists()) {
55 55
             return false;
56 56
         }
57 57
 
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
      */
67 67
     public function columnIsNullable($columnName)
68 68
     {
69
-        if (! $this->hasColumn($columnName)) {
69
+        if (!$this->hasColumn($columnName)) {
70 70
             return true;
71 71
         }
72 72
 
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
      */
84 84
     public function columnHasDefault($columnName)
85 85
     {
86
-        if (! $this->hasColumn($columnName)) {
86
+        if (!$this->hasColumn($columnName)) {
87 87
             return false;
88 88
         }
89 89
 
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
      */
101 101
     public function getColumnDefault($columnName)
102 102
     {
103
-        if (! $this->hasColumn($columnName)) {
103
+        if (!$this->hasColumn($columnName)) {
104 104
             return false;
105 105
         }
106 106
 
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
      */
117 117
     public function getColumns()
118 118
     {
119
-        if (! $this->schemaExists()) {
119
+        if (!$this->schemaExists()) {
120 120
             return [];
121 121
         }
122 122
 
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
130 130
      */
131 131
     private function schemaExists()
132 132
     {
133
-        if (! empty($this->schema)) {
133
+        if (!empty($this->schema)) {
134 134
             return true;
135 135
         }
136 136
 
Please login to merge, or discard this patch.
src/app/Library/Validation/Rules/BackpackCustomRule.php 1 patch
Spacing   +15 added lines, -16 removed lines patch added patch discarded remove patch
@@ -29,13 +29,13 @@  discard block
 block discarded – undo
29 29
 
30 30
     public bool $implicit = true;
31 31
 
32
-    public static function field(string|array|ValidationRule|Rule $rules = []): self
32
+    public static function field(string | array | ValidationRule | Rule $rules = []): self
33 33
     {
34 34
         $instance = new static();
35 35
         $instance->fieldRules = self::getRulesAsArray($rules);
36 36
 
37 37
         if ($instance->validatesArrays()) {
38
-            if (! in_array('array', $instance->getFieldRules())) {
38
+            if (!in_array('array', $instance->getFieldRules())) {
39 39
                 $instance->fieldRules[] = 'array';
40 40
             }
41 41
         }
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
 
96 96
     public function getFieldRules(): array
97 97
     {
98
-        return tap($this->fieldRules, function ($rule) {
98
+        return tap($this->fieldRules, function($rule) {
99 99
             if (is_a($rule, BackpackCustomRule::class, true)) {
100 100
                 $rule = $rule->getFieldRules();
101 101
             }
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
             $rules = explode('|', $rules);
111 111
         }
112 112
 
113
-        if (! is_array($rules)) {
113
+        if (!is_array($rules)) {
114 114
             $rules = [$rules];
115 115
         }
116 116
 
@@ -119,10 +119,10 @@  discard block
 block discarded – undo
119 119
 
120 120
     protected function ensureValueIsValid($value)
121 121
     {
122
-        if ($this->validatesArrays() && ! is_array($value)) {
122
+        if ($this->validatesArrays() && !is_array($value)) {
123 123
             try {
124 124
                 $value = json_decode($value, true) ?? [];
125
-            } catch(\Exception $e) {
125
+            } catch (\Exception $e) {
126 126
                 return false;
127 127
             }
128 128
         }
@@ -141,12 +141,12 @@  discard block
 block discarded – undo
141 141
             $attribute => $rules,
142 142
         ], $this->validator->customMessages, $this->getValidatorCustomAttributes($attribute));
143 143
 
144
-        return $validator->errors()->messages()[$attribute] ?? (! empty($validator->errors()->messages()) ? current($validator->errors()->messages()) : []);
144
+        return $validator->errors()->messages()[$attribute] ?? (!empty($validator->errors()->messages()) ? current($validator->errors()->messages()) : []);
145 145
     }
146 146
 
147 147
     private function getValidatorCustomAttributes(string $attribute): array
148 148
     {
149
-        if (! is_a($this, ValidGenericAjaxEndpoint::class) && ! Str::contains($attribute, '.*.')) {
149
+        if (!is_a($this, ValidGenericAjaxEndpoint::class) && !Str::contains($attribute, '.*.')) {
150 150
             return $this->validator->customAttributes;
151 151
         }
152 152
 
@@ -157,8 +157,7 @@  discard block
 block discarded – undo
157 157
     protected function getValidationAttributeString(string $attribute)
158 158
     {
159 159
         return Str::substrCount($attribute, '.') > 1 ?
160
-                Str::before($attribute, '.').'.*.'.Str::afterLast($attribute, '.') :
161
-                $attribute;
160
+                Str::before($attribute, '.').'.*.'.Str::afterLast($attribute, '.') : $attribute;
162 161
     }
163 162
 
164 163
     protected function validateOnSubmit(string $attribute, mixed $value): array
@@ -166,7 +165,7 @@  discard block
 block discarded – undo
166 165
         return $this->validateRules($attribute, $value);
167 166
     }
168 167
 
169
-    protected function validateFieldAndFile(string $attribute, null|array $data = null, array|null $customRules = null): array
168
+    protected function validateFieldAndFile(string $attribute, null | array $data = null, array | null $customRules = null): array
170 169
     {
171 170
         $fieldErrors = $this->validateFieldRules($attribute, $data, $customRules);
172 171
 
@@ -178,7 +177,7 @@  discard block
 block discarded – undo
178 177
     /**
179 178
      * Implementation.
180 179
      */
181
-    public function validateFieldRules(string $attribute, null|array|string|UploadedFile $data = null, array|null $customRules = null): array
180
+    public function validateFieldRules(string $attribute, null | array | string | UploadedFile $data = null, array | null $customRules = null): array
182 181
     {
183 182
         $data = $data ?? $this->data;
184 183
         $validationRuleAttribute = $this->getValidationAttributeString($attribute);
@@ -187,16 +186,16 @@  discard block
 block discarded – undo
187 186
         return $this->validateAndGetErrors($validationRuleAttribute, $data, $customRules ?? $this->getFieldRules());
188 187
     }
189 188
 
190
-    protected function prepareValidatorData(array|string|UploadedFile $data, string $attribute): array
189
+    protected function prepareValidatorData(array | string | UploadedFile $data, string $attribute): array
191 190
     {
192
-        if ($this->validatesArrays() && is_array($data) && ! Str::contains($attribute, '.')) {
191
+        if ($this->validatesArrays() && is_array($data) && !Str::contains($attribute, '.')) {
193 192
             return Arr::has($data, $attribute) ? $data : [$attribute => $data];
194 193
         }
195 194
 
196 195
         if (Str::contains($attribute, '.')) {
197 196
             $validData = [];
198 197
 
199
-            Arr::set($validData, $attribute, ! is_array($data) ? $data : Arr::get($data, $attribute));
198
+            Arr::set($validData, $attribute, !is_array($data) ? $data : Arr::get($data, $attribute));
200 199
 
201 200
             return $validData;
202 201
         }
@@ -211,7 +210,7 @@  discard block
 block discarded – undo
211 210
         $validationRuleAttribute = $this->getValidationAttributeString($attribute);
212 211
 
213 212
         $filesToValidate = Arr::get($items, $attribute);
214
-        $filesToValidate = is_array($filesToValidate) ? array_filter($filesToValidate, function ($item) {
213
+        $filesToValidate = is_array($filesToValidate) ? array_filter($filesToValidate, function($item) {
215 214
             return $item instanceof UploadedFile;
216 215
         }) : (is_a($filesToValidate, UploadedFile::class, true) ? [$filesToValidate] : []);
217 216
 
Please login to merge, or discard this patch.
src/app/Library/Uploaders/MultipleFiles.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@  discard block
 block discarded – undo
10 10
 
11 11
 class MultipleFiles extends Uploader
12 12
 {
13
-    public static function for(array $field, $configuration): UploaderInterface
13
+    public static function for (array $field, $configuration): UploaderInterface
14 14
     {
15 15
         return (new self($field, $configuration))->multiple();
16 16
     }
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
             $previousFiles = [];
30 30
         }
31 31
 
32
-        if (! is_array($previousFiles) && is_string($previousFiles)) {
32
+        if (!is_array($previousFiles) && is_string($previousFiles)) {
33 33
             $previousFiles = json_decode($previousFiles, true);
34 34
         }
35 35
 
@@ -38,14 +38,14 @@  discard block
 block discarded – undo
38 38
                 if (in_array($previousFile, $filesToDelete)) {
39 39
                     Storage::disk($this->getDisk())->delete($previousFile);
40 40
 
41
-                    $previousFiles = Arr::where($previousFiles, function ($value, $key) use ($previousFile) {
41
+                    $previousFiles = Arr::where($previousFiles, function($value, $key) use ($previousFile) {
42 42
                         return $value != $previousFile;
43 43
                     });
44 44
                 }
45 45
             }
46 46
         }
47 47
 
48
-        if (! is_array($value)) {
48
+        if (!is_array($value)) {
49 49
             $value = [];
50 50
         }
51 51
 
@@ -82,13 +82,13 @@  discard block
 block discarded – undo
82 82
         // create a temporary variable that we can unset keys
83 83
         // everytime one is found. That way we avoid iterating
84 84
         // already handled keys (notice we do a deep array copy)
85
-        $tempFileOrder = array_map(function ($item) {
85
+        $tempFileOrder = array_map(function($item) {
86 86
             return $item;
87 87
         }, $fileOrder);
88 88
 
89 89
         foreach ($previousRepeatableValues as $previousRow => $previousFiles) {
90 90
             foreach ($previousFiles ?? [] as $key => $file) {
91
-                $previousFileInArray = array_filter($tempFileOrder, function ($items, $key) use ($file, $tempFileOrder) {
91
+                $previousFileInArray = array_filter($tempFileOrder, function($items, $key) use ($file, $tempFileOrder) {
92 92
                     $found = array_search($file, $items ?? [], true);
93 93
                     if ($found !== false) {
94 94
                         Arr::forget($tempFileOrder, $key.'.'.$found);
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
 
99 99
                     return false;
100 100
                 }, ARRAY_FILTER_USE_BOTH);
101
-                if ($file && ! $previousFileInArray) {
101
+                if ($file && !$previousFileInArray) {
102 102
                     Storage::disk($this->getDisk())->delete($file);
103 103
                 }
104 104
             }
Please login to merge, or discard this patch.