Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Push — master ( e0fed9...d63a87 )
by Cristian
30:27 queued 15:21
created
src/app/Library/CrudPanel/Traits/AutoSet.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
             $this->getDbColumnTypes();
17 17
         }
18 18
 
19
-        array_map(function ($field) {
19
+        array_map(function($field) {
20 20
             $new_field = [
21 21
                 'name'       => $field,
22 22
                 'label'      => $this->makeLabel($field),
@@ -28,11 +28,11 @@  discard block
 block discarded – undo
28 28
                 'autoset'    => true,
29 29
             ];
30 30
 
31
-            if (! isset($this->fields()[$field])) {
31
+            if (!isset($this->fields()[$field])) {
32 32
                 $this->addField($new_field);
33 33
             }
34 34
 
35
-            if (! in_array($field, $this->model->getHidden()) && ! in_array($field, $this->columns())) {
35
+            if (!in_array($field, $this->model->getHidden()) && !in_array($field, $this->columns())) {
36 36
                 $this->addColumn([
37 37
                     'name'    => $field,
38 38
                     'label'   => $this->makeLabel($field),
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
 
111 111
         $dbColumnTypes = $this->getDbColumnTypes();
112 112
 
113
-        if (! isset($dbColumnTypes[$fieldName])) {
113
+        if (!isset($dbColumnTypes[$fieldName])) {
114 114
             return 'text';
115 115
         }
116 116
 
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
         $types = ['enum' => 'string'];
169 169
         $platform = $this->getSchema()->getConnection()->getDoctrineSchemaManager()->getDatabasePlatform();
170 170
         foreach ($types as $type_key => $type_value) {
171
-            if (! $platform->hasDoctrineTypeMappingFor($type_key)) {
171
+            if (!$platform->hasDoctrineTypeMappingFor($type_key)) {
172 172
                 $platform->registerDoctrineTypeMapping($type_key, $type_value);
173 173
             }
174 174
         }
@@ -221,13 +221,13 @@  discard block
 block discarded – undo
221 221
     {
222 222
         $fillable = $this->model->getFillable();
223 223
 
224
-        if (! $this->driverIsSql()) {
224
+        if (!$this->driverIsSql()) {
225 225
             $columns = $fillable;
226 226
         } else {
227 227
             // Automatically-set columns should be both in the database, and in the $fillable variable on the Eloquent Model
228 228
             $columns = $this->model->getConnection()->getSchemaBuilder()->getColumnListing($this->model->getTable());
229 229
 
230
-            if (! empty($fillable)) {
230
+            if (!empty($fillable)) {
231 231
                 $columns = array_intersect($columns, $fillable);
232 232
             }
233 233
         }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/ColumnsProtectedMethods.php 1 patch
Spacing   +9 added lines, -10 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
             $column = ['name' => $column];
50 50
         }
51 51
 
52
-        if (is_array($column) && ! isset($column['name'])) {
52
+        if (is_array($column) && !isset($column['name'])) {
53 53
             $column['name'] = 'anonymous_column_'.Str::random(5);
54 54
         }
55 55
 
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
      */
66 66
     protected function makeSureColumnHasLabel($column)
67 67
     {
68
-        if (! isset($column['label'])) {
68
+        if (!isset($column['label'])) {
69 69
             $column['label'] = mb_ucfirst($this->makeLabel($column['name']));
70 70
         }
71 71
 
@@ -82,11 +82,11 @@  discard block
 block discarded – undo
82 82
     {
83 83
         $could_be_relation = isset($column['entity']) && $column['entity'] !== false;
84 84
 
85
-        if (! isset($column['type']) && $could_be_relation) {
85
+        if (!isset($column['type']) && $could_be_relation) {
86 86
             $column['type'] = 'relationship';
87 87
         }
88 88
 
89
-        if (! isset($column['type'])) {
89
+        if (!isset($column['type'])) {
90 90
             $column['type'] = 'text';
91 91
         }
92 92
 
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
      */
104 104
     protected function makeSureColumnHasKey($column)
105 105
     {
106
-        if (! isset($column['key'])) {
106
+        if (!isset($column['key'])) {
107 107
             $column['key'] = str_replace('.', '__', $column['name']);
108 108
         }
109 109
 
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
      */
122 122
     protected function makeSureColumnHasWrapper($column)
123 123
     {
124
-        if (! isset($column['wrapper'])) {
124
+        if (!isset($column['wrapper'])) {
125 125
             $column['wrapper'] = [];
126 126
         }
127 127
 
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
     {
186 186
         // if this is a relation type field and no corresponding model was specified,
187 187
         // get it from the relation method defined in the main model
188
-        if (isset($column['entity']) && $column['entity'] !== false && ! isset($column['model'])) {
188
+        if (isset($column['entity']) && $column['entity'] !== false && !isset($column['model'])) {
189 189
             $column['model'] = $this->getRelationModel($column['entity']);
190 190
         }
191 191
 
@@ -206,8 +206,7 @@  discard block
 block discarded – undo
206 206
         $columnsArray = $this->columns();
207 207
 
208 208
         if (array_key_exists($targetColumnName, $columnsArray)) {
209
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) :
210
-                array_search($targetColumnName, array_keys($columnsArray)) + 1;
209
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) : array_search($targetColumnName, array_keys($columnsArray)) + 1;
211 210
 
212 211
             $element = array_pop($columnsArray);
213 212
             $beginningPart = array_slice($columnsArray, 0, $targetColumnPosition, true);
@@ -230,7 +229,7 @@  discard block
 block discarded – undo
230 229
     {
231 230
         static $cache = [];
232 231
 
233
-        if (! $this->driverIsSql()) {
232
+        if (!$this->driverIsSql()) {
234 233
             return true;
235 234
         }
236 235
 
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/FetchOperation.php 1 patch
Spacing   +6 added lines, -8 removed lines patch added patch discarded remove patch
@@ -46,8 +46,8 @@  discard block
 block discarded – undo
46 46
         // otherwise assume the arguments are actually the configuration array
47 47
         $config = [];
48 48
 
49
-        if (! is_array($arg)) {
50
-            if (! class_exists($arg)) {
49
+        if (!is_array($arg)) {
50
+            if (!class_exists($arg)) {
51 51
                 return response()->json(['error' => 'Class: '.$arg.' does not exists'], 500);
52 52
             }
53 53
             $config['model'] = $arg;
@@ -77,8 +77,7 @@  discard block
 block discarded – undo
77 77
 
78 78
         if ($search_string === false) {
79 79
             return ($config['paginate'] !== false) ?
80
-            $config['query']->paginate($config['paginate']) :
81
-            $config['query']->get();
80
+            $config['query']->paginate($config['paginate']) : $config['query']->get();
82 81
         }
83 82
 
84 83
         $textColumnTypes = ['string', 'json_string', 'text', 'longText', 'json_array', 'json'];
@@ -89,8 +88,8 @@  discard block
 block discarded – undo
89 88
         // .... 'query' => function($model) { return $model->where('active', 1); }
90 89
         // So it reads: SELECT ... WHERE active = 1 AND (XXX = x OR YYY = y) and not SELECT ... WHERE active = 1 AND XXX = x OR YYY = y;
91 90
 
92
-        if (! empty($config['query']->getQuery()->wheres)) {
93
-            $config['query'] = $config['query']->where(function ($query) use ($model_instance, $config, $search_string, $textColumnTypes) {
91
+        if (!empty($config['query']->getQuery()->wheres)) {
92
+            $config['query'] = $config['query']->where(function($query) use ($model_instance, $config, $search_string, $textColumnTypes) {
94 93
                 foreach ((array) $config['searchable_attributes'] as $k => $searchColumn) {
95 94
                     $operation = ($k == 0) ? 'where' : 'orWhere';
96 95
                     $columnType = $model_instance->getColumnType($searchColumn);
@@ -122,7 +121,6 @@  discard block
 block discarded – undo
122 121
 
123 122
         // return the results with or without pagination
124 123
         return ($config['paginate'] !== false) ?
125
-                    $config['query']->paginate($config['paginate']) :
126
-                    $config['query']->get();
124
+                    $config['query']->paginate($config['paginate']) : $config['query']->get();
127 125
     }
128 126
 }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Read.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
      */
57 57
     public function getEntry($id)
58 58
     {
59
-        if (! $this->entry) {
59
+        if (!$this->entry) {
60 60
             $this->entry = $this->model->findOrFail($id);
61 61
             $this->entry = $this->entry->withFakes();
62 62
         }
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
258 258
                 // we will apply the same labels as the values to the menu if developer didn't
259 259
                 $this->abortIfInvalidPageLength($menu[0]);
260 260
 
261
-                if (! isset($menu[1]) || ! is_array($menu[1])) {
261
+                if (!isset($menu[1]) || !is_array($menu[1])) {
262 262
                     $menu[1] = $menu[0];
263 263
                 }
264 264
             } else {
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/ListOperation.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
     {
42 42
         $this->crud->allowAccess('list');
43 43
 
44
-        $this->crud->operation('list', function () {
44
+        $this->crud->operation('list', function() {
45 45
             $this->crud->loadDefaultOperationSettingsFromConfig();
46 46
         });
47 47
     }
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
                 $column_number = (int) $order['column'];
100 100
                 $column_direction = (strtolower((string) $order['dir']) == 'asc' ? 'ASC' : 'DESC');
101 101
                 $column = $this->crud->findColumnById($column_number);
102
-                if ($column['tableColumn'] && ! isset($column['orderLogic'])) {
102
+                if ($column['tableColumn'] && !isset($column['orderLogic'])) {
103 103
                     // apply the current orderBy rules
104 104
                     $this->crud->orderByWithPrefix($column['name'], $column_direction);
105 105
                 }
@@ -119,12 +119,12 @@  discard block
 block discarded – undo
119 119
         $table = $this->crud->model->getTable();
120 120
         $key = $this->crud->model->getKeyName();
121 121
 
122
-        $hasOrderByPrimaryKey = collect($orderBy)->some(function ($item) use ($key, $table) {
122
+        $hasOrderByPrimaryKey = collect($orderBy)->some(function($item) use ($key, $table) {
123 123
             return (isset($item['column']) && $item['column'] === $key)
124 124
                 || (isset($item['sql']) && str_contains($item['sql'], "$table.$key"));
125 125
         });
126 126
 
127
-        if (! $hasOrderByPrimaryKey) {
127
+        if (!$hasOrderByPrimaryKey) {
128 128
             $this->crud->orderByWithPrefix($this->crud->model->getKeyName(), 'DESC');
129 129
         }
130 130
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Create.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
     {
83 83
         $all_relation_fields = $this->getRelationFields();
84 84
 
85
-        return Arr::where($all_relation_fields, function ($value, $key) {
85
+        return Arr::where($all_relation_fields, function($value, $key) {
86 86
             return isset($value['pivot']) && $value['pivot'];
87 87
         });
88 88
     }
@@ -161,11 +161,11 @@  discard block
 block discarded – undo
161 161
      */
162 162
     private function createRelationsForItem($item, $formattedData)
163 163
     {
164
-        if (! isset($formattedData['relations'])) {
164
+        if (!isset($formattedData['relations'])) {
165 165
             return false;
166 166
         }
167 167
         foreach ($formattedData['relations'] as $relationMethod => $relationData) {
168
-            if (! isset($relationData['model'])) {
168
+            if (!isset($relationData['model'])) {
169 169
                 continue;
170 170
             }
171 171
             $model = $relationData['model'];
@@ -222,10 +222,10 @@  discard block
 block discarded – undo
222 222
             if (isset($relation_field['pivot']) && $relation_field['pivot'] !== true) {
223 223
                 $key = implode('.relations.', explode('.', $this->getOnlyRelationEntity($relation_field)));
224 224
                 $fieldData = Arr::get($relationData, 'relations.'.$key, []);
225
-                if (! array_key_exists('model', $fieldData)) {
225
+                if (!array_key_exists('model', $fieldData)) {
226 226
                     $fieldData['model'] = $relation_field['model'];
227 227
                 }
228
-                if (! array_key_exists('parent', $fieldData)) {
228
+                if (!array_key_exists('parent', $fieldData)) {
229 229
                     $fieldData['parent'] = $this->getRelationModel($attributeKey, -1);
230 230
                 }
231 231
                 $relatedAttribute = Arr::last(explode('.', $attributeKey));
@@ -246,7 +246,7 @@  discard block
 block discarded – undo
246 246
 
247 247
         $related_method = Arr::last($entity_array);
248 248
 
249
-        if (! method_exists($relation_model, $related_method)) {
249
+        if (!method_exists($relation_model, $related_method)) {
250 250
             if (count($entity_array) <= 1) {
251 251
                 return $relation_field['entity'];
252 252
             } else {
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/FieldsProtectedMethods.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
      */
70 70
     public function overwriteFieldNameFromDotNotationToArray($field)
71 71
     {
72
-        if (! is_array($field['name']) && strpos($field['name'], '.') !== false) {
72
+        if (!is_array($field['name']) && strpos($field['name'], '.') !== false) {
73 73
             $entity_array = explode('.', $field['name']);
74 74
             $name_string = '';
75 75
 
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
             return ['name' => $field];
97 97
         }
98 98
 
99
-        if (is_array($field) && ! isset($field['name'])) {
99
+        if (is_array($field) && !isset($field['name'])) {
100 100
             abort(500, 'All fields must have their name defined');
101 101
         }
102 102
 
@@ -154,13 +154,13 @@  discard block
 block discarded – undo
154 154
     protected function makeSureFieldHasRelationshipData($field)
155 155
     {
156 156
         // only do this if "entity" is defined on the field
157
-        if (! isset($field['entity'])) {
157
+        if (!isset($field['entity'])) {
158 158
             return $field;
159 159
         }
160 160
 
161 161
         $extraFieldAttributes = $this->inferFieldAttributesFromRelationship($field);
162 162
 
163
-        if (! empty($extraFieldAttributes)) {
163
+        if (!empty($extraFieldAttributes)) {
164 164
             $field = array_merge($field, $extraFieldAttributes);
165 165
         } else {
166 166
             abort(500, 'Unable to process relationship data: '.$field['name']);
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
172 172
     protected function overwriteFieldNameFromEntity($field)
173 173
     {
174 174
         // if the entity doesn't have a dot, it means we don't need to overwrite the name
175
-        if (! Str::contains($field['entity'], '.')) {
175
+        if (!Str::contains($field['entity'], '.')) {
176 176
             return $field;
177 177
         }
178 178
 
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
         if (count(explode('.', $field['entity'])) == count(explode('.', $this->getOnlyRelationEntity($field)))) {
185 185
             $field['name'] = implode('.', array_slice(explode('.', $field['entity']), 0, -1));
186 186
             $relation = $this->getRelationInstance($field);
187
-            if (! empty($field['name'])) {
187
+            if (!empty($field['name'])) {
188 188
                 $field['name'] .= '.';
189 189
             }
190 190
             $field['name'] .= $relation->getForeignKeyName();
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
     {
198 198
         // if there's a model defined, but no attribute
199 199
         // guess an attribute using the identifiableAttribute functionality in CrudTrait
200
-        if (isset($field['model']) && ! isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
200
+        if (isset($field['model']) && !isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
201 201
             $field['attribute'] = call_user_func([(new $field['model']), 'identifiableAttribute']);
202 202
         }
203 203
 
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
      */
214 214
     protected function makeSureFieldHasLabel($field)
215 215
     {
216
-        if (! isset($field['label'])) {
216
+        if (!isset($field['label'])) {
217 217
             $name = is_array($field['name']) ? $field['name'][0] : $field['name'];
218 218
             $name = str_replace('_id', '', $name);
219 219
             $field['label'] = mb_ucfirst(str_replace('_', ' ', $name));
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
      */
232 232
     protected function makeSureFieldHasType($field)
233 233
     {
234
-        if (! isset($field['type'])) {
234
+        if (!isset($field['type'])) {
235 235
             $field['type'] = isset($field['relation_type']) ? $this->inferFieldTypeFromFieldRelation($field) : $this->inferFieldTypeFromDbColumnType($field['name']);
236 236
         }
237 237
 
@@ -248,7 +248,7 @@  discard block
 block discarded – undo
248 248
     {
249 249
         // if a tab was mentioned, we should enable it
250 250
         if (isset($field['tab'])) {
251
-            if (! $this->tabsEnabled()) {
251
+            if (!$this->tabsEnabled()) {
252 252
                 $this->enableTabs();
253 253
             }
254 254
         }
Please login to merge, or discard this patch.