Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Push — handle-uploads-inside-relation... ( ea6d1b...86419c )
by Pedro
15:29
created
tests/Unit/CrudPanel/CrudPanelFiltersTest.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
     {
49 49
         $this->crudPanel->setModel(User::class);
50 50
         $request = request()->create('/admin/users', 'GET', ['my_custom_filter' => 'foo']);
51
-        $request->setRouteResolver(function () use ($request) {
51
+        $request->setRouteResolver(function() use ($request) {
52 52
             return (new Route('GET', 'admin/users', ['UserCrudController', 'index']))->bind($request);
53 53
         });
54 54
         $this->crudPanel->setRequest($request);
@@ -64,10 +64,10 @@  discard block
 block discarded – undo
64 64
                     ->options(['test' => 'test'])
65 65
                     ->view('simple')
66 66
                     ->viewNamespace('crud::filters')
67
-                    ->ifActive(function () {
67
+                    ->ifActive(function() {
68 68
                         return true;
69 69
                     })
70
-                    ->ifInactive(function () {
70
+                    ->ifInactive(function() {
71 71
                         return true;
72 72
                     });
73 73
 
@@ -84,10 +84,10 @@  discard block
 block discarded – undo
84 84
     public function testWhenActiveAndWhenInactiveAliases()
85 85
     {
86 86
         $filter = CrudFilter::name('my_filter')
87
-                        ->whenActive(function () {
87
+                        ->whenActive(function() {
88 88
                             return true;
89 89
                         })
90
-                        ->whenInactive(function () {
90
+                        ->whenInactive(function() {
91 91
                             return true;
92 92
                         });
93 93
 
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
 
99 99
     public function testWhenNotActiveAlias()
100 100
     {
101
-        $filter = CrudFilter::name('my_filter')->whenNotActive(function () {
101
+        $filter = CrudFilter::name('my_filter')->whenNotActive(function() {
102 102
             return true;
103 103
         });
104 104
         $this->assertCount(1, $this->crudPanel->filters());
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
 
108 108
     public function testIfNotActiveAlias()
109 109
     {
110
-        $filter = CrudFilter::name('my_filter')->ifNotActive(function () {
110
+        $filter = CrudFilter::name('my_filter')->ifNotActive(function() {
111 111
             return true;
112 112
         });
113 113
         $this->assertCount(1, $this->crudPanel->filters());
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
 
117 117
     public function testElseAlias()
118 118
     {
119
-        $filter = CrudFilter::name('my_filter')->else(function () {
119
+        $filter = CrudFilter::name('my_filter')->else(function() {
120 120
             return true;
121 121
         });
122 122
         $this->assertCount(1, $this->crudPanel->filters());
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudPanel.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -109,11 +109,11 @@  discard block
 block discarded – undo
109 109
      */
110 110
     public function setModel($model_namespace)
111 111
     {
112
-        if (! class_exists($model_namespace)) {
112
+        if (!class_exists($model_namespace)) {
113 113
             throw new \Exception('The model does not exist.', 500);
114 114
         }
115 115
 
116
-        if (! method_exists($model_namespace, 'hasCrudTrait')) {
116
+        if (!method_exists($model_namespace, 'hasCrudTrait')) {
117 117
             throw new \Exception('Please use CrudTrait on the model.', 500);
118 118
         }
119 119
 
@@ -205,7 +205,7 @@  discard block
 block discarded – undo
205 205
 
206 206
         $complete_route = $route.'.index';
207 207
 
208
-        if (! \Route::has($complete_route)) {
208
+        if (!\Route::has($complete_route)) {
209 209
             throw new \Exception('There are no routes for this route name.', 404);
210 210
         }
211 211
 
@@ -303,7 +303,7 @@  discard block
 block discarded – undo
303 303
      */
304 304
     public function getFirstOfItsTypeInArray($type, $array)
305 305
     {
306
-        return Arr::first($array, function ($item) use ($type) {
306
+        return Arr::first($array, function($item) use ($type) {
307 307
             return $item['type'] == $type;
308 308
         });
309 309
     }
@@ -322,8 +322,8 @@  discard block
 block discarded – undo
322 322
      */
323 323
     public function sync($type, $fields, $attributes)
324 324
     {
325
-        if (! empty($this->{$type})) {
326
-            $this->{$type} = array_map(function ($field) use ($fields, $attributes) {
325
+        if (!empty($this->{$type})) {
326
+            $this->{$type} = array_map(function($field) use ($fields, $attributes) {
327 327
                 if (in_array($field['name'], (array) $fields)) {
328 328
                     $field = array_merge($field, $attributes);
329 329
                 }
@@ -353,15 +353,15 @@  discard block
 block discarded – undo
353 353
     {
354 354
         $relationArray = explode('.', $relationString);
355 355
 
356
-        if (! isset($length)) {
356
+        if (!isset($length)) {
357 357
             $length = count($relationArray);
358 358
         }
359 359
 
360
-        if (! isset($model)) {
360
+        if (!isset($model)) {
361 361
             $model = $this->model;
362 362
         }
363 363
 
364
-        $result = array_reduce(array_splice($relationArray, 0, $length), function ($obj, $method) {
364
+        $result = array_reduce(array_splice($relationArray, 0, $length), function($obj, $method) {
365 365
             try {
366 366
                 $result = $obj->$method();
367 367
 
@@ -396,7 +396,7 @@  discard block
 block discarded – undo
396 396
             if (is_array($entries)) {
397 397
                 //if attribute does not exist in main array we have more than one entry OR the attribute
398 398
                 //is an acessor that is not in $appends property of model.
399
-                if (! isset($entries[$attribute])) {
399
+                if (!isset($entries[$attribute])) {
400 400
                     //we first check if we don't have the attribute because it's an acessor that is not in appends.
401 401
                     if ($model_instance->hasGetMutator($attribute) && isset($entries[$modelKey])) {
402 402
                         $entry_in_database = $model_instance->find($entries[$modelKey]);
@@ -435,21 +435,21 @@  discard block
 block discarded – undo
435 435
      */
436 436
     public function parseTranslatableAttributes($model, $attribute, $value)
437 437
     {
438
-        if (! method_exists($model, 'isTranslatableAttribute')) {
438
+        if (!method_exists($model, 'isTranslatableAttribute')) {
439 439
             return $value;
440 440
         }
441 441
 
442
-        if (! $model->isTranslatableAttribute($attribute)) {
442
+        if (!$model->isTranslatableAttribute($attribute)) {
443 443
             return $value;
444 444
         }
445 445
 
446
-        if (! is_array($value)) {
446
+        if (!is_array($value)) {
447 447
             $decodedAttribute = json_decode($value, true);
448 448
         } else {
449 449
             $decodedAttribute = $value;
450 450
         }
451 451
 
452
-        if (is_array($decodedAttribute) && ! empty($decodedAttribute)) {
452
+        if (is_array($decodedAttribute) && !empty($decodedAttribute)) {
453 453
             if (isset($decodedAttribute[app()->getLocale()])) {
454 454
                 return $decodedAttribute[app()->getLocale()];
455 455
             } else {
@@ -475,7 +475,7 @@  discard block
 block discarded – undo
475 475
         $relation = $model->{$firstRelationName};
476 476
 
477 477
         $results = [];
478
-        if (! is_null($relation)) {
478
+        if (!is_null($relation)) {
479 479
             if ($relation instanceof Collection) {
480 480
                 $currentResults = $relation->all();
481 481
             } elseif (is_array($relation)) {
@@ -488,7 +488,7 @@  discard block
 block discarded – undo
488 488
 
489 489
             array_shift($relationArray);
490 490
 
491
-            if (! empty($relationArray)) {
491
+            if (!empty($relationArray)) {
492 492
                 foreach ($currentResults as $currentResult) {
493 493
                     $results = array_merge_recursive($results, $this->getRelatedEntries($currentResult, implode('.', $relationArray)));
494 494
                 }
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelSaveActionsTest.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -25,10 +25,10 @@  discard block
 block discarded – undo
25 25
         $this->singleSaveAction = [
26 26
             'name' => 'save_action_one',
27 27
             'button_text' => 'custom',
28
-            'redirect' => function ($crud, $request, $itemId) {
28
+            'redirect' => function($crud, $request, $itemId) {
29 29
                 return $crud->route;
30 30
             },
31
-            'visible' => function ($crud) {
31
+            'visible' => function($crud) {
32 32
                 return true;
33 33
             },
34 34
         ];
@@ -36,19 +36,19 @@  discard block
 block discarded – undo
36 36
         $this->multipleSaveActions = [
37 37
             [
38 38
                 'name' => 'save_action_one',
39
-                'redirect' => function ($crud, $request, $itemId) {
39
+                'redirect' => function($crud, $request, $itemId) {
40 40
                     return $crud->route;
41 41
                 },
42
-                'visible' => function ($crud) {
42
+                'visible' => function($crud) {
43 43
                     return true;
44 44
                 },
45 45
             ],
46 46
             [
47 47
                 'name' => 'save_action_two',
48
-                'redirect' => function ($crud, $request, $itemId) {
48
+                'redirect' => function($crud, $request, $itemId) {
49 49
                     return $crud->route;
50 50
                 },
51
-                'visible' => function ($crud) {
51
+                'visible' => function($crud) {
52 52
                     return true;
53 53
                 },
54 54
             ],
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelButtonsTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -285,7 +285,7 @@  discard block
 block discarded – undo
285 285
     public function testAddButtonFluently()
286 286
     {
287 287
         $button1 = CrudButton::name('lineTest')->to('line')->view('crud::buttons.test')->type('view');
288
-        $button2 = CrudButton::add('modelFunction')->model_function(function () {
288
+        $button2 = CrudButton::add('modelFunction')->model_function(function() {
289 289
             return 'test';
290 290
         })->section('top')->makeFirst();
291 291
         $this->assertEquals($button1->toArray(), $this->crudPanel->buttons()->last()->toArray());
@@ -295,7 +295,7 @@  discard block
 block discarded – undo
295 295
 
296 296
     private function getButtonByName($name)
297 297
     {
298
-        return $this->crudPanel->buttons()->first(function ($value) use ($name) {
298
+        return $this->crudPanel->buttons()->first(function($value) use ($name) {
299 299
             return $value->name == $name;
300 300
         });
301 301
     }
Please login to merge, or discard this patch.
src/app/Http/Controllers/CrudController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
         //
33 33
         // It's done inside a middleware closure in order to have
34 34
         // the complete request inside the CrudPanel object.
35
-        $this->middleware(function ($request, $next) {
35
+        $this->middleware(function($request, $next) {
36 36
             $this->crud = app('crud');
37 37
 
38 38
             $this->crud->setRequest($request);
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
     protected function setupConfigurationForCurrentOperation()
97 97
     {
98 98
         $operationName = $this->crud->getCurrentOperation();
99
-        if (! $operationName) {
99
+        if (!$operationName) {
100 100
             return;
101 101
         }
102 102
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Query.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
      */
100 100
     public function customOrderBy($column, $columnDirection = 'asc')
101 101
     {
102
-        if (! isset($column['orderLogic'])) {
102
+        if (!isset($column['orderLogic'])) {
103 103
             return $this->query;
104 104
         }
105 105
 
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
      */
190 190
     public function getTotalQueryCount()
191 191
     {
192
-        if (! $this->getOperationSetting('showEntryCount')) {
192
+        if (!$this->getOperationSetting('showEntryCount')) {
193 193
             return 0;
194 194
         }
195 195
 
@@ -228,7 +228,7 @@  discard block
 block discarded – undo
228 228
      */
229 229
     private function getCountFromQuery(Builder $query)
230 230
     {
231
-        if (! $this->driverIsSql()) {
231
+        if (!$this->driverIsSql()) {
232 232
             return $query->count();
233 233
         }
234 234
 
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
         $expressionColumns = [];
248 248
 
249 249
         foreach ($crudQuery->columns ?? [] as $column) {
250
-            if (! is_string($column) && is_a($column, 'Illuminate\Database\Query\Expression')) {
250
+            if (!is_string($column) && is_a($column, 'Illuminate\Database\Query\Expression')) {
251 251
                 $expressionColumns[] = $column;
252 252
             }
253 253
         }
Please login to merge, or discard this patch.
src/app/Models/Traits/HasEnumFields.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -23,8 +23,7 @@
 block discarded – undo
23 23
 
24 24
         try {
25 25
             $select = app()->version() < 10 ?
26
-                        DB::raw('SHOW COLUMNS FROM `'.$table_prefix.$instance->getTable().'` WHERE Field = "'.$field_name.'"') :
27
-                        DB::raw('SHOW COLUMNS FROM `'.$table_prefix.$instance->getTable().'` WHERE Field = "'.$field_name.'"')->getValue($connection->getQueryGrammar());
26
+                        DB::raw('SHOW COLUMNS FROM `'.$table_prefix.$instance->getTable().'` WHERE Field = "'.$field_name.'"') : DB::raw('SHOW COLUMNS FROM `'.$table_prefix.$instance->getTable().'` WHERE Field = "'.$field_name.'"')->getValue($connection->getQueryGrammar());
28 27
 
29 28
             $type = $connection->select($select)[0]->Type;
30 29
         } catch (\Exception $e) {
Please login to merge, or discard this patch.
src/app/Models/Traits/HasIdentifiableAttribute.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@
 block discarded – undo
63 63
         // we get the first column from database
64 64
         // that is NOT indexed (usually primary, foreign keys)
65 65
         foreach ($columns as $columnName => $columnProperties) {
66
-            if (! in_array($columnName, $indexedColumns)) {
66
+            if (!in_array($columnName, $indexedColumns)) {
67 67
                 //check for convention "field<_id>" in case developer didn't add foreign key constraints.
68 68
                 if (strpos($columnName, '_id') !== false) {
69 69
                     continue;
Please login to merge, or discard this patch.
src/routes/backpack/base.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
         'middleware' => config('backpack.base.web_middleware', 'web'),
19 19
         'prefix'     => config('backpack.base.route_prefix'),
20 20
     ],
21
-    function () {
21
+    function() {
22 22
         // if not otherwise configured, setup the auth routes
23 23
         if (config('backpack.base.setup_auth_routes')) {
24 24
             // Authentication Routes...
Please login to merge, or discard this patch.