Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Pull Request — master (#2032)
by Cristian
08:36
created
src/app/Library/CrudPanel/Traits/Operations.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
     /**
57 57
      * Convenience method to make sure all calls are made to a particular operation.
58 58
      *
59
-     * @param  string|array     $operation      Operation name in string form
59
+     * @param  string|array     $operations      Operation name in string form
60 60
      * @param  bool|\Closure    $closure        Code that calls CrudPanel methods.
61 61
      * @return void
62 62
      */
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
      * Allc configurations are put inside that operation's namespace.
71 71
      * Ex: show.configuration.
72 72
      *
73
-     * @param  string|array     $operation      Operation name in string form
73
+     * @param  string|array     $operations      Operation name in string form
74 74
      * @param  bool|\Closure    $closure        Code that calls CrudPanel methods.
75 75
      * @return void
76 76
      */
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Query.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@
 block discarded – undo
62 62
      * Order results of the query in a custom way.
63 63
      *
64 64
      * @param  array $column           Column array with all attributes
65
-     * @param  string $column_direction ASC or DESC
65
+     * @param  string $columnDirection ASC or DESC
66 66
      *
67 67
      * @return \Illuminate\Database\Eloquent\Builder
68 68
      */
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@
 block discarded – undo
68 68
      */
69 69
     public function customOrderBy($column, $columnDirection = 'asc')
70 70
     {
71
-        if (! isset($column['orderLogic'])) {
71
+        if (!isset($column['orderLogic'])) {
72 72
             return $this->query;
73 73
         }
74 74
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Search.php 4 patches
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,6 +35,7 @@  discard block
 block discarded – undo
35 35
 
36 36
     /**
37 37
      * Apply the search logic for each CRUD column.
38
+     * @param string $searchTerm
38 39
      */
39 40
     public function applySearchLogicForColumn($query, $column, $searchTerm)
40 41
     {
@@ -230,7 +231,7 @@  discard block
 block discarded – undo
230 231
      *
231 232
      * @param string   $view
232 233
      * @param array    $column
233
-     * @param object   $entry
234
+     * @param \Illuminate\Database\Eloquent\Model   $entry
234 235
      * @param bool|int $rowNumber The number shown to the user as row number (index)
235 236
      *
236 237
      * @return string
Please login to merge, or discard this patch.
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -2,8 +2,8 @@
 block discarded – undo
2 2
 
3 3
 namespace Backpack\CRUD\app\Library\CrudPanel\Traits;
4 4
 
5
-use Validator;
6 5
 use Carbon\Carbon;
6
+use Validator;
7 7
 
8 8
 trait Search
9 9
 {
Please login to merge, or discard this patch.
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -210,10 +210,10 @@
 block discarded – undo
210 210
         // add the details_row button to the first column
211 211
         if ($this->getOperationSetting('detailsRow')) {
212 212
             $details_row_button = \View::make('crud::columns.details_row_button')
213
-                                           ->with('crud', $this)
214
-                                           ->with('entry', $entry)
215
-                                           ->with('row_number', $rowNumber)
216
-                                           ->render();
213
+                                            ->with('crud', $this)
214
+                                            ->with('entry', $entry)
215
+                                            ->with('row_number', $rowNumber)
216
+                                            ->render();
217 217
             $row_items[0] = $details_row_button.$row_items[0];
218 218
         }
219 219
 
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -22,9 +22,9 @@  discard block
 block discarded – undo
22 22
      */
23 23
     public function applySearchTerm($searchTerm)
24 24
     {
25
-        return $this->query->where(function ($query) use ($searchTerm) {
25
+        return $this->query->where(function($query) use ($searchTerm) {
26 26
             foreach ($this->columns() as $column) {
27
-                if (! isset($column['type'])) {
27
+                if (!isset($column['type'])) {
28 28
                     abort(400, 'Missing column type when trying to apply search term.');
29 29
                 }
30 30
 
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
 
83 83
                 case 'select':
84 84
                 case 'select_multiple':
85
-                    $query->orWhereHas($column['entity'], function ($q) use ($column, $searchTerm) {
85
+                    $query->orWhereHas($column['entity'], function($q) use ($column, $searchTerm) {
86 86
                         $q->where($column['attribute'], 'like', '%'.$searchTerm.'%');
87 87
                     });
88 88
                     break;
@@ -274,7 +274,7 @@  discard block
 block discarded – undo
274 274
      */
275 275
     private function renderCellView($view, $column, $entry, $rowNumber = false)
276 276
     {
277
-        if (! view()->exists($view)) {
277
+        if (!view()->exists($view)) {
278 278
             $view = 'crud::columns.text'; // fallback to text column
279 279
         }
280 280
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Settings.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -102,7 +102,7 @@
 block discarded – undo
102 102
      * Defaults to the current operation.
103 103
      *
104 104
      * @param  string   $key   Has no operation prepended. (ex: exportButtons)
105
-     * @return mixed      [description]
105
+     * @return boolean      [description]
106 106
      */
107 107
     public function hasOperationSetting(string $key, $operation = null)
108 108
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
      */
50 50
     public function settings()
51 51
     {
52
-        return \Arr::sort($this->settings, function ($value, $key) {
52
+        return \Arr::sort($this->settings, function($value, $key) {
53 53
             return $key;
54 54
         });
55 55
     }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Tabs.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -35,6 +35,9 @@
 block discarded – undo
35 35
         return ! $this->tabsEnabled();
36 36
     }
37 37
 
38
+    /**
39
+     * @param string $type
40
+     */
38 41
     public function setTabsType($type)
39 42
     {
40 43
         $this->enableTabs();
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
      */
33 33
     public function tabsDisabled()
34 34
     {
35
-        return ! $this->tabsEnabled();
35
+        return !$this->tabsEnabled();
36 36
     }
37 37
 
38 38
     public function setTabsType($type)
@@ -114,8 +114,8 @@  discard block
 block discarded – undo
114 114
     {
115 115
         $all_fields = $this->getCurrentFields();
116 116
 
117
-        $fields_without_a_tab = collect($all_fields)->filter(function ($value, $key) {
118
-            return ! isset($value['tab']);
117
+        $fields_without_a_tab = collect($all_fields)->filter(function($value, $key) {
118
+            return !isset($value['tab']);
119 119
         });
120 120
 
121 121
         return $fields_without_a_tab;
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
         if ($this->tabExists($label)) {
132 132
             $all_fields = $this->getCurrentFields();
133 133
 
134
-            $fields_for_current_tab = collect($all_fields)->filter(function ($value, $key) use ($label) {
134
+            $fields_for_current_tab = collect($all_fields)->filter(function($value, $key) use ($label) {
135 135
                 return isset($value['tab']) && $value['tab'] == $label;
136 136
             });
137 137
 
@@ -150,11 +150,11 @@  discard block
 block discarded – undo
150 150
         $fields = $this->getCurrentFields();
151 151
 
152 152
         $fields_with_tabs = collect($fields)
153
-            ->filter(function ($value, $key) {
153
+            ->filter(function($value, $key) {
154 154
                 return isset($value['tab']);
155 155
             })
156
-            ->each(function ($value, $key) use (&$tabs) {
157
-                if (! in_array($value['tab'], $tabs)) {
156
+            ->each(function($value, $key) use (&$tabs) {
157
+                if (!in_array($value['tab'], $tabs)) {
158 158
                     $tabs[] = $value['tab'];
159 159
                 }
160 160
             });
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Validation.php 2 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -88,7 +88,6 @@
 block discarded – undo
88 88
      * for the given operation.
89 89
      *
90 90
      * @param string $inputKey Field or input name.
91
-     * @param string $operation create / update
92 91
      *
93 92
      * @return bool
94 93
      */
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@
 block discarded – undo
94 94
      */
95 95
     public function isRequired($inputKey)
96 96
     {
97
-        if (! $this->hasOperationSetting('requiredFields')) {
97
+        if (!$this->hasOperationSetting('requiredFields')) {
98 98
             return false;
99 99
         }
100 100
 
Please login to merge, or discard this patch.
src/app/Models/Traits/CrudTrait.php 3 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@
 block discarded – undo
69 69
      *
70 70
      * @param array $columns - the database columns that contain the JSONs
71 71
      *
72
-     * @return Model
72
+     * @return CrudTrait
73 73
      */
74 74
     public function withFakes($columns = [])
75 75
     {
Please login to merge, or discard this patch.
Unused Use Statements   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -3,9 +3,9 @@
 block discarded – undo
3 3
 namespace Backpack\CRUD\app\Models\Traits;
4 4
 
5 5
 use DB;
6
-use Traversable;
7
-use Illuminate\Support\Facades\Config;
8 6
 use Illuminate\Database\Eloquent\Model;
7
+use Illuminate\Support\Facades\Config;
8
+use Traversable;
9 9
 
10 10
 trait CrudTrait
11 11
 {
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
         $conn->getDoctrineSchemaManager()->getDatabasePlatform()->registerDoctrineTypeMapping('json', 'json_array');
70 70
         $conn->getDoctrineSchemaManager()->getDatabasePlatform()->registerDoctrineTypeMapping('jsonb', 'json_array');
71 71
 
72
-        return ! $conn->getDoctrineColumn($table, $column_name)->getNotnull();
72
+        return !$conn->getDoctrineColumn($table, $column_name)->getNotnull();
73 73
     }
74 74
 
75 75
     /*
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
     public function addFakes($columns = ['extras'])
87 87
     {
88 88
         foreach ($columns as $key => $column) {
89
-            if (! isset($this->attributes[$column])) {
89
+            if (!isset($this->attributes[$column])) {
90 90
                 continue;
91 91
             }
92 92
 
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
      */
135 135
     public function shouldDecodeFake($column)
136 136
     {
137
-        return ! in_array($column, array_keys($this->casts));
137
+        return !in_array($column, array_keys($this->casts));
138 138
     }
139 139
 
140 140
     /**
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
      */
146 146
     public function shouldEncodeFake($column)
147 147
     {
148
-        return ! in_array($column, array_keys($this->casts));
148
+        return !in_array($column, array_keys($this->casts));
149 149
     }
150 150
 
151 151
     /*
@@ -219,7 +219,7 @@  discard block
 block discarded – undo
219 219
     public function uploadMultipleFilesToDisk($value, $attribute_name, $disk, $destination_path)
220 220
     {
221 221
         $request = \Request::instance();
222
-        if (! is_array($this->{$attribute_name})) {
222
+        if (!is_array($this->{$attribute_name})) {
223 223
             $attribute_value = json_decode($this->{$attribute_name}, true) ?? [];
224 224
         } else {
225 225
             $attribute_value = $this->{$attribute_name};
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
         if ($files_to_clear) {
232 232
             foreach ($files_to_clear as $key => $filename) {
233 233
                 \Storage::disk($disk)->delete($filename);
234
-                $attribute_value = array_where($attribute_value, function ($value, $key) use ($filename) {
234
+                $attribute_value = array_where($attribute_value, function($value, $key) use ($filename) {
235 235
                     return $value != $filename;
236 236
                 });
237 237
             }
Please login to merge, or discard this patch.
src/app/Models/Traits/InheritsRelationsFromParentModel.php 2 patches
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -2,8 +2,8 @@
 block discarded – undo
2 2
 
3 3
 namespace Backpack\CRUD\app\Models\Traits;
4 4
 
5
-use ReflectionClass;
6 5
 use Illuminate\Support\Str;
6
+use ReflectionClass;
7 7
 
8 8
 /**
9 9
  * This trait helps a child model (ex: BackpackUser) inherit all relationships of its parent model (ex: User).
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -18,14 +18,14 @@  discard block
 block discarded – undo
18 18
 
19 19
     public static function bootHasParent()
20 20
     {
21
-        static::creating(function ($model) {
21
+        static::creating(function($model) {
22 22
             if ($model->parentHasHasChildrenTrait()) {
23 23
                 $model->forceFill(
24 24
                     [$model->getInheritanceColumn() => $model->classToAlias(get_class($model))]
25 25
                 );
26 26
             }
27 27
         });
28
-        static::addGlobalScope(function ($query) {
28
+        static::addGlobalScope(function($query) {
29 29
             $instance = new static();
30 30
             if ($instance->parentHasHasChildrenTrait()) {
31 31
                 $query->where($instance->getTable().'.'.$instance->getInheritanceColumn(), $instance->classToAlias(get_class($instance)));
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
 
41 41
     public function getTable()
42 42
     {
43
-        if (! isset($this->table)) {
43
+        if (!isset($this->table)) {
44 44
             return str_replace('\\', '', Str::snake(Str::plural(class_basename($this->getParentClass()))));
45 45
         }
46 46
 
Please login to merge, or discard this patch.
src/app/Models/Traits/SpatieTranslatable/Sluggable.php 3 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,6 @@
 block discarded – undo
37 37
      * Query scope for finding "similar" slugs, used to determine uniqueness.
38 38
      *
39 39
      * @param \Illuminate\Database\Eloquent\Builder $query
40
-     * @param \Illuminate\Database\Eloquent\Model $model
41 40
      * @param string $attribute
42 41
      * @param array $config
43 42
      * @param string $slug
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@
 block discarded – undo
48 48
         $separator = $config['separator'];
49 49
         $attribute = $attribute.'->'.$this->getLocale();
50 50
 
51
-        return $query->where(function (Builder $q) use ($attribute, $slug, $separator) {
51
+        return $query->where(function(Builder $q) use ($attribute, $slug, $separator) {
52 52
             $q->where($attribute, '=', $slug)
53 53
                 ->orWhere($attribute, 'LIKE', $slug.$separator.'%')
54 54
                 // Fixes issues with Json data types in MySQL where data is sourrounded by "
Please login to merge, or discard this patch.
Unused Use Statements   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -2,9 +2,9 @@
 block discarded – undo
2 2
 
3 3
 namespace Backpack\CRUD\app\Models\Traits\SpatieTranslatable;
4 4
 
5
-use Illuminate\Database\Eloquent\Model;
6
-use Illuminate\Database\Eloquent\Builder;
7 5
 use Cviebrock\EloquentSluggable\Sluggable as OriginalSluggable;
6
+use Illuminate\Database\Eloquent\Builder;
7
+use Illuminate\Database\Eloquent\Model;
8 8
 
9 9
 trait Sluggable
10 10
 {
Please login to merge, or discard this patch.