Laravel-Backpack / CRUD

src/PanelTraits/Fields.php

Spacing +6 added lines, -6 removed lines

@@ -25,23 +25,23 @@ 
 
         // if this is a relation type field and no corresponding model was specified, get it from the relation method
         // defined in the main model
-        if (isset($complete_field_array['entity']) && ! isset($complete_field_array['model'])) {
+        if (isset($complete_field_array['entity']) && !isset($complete_field_array['model'])) {
             $complete_field_array['model'] = $this->getRelationModel($complete_field_array['entity']);
         }
 
         // if the label is missing, we should set it
-        if (! isset($complete_field_array['label'])) {
+        if (!isset($complete_field_array['label'])) {
             $complete_field_array['label'] = ucfirst($complete_field_array['name']);
         }
 
         // if the field type is missing, we should set it
-        if (! isset($complete_field_array['type'])) {
+        if (!isset($complete_field_array['type'])) {
             $complete_field_array['type'] = $this->getFieldTypeFromDbColumnType($complete_field_array['name']);
         }
 
         // if a tab was mentioned, we should enable it
         if (isset($complete_field_array['tab'])) {
-            if (! $this->tabsEnabled()) {
+            if (!$this->tabsEnabled()) {
                 $this->enableTabs();
             }
         }
@@ -154,7 +154,7 @@ 
      */
     public function removeFields($array_of_names, $form = 'both')
     {
-        if (! empty($array_of_names)) {
+        if (!empty($array_of_names)) {
             foreach ($array_of_names as $name) {
                 $this->removeField($name, $form);
             }
@@ -218,7 +218,7 @@ 
                 $jsonCastables = ['array', 'object', 'json'];
                 $fieldCasting = $casted_attributes[$field['name']];
 
-                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && ! empty($data[$field['name']]) && ! is_array($data[$field['name']])) {
+                if (in_array($fieldCasting, $jsonCastables) && isset($data[$field['name']]) && !empty($data[$field['name']]) && !is_array($data[$field['name']])) {
                     try {
                         $data[$field['name']] = json_decode($data[$field['name']]);
                     } catch (Exception $e) {

src/app/Http/Controllers/CrudFeatures/AjaxTable.php

Spacing +2 added lines, -2 removed lines

@@ -14,7 +14,7 @@ 
 
         // create an array with the names of the searchable columns
         $columns = collect($this->crud->columns)
-                    ->reject(function ($column, $key) {
+                    ->reject(function($column, $key) {
                         // the select_multiple, model_function and model_function_attribute columns are not searchable
                         return isset($column['type']) && ($column['type'] == 'select_multiple' || $column['type'] == 'model_function' || $column['type'] == 'model_function_attribute');
                     })
@@ -29,7 +29,7 @@ 
         $dataTable = new \LiveControl\EloquentDataTable\DataTable($this->crud->query, $columns);
 
         // make the datatable use the column types instead of just echoing the text
-        $dataTable->setFormatRowFunction(function ($entry) {
+        $dataTable->setFormatRowFunction(function($entry) {
             // get the actual HTML for each row's cell
             $row_items = $this->crud->getRowViews($entry, $this->crud);
 

src/PanelTraits/FakeColumns.php

Spacing +3 added lines, -3 removed lines

@@ -24,19 +24,19 @@
             if (isset($field['fake']) && $field['fake'] == true) {
                 // add it to the request in its appropriate variable - the one defined, if defined
                 if (isset($field['store_in'])) {
-                    if (! in_array($field['store_in'], $fakeFieldsColumnsArray, true)) {
+                    if (!in_array($field['store_in'], $fakeFieldsColumnsArray, true)) {
                         array_push($fakeFieldsColumnsArray, $field['store_in']);
                     }
                 } else {
                     //otherwise in the one defined in the $crud variable
-                    if (! in_array('extras', $fakeFieldsColumnsArray, true)) {
+                    if (!in_array('extras', $fakeFieldsColumnsArray, true)) {
                         array_push($fakeFieldsColumnsArray, 'extras');
                     }
                 }
             }
         }
 
-        if (! count($fakeFieldsColumnsArray)) {
+        if (!count($fakeFieldsColumnsArray)) {
             $fakeFieldsColumnsArray = ['extras'];
         }
 

Doc Comments +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
      * been found.
      *
      * @param string $form The CRUD form. Can be 'create', 'update' or 'both'. Default is 'create'.
-     * @param int|bool $id Optional entity ID needed in the case of the update form.
+     * @param integer $id Optional entity ID needed in the case of the update form.
      * @return array The fake columns array.
      */
     public function getFakeColumnsAsArray($form = 'create', $id = false)

src/PanelTraits/FakeFields.php

Spacing +2 added lines, -2 removed lines

@@ -29,7 +29,7 @@ 
                 $fakeFieldKey = isset($field['store_in']) ? $field['store_in'] : 'extras';
                 $this->addCompactedField($requestInput, $field['name'], $fakeFieldKey);
 
-                if (! in_array($fakeFieldKey, $compactedFakeFields)) {
+                if (!in_array($fakeFieldKey, $compactedFakeFields)) {
                     $compactedFakeFields[] = $fakeFieldKey;
                 }
             }
@@ -37,7 +37,7 @@ 
 
         // json_encode all fake_value columns in the database, so they can be properly stored and interpreted
         foreach ($compactedFakeFields as $value) {
-            if (! (property_exists($this->model, 'translatable') && in_array($value, $this->model->getTranslatableAttributes(), true))) {
+            if (!(property_exists($this->model, 'translatable') && in_array($value, $this->model->getTranslatableAttributes(), true))) {
                 $requestInput[$value] = json_encode($requestInput[$value]);
             }
         }

src/PanelTraits/Buttons.php

Spacing +3 added lines, -3 removed lines

@@ -94,7 +94,7 @@ 
      */
     public function removeButton($name, $stack = null)
     {
-        $this->buttons = $this->buttons->reject(function ($button) use ($name, $stack) {
+        $this->buttons = $this->buttons->reject(function($button) use ($name, $stack) {
             return $stack == null ? $button->name == $name : ($button->stack == $stack) && ($button->name == $name);
         });
     }
@@ -106,14 +106,14 @@ 
 
     public function removeAllButtonsFromStack($stack)
     {
-        $this->buttons = $this->buttons->reject(function ($button) use ($stack) {
+        $this->buttons = $this->buttons->reject(function($button) use ($stack) {
             return $button->stack == $stack;
         });
     }
 
     public function removeButtonFromStack($name, $stack)
     {
-        $this->buttons = $this->buttons->reject(function ($button) use ($name, $stack) {
+        $this->buttons = $this->buttons->reject(function($button) use ($name, $stack) {
             return $button->name == $name && $button->stack == $stack;
         });
     }

Doc Comments +12 added lines

@@ -59,6 +59,9 @@ 
         $this->addButton($stack, $name, 'model_function', $model_function_name, $position);
     }
 
+    /**
+     * @param string $view
+     */
     public function addButtonFromView($stack, $name, $view, $position = false)
     {
         $view = 'vendor.backpack.crud.buttons.'.$view;
@@ -104,6 +107,9 @@ 
         $this->buttons = collect([]);
     }
 
+    /**
+     * @param string $stack
+     */
     public function removeAllButtonsFromStack($stack)
     {
         $this->buttons = $this->buttons->reject(function ($button) use ($stack) {
@@ -126,6 +132,12 @@ 
     public $type = 'view';
     public $content;
 
+    /**
+     * @param string $stack
+     * @param string $name
+     * @param string $type
+     * @param string $content
+     */
     public function __construct($stack, $name, $type, $content)
     {
         $this->stack = $stack;

src/PanelTraits/Access.php

Spacing +3 added lines, -3 removed lines

@@ -33,7 +33,7 @@ 
      */
     public function hasAccess($permission)
     {
-        if (! in_array($permission, $this->access)) {
+        if (!in_array($permission, $this->access)) {
             return false;
         }
 
@@ -68,7 +68,7 @@ 
     public function hasAccessToAll($permission_array)
     {
         foreach ($permission_array as $key => $permission) {
-            if (! in_array($permission, $this->access)) {
+            if (!in_array($permission, $this->access)) {
                 return false;
             }
         }
@@ -86,7 +86,7 @@ 
      */
     public function hasAccessOrFail($permission)
     {
-        if (! in_array($permission, $this->access)) {
+        if (!in_array($permission, $this->access)) {
             throw new AccessDeniedException(trans('backpack::crud.unauthorized_access'));
         }
 

Doc Comments +6 added lines

@@ -12,12 +12,18 @@
     |--------------------------------------------------------------------------
     */
 
+    /**
+     * @param string $access
+     */
     public function allowAccess($access)
     {
         // $this->addButtons((array)$access);
         return $this->access = array_merge(array_diff((array) $access, $this->access), $this->access);
     }
 
+    /**
+     * @param string $access
+     */
     public function denyAccess($access)
     {
         // $this->removeButtons((array)$access);

src/PanelTraits/Delete.php

Doc Comments +1 added lines, -1 removed lines

@@ -15,7 +15,7 @@
      *
      * @param  int $id The id of the item to be deleted.
      *
-     * @return bool True if the item was deleted.
+     * @return string True if the item was deleted.
      *
      * @throws \Illuminate\Database\Eloquent\ModelNotFoundException if the model was not found.
      *

src/PanelTraits/Columns.php

Spacing +9 added lines, -10 removed lines

@@ -54,7 +54,7 @@ 
     public function addColumn($column)
     {
         // if a string was passed, not an array, change it to an array
-        if (! is_array($column)) {
+        if (!is_array($column)) {
             $column = ['name' => $column];
         }
 
@@ -62,7 +62,7 @@ 
         $column_with_details = $this->addDefaultLabel($column);
 
         // make sure the column has a name
-        if (! array_key_exists('name', $column_with_details)) {
+        if (!array_key_exists('name', $column_with_details)) {
             $column_with_details['name'] = 'anonymous_column_'.str_random(5);
         }
 
@@ -70,7 +70,7 @@ 
 
         // if this is a relation type field and no corresponding model was specified, get it from the relation method
         // defined in the main model
-        if (isset($column_with_details['entity']) && ! isset($column_with_details['model'])) {
+        if (isset($column_with_details['entity']) && !isset($column_with_details['model'])) {
             $column_with_details['model'] = $this->getRelationModel($column_with_details['entity']);
         }
 
@@ -124,8 +124,7 @@ 
         $targetColumnName = is_array($targetColumn) ? $targetColumn['name'] : $targetColumn;
 
         if (array_key_exists($targetColumnName, $this->columns)) {
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($this->columns)) :
-                array_search($targetColumnName, array_keys($this->columns)) + 1;
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($this->columns)) : array_search($targetColumnName, array_keys($this->columns)) + 1;
 
             $element = array_pop($this->columns);
             $beginningPart = array_slice($this->columns, 0, $targetColumnPosition, true);
@@ -159,7 +158,7 @@ 
      */
     public function addDefaultLabel($array)
     {
-        if (! array_key_exists('label', (array) $array) && array_key_exists('name', (array) $array)) {
+        if (!array_key_exists('label', (array) $array) && array_key_exists('name', (array) $array)) {
             $array = array_merge(['label' => ucfirst($this->makeLabel($array['name']))], $array);
 
             return $array;
@@ -185,7 +184,7 @@ 
      */
     public function removeColumns($columns)
     {
-        if (! empty($columns)) {
+        if (!empty($columns)) {
             foreach ($columns as $columnName) {
                 $this->removeColumn($columnName);
             }
@@ -206,8 +205,8 @@ 
      */
     public function remove($entity, $fields)
     {
-        return array_values(array_filter($this->{$entity}, function ($field) use ($fields) {
-            return ! in_array($field['name'], (array) $fields);
+        return array_values(array_filter($this->{$entity}, function($field) use ($fields) {
+            return !in_array($field['name'], (array) $fields);
         }));
     }
 
@@ -258,7 +257,7 @@ 
     {
         $columns = $this->getColumns();
 
-        return collect($columns)->pluck('entity')->reject(function ($value, $key) {
+        return collect($columns)->pluck('entity')->reject(function($value, $key) {
             return $value == null;
         })->toArray();
     }

Doc Comments +2 added lines, -2 removed lines

@@ -94,7 +94,7 @@ 
     /**
      * Move the most recently added column after the given target column.
      *
-     * @param string|array $targetColumn The target column name or array.
+     * @param string $targetColumn The target column name or array.
      */
     public function afterColumn($targetColumn)
     {
@@ -104,7 +104,7 @@ 
     /**
      * Move the most recently added column before the given target column.
      *
-     * @param string|array $targetColumn The target column name or array.
+     * @param string $targetColumn The target column name or array.
      */
     public function beforeColumn($targetColumn)
     {

tests/Unit/CrudPanel/CrudPanelCreateTest.php

Unused Use Statements +2 added lines, -2 removed lines

@@ -2,9 +2,9 @@
 
 namespace Backpack\CRUD\Tests\Unit\CrudPanel;
 
-use Faker\Factory;
-use Backpack\CRUD\Tests\Unit\Models\User;
 use Backpack\CRUD\Tests\Unit\Models\Article;
+use Backpack\CRUD\Tests\Unit\Models\User;
+use Faker\Factory;
 
 class CrudPanelCreateTest extends BaseDBCrudPanelTest
 {