Laravel-Backpack / CRUD

tests/config/database/migrations/2020_03_31_114745_create_pivotable_relations_tables.php

Spacing +13 added lines, -13 removed lines

@@ -13,14 +13,14 @@ 
      */
     public function up()
     {
-        Schema::create('comments', function (Blueprint $table) {
+        Schema::create('comments', function(Blueprint $table) {
             $table->bigIncrements('id');
             $table->string('text')->nullable();
             $table->morphs('commentable');
             $table->timestamps();
         });
 
-        Schema::create('recommendables', function (Blueprint $table) {
+        Schema::create('recommendables', function(Blueprint $table) {
             $table->bigIncrements('id');
             $table->string('text')->nullable();
             $table->morphs('recommendable');
@@ -28,7 +28,7 @@ 
             $table->timestamps();
         });
 
-        Schema::create('billables', function (Blueprint $table) {
+        Schema::create('billables', function(Blueprint $table) {
             $table->bigIncrements('id');
             $table->string('text')->nullable();
             $table->morphs('billable');
@@ -36,7 +36,7 @@ 
             $table->timestamps();
         });
 
-        Schema::create('articles_user', function (Blueprint $table) {
+        Schema::create('articles_user', function(Blueprint $table) {
             $table->increments('id');
             $table->integer('article_id')->unsigned();
             $table->integer('user_id')->unsigned();
@@ -44,54 +44,54 @@ 
             $table->nullableTimestamps();
         });
 
-        Schema::create('recommends', function (Blueprint $table) {
+        Schema::create('recommends', function(Blueprint $table) {
             $table->bigIncrements('id');
             $table->string('title')->nullable();
             $table->timestamps();
         });
 
-        Schema::create('bills', function (Blueprint $table) {
+        Schema::create('bills', function(Blueprint $table) {
             $table->bigIncrements('id');
             $table->string('title')->nullable();
             $table->timestamps();
         });
 
-        Schema::create('stars', function (Blueprint $table) {
+        Schema::create('stars', function(Blueprint $table) {
             $table->bigIncrements('id');
             $table->string('starable_type');
             $table->bigInteger('starable_id');
             $table->string('title')->nullable();
         });
 
-        Schema::create('universes', function (Blueprint $table) {
+        Schema::create('universes', function(Blueprint $table) {
             $table->bigIncrements('id');
             $table->bigInteger('user_id');
             $table->string('title')->nullable();
         });
 
-        Schema::create('planets', function (Blueprint $table) {
+        Schema::create('planets', function(Blueprint $table) {
             $table->bigIncrements('id');
             $table->bigInteger('user_id')->nullable();
             $table->string('title')->nullable();
         });
 
-        Schema::create('comets', function (Blueprint $table) {
+        Schema::create('comets', function(Blueprint $table) {
             $table->bigIncrements('id');
             $table->bigInteger('user_id')->default(0);
         });
 
-        Schema::create('bangs', function (Blueprint $table) {
+        Schema::create('bangs', function(Blueprint $table) {
             $table->bigIncrements('id');
             $table->string('name');
         });
 
-        Schema::create('account_details_bang', function (Blueprint $table) {
+        Schema::create('account_details_bang', function(Blueprint $table) {
             $table->bigIncrements('id');
             $table->bigInteger('account_details_id');
             $table->bigInteger('bang_id');
         });
 
-        Schema::create('account_details_bangs_pivot', function (Blueprint $table) {
+        Schema::create('account_details_bangs_pivot', function(Blueprint $table) {
             $table->bigIncrements('id');
             $table->bigInteger('account_details_id');
             $table->bigInteger('bang_id');

src/helpers.php

Spacing +18 added lines, -18 removed lines

@@ -1,6 +1,6 @@ 
 <?php
 
-if (! function_exists('backpack_url')) {
+if (!function_exists('backpack_url')) {
     /**
      * Appends the configured backpack prefix and returns
      * the URL using the standard Laravel helpers.
@@ -10,13 +10,13 @@ 
      */
     function backpack_url($path = null, $parameters = [], $secure = null)
     {
-        $path = ! $path || (substr($path, 0, 1) == '/') ? $path : '/'.$path;
+        $path = !$path || (substr($path, 0, 1) == '/') ? $path : '/'.$path;
 
         return url(config('backpack.base.route_prefix', 'admin').$path, $parameters, $secure);
     }
 }
 
-if (! function_exists('backpack_authentication_column')) {
+if (!function_exists('backpack_authentication_column')) {
     /**
      * Return the username column name.
      * The Laravel default (and Backpack default) is 'email'.
@@ -29,7 +29,7 @@ 
     }
 }
 
-if (! function_exists('backpack_form_input')) {
+if (!function_exists('backpack_form_input')) {
     /**
      * Parse the submitted input in request('form') to an usable array.
      * Joins the multiple[] fields in a single key and transform the dot notation fields into arrayed ones.
@@ -58,7 +58,7 @@ 
             }
 
             if (is_null($input_arg)) {
-                if (! isset($result[$input_key])) {
+                if (!isset($result[$input_key])) {
                     $result[$input_key] = $start ? [$row['value']] : $row['value'];
                 } else {
                     array_push($result[$input_key], $row['value']);
@@ -72,7 +72,7 @@ 
     }
 }
 
-if (! function_exists('backpack_users_have_email')) {
+if (!function_exists('backpack_users_have_email')) {
     /**
      * Check if the email column is present on the user table.
      *
@@ -87,7 +87,7 @@ 
     }
 }
 
-if (! function_exists('backpack_avatar_url')) {
+if (!function_exists('backpack_avatar_url')) {
     /**
      * Returns the avatar URL of a user.
      *
@@ -119,7 +119,7 @@ 
     }
 }
 
-if (! function_exists('backpack_middleware')) {
+if (!function_exists('backpack_middleware')) {
     /**
      * Return the key of the middleware used across Backpack.
      * That middleware checks if the visitor is an admin.
@@ -133,7 +133,7 @@ 
     }
 }
 
-if (! function_exists('backpack_guard_name')) {
+if (!function_exists('backpack_guard_name')) {
     /*
      * Returns the name of the guard defined
      * by the application config
@@ -144,7 +144,7 @@ 
     }
 }
 
-if (! function_exists('backpack_auth')) {
+if (!function_exists('backpack_auth')) {
     /*
      * Returns the user instance if it exists
      * of the currently authenticated admin
@@ -156,7 +156,7 @@ 
     }
 }
 
-if (! function_exists('backpack_user')) {
+if (!function_exists('backpack_user')) {
     /*
      * Returns back a user instance without
      * the admin guard, however allows you
@@ -168,7 +168,7 @@ 
     }
 }
 
-if (! function_exists('mb_ucfirst')) {
+if (!function_exists('mb_ucfirst')) {
     /**
      * Capitalize the first letter of a string,
      * even if that string is multi-byte (non-latin alphabet).
@@ -189,7 +189,7 @@ 
     }
 }
 
-if (! function_exists('backpack_view')) {
+if (!function_exists('backpack_view')) {
     /**
      * Returns a new displayable view based on the configured backpack view namespace.
      * If that view doesn't exist, it will load the one from the original theme.
@@ -208,7 +208,7 @@ 
 
         $returnView = $theme.$view;
 
-        if (! view()->exists($returnView)) {
+        if (!view()->exists($returnView)) {
             $returnView = $originalTheme.$view;
         }
 
@@ -216,7 +216,7 @@ 
     }
 }
 
-if (! function_exists('square_brackets_to_dots')) {
+if (!function_exists('square_brackets_to_dots')) {
     /**
      * Turns a string from bracket-type array to dot-notation array.
      * Ex: array[0][property] turns into array.0.property.
@@ -232,7 +232,7 @@ 
     }
 }
 
-if (! function_exists('is_countable')) {
+if (!function_exists('is_countable')) {
     /**
      * We need this because is_countable was only introduced in PHP 7.3,
      * and in PHP 7.2 you should check if count() argument is really countable.
@@ -247,7 +247,7 @@ 
     }
 }
 
-if (! function_exists('old_empty_or_null')) {
+if (!function_exists('old_empty_or_null')) {
     /**
      * This method is an alternative to Laravel's old() helper, which mistakenly
      * returns NULL it two cases:
@@ -279,7 +279,7 @@ 
     }
 }
 
-if (! function_exists('is_multidimensional_array')) {
+if (!function_exists('is_multidimensional_array')) {
     /**
      * If any of the items inside a given array is an array, the array is considered multidimensional.
      *

src/app/Library/CrudPanel/Traits/FieldsProtectedMethods.php

Spacing +8 added lines, -8 removed lines

@@ -68,7 +68,7 @@ 
      */
     public function overwriteFieldNameFromDotNotationToArray($field)
     {
-        if (! is_array($field['name']) && strpos($field['name'], '.') !== false) {
+        if (!is_array($field['name']) && strpos($field['name'], '.') !== false) {
             $entity_array = explode('.', $field['name']);
             $name_string = '';
 
@@ -110,7 +110,7 @@ 
             return ['name' => $field];
         }
 
-        if (is_array($field) && ! isset($field['name'])) {
+        if (is_array($field) && !isset($field['name'])) {
             abort(500, 'All fields must have their name defined');
         }
 
@@ -175,7 +175,7 @@ 
     {
         // if there's a model defined, but no attribute
         // guess an attribute using the identifiableAttribute functionality in CrudTrait
-        if (isset($field['model']) && ! isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
+        if (isset($field['model']) && !isset($field['attribute']) && method_exists($field['model'], 'identifiableAttribute')) {
             $field['attribute'] = call_user_func([(new $field['model']()), 'identifiableAttribute']);
         }
 
@@ -191,7 +191,7 @@ 
      */
     protected function makeSureFieldHasLabel($field)
     {
-        if (! isset($field['label'])) {
+        if (!isset($field['label'])) {
             $name = is_array($field['name']) ? $field['name'][0] : $field['name'];
             $name = str_replace('_id', '', $name);
             $field['label'] = mb_ucfirst(str_replace('_', ' ', $name));
@@ -209,7 +209,7 @@ 
      */
     protected function makeSureFieldHasType($field)
     {
-        if (! isset($field['type'])) {
+        if (!isset($field['type'])) {
             $field['type'] = isset($field['relation_type']) ? 'relationship' : $this->inferFieldTypeFromDbColumnType($field['name']);
         }
 
@@ -225,7 +225,7 @@ 
      */
     protected function makeSureSubfieldsHaveNecessaryAttributes($field)
     {
-        if (! isset($field['subfields'])) {
+        if (!isset($field['subfields'])) {
             return $field;
         }
 
@@ -235,7 +235,7 @@ 
                 $subfield = ['name' => $subfield];
             }
 
-            if (! isset($field['model'])) {
+            if (!isset($field['model'])) {
                 // we're inside a simple 'repeatable' with no model/relationship, so
                 // we assume all subfields are supposed to be text fields
                 $subfield['type'] = $subfield['type'] ?? 'text';
@@ -264,7 +264,7 @@ 
     {
         // if a tab was mentioned, we should enable it
         if (isset($field['tab'])) {
-            if (! $this->tabsEnabled()) {
+            if (!$this->tabsEnabled()) {
                 $this->enableTabs();
             }
         }

src/app/Library/CrudPanel/Traits/Fields.php

Spacing +13 added lines, -13 removed lines

@@ -117,7 +117,7 @@ 
      */
     public function afterField($targetFieldName)
     {
-        $this->transformFields(function ($fields) use ($targetFieldName) {
+        $this->transformFields(function($fields) use ($targetFieldName) {
             return $this->moveField($fields, $targetFieldName, false);
         });
     }
@@ -129,7 +129,7 @@ 
      */
     public function beforeField($targetFieldName)
     {
-        $this->transformFields(function ($fields) use ($targetFieldName) {
+        $this->transformFields(function($fields) use ($targetFieldName) {
             return $this->moveField($fields, $targetFieldName, true);
         });
     }
@@ -141,7 +141,7 @@ 
      */
     public function makeFirstField()
     {
-        if (! $this->fields()) {
+        if (!$this->fields()) {
             return false;
         }
 
@@ -156,7 +156,7 @@ 
      */
     public function removeField($name)
     {
-        $this->transformFields(function ($fields) use ($name) {
+        $this->transformFields(function($fields) use ($name) {
             Arr::forget($fields, $name);
 
             return $fields;
@@ -170,7 +170,7 @@ 
      */
     public function removeFields($array_of_names)
     {
-        if (! empty($array_of_names)) {
+        if (!empty($array_of_names)) {
             foreach ($array_of_names as $name) {
                 $this->removeField($name);
             }
@@ -183,7 +183,7 @@ 
     public function removeAllFields()
     {
         $current_fields = $this->getCleanStateFields();
-        if (! empty($current_fields)) {
+        if (!empty($current_fields)) {
             foreach ($current_fields as $field) {
                 $this->removeField($field['name']);
             }
@@ -280,7 +280,7 @@ 
                 $jsonCastables = ['array', 'object', 'json'];
                 $fieldCasting = $casted_attributes[$field['name']];
 
-                if (in_array($fieldCasting, $jsonCastables) && isset($input[$field['name']]) && ! empty($input[$field['name']]) && ! is_array($input[$field['name']])) {
+                if (in_array($fieldCasting, $jsonCastables) && isset($input[$field['name']]) && !empty($input[$field['name']]) && !is_array($input[$field['name']])) {
                     try {
                         $input[$field['name']] = json_decode($input[$field['name']]);
                     } catch (\Exception $e) {
@@ -309,7 +309,7 @@ 
      */
     public function orderFields($order)
     {
-        $this->transformFields(function ($fields) use ($order) {
+        $this->transformFields(function($fields) use ($order) {
             return $this->applyOrderToFields($fields, $order);
         });
     }
@@ -335,7 +335,7 @@ 
     public function hasUploadFields()
     {
         $fields = $this->getCleanStateFields();
-        $upload_fields = Arr::where($fields, function ($value, $key) {
+        $upload_fields = Arr::where($fields, function($value, $key) {
             return isset($value['upload']) && $value['upload'] == true;
         });
 
@@ -398,7 +398,7 @@ 
         $alreadyLoaded = $this->getLoadedFieldTypes();
         $type = $this->getFieldTypeWithNamespace($field);
 
-        if (! in_array($type, $this->getLoadedFieldTypes(), true)) {
+        if (!in_array($type, $this->getLoadedFieldTypes(), true)) {
             $alreadyLoaded[] = $type;
             $this->setLoadedFieldTypes($alreadyLoaded);
 
@@ -439,7 +439,7 @@ 
      */
     public function fieldTypeNotLoaded($field)
     {
-        return ! in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
+        return !in_array($this->getFieldTypeWithNamespace($field), $this->getLoadedFieldTypes());
     }
 
     /**
@@ -479,7 +479,7 @@ 
      */
     public function hasFieldWhere($attribute, $value)
     {
-        $match = Arr::first($this->getCleanStateFields(), function ($field, $fieldKey) use ($attribute, $value) {
+        $match = Arr::first($this->getCleanStateFields(), function($field, $fieldKey) use ($attribute, $value) {
             return isset($field[$attribute]) && $field[$attribute] == $value;
         });
 
@@ -495,7 +495,7 @@ 
      */
     public function firstFieldWhere($attribute, $value)
     {
-        return Arr::first($this->getCleanStateFields(), function ($field, $fieldKey) use ($attribute, $value) {
+        return Arr::first($this->getCleanStateFields(), function($field, $fieldKey) use ($attribute, $value) {
             return isset($field[$attribute]) && $field[$attribute] == $value;
         });
     }

tests/Unit/CrudPanel/CrudPanelCreateTest.php

Spacing +2 added lines, -2 removed lines

@@ -593,7 +593,7 @@ 
 
     public function testCreateBelongsToFake()
     {
-        $belongsToField = [   // select_grouped
+        $belongsToField = [// select_grouped
             'label'                      => 'Select_grouped',
             'type'                       => 'select_grouped', //https://github.com/Laravel-Backpack/CRUD/issues/502
             'name'                       => 'bang_relation_field',
@@ -727,7 +727,7 @@ 
                 'nickname' => 'i_have_has_one',
                 'profile_picture' => 'ohh my picture 1.jpg',
                 'article' => 1,
-                'addresses' => [ // HasOne is tested in other test function
+                'addresses' => [// HasOne is tested in other test function
                     [
                         'city' => 2,
                         'street' => 'test',

src/app/Library/CrudPanel/Traits/Create.php

Spacing +3 added lines, -3 removed lines

@@ -111,7 +111,7 @@ 
                     // - a single dimensional array: [1,2,3]
                     // - an array of arrays: [[1][2][3]]
                     // if is as single dimensional array we can only attach.
-                    if ($relationValues === null || ! is_multidimensional_array($relationValues)) {
+                    if ($relationValues === null || !is_multidimensional_array($relationValues)) {
                         $this->attachManyRelation($item, $relation, $relationDetails, $relationValues);
                     } else {
                         $this->createManyEntries($item, $relation, $relationMethod, $relationDetails);
@@ -264,7 +264,7 @@ 
             return $removedEntries->delete();
         }
 
-        if (! $relationColumnIsNullable && $modelInstance->dbColumnHasDefault($relationForeignKey)) {
+        if (!$relationColumnIsNullable && $modelInstance->dbColumnHasDefault($relationForeignKey)) {
             return $removedEntries->update([$relationForeignKey => $modelInstance->getDbColumnDefault($relationForeignKey)]);
         }
 
@@ -308,7 +308,7 @@ 
         }
 
         // use the collection of sent ids to match agains database ids, delete the ones not found in the submitted ids.
-        if (! empty($relatedItemsSent)) {
+        if (!empty($relatedItemsSent)) {
             // we perform the cleanup of removed database items
             $entry->{$relationMethod}()->whereNotIn($relation_local_key, $relatedItemsSent)->delete();
         }

src/app/Library/CrudPanel/Traits/Input.php

Spacing +4 added lines, -4 removed lines

@@ -97,7 +97,7 @@ 
         }
 
         //remove fields that are not in the submitted form input
-        $relationFields = array_filter($relationFields, function ($field) use ($input) {
+        $relationFields = array_filter($relationFields, function($field) use ($input) {
             return Arr::has($input, $field['name']) || isset($input[$field['name']]) || Arr::has($input, Str::afterLast($field['name'], '.'));
         });
 
@@ -176,7 +176,7 @@ 
 
             // when using dot notation if relationMethod is not set we are sure we want to exclude those relations.
             if ($this->getOnlyRelationEntity($field) !== $field['entity']) {
-                if (! $relationMethod) {
+                if (!$relationMethod) {
                     $excludedFields[] = $nameToExclude;
                 }
                 continue;
@@ -188,8 +188,8 @@ 
             }
         }
 
-        return Arr::where($input, function ($item, $key) use ($excludedFields) {
-            return ! in_array($key, $excludedFields);
+        return Arr::where($input, function($item, $key) use ($excludedFields) {
+            return !in_array($key, $excludedFields);
         });
     }
 }

src/app/Library/CrudPanel/Traits/Relationships.php

Spacing +9 added lines, -9 removed lines

@@ -65,7 +65,7 @@ 
         $model = $this->getRelationModel($entity, -1);
         $lastSegmentAfterDot = Str::of($field['entity'])->afterLast('.');
 
-        if (! method_exists($model, $lastSegmentAfterDot)) {
+        if (!method_exists($model, $lastSegmentAfterDot)) {
             return (string) Str::of($field['entity'])->beforeLast('.');
         }
 
@@ -86,7 +86,7 @@ 
 
         return collect($this->getCleanStateFields())
             ->whereIn('relation_type', $relation_types)
-            ->filter(function ($item) use ($nested) {
+            ->filter(function($item) use ($nested) {
                 if ($nested) {
                     return true;
                 }
@@ -130,7 +130,7 @@ 
      */
     private function getRelationFieldsWithoutRelationType($relations, $fields = [])
     {
-        if (! is_array($relations)) {
+        if (!is_array($relations)) {
             $relations = [$relations];
         }
 
@@ -139,8 +139,8 @@ 
         }
 
         foreach ($relations as $relation) {
-            $fields = array_filter($fields, function ($field) use ($relation) {
-                if (! isset($field['relation_type'])) {
+            $fields = array_filter($fields, function($field) use ($relation) {
+                if (!isset($field['relation_type'])) {
                     return false;
                 }
 
@@ -174,7 +174,7 @@ 
                     $fields = array_merge($field['subfields'], $fields);
                 }
             }
-            $fields = array_filter($fields, function ($field) {
+            $fields = array_filter($fields, function($field) {
                 return isset($field['relation_type']) && $field['relation_type'] === 'BelongsTo';
             });
         }
@@ -243,8 +243,8 @@ 
     {
         $all_relation_fields = $this->getRelationFields();
 
-        return Arr::where($all_relation_fields, function ($value, $key) {
-            return isset($value['pivot']) && ! $value['pivot'];
+        return Arr::where($all_relation_fields, function($value, $key) {
+            return isset($value['pivot']) && !$value['pivot'];
         });
     }
 
@@ -257,7 +257,7 @@ 
     {
         $all_relation_fields = $this->getRelationFields();
 
-        return Arr::where($all_relation_fields, function ($value, $key) {
+        return Arr::where($all_relation_fields, function($value, $key) {
             return isset($value['pivot']) && $value['pivot'];
         });
     }

src/app/Library/CrudPanel/Traits/Update.php

Spacing +9 added lines, -9 removed lines

@@ -47,7 +47,7 @@ 
         }
 
         // always have a hidden input for the entry id
-        if (! array_key_exists('id', $fields)) {
+        if (!array_key_exists('id', $fields)) {
             $fields['id'] = [
                 'name'  => $entry->getKeyName(),
                 'value' => $entry->getKey(),
@@ -72,7 +72,7 @@ 
         $fieldEntity = $field['entity'] ?? false;
         $fakeField = $field['fake'] ?? false;
 
-        if ($fieldEntity && ! $fakeField) {
+        if ($fieldEntity && !$fakeField) {
             return $this->getModelAttributeValueFromRelationship($model, $field);
         }
 
@@ -102,7 +102,7 @@ 
     {
         [$relatedModel, $relationMethod] = $this->getModelAndMethodFromEntity($model, $field);
 
-        if (! method_exists($relatedModel, $relationMethod)) {
+        if (!method_exists($relatedModel, $relationMethod)) {
             return $relatedModel->{$relationMethod};
         }
 
@@ -120,7 +120,7 @@ 
                 foreach ($relationModels as $model) {
                     // when subfields are NOT set we don't need to get any more values
                     // we just return the plain models as we only need the ids
-                    if (! isset($field['subfields'])) {
+                    if (!isset($field['subfields'])) {
                         $result->push($model);
                         continue;
                     }
@@ -147,13 +147,13 @@ 
                 break;
             case 'HasOne':
             case 'MorphOne':
-                if (! method_exists($relatedModel, $relationMethod)) {
+                if (!method_exists($relatedModel, $relationMethod)) {
                     return;
                 }
 
                 $model = $relatedModel->{$relationMethod};
 
-                if (! $model) {
+                if (!$model) {
                     return;
                 }
 
@@ -215,7 +215,7 @@ 
 
         $relationArray = explode('.', $relationEntity);
 
-        $relatedModel = array_reduce(array_splice($relationArray, 0, -1), function ($obj, $method) {
+        $relatedModel = array_reduce(array_splice($relationArray, 0, -1), function($obj, $method) {
             // if the string ends with `_id` we strip it out
             $method = Str::endsWith($method, '_id') ? Str::replaceLast('_id', '', $method) : $method;
 
@@ -241,7 +241,7 @@ 
             $name = is_string($subfield) ? $subfield : $subfield['name'];
             // if the subfield name does not contain a dot we just need to check
             // if it has subfields and return the result accordingly.
-            if (! Str::contains($name, '.')) {
+            if (!Str::contains($name, '.')) {
                 // when subfields are present, $relatedModel->{$name} returns a model instance
                 // otherwise returns the model attribute.
                 if ($relatedModel->{$name}) {
@@ -261,7 +261,7 @@ 
                     $iterator = $iterator->$part;
                 }
 
-                Arr::set($result, $name, (! is_string($iterator) && ! is_null($iterator) ? $this->getModelWithFakes($iterator)->getAttributes() : $iterator));
+                Arr::set($result, $name, (!is_string($iterator) && !is_null($iterator) ? $this->getModelWithFakes($iterator)->getAttributes() : $iterator));
             }
         }