Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Test Setup Failed
Pull Request — master (#2940)
by Cristian
19:23 queued 04:24
created
src/app/Library/CrudPanel/Traits/AutoSet.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -16,8 +16,8 @@  discard block
 block discarded – undo
16 16
             $this->getDbColumnTypes();
17 17
         }
18 18
 
19
-        array_map(function ($field) use ($setFields, $setColumns) {
20
-            if ($setFields && ! isset($this->getCleanStateFields()[$field])) {
19
+        array_map(function($field) use ($setFields, $setColumns) {
20
+            if ($setFields && !isset($this->getCleanStateFields()[$field])) {
21 21
                 $this->addField([
22 22
                     'name'       => $field,
23 23
                     'label'      => $this->makeLabel($field),
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
                 ]);
31 31
             }
32 32
 
33
-            if ($setColumns && ! in_array($field, $this->model->getHidden()) && ! isset($this->columns()[$field])) {
33
+            if ($setColumns && !in_array($field, $this->model->getHidden()) && !isset($this->columns()[$field])) {
34 34
                 $this->addColumn([
35 35
                     'name'    => $field,
36 36
                     'label'   => $this->makeLabel($field),
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
 
108 108
         $dbColumnTypes = $this->getDbColumnTypes();
109 109
 
110
-        if (! isset($dbColumnTypes[$fieldName])) {
110
+        if (!isset($dbColumnTypes[$fieldName])) {
111 111
             return 'text';
112 112
         }
113 113
 
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
         $types = ['enum' => 'string'];
166 166
         $platform = $this->getSchema()->getConnection()->getDoctrineSchemaManager()->getDatabasePlatform();
167 167
         foreach ($types as $type_key => $type_value) {
168
-            if (! $platform->hasDoctrineTypeMappingFor($type_key)) {
168
+            if (!$platform->hasDoctrineTypeMappingFor($type_key)) {
169 169
                 $platform->registerDoctrineTypeMapping($type_key, $type_value);
170 170
             }
171 171
         }
@@ -216,13 +216,13 @@  discard block
 block discarded – undo
216 216
     {
217 217
         $fillable = $this->model->getFillable();
218 218
 
219
-        if (! $this->driverIsSql()) {
219
+        if (!$this->driverIsSql()) {
220 220
             $columns = $fillable;
221 221
         } else {
222 222
             // Automatically-set columns should be both in the database, and in the $fillable variable on the Eloquent Model
223 223
             $columns = $this->model->getConnection()->getSchemaBuilder()->getColumnListing($this->model->getTable());
224 224
 
225
-            if (! empty($fillable)) {
225
+            if (!empty($fillable)) {
226 226
                 $columns = array_intersect($columns, $fillable);
227 227
             }
228 228
         }
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/ColumnsProtectedMethods.php 1 patch
Spacing   +7 added lines, -8 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
             $column = ['name' => $column];
50 50
         }
51 51
 
52
-        if (is_array($column) && ! isset($column['name'])) {
52
+        if (is_array($column) && !isset($column['name'])) {
53 53
             $column['name'] = 'anonymous_column_'.Str::random(5);
54 54
         }
55 55
 
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
      */
66 66
     protected function makeSureColumnHasLabel($column)
67 67
     {
68
-        if (! isset($column['label'])) {
68
+        if (!isset($column['label'])) {
69 69
             $column['label'] = mb_ucfirst($this->makeLabel($column['name']));
70 70
         }
71 71
 
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
      */
147 147
     protected function makeSureColumnHasKey($column)
148 148
     {
149
-        if (! isset($column['key'])) {
149
+        if (!isset($column['key'])) {
150 150
             $column['key'] = str_replace('.', '__', $column['name']);
151 151
         }
152 152
 
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
      */
165 165
     protected function makeSureColumnHasWrapper($column)
166 166
     {
167
-        if (! isset($column['wrapper'])) {
167
+        if (!isset($column['wrapper'])) {
168 168
             $column['wrapper'] = [];
169 169
         }
170 170
 
@@ -255,7 +255,7 @@  discard block
 block discarded – undo
255 255
     {
256 256
         // if this is a relation type field and no corresponding model was specified,
257 257
         // get it from the relation method defined in the main model
258
-        if (isset($column['entity']) && $column['entity'] !== false && ! isset($column['model'])) {
258
+        if (isset($column['entity']) && $column['entity'] !== false && !isset($column['model'])) {
259 259
             $column['model'] = $this->getRelationModel($column['entity']);
260 260
         }
261 261
 
@@ -276,8 +276,7 @@  discard block
 block discarded – undo
276 276
         $columnsArray = $this->columns();
277 277
 
278 278
         if (array_key_exists($targetColumnName, $columnsArray)) {
279
-            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) :
280
-                array_search($targetColumnName, array_keys($columnsArray)) + 1;
279
+            $targetColumnPosition = $before ? array_search($targetColumnName, array_keys($columnsArray)) : array_search($targetColumnName, array_keys($columnsArray)) + 1;
281 280
 
282 281
             $element = array_pop($columnsArray);
283 282
             $beginningPart = array_slice($columnsArray, 0, $targetColumnPosition, true);
@@ -299,7 +298,7 @@  discard block
 block discarded – undo
299 298
     {
300 299
         static $cache = [];
301 300
 
302
-        if (! $this->driverIsSql()) {
301
+        if (!$this->driverIsSql()) {
303 302
             return true;
304 303
         }
305 304
 
Please login to merge, or discard this patch.
src/app/Http/Controllers/Operations/ShowOperation.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -30,25 +30,25 @@
 block discarded – undo
30 30
         $this->crud->allowAccess('show');
31 31
         $this->crud->setOperationSetting('setFromDb', true);
32 32
 
33
-        $this->crud->operation('show', function () {
33
+        $this->crud->operation('show', function() {
34 34
             $this->crud->loadDefaultOperationSettingsFromConfig();
35 35
 
36
-            if (! method_exists($this, 'setupShowOperation')) {
36
+            if (!method_exists($this, 'setupShowOperation')) {
37 37
                 $this->autoSetupShowOperation();
38 38
             }
39 39
         });
40 40
 
41
-        $this->crud->operation('list', function () {
41
+        $this->crud->operation('list', function() {
42 42
             $this->crud->addButton('line', 'show', 'view', 'crud::buttons.show', 'beginning');
43 43
         });
44 44
 
45
-        $this->crud->operation(['create', 'update'], function () {
45
+        $this->crud->operation(['create', 'update'], function() {
46 46
             $this->crud->addSaveAction([
47 47
                 'name' => 'save_and_preview',
48
-                'visible' => function ($crud) {
48
+                'visible' => function($crud) {
49 49
                     return $crud->hasAccess('show');
50 50
                 },
51
-                'redirect' => function ($crud, $request, $itemId = null) {
51
+                'redirect' => function($crud, $request, $itemId = null) {
52 52
                     $itemId = $itemId ?: $request->input('id');
53 53
                     $redirectUrl = $crud->route.'/'.$itemId.'/show';
54 54
                     if ($request->has('_locale')) {
Please login to merge, or discard this patch.
src/app/Models/Traits/HasRelationshipFields.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
         [$conn, $table] = self::getConnectionAndTable();
68 68
 
69 69
         // MongoDB columns are alway nullable
70
-        if (! in_array($conn->getConfig()['driver'], CRUD::getSqlDriverList())) {
70
+        if (!in_array($conn->getConfig()['driver'], CRUD::getSqlDriverList())) {
71 71
             return true;
72 72
         }
73 73
 
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
             // check for NOT NULL
78 78
             $notNull = $column->getNotnull();
79 79
             // return the value of nullable (aka the inverse of NOT NULL)
80
-            return ! $notNull;
80
+            return !$notNull;
81 81
         } catch (\Exception $e) {
82 82
             return true;
83 83
         }
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
         [$conn, $table] = self::getConnectionAndTable();
95 95
 
96 96
         // MongoDB columns don't have default values
97
-        if (! in_array($conn->getConfig()['driver'], CRUD::getSqlDriverList())) {
97
+        if (!in_array($conn->getConfig()['driver'], CRUD::getSqlDriverList())) {
98 98
             return false;
99 99
         }
100 100
 
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/Traits/Validation.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -29,10 +29,10 @@  discard block
 block discarded – undo
29 29
         // construct the validation rules array
30 30
         // (eg. ['name' => 'required|min:2'])
31 31
         $rules = collect($fields)
32
-                    ->filter(function ($value, $key) {
32
+                    ->filter(function($value, $key) {
33 33
                         // only keep fields where 'validationRules' attribute is defined
34 34
                         return array_key_exists('validationRules', $value);
35
-                    })->map(function ($item, $key) {
35
+                    })->map(function($item, $key) {
36 36
                         // only keep the rules, not the entire field definition
37 37
                         return $item['validationRules'];
38 38
                     })->toArray();
@@ -41,10 +41,10 @@  discard block
 block discarded – undo
41 41
         // (eg. ['title.required' => 'You gotta write smth man.'])
42 42
         $messages = [];
43 43
         collect($fields)
44
-                    ->filter(function ($value, $key) {
44
+                    ->filter(function($value, $key) {
45 45
                         // only keep fields where 'validationMessages' attribute is defined
46 46
                         return array_key_exists('validationMessages', $value);
47
-                    })->each(function ($item, $key) use (&$messages) {
47
+                    })->each(function($item, $key) use (&$messages) {
48 48
                         foreach ($item['validationMessages'] as $rule => $message) {
49 49
                             $messages[$key.'.'.$rule] = $message;
50 50
                         }
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
      */
75 75
     public function setValidation($classOrRulesArray = false, $messages = [])
76 76
     {
77
-        if (! $classOrRulesArray) {
77
+        if (!$classOrRulesArray) {
78 78
             $this->setValidationFromFields();
79 79
         } elseif (is_array($classOrRulesArray)) {
80 80
             $this->setValidationFromArray($classOrRulesArray, $messages);
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
      */
203 203
     public function isRequired($inputKey)
204 204
     {
205
-        if (! $this->hasOperationSetting('requiredFields')) {
205
+        if (!$this->hasOperationSetting('requiredFields')) {
206 206
             return false;
207 207
         }
208 208
 
Please login to merge, or discard this patch.
src/resources/views/crud/fields/table.blade.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
 <?php
4 4
     $max = isset($field['max']) && (int) $field['max'] > 0 ? $field['max'] : -1;
5 5
     $min = isset($field['min']) && (int) $field['min'] > 0 ? $field['min'] : -1;
6
-    $item_name = strtolower(isset($field['entity_singular']) && ! empty($field['entity_singular']) ? $field['entity_singular'] : $field['label']);
6
+    $item_name = strtolower(isset($field['entity_singular']) && !empty($field['entity_singular']) ? $field['entity_singular'] : $field['label']);
7 7
 
8 8
     $items = old_empty_or_null($field['name'], '') ?? $field['value'] ?? $field['default'] ?? '';
9 9
 
@@ -15,12 +15,12 @@  discard block
 block discarded – undo
15 15
         } else {
16 16
             $items = '[]';
17 17
         }
18
-    } elseif (is_string($items) && ! is_array(json_decode($items))) {
18
+    } elseif (is_string($items) && !is_array(json_decode($items))) {
19 19
         $items = '[]';
20 20
     }
21 21
 
22 22
     // make sure columns are defined
23
-    if (! isset($field['columns'])) {
23
+    if (!isset($field['columns'])) {
24 24
         $field['columns'] = ['value' => 'Value'];
25 25
     }
26 26
 
Please login to merge, or discard this patch.
src/resources/views/crud/fields/checklist_dependency.blade.php 1 patch
Indentation   +24 added lines, -24 removed lines patch added patch discarded remove patch
@@ -33,35 +33,35 @@
 block discarded – undo
33 33
         $old_primary_dependency = old_empty_or_null($primary_dependency['name'], false) ?? false;
34 34
         $old_secondary_dependency = old_empty_or_null($secondary_dependency['name'], false) ?? false;
35 35
 
36
-      //for update form, get initial state of the entity
37
-      if (isset($id) && $id) {
36
+        //for update form, get initial state of the entity
37
+        if (isset($id) && $id) {
38 38
 
39 39
         //get entity with relations for primary dependency
40
-          $entity_dependencies = $entity_model->with($primary_dependency['entity'])
41
-          ->with($primary_dependency['entity'].'.'.$primary_dependency['entity_secondary'])
42
-          ->find($id);
40
+            $entity_dependencies = $entity_model->with($primary_dependency['entity'])
41
+            ->with($primary_dependency['entity'].'.'.$primary_dependency['entity_secondary'])
42
+            ->find($id);
43 43
 
44
-          $secondaries_from_primary = [];
44
+            $secondaries_from_primary = [];
45 45
 
46
-          //convert relation in array
47
-          $primary_array = $entity_dependencies->{$primary_dependency['entity']}->toArray();
46
+            //convert relation in array
47
+            $primary_array = $entity_dependencies->{$primary_dependency['entity']}->toArray();
48 48
 
49
-          $secondary_ids = [];
50
-          //create secondary dependency from primary relation, used to check what checkbox must be checked from second checklist
51
-          if ($old_primary_dependency) {
52
-              foreach ($old_primary_dependency as $primary_item) {
53
-                  foreach ($dependencyArray[$primary_item] as $second_item) {
54
-                      $secondary_ids[$second_item] = $second_item;
55
-                  }
56
-              }
57
-          } else { //create dependencies from relation if not from validate error
58
-              foreach ($primary_array as $primary_item) {
59
-                  foreach ($primary_item[$secondary_dependency['entity']] as $second_item) {
60
-                      $secondary_ids[$second_item['id']] = $second_item['id'];
61
-                  }
62
-              }
63
-          }
64
-      }
49
+            $secondary_ids = [];
50
+            //create secondary dependency from primary relation, used to check what checkbox must be checked from second checklist
51
+            if ($old_primary_dependency) {
52
+                foreach ($old_primary_dependency as $primary_item) {
53
+                    foreach ($dependencyArray[$primary_item] as $second_item) {
54
+                        $secondary_ids[$second_item] = $second_item;
55
+                    }
56
+                }
57
+            } else { //create dependencies from relation if not from validate error
58
+                foreach ($primary_array as $primary_item) {
59
+                    foreach ($primary_item[$secondary_dependency['entity']] as $second_item) {
60
+                        $secondary_ids[$second_item['id']] = $second_item['id'];
61
+                    }
62
+                }
63
+            }
64
+        }
65 65
 
66 66
         //json encode of dependency matrix
67 67
         $dependencyJson = json_encode($dependencyArray);
Please login to merge, or discard this patch.
src/resources/views/crud/fields/date_range.blade.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,11 +3,11 @@  discard block
 block discarded – undo
3 3
 <?php
4 4
     // if the column has been cast to Carbon or Date (using attribute casting)
5 5
     // get the value as a date string
6
-    if (! function_exists('formatDate')) {
6
+    if (!function_exists('formatDate')) {
7 7
         function formatDate($entry, $dateFieldName)
8 8
         {
9 9
             $formattedDate = null;
10
-            if (isset($entry) && ! empty($entry->{$dateFieldName})) {
10
+            if (isset($entry) && !empty($entry->{$dateFieldName})) {
11 11
                 $dateField = $entry->{$dateFieldName};
12 12
                 if ($dateField instanceof \Carbon\CarbonInterface) {
13 13
                     $formattedDate = $dateField->format('Y-m-d H:i:s');
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
     }
22 22
 
23 23
     if (isset($field['value'])) {
24
-        if (isset($entry) && ! is_array($field['value'])) {
24
+        if (isset($entry) && !is_array($field['value'])) {
25 25
             $start_value = formatDate($entry, $field['name'][0]);
26 26
             $end_value = formatDate($entry, $field['name'][1]);
27 27
         } elseif (is_array($field['value'])) { // gets here when inside repeatable
Please login to merge, or discard this patch.
src/app/Library/CrudPanel/CrudButton.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -274,7 +274,7 @@  discard block
 block discarded – undo
274 274
     {
275 275
         $type = $this->name;
276 276
 
277
-        $paths = array_map(function ($item) use ($type) {
277
+        $paths = array_map(function($item) use ($type) {
278 278
             return $item.'.'.$type;
279 279
         }, config('backpack.crud.view_namespaces.buttons'));
280 280
 
@@ -440,7 +440,7 @@  discard block
 block discarded – undo
440 440
     {
441 441
         $itemExists = $this->collection()->contains('name', $this->name);
442 442
 
443
-        if (! $itemExists) {
443
+        if (!$itemExists) {
444 444
             if ($this->position == 'beginning') {
445 445
                 $this->collection()->prepend($this);
446 446
             } else {
Please login to merge, or discard this patch.