Backpack\CRUD\app\Library\Validation\Rules\ValidUpload

Complexity

Total Complexity

6

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	field()	0	3	1
A	validateRules()	0	15	5

<?php

namespace Backpack\CRUD\app\Library\Validation\Rules;

use Backpack\CRUD\app\Library\CrudPanel\CrudPanelFacade;
use Backpack\CRUD\app\Library\Validation\Rules\Support\HasFiles;
use Closure;
use Illuminate\Contracts\Validation\Rule;
use Illuminate\Contracts\Validation\ValidationRule;

class ValidUpload extends BackpackCustomRule
{
    use HasFiles;

    /**
     * Run the validation rule.
     *
     * @param  string  $attribute
     * @param  mixed  $value
     * @param  Closure(string): \Illuminate\Translation\PotentiallyTranslatedString  $fail
     * @return void
     */
    public function validateRules(string $attribute, mixed $value): array
    {
        $entry = CrudPanelFacade::getCurrentEntry();

The method getCurrentEntry() does not exist on Backpack\CRUD\app\Library\CrudPanel\CrudPanelFacade. Since you implemented __callStatic, consider adding a @method annotation.

        if (! array_key_exists($attribute, $this->data) && $entry) {
            return [];

The expression return array() returns the type array which is incompatible with the documented return type void.

        }

        $fieldErrors = $this->validateFieldRules($attribute, $value);

        if (! empty($value) && ! empty($this->getFileRules())) {
            $fileErrors = $this->validateFileRules($attribute, $value);
        }

        return array_merge($fieldErrors, $fileErrors ?? []);

The expression return array_merge($fieldErrors, $fileErrors ?? array()) returns the type array which is incompatible with the documented return type void.

    }

    public static function field(string|array|ValidationRule|Rule $rules = []): self
    {
        return parent::field($rules);

The expression return parent::field($rules) returns the type Backpack\CRUD\app\Library\Validation\Rules\BackpackCustomRule which includes types incompatible with the type-hinted return Backpack\CRUD\app\Library\Validation\Rules\ValidUpload.

    }
}