Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Passed
Pull Request — main (#5271)
by Cristian
28:19 queued 13:35
created
src/macros.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -19,8 +19,8 @@  discard block
 block discarded – undo
19 19
  *      - when true: `address[street]`
20 20
  *      - when false: `[address][street]`
21 21
  */
22
-if (! Str::hasMacro('dotsToSquareBrackets')) {
23
-    Str::macro('dotsToSquareBrackets', function ($string, $ignore = [], $keyFirst = true) {
22
+if (!Str::hasMacro('dotsToSquareBrackets')) {
23
+    Str::macro('dotsToSquareBrackets', function($string, $ignore = [], $keyFirst = true) {
24 24
         $stringParts = explode('.', $string);
25 25
         $result = '';
26 26
 
@@ -34,8 +34,8 @@  discard block
 block discarded – undo
34 34
         return $result;
35 35
     });
36 36
 }
37
-if (! CrudColumn::hasMacro('withFiles')) {
38
-    CrudColumn::macro('withFiles', function ($uploadDefinition = [], $subfield = null, $registerUploaderEvents = true) {
37
+if (!CrudColumn::hasMacro('withFiles')) {
38
+    CrudColumn::macro('withFiles', function($uploadDefinition = [], $subfield = null, $registerUploaderEvents = true) {
39 39
         /** @var CrudField|CrudColumn $this */
40 40
         RegisterUploadEvents::handle($this, $uploadDefinition, 'withFiles', $subfield, $registerUploaderEvents);
41 41
 
@@ -43,8 +43,8 @@  discard block
 block discarded – undo
43 43
     });
44 44
 }
45 45
 
46
-if (! CrudField::hasMacro('withFiles')) {
47
-    CrudField::macro('withFiles', function ($uploadDefinition = [], $subfield = null, $registerUploaderEvents = true) {
46
+if (!CrudField::hasMacro('withFiles')) {
47
+    CrudField::macro('withFiles', function($uploadDefinition = [], $subfield = null, $registerUploaderEvents = true) {
48 48
         /** @var CrudField|CrudColumn $this */
49 49
         RegisterUploadEvents::handle($this, $uploadDefinition, 'withFiles', $subfield, $registerUploaderEvents);
50 50
 
@@ -58,8 +58,8 @@  discard block
 block discarded – undo
58 58
  *
59 59
  * It will go to the given CrudController and get the setupRoutes() method on it.
60 60
  */
61
-if (! Route::hasMacro('crud')) {
62
-    Route::macro('crud', function ($name, $controller) {
61
+if (!Route::hasMacro('crud')) {
62
+    Route::macro('crud', function($name, $controller) {
63 63
         // put together the route name prefix,
64 64
         // as passed to the Route::group() statements
65 65
         $routeName = '';
Please login to merge, or discard this patch.
tests/Unit/CrudPanel/CrudPanelValidationTest.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
             'password' => 'test',
46 46
         ]);
47 47
 
48
-        $request->setRouteResolver(function () use ($request) {
48
+        $request->setRouteResolver(function() use ($request) {
49 49
             return (new Route('POST', 'users', ['Backpack\CRUD\Tests\Config\Http\Controllers\UserCrudController', 'create']))->bind($request);
50 50
         });
51 51
 
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
             'email'    => '',
86 86
         ]);
87 87
 
88
-        $request->setRouteResolver(function () use ($request) {
88
+        $request->setRouteResolver(function() use ($request) {
89 89
             return (new Route('POST', 'users', ['Backpack\CRUD\Tests\Config\Http\Controllers\UserCrudController', 'create']))->bind($request);
90 90
         });
91 91
 
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
             'password' => 'test',
126 126
         ]);
127 127
 
128
-        $request->setRouteResolver(function () use ($request) {
128
+        $request->setRouteResolver(function() use ($request) {
129 129
             return (new Route('POST', 'users', ['Backpack\CRUD\Tests\Config\Http\Controllers\UserCrudController', 'create']))->bind($request);
130 130
         });
131 131
 
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
             'name'        => 'test',
248 248
         ]);
249 249
 
250
-        $request->setRouteResolver(function () use ($request) {
250
+        $request->setRouteResolver(function() use ($request) {
251 251
             return (new Route('POST', 'users', ['Backpack\CRUD\Tests\Config\Http\Controllers\UserCrudController', 'create']))->bind($request);
252 252
         });
253 253
 
Please login to merge, or discard this patch.
tests/BaseTestClass.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@
 block discarded – undo
23 23
             (array) config('backpack.base.middleware_key', 'admin'),
24 24
             'prefix'     => config('backpack.base.route_prefix', 'admin'),
25 25
         ],
26
-            function () {
26
+            function() {
27 27
                 Route::crud('users', 'Backpack\CRUD\Tests\config\Http\Controllers\UserCrudController');
28 28
             }
29 29
         );
Please login to merge, or discard this patch.
tests/config/CrudPanel/BaseCrudPanel.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
     {
25 25
         parent::setUp();
26 26
 
27
-        $this->app->singleton('crud', function ($app) {
27
+        $this->app->singleton('crud', function($app) {
28 28
             return new CrudPanel($app);
29 29
         });
30 30
         $this->crudPanel = app('crud');
Please login to merge, or discard this patch.
tests/config/Http/CrudControllerTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@
 block discarded – undo
23 23
     {
24 24
         parent::getEnvironmentSetUp($app);
25 25
 
26
-        $app->singleton('crud', function ($app) {
26
+        $app->singleton('crud', function($app) {
27 27
             return new CrudPanel($app);
28 28
         });
29 29
 
Please login to merge, or discard this patch.
src/helpers.php 1 patch
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -5,7 +5,7 @@  discard block
 block discarded – undo
5 5
 use Illuminate\Support\Facades\Log;
6 6
 use Illuminate\Support\Str;
7 7
 
8
-if (! function_exists('backpack_url')) {
8
+if (!function_exists('backpack_url')) {
9 9
     /**
10 10
      * Appends the configured backpack prefix and returns
11 11
      * the URL using the standard Laravel helpers.
@@ -15,13 +15,13 @@  discard block
 block discarded – undo
15 15
      */
16 16
     function backpack_url($path = null, $parameters = [], $secure = null)
17 17
     {
18
-        $path = ! $path || (substr($path, 0, 1) == '/') ? $path : '/'.$path;
18
+        $path = !$path || (substr($path, 0, 1) == '/') ? $path : '/'.$path;
19 19
 
20 20
         return url(config('backpack.base.route_prefix', 'admin').$path, $parameters, $secure);
21 21
     }
22 22
 }
23 23
 
24
-if (! function_exists('backpack_authentication_column')) {
24
+if (!function_exists('backpack_authentication_column')) {
25 25
     /**
26 26
      * Return the username column name.
27 27
      * The Laravel default (and Backpack default) is 'email'.
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
     }
35 35
 }
36 36
 
37
-if (! function_exists('backpack_email_column')) {
37
+if (!function_exists('backpack_email_column')) {
38 38
     /**
39 39
      * Return the email column name.
40 40
      * The Laravel default (and Backpack default) is 'email'.
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
     }
48 48
 }
49 49
 
50
-if (! function_exists('backpack_form_input')) {
50
+if (!function_exists('backpack_form_input')) {
51 51
     /**
52 52
      * Parse the submitted input in request('form') to an usable array.
53 53
      * Joins the multiple[] fields in a single key and transform the dot notation fields into arrayed ones.
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
     }
121 121
 }
122 122
 
123
-if (! function_exists('backpack_users_have_email')) {
123
+if (!function_exists('backpack_users_have_email')) {
124 124
     /**
125 125
      * Check if the email column is present on the user table.
126 126
      *
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
     }
136 136
 }
137 137
 
138
-if (! function_exists('backpack_avatar_url')) {
138
+if (!function_exists('backpack_avatar_url')) {
139 139
     /**
140 140
      * Returns the avatar URL of a user.
141 141
      *
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
     {
147 147
         switch (config('backpack.base.avatar_type')) {
148 148
             case 'gravatar':
149
-                if (backpack_users_have_email() && ! empty($user->email)) {
149
+                if (backpack_users_have_email() && !empty($user->email)) {
150 150
                     $avatarLink = Gravatar::fallback(config('backpack.base.gravatar_fallback'))->get($user->email, ['size' => 80]);
151 151
 
152 152
                     // if we can save it locally, for safer loading, let's do it
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
     }
165 165
 }
166 166
 
167
-if (! function_exists('backpack_middleware')) {
167
+if (!function_exists('backpack_middleware')) {
168 168
     /**
169 169
      * Return the key of the middleware used across Backpack.
170 170
      * That middleware checks if the visitor is an admin.
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
     }
179 179
 }
180 180
 
181
-if (! function_exists('backpack_guard_name')) {
181
+if (!function_exists('backpack_guard_name')) {
182 182
     /*
183 183
      * Returns the name of the guard defined
184 184
      * by the application config
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
     }
190 190
 }
191 191
 
192
-if (! function_exists('backpack_auth')) {
192
+if (!function_exists('backpack_auth')) {
193 193
     /*
194 194
      * Returns the user instance if it exists
195 195
      * of the currently authenticated admin
@@ -201,7 +201,7 @@  discard block
 block discarded – undo
201 201
     }
202 202
 }
203 203
 
204
-if (! function_exists('backpack_user')) {
204
+if (!function_exists('backpack_user')) {
205 205
     /*
206 206
      * Returns back a user instance without
207 207
      * the admin guard, however allows you
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
     }
214 214
 }
215 215
 
216
-if (! function_exists('mb_ucfirst')) {
216
+if (!function_exists('mb_ucfirst')) {
217 217
     /**
218 218
      * Capitalize the first letter of a string,
219 219
      * even if that string is multi-byte (non-latin alphabet).
@@ -234,7 +234,7 @@  discard block
 block discarded – undo
234 234
     }
235 235
 }
236 236
 
237
-if (! function_exists('backpack_view')) {
237
+if (!function_exists('backpack_view')) {
238 238
     /**
239 239
      * Returns a new displayable view path, based on the configured backpack view namespace.
240 240
      * If that view doesn't exist, it falls back to the fallback namespace.
@@ -259,8 +259,8 @@  discard block
 block discarded – undo
259 259
 
260 260
         $errorMessage = 'The view: ['.$view.'] was not found in any of the following view paths: ['.implode(' ], [ ', $viewPaths).']';
261 261
 
262
-        $errorDetails = (function () {
263
-            if (env('APP_ENV') === 'production' || ! env('APP_DEBUG')) {
262
+        $errorDetails = (function() {
263
+            if (env('APP_ENV') === 'production' || !env('APP_DEBUG')) {
264 264
                 return '';
265 265
             }
266 266
 
@@ -276,7 +276,7 @@  discard block
 block discarded – undo
276 276
     }
277 277
 }
278 278
 
279
-if (! function_exists('backpack_theme_config')) {
279
+if (!function_exists('backpack_theme_config')) {
280 280
     /**
281 281
      * Returns a config value from the current theme's config file.
282 282
      * It assumes the theme's config namespace is the same as the view namespace.
@@ -315,7 +315,7 @@  discard block
 block discarded – undo
315 315
     }
316 316
 }
317 317
 
318
-if (! function_exists('square_brackets_to_dots')) {
318
+if (!function_exists('square_brackets_to_dots')) {
319 319
     /**
320 320
      * Turns a string from bracket-type array to dot-notation array.
321 321
      * Ex: array[0][property] turns into array.0.property.
@@ -331,7 +331,7 @@  discard block
 block discarded – undo
331 331
     }
332 332
 }
333 333
 
334
-if (! function_exists('old_empty_or_null')) {
334
+if (!function_exists('old_empty_or_null')) {
335 335
     /**
336 336
      * This method is an alternative to Laravel's old() helper, which mistakenly
337 337
      * returns NULL it two cases:
@@ -363,7 +363,7 @@  discard block
 block discarded – undo
363 363
     }
364 364
 }
365 365
 
366
-if (! function_exists('is_multidimensional_array')) {
366
+if (!function_exists('is_multidimensional_array')) {
367 367
     /**
368 368
      * If any of the items inside a given array is an array, the array is considered multidimensional.
369 369
      *
@@ -382,7 +382,7 @@  discard block
 block discarded – undo
382 382
     }
383 383
 }
384 384
 
385
-if (! function_exists('backpack_pro')) {
385
+if (!function_exists('backpack_pro')) {
386 386
     /**
387 387
      * Check if the backpack/pro package is installed.
388 388
      *
@@ -393,7 +393,7 @@  discard block
 block discarded – undo
393 393
         if (app()->runningUnitTests()) {
394 394
             return true;
395 395
         }
396
-        if (! \Composer\InstalledVersions::isInstalled('backpack/pro')) {
396
+        if (!\Composer\InstalledVersions::isInstalled('backpack/pro')) {
397 397
             return false;
398 398
         }
399 399
 
Please login to merge, or discard this patch.
src/config/backpack/ui.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -70,13 +70,13 @@  discard block
 block discarded – undo
70 70
     ],
71 71
 
72 72
     // CSS files that are loaded in all pages, using Laravel's mix() helper
73
-    'mix_styles' => [ // file_path => manifest_directory_path
73
+    'mix_styles' => [// file_path => manifest_directory_path
74 74
         // 'css/app.css' => '',
75 75
     ],
76 76
 
77 77
     // CSS files that are loaded in all pages, using Laravel's @vite() helper
78 78
     // Please note that support for Vite was added in Laravel 9.19. Earlier versions are not able to use this feature.
79
-    'vite_styles' => [ // resource file_path
79
+    'vite_styles' => [// resource file_path
80 80
         // 'resources/css/app.css',
81 81
     ],
82 82
 
@@ -152,12 +152,12 @@  discard block
 block discarded – undo
152 152
     ],
153 153
 
154 154
     // JS files that are loaded in all pages, using Laravel's mix() helper
155
-    'mix_scripts' => [ // file_path => manifest_directory_path
155
+    'mix_scripts' => [// file_path => manifest_directory_path
156 156
         // 'js/app.js' => '',
157 157
     ],
158 158
 
159 159
     // JS files that are loaded in all pages, using Laravel's @vite() helper
160
-    'vite_scripts' => [ // resource file_path
160
+    'vite_scripts' => [// resource file_path
161 161
         // 'resources/js/app.js',
162 162
     ],
163 163
 
Please login to merge, or discard this patch.
src/app/Library/Uploaders/Support/Traits/HandleRepeatableUploads.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
         foreach (app('UploadersRepository')->getRepeatableUploadersFor($this->getRepeatableContainerName()) as $uploader) {
77 77
             $uploadedValues = $uploader->uploadRepeatableFiles($values->pluck($uploader->getName())->toArray(), $this->getPreviousRepeatableValues($entry, $uploader));
78 78
 
79
-            $values = $values->map(function ($item, $key) use ($uploadedValues, $uploader) {
79
+            $values = $values->map(function($item, $key) use ($uploadedValues, $uploader) {
80 80
                 $item[$uploader->getName()] = $uploadedValues[$key] ?? null;
81 81
 
82 82
                 return $item;
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
 
97 97
         $values = $entry->{$this->getRepeatableContainerName()};
98 98
         $values = is_string($values) ? json_decode($values, true) : $values;
99
-        $values = array_map(function ($item) use ($repeatableUploaders) {
99
+        $values = array_map(function($item) use ($repeatableUploaders) {
100 100
             foreach ($repeatableUploaders as $upload) {
101 101
                 $item[$upload->getName()] = $this->getValuesWithPathStripped($item, $upload);
102 102
             }
@@ -119,12 +119,12 @@  discard block
 block discarded – undo
119 119
 
120 120
         $repeatableValues = collect($entry->{$this->getName()});
121 121
         foreach (app('UploadersRepository')->getRepeatableUploadersFor($this->getRepeatableContainerName()) as $upload) {
122
-            if (! $upload->shouldDeleteFiles()) {
122
+            if (!$upload->shouldDeleteFiles()) {
123 123
                 continue;
124 124
             }
125 125
             $values = $repeatableValues->pluck($upload->getName())->toArray();
126 126
             foreach ($values as $value) {
127
-                if (! $value) {
127
+                if (!$value) {
128 128
                     continue;
129 129
                 }
130 130
 
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
     /**
148 148
      * Given two multidimensional arrays/collections, merge them recursively.
149 149
      */
150
-    protected function mergeValuesRecursive(array|Collection $array1, array|Collection $array2): array|Collection
150
+    protected function mergeValuesRecursive(array | Collection $array1, array | Collection $array2): array | Collection
151 151
     {
152 152
         $merged = $array1;
153 153
         foreach ($array2 as $key => &$value) {
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
     {
170 170
         $items = CRUD::getRequest()->input('_order_'.$this->getRepeatableContainerName()) ?? [];
171 171
 
172
-        array_walk($items, function (&$key, $value) {
172
+        array_walk($items, function(&$key, $value) {
173 173
             $requestValue = $key[$this->getName()] ?? null;
174 174
             $key = $this->handleMultipleFiles ? (is_string($requestValue) ? explode(',', $requestValue) : $requestValue) : $requestValue;
175 175
         });
@@ -181,18 +181,18 @@  discard block
 block discarded – undo
181 181
     {
182 182
         $previousValues = json_decode($entry->getOriginal($uploader->getRepeatableContainerName()), true);
183 183
 
184
-        if (! empty($previousValues)) {
184
+        if (!empty($previousValues)) {
185 185
             $previousValues = array_column($previousValues, $uploader->getName());
186 186
         }
187 187
 
188 188
         return $previousValues ?? [];
189 189
     }
190 190
 
191
-    private function getValuesWithPathStripped(array|string|null $item, UploaderInterface $upload)
191
+    private function getValuesWithPathStripped(array | string | null $item, UploaderInterface $upload)
192 192
     {
193 193
         $uploadedValues = $item[$upload->getName()] ?? null;
194 194
         if (is_array($uploadedValues)) {
195
-            return array_map(function ($value) use ($upload) {
195
+            return array_map(function($value) use ($upload) {
196 196
                 return Str::after($value, $upload->getPath());
197 197
             }, $uploadedValues);
198 198
         }
Please login to merge, or discard this patch.
src/app/Library/Uploaders/Uploader.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@  discard block
 block discarded – undo
25 25
 
26 26
     private bool $deleteWhenEntryIsDeleted = true;
27 27
 
28
-    private bool|string $attachedToFakeField = false;
28
+    private bool | string $attachedToFakeField = false;
29 29
 
30 30
     /**
31 31
      * Cloud disks have the ability to generate temporary URLs to files, should we do it?
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
     /*******************************
58 58
      * Static methods
59 59
      *******************************/
60
-    public static function for(array $crudObject, array $definition): UploaderInterface
60
+    public static function for (array $crudObject, array $definition): UploaderInterface
61 61
     {
62 62
         return new static($crudObject, $definition);
63 63
     }
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
     public function deleteUploadedFiles(Model $entry): void
99 99
     {
100 100
         if ($this->deleteWhenEntryIsDeleted) {
101
-            if (! in_array(SoftDeletes::class, class_uses_recursive($entry), true)) {
101
+            if (!in_array(SoftDeletes::class, class_uses_recursive($entry), true)) {
102 102
                 $this->performFileDeletion($entry);
103 103
 
104 104
                 return;
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
 
160 160
     public function getPreviousFiles(Model $entry): mixed
161 161
     {
162
-        if (! $this->attachedToFakeField) {
162
+        if (!$this->attachedToFakeField) {
163 163
             return $this->getOriginalValue($entry);
164 164
         }
165 165
 
@@ -198,7 +198,7 @@  discard block
 block discarded – undo
198 198
         $value = $entry->{$this->name};
199 199
 
200 200
         if ($this->handleMultipleFiles) {
201
-            if (! isset($entry->getCasts()[$this->name]) && is_string($value)) {
201
+            if (!isset($entry->getCasts()[$this->name]) && is_string($value)) {
202 202
                 $entry->{$this->name} = json_decode($value, true);
203 203
             }
204 204
 
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
226 226
 
227 227
         if ($this->handleMultipleFiles) {
228 228
             // ensure we have an array of values when field is not casted in model.
229
-            if (! isset($entry->getCasts()[$this->name]) && is_string($values)) {
229
+            if (!isset($entry->getCasts()[$this->name]) && is_string($values)) {
230 230
                 $values = json_decode($values, true);
231 231
             }
232 232
             foreach ($values as $value) {
@@ -242,7 +242,7 @@  discard block
 block discarded – undo
242 242
 
243 243
     private function performFileDeletion(Model $entry)
244 244
     {
245
-        if ($this->isRelationship || ! $this->handleRepeatableFiles) {
245
+        if ($this->isRelationship || !$this->handleRepeatableFiles) {
246 246
             $this->deleteFiles($entry);
247 247
 
248 248
             return;
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
     {
266 266
         $previousValue = $entry->getOriginal($field ?? $this->getName());
267 267
 
268
-        if (! $previousValue) {
268
+        if (!$previousValue) {
269 269
             return $previousValue;
270 270
         }
271 271
 
Please login to merge, or discard this patch.