Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Pull Request — master (#103)
by Nathaniel
03:30
created
src/resources/views-elfinder/elfinder.blade.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@  discard block
 block discarded – undo
17 17
     <!-- elFinder JS (REQUIRED) -->
18 18
     <script src="<?= asset($dir.'/js/elfinder.min.js') ?>"></script>
19 19
 
20
-    <?php if($locale){ ?>
20
+    <?php if ($locale) { ?>
21 21
         <!-- elFinder translation (OPTIONAL) -->
22 22
         <script src="<?= asset($dir."/js/i18n/elfinder.$locale.js") ?>"></script>
23 23
     <?php } ?>
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
         $().ready(function() {
41 41
             var elf = $('#elfinder').elfinder({
42 42
                 // set your elFinder options here
43
-                <?php if($locale){ ?>
43
+                <?php if ($locale) { ?>
44 44
                     lang: '<?= $locale ?>', // locale
45 45
                 <?php } ?>
46 46
                 customData: {
Please login to merge, or discard this patch.
src/resources/views/fields/checklist_dependency.blade.php 3 patches
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -15,15 +15,15 @@  discard block
 block discarded – undo
15 15
       $dependencyArray = [];
16 16
 
17 17
       //convert dependency array to simple matrix ( prymary id as key and array with secondaries id )
18
-      foreach($dependencies as $primary){
18
+      foreach ($dependencies as $primary) {
19 19
           $dependencyArray[$primary->id] = [];
20
-        foreach($primary->{$primary_dependency['entity_secondary']} as $secondary){
20
+        foreach ($primary->{$primary_dependency['entity_secondary']} as $secondary) {
21 21
             $dependencyArray[$primary->id][] = $secondary->id;
22 22
         }
23 23
       }
24 24
 
25 25
       //for update form, get initial state of the entity
26
-      if( isset($id) && $id ){
26
+      if (isset($id) && $id) {
27 27
         
28 28
         //get entity with relations for primary dependency
29 29
         $entity_dependencies = $entity_model->with($primary_dependency['entity'])
@@ -39,15 +39,15 @@  discard block
 block discarded – undo
39 39
         $secondary_ids = [];
40 40
         
41 41
         //create secondary dependency from primary relation, used to check what chekbox must be check from second checklist
42
-        if( old($primary_dependency['name']) ) {
43
-          foreach( old($primary_dependency['name']) as $primary_item ){
44
-            foreach($dependencyArray[$primary_item] as $second_item ){
42
+        if (old($primary_dependency['name'])) {
43
+          foreach (old($primary_dependency['name']) as $primary_item) {
44
+            foreach ($dependencyArray[$primary_item] as $second_item) {
45 45
                 $secondary_ids[$second_item] = $second_item;
46 46
             }
47 47
           }
48
-        }else{ //create dependecies from relation if not from validate error
49
-          foreach( $primary_array as $primary_item ){
50
-            foreach($primary_item[$secondary_dependency['entity']] as $second_item ){
48
+        } else { //create dependecies from relation if not from validate error
49
+          foreach ($primary_array as $primary_item) {
50
+            foreach ($primary_item[$secondary_dependency['entity']] as $second_item) {
51 51
                 $secondary_ids[$second_item['id']] = $second_item['id'];
52 52
             }
53 53
           }
Please login to merge, or discard this patch.
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
                 $secondary_ids[$second_item] = $second_item;
46 46
             }
47 47
           }
48
-        }else{ //create dependecies from relation if not from validate error
48
+        } else{ //create dependecies from relation if not from validate error
49 49
           foreach( $primary_array as $primary_item ){
50 50
             foreach($primary_item[$secondary_dependency['entity']] as $second_item ){
51 51
                 $secondary_ids[$second_item['id']] = $second_item['id'];
Please login to merge, or discard this patch.
Indentation   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -2,34 +2,34 @@  discard block
 block discarded – undo
2 2
   <div class="form-group checklist_dependency"  data-entity ="{{ $field['field_unique_name'] }}">
3 3
     <label>{{ $field['label'] }}</label>
4 4
     <?php
5
-      $entity_model = $crud->getModel();
5
+        $entity_model = $crud->getModel();
6 6
 
7
-      //short name for dependency fields
8
-      $primary_dependency = $field['subfields']['primary'];
9
-      $secondary_dependency = $field['subfields']['secondary'];
7
+        //short name for dependency fields
8
+        $primary_dependency = $field['subfields']['primary'];
9
+        $secondary_dependency = $field['subfields']['secondary'];
10 10
 
11 11
 
12
-      //all items with relation
13
-      $dependencies = $primary_dependency['model']::with($primary_dependency['entity_secondary'])->get();
12
+        //all items with relation
13
+        $dependencies = $primary_dependency['model']::with($primary_dependency['entity_secondary'])->get();
14 14
 
15
-      $dependencyArray = [];
15
+        $dependencyArray = [];
16 16
 
17
-      //convert dependency array to simple matrix ( prymary id as key and array with secondaries id )
18
-      foreach($dependencies as $primary){
19
-          $dependencyArray[$primary->id] = [];
17
+        //convert dependency array to simple matrix ( prymary id as key and array with secondaries id )
18
+        foreach($dependencies as $primary){
19
+            $dependencyArray[$primary->id] = [];
20 20
         foreach($primary->{$primary_dependency['entity_secondary']} as $secondary){
21 21
             $dependencyArray[$primary->id][] = $secondary->id;
22 22
         }
23
-      }
23
+        }
24 24
 
25
-      //for update form, get initial state of the entity
26
-      if( isset($id) && $id ){
25
+        //for update form, get initial state of the entity
26
+        if( isset($id) && $id ){
27 27
 
28 28
         //get entity with relations for primary dependency
29 29
         $entity_dependencies = $entity_model->with($primary_dependency['entity'])
30
-          ->with($primary_dependency['entity'].'.'.$primary_dependency['entity_secondary'])
31
-          ->where('id', $id)
32
-          ->first();
30
+            ->with($primary_dependency['entity'].'.'.$primary_dependency['entity_secondary'])
31
+            ->where('id', $id)
32
+            ->first();
33 33
 
34 34
         $secondaries_from_primary = [];
35 35
 
@@ -40,23 +40,23 @@  discard block
 block discarded – undo
40 40
 
41 41
         //create secondary dependency from primary relation, used to check what chekbox must be check from second checklist
42 42
         if( old($primary_dependency['name']) ) {
43
-          foreach( old($primary_dependency['name']) as $primary_item ){
43
+            foreach( old($primary_dependency['name']) as $primary_item ){
44 44
             foreach($dependencyArray[$primary_item] as $second_item ){
45 45
                 $secondary_ids[$second_item] = $second_item;
46 46
             }
47
-          }
47
+            }
48 48
         }else{ //create dependecies from relation if not from validate error
49
-          foreach( $primary_array as $primary_item ){
49
+            foreach( $primary_array as $primary_item ){
50 50
             foreach($primary_item[$secondary_dependency['entity']] as $second_item ){
51 51
                 $secondary_ids[$second_item['id']] = $second_item['id'];
52 52
             }
53
-          }
53
+            }
54 54
         }
55 55
 
56
-      }
56
+        }
57 57
 
58
-      //json encode of dependency matrix
59
-      $dependencyJson = json_encode($dependencyArray);
58
+        //json encode of dependency matrix
59
+        $dependencyJson = json_encode($dependencyArray);
60 60
     ?>
61 61
     <script>
62 62
      var  {{ $field['field_unique_name'] }} = {!! $dependencyJson !!};
Please login to merge, or discard this patch.
src/resources/views/fields/checklist.blade.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,7 +1,7 @@
 block discarded – undo
1 1
 <!-- select2 -->
2 2
   <div class="form-group">
3 3
     <label>{{ $field['label'] }}</label>
4
-    <?php $entity_model = $crud->getModel();?>
4
+    <?php $entity_model = $crud->getModel(); ?>
5 5
    
6 6
     <div class="row">
7 7
         @foreach ($field['model']::all() as $connected_entity_entry)
Please login to merge, or discard this patch.
src/CrudServiceProvider.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@
 block discarded – undo
66 66
 
67 67
     private function registerCRUD()
68 68
     {
69
-        $this->app->bind('CRUD', function ($app) {
69
+        $this->app->bind('CRUD', function($app) {
70 70
             return new CRUD($app);
71 71
         });
72 72
     }
Please login to merge, or discard this patch.
Indentation   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -87,23 +87,23 @@
 block discarded – undo
87 87
         Route::post($name.'/search', [
88 88
             'as' => 'crud.'.$name.'.search',
89 89
             'uses' => $controller.'@search'
90
-          ]);
90
+            ]);
91 91
         Route::get($name.'/reorder', [
92 92
             'as' => 'crud.'.$name.'.reorder',
93 93
             'uses' => $controller.'@reorder'
94
-          ]);
94
+            ]);
95 95
         Route::post($name.'/reorder', [
96 96
             'as' => 'crud.'.$name.'.save.reorder',
97 97
             'uses' => $controller.'@saveReorder'
98
-          ]);
98
+            ]);
99 99
         Route::get($name.'/{id}/details',  [
100 100
             'as' => 'crud.'.$name.'.showDetailsRow',
101 101
             'uses' => $controller.'@showDetailsRow'
102
-          ]);
102
+            ]);
103 103
         Route::get($name.'/{id}/translate/{lang}',  [
104 104
             'as' => 'crud.'.$name.'.translateItem',
105 105
             'uses' => $controller.'@translateItem'
106
-          ]);
106
+            ]);
107 107
 
108 108
         $options_with_default_route_names = array_merge([
109 109
             'names' => [
Please login to merge, or discard this patch.
src/CrudTrait.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@
 block discarded – undo
69 69
      *
70 70
      * @param array $columns - the database columns that contain the JSONs
71 71
      *
72
-     * @return Model
72
+     * @return CrudTrait
73 73
      */
74 74
     public function withFakes($columns = [])
75 75
     {
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
         foreach ($columns as $key => $column) {
53 53
             $column_contents = $this->{$column};
54 54
 
55
-            if (! is_object($this->{$column})) {
55
+            if (!is_object($this->{$column})) {
56 56
                 $column_contents = json_decode($this->{$column});
57 57
             }
58 58
 
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
     {
76 76
         $model = '\\'.get_class($this);
77 77
 
78
-        if (! count($columns)) {
78
+        if (!count($columns)) {
79 79
             if (property_exists($model, 'fakeColumns')) {
80 80
                 $columns = $this->fakeColumns;
81 81
             } else {
Please login to merge, or discard this patch.
src/app/Http/Controllers/CrudController.php 2 patches
Unused Use Statements   +1 added lines, -3 removed lines patch added patch discarded remove patch
@@ -2,14 +2,12 @@
 block discarded – undo
2 2
 
3 3
 namespace Backpack\CRUD\app\Http\Controllers;
4 4
 
5
-use Backpack\CRUD\app\Http\Requests\CrudRequest as StoreRequest;
6
-use Backpack\CRUD\app\Http\Requests\CrudRequest as UpdateRequest;
7 5
 use Backpack\CRUD\Crud;
6
+use Backpack\CRUD\app\Http\Requests\CrudRequest as UpdateRequest;
8 7
 use Illuminate\Foundation\Bus\DispatchesJobs;
9 8
 use Illuminate\Foundation\Validation\ValidatesRequests;
10 9
 // VALIDATION: change the requests to match your own file names if you need form validation
11 10
 use Illuminate\Routing\Controller as BaseController;
12
-use Illuminate\Support\Facades\Form as Form;
13 11
 
14 12
 class CrudController extends BaseController
15 13
 {
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
         $this->data['title'] = ucfirst($this->crud->entity_name_plural);
38 38
 
39 39
         // get all entries if AJAX is not enabled
40
-        if (! $this->data['crud']->ajaxTable()) {
40
+        if (!$this->data['crud']->ajaxTable()) {
41 41
             $this->data['entries'] = $this->data['crud']->getEntries();
42 42
         }
43 43
 
@@ -190,7 +190,7 @@  discard block
 block discarded – undo
190 190
     {
191 191
         $this->crud->hasAccessOrFail('reorder');
192 192
 
193
-        if (! $this->crud->isReorderEnabled()) {
193
+        if (!$this->crud->isReorderEnabled()) {
194 194
             abort(403, 'Reorder is disabled.');
195 195
         }
196 196
 
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
         $dataTable = new DataTable($this->crud->query, $columns);
260 260
 
261 261
         // make the datatable use the column types instead of just echoing the text
262
-        $dataTable->setFormatRowFunction(function ($entry) {
262
+        $dataTable->setFormatRowFunction(function($entry) {
263 263
             // get the actual HTML for each row's cell
264 264
             $row_items = $this->crud->getRowViews($entry, $this->crud);
265 265
 
Please login to merge, or discard this patch.
src/resources/views-elfinder/filepicker.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
     <!-- Include jQuery, jQuery UI, elFinder (REQUIRED) -->
27 27
 
28 28
     <?php
29
-    $mimeTypes = implode(',', array_map(function ($t) {
29
+    $mimeTypes = implode(',', array_map(function($t) {
30 30
         return "'".$t."'";
31 31
     }, explode(',', $type)));
32 32
     ?>
Please login to merge, or discard this patch.
src/PanelTraits/Update.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
 
44 44
         foreach ($fields as $k => $field) {
45 45
             // set the value
46
-            if (! isset($fields[$k]['value'])) {
46
+            if (!isset($fields[$k]['value'])) {
47 47
                 if (isset($field['subfields'])) {
48 48
                     $fields[$k]['value'] = [];
49 49
                     foreach ($field['subfields'] as $key => $subfield) {
Please login to merge, or discard this patch.
src/PanelTraits/Fields.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -27,12 +27,12 @@  discard block
 block discarded – undo
27 27
         }
28 28
 
29 29
         // if the label is missing, we should set it
30
-        if (! isset($complete_field_array['label'])) {
30
+        if (!isset($complete_field_array['label'])) {
31 31
             $complete_field_array['label'] = ucfirst($complete_field_array['name']);
32 32
         }
33 33
 
34 34
         // if the field type is missing, we should set it
35
-        if (! isset($complete_field_array['type'])) {
35
+        if (!isset($complete_field_array['type'])) {
36 36
             $complete_field_array['type'] = $this->getFieldTypeFromDbColumnType($complete_field_array['name']);
37 37
         }
38 38
 
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
      */
95 95
     public function removeFields($array_of_names, $form = 'both')
96 96
     {
97
-        if (! empty($array_of_names)) {
97
+        if (!empty($array_of_names)) {
98 98
             foreach ($array_of_names as $name) {
99 99
                 $this->removeField($name, $form);
100 100
             }
Please login to merge, or discard this patch.